[jira] [Commented] (ZOOKEEPER-2757) Incorrect path crashes zkCli

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016929#comment-16016929 ] ASF GitHub Bot commented on ZOOKEEPER-2757: --- Github user afine commented on the issue:

[GitHub] zookeeper issue #240: ZOOKEEPER-2757: Incorrect path crashes zkCli

2017-05-18 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/240 @hanm I'm not sure that we should always assume that an IllegalArgumentException will only be thrown when a path is invalid. Since IllegalArgumentException does not need to be caught, it will be

Success: ZOOKEEPER- PreCommit Build #718

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/718/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.23 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016924#comment-16016924 ] Hadoop QA commented on ZOOKEEPER-2784: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016915#comment-16016915 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-18 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117406260 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -660,6 +665,9 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2775) ZK Client not able to connect with Xid out of order error

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016903#comment-16016903 ] ASF GitHub Bot commented on ZOOKEEPER-2775: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #254: ZOOKEEPER-2775: ZK Client not able to connect with Xid...

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/254 >> Will this results in any consistency issues later? I guess the previous behavior was problematic and the fact tunnelAuthInProgress always return false once a login failed (even after a

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016899#comment-16016899 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-18 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117403350 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -660,6 +665,9 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016883#comment-16016883 ] Hadoop QA commented on ZOOKEEPER-2784: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #717

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/717/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.31 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016879#comment-16016879 ] Hadoop QA commented on ZOOKEEPER-2784: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #716

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/716/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.30 MB...] [exec]

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-18 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117400479 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -18,36 +18,32 @@ package org.apache.zookeeper.test;

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016869#comment-16016869 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016867#comment-16016867 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-18 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117400348 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -18,36 +18,32 @@ package org.apache.zookeeper.test;

Failed: ZOOKEEPER- PreCommit Build #715

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/715/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.88 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016854#comment-16016854 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #714

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/714/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.03 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016825#comment-16016825 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #713

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/713/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.37 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2774) Ephemeral znode will not be removed when sesstion timeout, if the system time of ZooKeeper node changes unexpectedly.

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016756#comment-16016756 ] ASF GitHub Bot commented on ZOOKEEPER-2774: --- Github user JiangJiafu commented on the issue:

[jira] [Commented] (ZOOKEEPER-2774) Ephemeral znode will not be removed when sesstion timeout, if the system time of ZooKeeper node changes unexpectedly.

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016757#comment-16016757 ] ASF GitHub Bot commented on ZOOKEEPER-2774: --- Github user JiangJiafu closed the pull request

[GitHub] zookeeper issue #253: ZOOKEEPER-2774

2017-05-18 Thread JiangJiafu
Github user JiangJiafu commented on the issue: https://github.com/apache/zookeeper/pull/253 Thanks for your work @hanm @afine . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zookeeper pull request #253: ZOOKEEPER-2774

2017-05-18 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

ZooKeeper_branch35_openjdk7 - Build # 528 - Failure

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/528/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 48.13 MB...] [junit] at

[GitHub] zookeeper issue #257: ZOOKEEPER-2784: Add same `sid` config problem check

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/257 @asdf2014 : There are lots of formatting changes in this patch, which makes review harder. Can you please update the patch to avoid those formatting changes? See [How To

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016660#comment-16016660 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user hanm commented on the issue:

ZooKeeper-trunk-openjdk7 - Build # 1474 - Failure

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1474/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.37 MB...] [junit] at

[jira] [Commented] (ZOOKEEPER-2757) Incorrect path crashes zkCli

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016650#comment-16016650 ] ASF GitHub Bot commented on ZOOKEEPER-2757: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #240: ZOOKEEPER-2757: Incorrect path crashes zkCli

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/240 How about catch the IllegalArgumentException at ZooKeeperMain.processCmd and directly print the exception message? This way we don't need to make change to individual command. --- If your project

[jira] [Commented] (ZOOKEEPER-2730) Cleanup findbug warnings in branch-3.4: Internationalization Warnings

2017-05-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016635#comment-16016635 ] Michael Han commented on ZOOKEEPER-2730: [~gosubpl] go for it. > Cleanup findbug warnings in

ZooKeeper_branch35_jdk8 - Build # 529 - Failure

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/529/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.71 MB...] [junit] 2017-05-18 23:13:49,957

[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016632#comment-16016632 ] ASF GitHub Bot commented on ZOOKEEPER-2684: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #167: commitProcessor does not crash when an unseen commit s...

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/167 @nerdyyatrice I don't see Jenkins pre-commit build is kicked off for your patch. I think a combination of these should kick the build bot: * Put string "ZOOKEEPER-2684" in pull request title. The

Success: ZOOKEEPER- PreCommit Build #712

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/712/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.37 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2753) Introduce a python script for generating flaky test report

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016622#comment-16016622 ] Hadoop QA commented on ZOOKEEPER-2753: -- +1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #711

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/711/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.29 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2731) Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016612#comment-16016612 ] Hadoop QA commented on ZOOKEEPER-2731: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016601#comment-16016601 ] ASF GitHub Bot commented on ZOOKEEPER-2684: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #167: commitProcessor does not crash when an unseen commit s...

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/167 ZOOKEEPER-2684 kick jenkins bot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

ZooKeeper-trunk-jdk8 - Build # 1052 - Failure

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1052/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.34 MB...] [junit] at

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016559#comment-16016559 ] Hadoop QA commented on ZOOKEEPER-2733: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #710

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/710/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.48 MB...] [exec] +1

ZooKeeper_branch34_openjdk7 - Build # 1501 - Still Failing

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1501/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by an SCM change [EnvInject] - Loading node

[jira] [Commented] (ZOOKEEPER-2762) Multithreaded correctness Warnings

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016548#comment-16016548 ] Hadoop QA commented on ZOOKEEPER-2762: -- -1 overall. GitHub Pull Request Build +1

ZooKeeper-trunk - Build # 3394 - Failure

2017-05-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3394/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.48 MB...] [junit] 2017-05-18 22:05:48,714 [myid:] -

Failed: ZOOKEEPER- PreCommit Build #709

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/709/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.53 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016546#comment-16016546 ] Hadoop QA commented on ZOOKEEPER-2732: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2785) Server inappropriately throttles connections under load before SASL completes

2017-05-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016549#comment-16016549 ] Hudson commented on ZOOKEEPER-2785: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3394 (See

Failed: ZOOKEEPER- PreCommit Build #708

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/708/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.38 MB...] [exec] +0

[jira] [Commented] (ZOOKEEPER-2730) Cleanup findbug warnings in branch-3.4: Internationalization Warnings

2017-05-18 Thread Janek P (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016506#comment-16016506 ] Janek P commented on ZOOKEEPER-2730: Is anyone working on that or is it free for grabs? > Cleanup

[jira] [Commented] (ZOOKEEPER-2774) Ephemeral znode will not be removed when sesstion timeout, if the system time of ZooKeeper node changes unexpectedly.

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016491#comment-16016491 ] ASF GitHub Bot commented on ZOOKEEPER-2774: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #253: ZOOKEEPER-2774

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/253 Merged to branch-3.4. Please close this pull request, @JiangJiafu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Resolved] (ZOOKEEPER-2774) Ephemeral znode will not be removed when sesstion timeout, if the system time of ZooKeeper node changes unexpectedly.

2017-05-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2774. Resolution: Fixed Fix Version/s: 3.4.11 Issue resolved by pull request 253

[jira] [Commented] (ZOOKEEPER-2731) Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016488#comment-16016488 ] ASF GitHub Bot commented on ZOOKEEPER-2731: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117358635 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016479#comment-16016479 ] Hadoop QA commented on ZOOKEEPER-2733: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #706

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/706/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.72 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2785) Server inappropriately throttles connections under load before SASL completes

2017-05-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016477#comment-16016477 ] Michael Han commented on ZOOKEEPER-2785: Merged to master, 3.5, and 3.4.

[jira] [Resolved] (ZOOKEEPER-2785) Server inappropriately throttles connections under load before SASL completes

2017-05-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2785. Resolution: Fixed Fix Version/s: 3.5.4 3.6.0 Issue resolved

[jira] [Commented] (ZOOKEEPER-2785) Server inappropriately throttles connections under load before SASL completes

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016473#comment-16016473 ] ASF GitHub Bot commented on ZOOKEEPER-2785: --- Github user asfgit closed the pull request at:

[GitHub] zookeeper pull request #256: ZOOKEEPER-2785 Server inappropriately throttles...

2017-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (ZOOKEEPER-2762) Multithreaded correctness Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016455#comment-16016455 ] ASF GitHub Bot commented on ZOOKEEPER-2762: --- Github user afine commented on the issue:

[GitHub] zookeeper issue #239: ZOOKEEPER-2762: Cleanup findbug warnings in branch-3.4...

2017-05-18 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/239 Done, thanks for the review @rakeshadr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016451#comment-16016451 ] ASF GitHub Bot commented on ZOOKEEPER-2732: --- GitHub user afine opened a pull request:

[GitHub] zookeeper pull request #258: ZOOKEEPER-2732: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/258 ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings @rakeshadr Apologies for recreating this, I accidentally pushed a bad branch in

Failed: ZOOKEEPER- PreCommit Build #707

2017-05-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/707/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 3.19 KB...] [exec] Pull request

[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016440#comment-16016440 ] ASF GitHub Bot commented on ZOOKEEPER-2732: --- Github user afine closed the pull request at:

[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016431#comment-16016431 ] ASF GitHub Bot commented on ZOOKEEPER-2732: --- GitHub user afine reopened a pull request:

[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016430#comment-16016430 ] ASF GitHub Bot commented on ZOOKEEPER-2732: --- Github user afine closed the pull request at:

[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
GitHub user afine reopened a pull request: https://github.com/apache/zookeeper/pull/231 ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/afine/zookeeper

[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016416#comment-16016416 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016411#comment-16016411 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016413#comment-16016413 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016414#comment-16016414 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016415#comment-16016415 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016417#comment-16016417 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117345561 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Observer.java --- @@ -125,6 +125,8 @@ protected void processPacket(QuorumPacket qp) throws

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117345541 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java --- @@ -135,6 +135,8 @@ protected void processPacket(QuorumPacket qp) throws

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117345515 --- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java --- @@ -133,11 +133,17 @@ public boolean accept(File f){ }

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117345471 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -504,6 +504,8 @@ protected void pRequest2Txn(int type, long zxid,

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016382#comment-16016382 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117341551 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -628,14 +628,7 @@ protected void pRequest(Request request) throws

[jira] [Commented] (ZOOKEEPER-2774) Ephemeral znode will not be removed when sesstion timeout, if the system time of ZooKeeper node changes unexpectedly.

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016193#comment-16016193 ] ASF GitHub Bot commented on ZOOKEEPER-2774: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #253: ZOOKEEPER-2774

2017-05-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/253 LGTM - all unit test passed. The Jenkins check failed because it has findbug warnings and that is a known issue for branch-3.4. I will merge this to branch-3.4 soon. One suggestion, in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015987#comment-16015987 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015989#comment-16015989 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015984#comment-16015984 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015983#comment-16015983 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015988#comment-16015988 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015985#comment-16015985 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015982#comment-16015982 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[jira] [Commented] (ZOOKEEPER-2733) Cleanup findbug warnings in branch-3.4: Dodgy code Warnings

2017-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015986#comment-16015986 ] ASF GitHub Bot commented on ZOOKEEPER-2733: --- Github user rakeshadr commented on a diff in

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117279935 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -628,14 +628,7 @@ protected void pRequest(Request request) throws

[GitHub] zookeeper pull request #236: ZOOKEEPER-2733: Cleanup findbug warnings in bra...

2017-05-18 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/236#discussion_r117287341 --- Diff: ivy.xml --- @@ -49,6 +49,8 @@ + --- End diff -- I'd prefer to exclude

  1   2   >