[jira] [Updated] (ZOOKEEPER-2930) Leader cannot be elected due to network timeout of some members.

[Jiafu Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiafu Jiang updated ZOOKEEPER-2930:
---
Component/s: server
 quorum

> Leader cannot be elected due to network timeout of some members.
> 
>
> Key: ZOOKEEPER-2930
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2930
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection, quorum, server
>Affects Versions: 3.4.10
> Environment: Java 8
> ZooKeeper 3.4.11(from github)
> Centos6.5
>Reporter: Jiafu Jiang
> Attachments: zoo.cfg, zookeeper1.log, zookeeper2.log
>
>
> I deploy a cluster of ZooKeeper with three nodes:
> ofs_zk1:20.10.11.101, 30.10.11.101
> ofs_zk2:20.10.11.102, 30.10.11.102
> ofs_zk3:20.10.11.103, 30.10.11.103
> I shutdown the network interfaces of ofs_zk2 using "ifdown eth0 eth1" command.
> It is supposed that the new Leader should be elected in some seconds, but the 
> fact is, ofs_zk1 and ofs_zk3 just keep electing again and again, but none of 
> them can become the new Leader.
> I change the log level to DEBUG (the default is INFO), and restart zookeeper 
> servers on ofs_zk1 and ofs_zk2 again, but it can not fix the problem.
> I read the log and the ZooKeeper source code, and I think I find the reason.
> When the potential leader(says ofs_zk3) begins the 
> election(FastLeaderElection.lookForLeader()), it will send notifications to 
> all the servers. 
> When it fails to receive any notification during a timeout, it will resend 
> the notifications, and double the timeout. This process will repeat until any 
> notification is received or the timeout reaches a max value.
> The FastLeaderElection.sendNotifications() just put the notification message 
> into a queue and return. The WorkerSender is responsable to send the 
> notifications.
> The WorkerSender just process the notifications one by one by passing the 
> notifications to QuorumCnxManager. Here comes the problem, the 
> QuorumCnxManager.toSend() blocks for a long time when the notification is 
> send to ofs_zk2(whose network is down) and some notifications (which belongs 
> to ofs_zk1) will thus be blocked for a long time. The repeated notifications 
> by FastLeaderElection.sendNotifications() just make things worse.
> Here is the related source code:
> {code:java}
> public void toSend(Long sid, ByteBuffer b) {
> /*
>  * If sending message to myself, then simply enqueue it (loopback).
>  */
> if (this.mySid == sid) {
>  b.position(0);
>  addToRecvQueue(new Message(b.duplicate(), sid));
> /*
>  * Otherwise send to the corresponding thread to send.
>  */
> } else {
>  /*
>   * Start a new connection if doesn't have one already.
>   */
>  ArrayBlockingQueue bq = new 
> ArrayBlockingQueue(SEND_CAPACITY);
>  ArrayBlockingQueue bqExisting = 
> queueSendMap.putIfAbsent(sid, bq);
>  if (bqExisting != null) {
>  addToSendQueue(bqExisting, b);
>  } else {
>  addToSendQueue(bq, b);
>  }
>  
>  // This may block!!!
>  connectOne(sid);
> 
> }
> }
> {code}
> Therefore, when ofs_zk3 believes that it is the leader, it begins to wait the 
> epoch ack, but in fact the ofs_zk1 does not receive the notification(which 
> says the leader is ofs_zk3) because the ofs_zk3 has not sent the 
> notification(which may still exist in the sendqueue of WorkerSender). At 
> last, the potential leader ofs_zk3 fails to receive the epoch ack in timeout, 
> so it quits the leader and begins a new election. 
> The log files of ofs_zk1 and ofs_zk3 are attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch34_jdk7 - Build # 1715 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1715/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 31.46 MB...]
[junit] 2017-11-07 02:40:30,807 [myid:] - INFO  
[main:PrepRequestProcessor@769] - Shutting down
[junit] 2017-11-07 02:40:30,807 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-11-07 02:40:30,807 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop!
[junit] 2017-11-07 02:40:30,808 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-11-07 02:40:30,808 [myid:] - INFO  
[main:FinalRequestProcessor@403] - shutdown of request processor complete
[junit] 2017-11-07 02:40:30,808 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-11-07 02:40:30,809 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-11-07 02:40:30,810 [myid:] - INFO  [main:ClientBase@489] - 
STARTING server
[junit] 2017-11-07 02:40:30,810 [myid:] - INFO  [main:ClientBase@410] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-11-07 02:40:30,810 [myid:] - INFO  
[main:ServerCnxnFactory@117] - Using 
org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
[junit] 2017-11-07 02:40:30,811 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-11-07 02:40:30,811 [myid:] - INFO  [main:ClientBase@385] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-11-07 02:40:30,811 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build/test/tmp/test4458030328328862244.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build/test/tmp/test4458030328328862244.junit.dir/version-2
[junit] 2017-11-07 02:40:30,814 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-07 02:40:30,814 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-11-07 02:40:30,814 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@215] - 
Accepted socket connection from /127.0.0.1:52752
[junit] 2017-11-07 02:40:30,815 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@892] - Processing 
stat command from /127.0.0.1:52752
[junit] 2017-11-07 02:40:30,815 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@683] - Stat command output
[junit] 2017-11-07 02:40:30,815 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1040] - Closed socket connection for client 
/127.0.0.1:52752 (no session established for client)
[junit] 2017-11-07 02:40:30,815 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-11-07 02:40:30,817 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-11-07 02:40:30,817 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-11-07 02:40:30,817 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-11-07 02:40:30,817 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-11-07 02:40:30,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 33047
[junit] 2017-11-07 02:40:30,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-11-07 02:40:30,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-11-07 02:40:30,818 [myid:] - INFO  [main:ClientBase@566] - 
tearDown starting
[junit] 2017-11-07 02:40:30,893 [myid:] - INFO  [main:ZooKeeper@687] - 
Session: 0x107bf247874 closed
[junit] 2017-11-07 02:40:30,894 [myid:] - INFO  [main:ClientBase@536] - 
STOPPING server
[junit] 2017-11-07 02:40:30,894 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@242] - 
NIOServerCnxn factory exited run method
[junit] 2017-11-07 02:40:30,894 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
session: 0x107bf247874
[junit] 2017-11-07 02:40:30,894 [myid:] - INFO  [main:ZooKeeperServer@501] 
- shutting down
[junit] 2017-11-07 02:40:30,894 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR 

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241340#comment-16241340
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1168//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1168//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1168//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241334#comment-16241334
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1165//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1165//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1165//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Apache ZooKeeper release 3.4.11 candidate 1

[Michael Han]

One minor issue on release note - ZOOKEEPER-2829 should be included. I
think it's missing in release note because the "Fixed Version" field was
not set on that JIRA issue.

Other than this, I am +1.

Verified with JDK 1.8.0_151 on OS X 10.12.6

- Check sum and signature verified.
- API documentations looks good.
- All unit tests passed.
- Set up 3 node cluster, verified through zk commands and a couple of 4lw.


On Tue, Nov 7, 2017 at 1:43 AM, Rakesh Radhakrishnan 
wrote:

> Thanks for making the release.
>
> Here is my +1.
>
> Verified using jdk 1.8.0_111 and CentOS 7.3.1611 env
>
> - checked previously reported cases of 'readme.md' and rc tag, looks good.
> - xsum/sig verified.
> - release note looks good.
> - setup a small 3 node cluster.
> - ran command line zk client - create & delete set of child znodes, get
> data, set data znode.
> - ran few 4lw commands.
> - ran unit test, looks good.
>
>
> Rakesh
>
> On Mon, Nov 6, 2017 at 10:48 PM, Patrick Hunt  wrote:
>
> > I ran a number of tests in addition to what's documented on the cwiki.
> > Including bringing up ensembles of various sizes. All seemed fine to me.
> >
> > I'm +1.
> >
> > Patrick
> >
> > On Fri, Nov 3, 2017 at 2:10 PM, Abraham Fine  wrote:
> >
> > > +1 (non-binding)
> > >
> > > - Verified signatures and xsums for tarball and jar
> > > - Successfully compiled and ran the tests (using java 1.8.0_152-ea)
> > > - Checked the documentation
> > > - Spun up 3 node cluster
> > >
> > > On Fri, Nov 3, 2017, at 09:50, Andor Molnar wrote:
> > > > Sent too early.
> > > >
> > > > - also verified JMX beans
> > > >
> > > > On Fri, Nov 3, 2017 at 5:50 PM, Andor Molnar 
> > wrote:
> > > >
> > > > > Hi Pat,
> > > > >
> > > > > I've done verification with JDK 1.7.0_141 on my mac desktop:
> > > > >
> > > > > - signatures verified.
> > > > > - started a few different cluster sizes(1,3,5).
> > > > > - ran command line zk client - create, delete, get data, set data
> > > znode.
> > > > > - ran few 4lw commands.
> > > > > - ran unit test, looks good.
> > > > >
> > > > > Not sure if it's a problem, but md5/sha1 signature files in
> > dist-maven
> > > > > folder contain only the hash, but not filename. I was unable to
> > verify
> > > them
> > > > > with standard md5sum/sha1sum commands.
> > > > >
> > > > > Regards,
> > > > > Andor
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Nov 1, 2017 at 8:14 PM, Patrick Hunt 
> > wrote:
> > > > >
> > > > >> This is a bugfix release candidate for 3.4.11. It fixes 53 issues.
> > > > >>
> > > > >> The full release notes is available at:
> > > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > >> projectId=12310801=12339207
> > > > >>
> > > > >> *** Please download, test and vote by November 6th 2017, 23:59
> > UTC+0.
> > > ***
> > > > >>
> > > > >> Source files:
> > > > >> *https://people.apache.org/~phunt/zookeeper-3.4.11-candidate-1/*
> > > > >> 
> > > > >>
> > > > >> Maven staging repo:
> > > > >> https://repository.apache.org/content/groups/staging/org/
> > > > >> apache/zookeeper/zookeeper/3.4.11/
> > > > >>
> > > > >> The release candidate tag in git to be voted upon:
> > release-3.4.11-rc1
> > > > >>
> > > > >> ZooKeeper's KEYS file containing PGP keys we use to sign the
> > release:
> > > > >> http://www.apache.org/dist/zookeeper/KEYS
> > > > >>
> > > > >> Should we release this candidate?
> > > > >>
> > > > >> Regards,
> > > > >>
> > > > >> Patrick
> > > > >>
> > > > >
> > > > >
> > >
> >
>

Failed: ZOOKEEPER- PreCommit Build #1167

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.59 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 25e81388e3d147a2d5b48f0d23fd602001a5bb76 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1713:
 exec returned: 1

Total time: 3 minutes 12 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 580.75 KB of artifacts by 11.0% relative to #1162
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241325#comment-16241325
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241326#comment-16241326
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1167//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1166

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 39.04 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1166//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] fd69910542c4fba7189b11dabf8d0c51ecfa36aa logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 2

Total time: 7 minutes 13 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 577.19 KB of artifacts by 49.9% relative to #1162
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
35 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testEarlyLeaderAbandonment

Error Message:
Waiting too long

Stack Trace:
java.lang.RuntimeException: Waiting too long
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:354)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testEarlyLeaderAbandonment(QuorumPeerMainTest.java:176)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testHighestZxidJoinLate

Error Message:
Waiting too long

Stack Trace:
java.lang.RuntimeException: Waiting too long
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForOne(QuorumPeerMainTest.java:342)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testHighestZxidJoinLate(QuorumPeerMainTest.java:306)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.server.quorum.ReconfigLegacyTest.testRestartZooKeeperServer

Error Message:
waiting for server 0 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 0 being up
at 

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241301#comment-16241301
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1163

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.02 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 09dddc181bd163fd79c1c6097c17eff6e0a6 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 2

Total time: 3 minutes 21 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 577.19 KB of artifacts by 49.9% relative to #1162
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.server.CRCTest.testChecksums

Error Message:
Transaction log: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/test/tmp/test6048200543474872201.junit.dir/version-2/snapshot.5e1
 has invalid magic number 1514885966 != 1514884167

Stack Trace:
java.io.IOException: Transaction log: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/test/tmp/test6048200543474872201.junit.dir/version-2/snapshot.5e1
 has invalid magic number 1514885966 != 1514884167
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:626)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:643)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:609)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:585)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.(FileTxnLog.java:547)
at 
org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:369)
at 
org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:356)
at 

Failed: ZOOKEEPER- PreCommit Build #1164

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1164/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.05 KB...]
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to cause Findbugs (version 
3.0.1) to fail.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1164//testReport/
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1164//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 74520023bb73d3ad5c19b15a09cc806b8326b49e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1713:
 exec returned: 2

Total time: 2 minutes 20 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241302#comment-16241302
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to cause Findbugs (version 3.0.1) to fail.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1164//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1164//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241296#comment-16241296
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2932:
---

Github user OuYangLiang commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/414#discussion_r149251675
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -255,30 +255,19 @@ private void padFile(FileOutputStream out) throws 
IOException {
  */
 public static File[] getLogFiles(File[] logDirList,long snapshotZxid) {
 List files = Util.sortDataDir(logDirList, "log", true);
--- End diff --

Agree, I'll make the change, thanks.


> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #414: ZOOKEEPER-2932 Performance enhancement about pu...

[OuYangLiang]

Github user OuYangLiang commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/414#discussion_r149251675
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -255,30 +255,19 @@ private void padFile(FileOutputStream out) throws 
IOException {
  */
 public static File[] getLogFiles(File[] logDirList,long snapshotZxid) {
 List files = Util.sortDataDir(logDirList, "log", true);
--- End diff --

Agree, I'll make the change, thanks.


---

ZooKeeper_branch34 - Build # 2141 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2141/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 31.61 MB...]
[junit] 2017-11-07 00:30:39,103 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-11-07 00:30:39,103 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop!
[junit] 2017-11-07 00:30:39,103 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-11-07 00:30:39,104 [myid:] - INFO  
[main:FinalRequestProcessor@403] - shutdown of request processor complete
[junit] 2017-11-07 00:30:39,104 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-11-07 00:30:39,104 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-11-07 00:30:39,105 [myid:] - INFO  [main:ClientBase@489] - 
STARTING server
[junit] 2017-11-07 00:30:39,106 [myid:] - INFO  [main:ClientBase@410] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-11-07 00:30:39,106 [myid:] - INFO  
[main:ServerCnxnFactory@117] - Using 
org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
[junit] 2017-11-07 00:30:39,106 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-11-07 00:30:39,106 [myid:] - INFO  [main:ClientBase@385] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-11-07 00:30:39,107 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/test/tmp/test618292778652841928.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/test/tmp/test618292778652841928.junit.dir/version-2
[junit] 2017-11-07 00:30:39,109 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-07 00:30:39,109 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-11-07 00:30:39,110 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@215] - 
Accepted socket connection from /127.0.0.1:52780
[junit] 2017-11-07 00:30:39,110 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@892] - Processing 
stat command from /127.0.0.1:52780
[junit] 2017-11-07 00:30:39,110 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@683] - Stat command output
[junit] 2017-11-07 00:30:39,111 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1040] - Closed socket connection for client 
/127.0.0.1:52780 (no session established for client)
[junit] 2017-11-07 00:30:39,111 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-11-07 00:30:39,112 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 33109
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-11-07 00:30:39,113 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-11-07 00:30:39,114 [myid:] - INFO  [main:ClientBase@566] - 
tearDown starting
[junit] 2017-11-07 00:30:39,191 [myid:] - INFO  [main:ZooKeeper@687] - 
Session: 0x107bead9425 closed
[junit] 2017-11-07 00:30:39,191 [myid:] - INFO  [main:ClientBase@536] - 
STOPPING server
[junit] 2017-11-07 00:30:39,191 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@242] - 
NIOServerCnxn factory exited run method
[junit] 2017-11-07 00:30:39,191 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
session: 0x107bead9425
[junit] 2017-11-07 00:30:39,191 [myid:] - INFO  [main:ZooKeeperServer@501] 
- shutting down
[junit] 2017-11-07 00:30:39,191 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-07 00:30:39,192 [myid:] - INFO  
[main:SessionTrackerImpl@226] - 

[jira] [Created] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk

[Abraham Fine (JIRA)]

Abraham Fine created ZOOKEEPER-2935:
---

 Summary: [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from 
branch-3.5 to trunk
 Key: ZOOKEEPER-2935
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Abraham Fine
Assignee: Abraham Fine






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240964#comment-16240964
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2932:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/414#discussion_r149206744
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -255,30 +255,19 @@ private void padFile(FileOutputStream out) throws 
IOException {
  */
 public static File[] getLogFiles(File[] logDirList,long snapshotZxid) {
 List files = Util.sortDataDir(logDirList, "log", true);
--- End diff --

couldn't we make the last param false and then we can use a simpler `for 
(File f : files)` loop?


> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #414: ZOOKEEPER-2932 Performance enhancement about pu...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/414#discussion_r149206744
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -255,30 +255,19 @@ private void padFile(FileOutputStream out) throws 
IOException {
  */
 public static File[] getLogFiles(File[] logDirList,long snapshotZxid) {
 List files = Util.sortDataDir(logDirList, "log", true);
--- End diff --

couldn't we make the last param false and then we can use a simpler `for 
(File f : files)` loop?


---

[jira] [Updated] (ZOOKEEPER-2931) WriteLock recipe: incorrect znode ordering when the sessionId is part of the znode name

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated ZOOKEEPER-2931:

Affects Version/s: 3.4.10
   3.5.3

> WriteLock recipe: incorrect znode ordering when the sessionId is part of the 
> znode name
> ---
>
> Key: ZOOKEEPER-2931
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2931
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Javier Cacheiro
>
> When the nodes are sorted in WriteLock.java using a TreeSet the whole znode 
> path is taken into account and not just the sequence number.
> This causes an issue when the sessionId is included in the znode path because 
> a znode with a lower sessionId will appear as lower than other znode with a 
> higher sessionId even if its sequence number is bigger. 
> In specific situations this ended with two clients holding the lock at the 
> same time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated ZOOKEEPER-2934:

Description: 
I see errors like: 
{code}
/var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
 error: expected expression before ')' token
 log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
  ^
{code}

> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>
> I see errors like: 
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
>  error: expected expression before ')' token
>  log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
>   ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile

[Abraham Fine (JIRA)]

Abraham Fine created ZOOKEEPER-2934:
---

 Summary: c versions of election and queue recipes do not compile
 Key: ZOOKEEPER-2934
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
 Project: ZooKeeper
  Issue Type: Bug
  Components: recipes
Affects Versions: 3.5.3, 3.4.10
Reporter: Abraham Fine






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1162

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1162/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.39 MB...]
 [exec]   
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1162//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1162//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1162//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] f984c4e1abbe4fb218a482643d9f193aaf4a6fe6 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 34 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2793) [QP MutualAuth]: Implement a mechanism to build "authzHosts" for dynamic reconfig servers

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240612#comment-16240612
 ] 

Rakesh R commented on ZOOKEEPER-2793:
-

[~phunt], would be great to see your feedback on my above comments, when you 
get a chance. Thanks!

> [QP MutualAuth]: Implement a mechanism to build "authzHosts" for dynamic 
> reconfig servers
> -
>
> Key: ZOOKEEPER-2793
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2793
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: quorum, security
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.5.4, 3.6.0
>
>
> {{QuorumServer}} will do the authorization checks against configured 
> authorized hosts. During LE, QuorumLearner will send an authentication packet 
> to QuorumServer. Now, QuorumServer will check that the connecting 
> QuorumLearner’s hostname exists in the authorized hosts. If not exists then 
> connecting peer is not authorized to join this ensemble and the request will 
> be rejected immediately. 
> In {{branch-3.4}} building {{authzHosts}} list is pretty straight forward, 
> can use the ensemble server details in zoo.cfg file. But with dynamic 
> reconfig, it has to consider the dynamic add/remove/update servers and need 
> to discuss the ways to handle dynamic cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Apache ZooKeeper release 3.4.11 candidate 1

[Rakesh Radhakrishnan]

Thanks for making the release.

Here is my +1.

Verified using jdk 1.8.0_111 and CentOS 7.3.1611 env

- checked previously reported cases of 'readme.md' and rc tag, looks good.
- xsum/sig verified.
- release note looks good.
- setup a small 3 node cluster.
- ran command line zk client - create & delete set of child znodes, get
data, set data znode.
- ran few 4lw commands.
- ran unit test, looks good.


Rakesh

On Mon, Nov 6, 2017 at 10:48 PM, Patrick Hunt  wrote:

> I ran a number of tests in addition to what's documented on the cwiki.
> Including bringing up ensembles of various sizes. All seemed fine to me.
>
> I'm +1.
>
> Patrick
>
> On Fri, Nov 3, 2017 at 2:10 PM, Abraham Fine  wrote:
>
> > +1 (non-binding)
> >
> > - Verified signatures and xsums for tarball and jar
> > - Successfully compiled and ran the tests (using java 1.8.0_152-ea)
> > - Checked the documentation
> > - Spun up 3 node cluster
> >
> > On Fri, Nov 3, 2017, at 09:50, Andor Molnar wrote:
> > > Sent too early.
> > >
> > > - also verified JMX beans
> > >
> > > On Fri, Nov 3, 2017 at 5:50 PM, Andor Molnar 
> wrote:
> > >
> > > > Hi Pat,
> > > >
> > > > I've done verification with JDK 1.7.0_141 on my mac desktop:
> > > >
> > > > - signatures verified.
> > > > - started a few different cluster sizes(1,3,5).
> > > > - ran command line zk client - create, delete, get data, set data
> > znode.
> > > > - ran few 4lw commands.
> > > > - ran unit test, looks good.
> > > >
> > > > Not sure if it's a problem, but md5/sha1 signature files in
> dist-maven
> > > > folder contain only the hash, but not filename. I was unable to
> verify
> > them
> > > > with standard md5sum/sha1sum commands.
> > > >
> > > > Regards,
> > > > Andor
> > > >
> > > >
> > > >
> > > > On Wed, Nov 1, 2017 at 8:14 PM, Patrick Hunt 
> wrote:
> > > >
> > > >> This is a bugfix release candidate for 3.4.11. It fixes 53 issues.
> > > >>
> > > >> The full release notes is available at:
> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > >> projectId=12310801=12339207
> > > >>
> > > >> *** Please download, test and vote by November 6th 2017, 23:59
> UTC+0.
> > ***
> > > >>
> > > >> Source files:
> > > >> *https://people.apache.org/~phunt/zookeeper-3.4.11-candidate-1/*
> > > >> 
> > > >>
> > > >> Maven staging repo:
> > > >> https://repository.apache.org/content/groups/staging/org/
> > > >> apache/zookeeper/zookeeper/3.4.11/
> > > >>
> > > >> The release candidate tag in git to be voted upon:
> release-3.4.11-rc1
> > > >>
> > > >> ZooKeeper's KEYS file containing PGP keys we use to sign the
> release:
> > > >> http://www.apache.org/dist/zookeeper/KEYS
> > > >>
> > > >> Should we release this candidate?
> > > >>
> > > >> Regards,
> > > >>
> > > >> Patrick
> > > >>
> > > >
> > > >
> >
>

Re: [VOTE] Apache ZooKeeper release 3.4.11 candidate 1

[Patrick Hunt]

I ran a number of tests in addition to what's documented on the cwiki.
Including bringing up ensembles of various sizes. All seemed fine to me.

I'm +1.

Patrick

On Fri, Nov 3, 2017 at 2:10 PM, Abraham Fine  wrote:

> +1 (non-binding)
>
> - Verified signatures and xsums for tarball and jar
> - Successfully compiled and ran the tests (using java 1.8.0_152-ea)
> - Checked the documentation
> - Spun up 3 node cluster
>
> On Fri, Nov 3, 2017, at 09:50, Andor Molnar wrote:
> > Sent too early.
> >
> > - also verified JMX beans
> >
> > On Fri, Nov 3, 2017 at 5:50 PM, Andor Molnar  wrote:
> >
> > > Hi Pat,
> > >
> > > I've done verification with JDK 1.7.0_141 on my mac desktop:
> > >
> > > - signatures verified.
> > > - started a few different cluster sizes(1,3,5).
> > > - ran command line zk client - create, delete, get data, set data
> znode.
> > > - ran few 4lw commands.
> > > - ran unit test, looks good.
> > >
> > > Not sure if it's a problem, but md5/sha1 signature files in dist-maven
> > > folder contain only the hash, but not filename. I was unable to verify
> them
> > > with standard md5sum/sha1sum commands.
> > >
> > > Regards,
> > > Andor
> > >
> > >
> > >
> > > On Wed, Nov 1, 2017 at 8:14 PM, Patrick Hunt  wrote:
> > >
> > >> This is a bugfix release candidate for 3.4.11. It fixes 53 issues.
> > >>
> > >> The full release notes is available at:
> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >> projectId=12310801=12339207
> > >>
> > >> *** Please download, test and vote by November 6th 2017, 23:59 UTC+0.
> ***
> > >>
> > >> Source files:
> > >> *https://people.apache.org/~phunt/zookeeper-3.4.11-candidate-1/*
> > >> 
> > >>
> > >> Maven staging repo:
> > >> https://repository.apache.org/content/groups/staging/org/
> > >> apache/zookeeper/zookeeper/3.4.11/
> > >>
> > >> The release candidate tag in git to be voted upon: release-3.4.11-rc1
> > >>
> > >> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > >> http://www.apache.org/dist/zookeeper/KEYS
> > >>
> > >> Should we release this candidate?
> > >>
> > >> Regards,
> > >>
> > >> Patrick
> > >>
> > >
> > >
>

[GitHub] zookeeper pull request #413: WriteLock recipe: Fix bug in znode ordering whe...

[javicacheiro]

Github user javicacheiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/413#discussion_r149135888
  
--- Diff: 
src/recipes/lock/test/org/apache/zookeeper/recipes/lock/ZNodeNameTest.java ---
@@ -37,17 +37,30 @@ public void testOrderWithSamePrefix() throws Exception {
 @Test
 public void testOrderWithDifferentPrefixes() throws Exception {
 String[] names = { "r-3", "r-2", "r-1", "w-2", "w-1" };
-String[] expected = { "r-1", "r-2", "r-3", "w-1", "w-2" };
+// names with duplicated sequence numbers are not included in the 
result
+String[] expected = { "r-1", "r-2", "r-3" };
--- End diff --

I agree it is a confusing behaviour of the current implementation. The 
reason is that we are using a TreeSet to do the sorting so when a new ZNodeName 
is added and the compareTo method returns 0 with any of the existing Set 
members, then it is considered a duplicate and it is not added. So in this case 
w-2 will be considered a duplicate of r-2 because they share the same sequence 
number. In the WriteLock context trying to sort znodes with duplicated sequence 
numbers will probably indicate some problem. 

To adhere to the principle of least surprise I have changed the 
implementation of the compareTo so it produces the expected result.






---

[jira] [Created] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

[Andor Molnar (JIRA)]

Andor Molnar created ZOOKEEPER-2933:
---

 Summary: Ability to monitor the jute.maxBuffer usage in real-time
 Key: ZOOKEEPER-2933
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
 Project: ZooKeeper
  Issue Type: New Feature
  Components: jute, server
Reporter: Andor Molnar
Assignee: Andor Molnar
 Fix For: 3.5.4, 3.6.0


This is related to jute.maxbuffer problems on the server side when Leader 
generates a proposal that doesn't fit into Follower's Jute buffer causing the 
quorum to be broken.

Proposed solution is to add the following new JMX Beans:

1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
jute.maxbuffer setting,
2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240353#comment-16240353
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1159//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1159//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1159//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240348#comment-16240348
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1156//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1156//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1156//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240346#comment-16240346
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1160

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.24 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] f870f5815f417a75e14f61ef954791d062cceaeb logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 2

Total time: 8 minutes 24 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 577.19 KB of artifacts by 49.9% relative to #1155
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
28 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testEarlyLeaderAbandonment

Error Message:
Waiting too long

Stack Trace:
java.lang.RuntimeException: Waiting too long
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:354)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testEarlyLeaderAbandonment(QuorumPeerMainTest.java:176)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testHighestZxidJoinLate

Error Message:
Waiting too long

Stack Trace:
java.lang.RuntimeException: Waiting too long
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForOne(QuorumPeerMainTest.java:342)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testHighestZxidJoinLate(QuorumPeerMainTest.java:306)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.server.quorum.ReconfigLegacyTest.testRestartZooKeeperServer

Error Message:
waiting for server 0 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 0 being up
at 

Failed: ZOOKEEPER- PreCommit Build #1161

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.58 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1161//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] cbcbb158976947d87bfe9e5ac769f8a10ad3c0e3 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1713:
 exec returned: 1

Total time: 3 minutes 19 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 580.75 KB of artifacts by 11.0% relative to #1155
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240345#comment-16240345
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1160//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240334#comment-16240334
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240335#comment-16240335
 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//console

This message is automatically generated.

> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1157

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 12.16 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1157//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 8ac22008b82e6015e725edf6aeaa882967728da1 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 2

Total time: 4 minutes 52 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 577.19 KB of artifacts by 49.9% relative to #1155
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  org.apache.zookeeper.server.CRCTest.testChecksums

Error Message:
Transaction log: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/test/tmp/test3162760667160647124.junit.dir/version-2/snapshot.703
 has invalid magic number 1514885966 != 1514884167

Stack Trace:
java.io.IOException: Transaction log: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/test/tmp/test3162760667160647124.junit.dir/version-2/snapshot.703
 has invalid magic number 1514885966 != 1514884167
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:628)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:645)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:611)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:587)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.(FileTxnLog.java:549)
at 
org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:371)
at 
org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:358)
at 

Failed: ZOOKEEPER- PreCommit Build #1158

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 31.96 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 553fe6f8aa7a52a5f7e6237781bb501f63cc5dc4 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1713:
 exec returned: 1

Total time: 2 minutes 57 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 578.50 KB of artifacts by 11.1% relative to #1155
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2932
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240323#comment-16240323
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2932:
---

GitHub user OuYangLiang opened a pull request:

https://github.com/apache/zookeeper/pull/414

ZOOKEEPER-2932 Performance enhancement about purging task.

The method FileTxnLog.getLogFiles is used to find out the target log files 
to be retained base on the given zxid when purging task is running. The current 
implementation of this method is trivial to understand, and iterate the log 
files twice to achieve its purchase. It could be improved from both performance 
and readability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OuYangLiang/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #414


commit 598841212f6e197f2a5577a84432a6bd7e886201
Author: ouyangliang 
Date:   2017-11-06T13:48:43Z

ZOOKEEPER-2932 Performance enhancement about purging task.




> Performance enhancement about purging task
> --
>
> Key: ZOOKEEPER-2932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to 
> be retained base on the given zxid when purging task is running. The current 
> implementation of this method is trivial to understand, and iterate the log 
> files twice to achieve its purchase. It could be improved from both 
> performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #414: ZOOKEEPER-2932 Performance enhancement about pu...

[OuYangLiang]

GitHub user OuYangLiang opened a pull request:

https://github.com/apache/zookeeper/pull/414

ZOOKEEPER-2932 Performance enhancement about purging task.

The method FileTxnLog.getLogFiles is used to find out the target log files 
to be retained base on the given zxid when purging task is running. The current 
implementation of this method is trivial to understand, and iterate the log 
files twice to achieve its purchase. It could be improved from both performance 
and readability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OuYangLiang/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #414


commit 598841212f6e197f2a5577a84432a6bd7e886201
Author: ouyangliang 
Date:   2017-11-06T13:48:43Z

ZOOKEEPER-2932 Performance enhancement about purging task.




---

[GitHub] zookeeper pull request #413: WriteLock recipe: Fix bug in znode ordering whe...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/413#discussion_r149077678
  
--- Diff: 
src/recipes/lock/test/org/apache/zookeeper/recipes/lock/ZNodeNameTest.java ---
@@ -37,17 +37,30 @@ public void testOrderWithSamePrefix() throws Exception {
 @Test
 public void testOrderWithDifferentPrefixes() throws Exception {
 String[] names = { "r-3", "r-2", "r-1", "w-2", "w-1" };
-String[] expected = { "r-1", "r-2", "r-3", "w-1", "w-2" };
+// names with duplicated sequence numbers are not included in the 
result
+String[] expected = { "r-1", "r-2", "r-3" };
--- End diff --

Why have you removed "w-1" and "w-2" elements from here?
I think the expected list could be:
`String[] expected = { "r-1", "w-1", "r-2", "w-2", "r-3"};`


---

[jira] [Created] (ZOOKEEPER-2932) Performance enhancement about purging task

[OuYang Liang (JIRA)]

OuYang Liang created ZOOKEEPER-2932:
---

 Summary: Performance enhancement about purging task
 Key: ZOOKEEPER-2932
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: OuYang Liang


The method FileTxnLog.getLogFiles is used to find out the target log files to 
be retained base on the given zxid when purging task is running. The current 
implementation of this method is trivial to understand, and iterate the log 
files twice to achieve its purchase. It could be improved from both performance 
and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)