+1 (non-binding) on the "dockerisation" of the tests!
I agree though, that the change needs to be voted first by the community,
and of course agreed on by committers / PMC members.
Let's see the reactions on this thread. But if not enough votes come in,
you could try starting a new thread, and
Great work Michael,
I am totally +1 on using docker for network isolation
I think that Apache CI may allow out-of-the-box execution in Docker
containers, in fact we have the "CloudBees Docker Custom Build
Environment Plugin"
We can use a public image or provide on the repo a Dockerfile.
In my
With the use of a Docker container (to prevent port collisions) and a
stack of cleanups to test code, I've made some progress towards
reliable test runs in our environment.
(https://github.com/mkedwards/zookeeper/commits/rollup-3.5, if you're
curious.) The list below consists of the "top 40"
Thanks! I assigned 2778 to myself.
ZOOKEEPER-2778: A port to the master branch of the current state of
my patch is in https://github.com/apache/zookeeper/pull/719. Be aware
that there are a couple of touches to the code needed in 3.5 that
aren't needed in master:
Hi Michael,
I added you to the contributors list in Jira, now you can assign tickets to
yourself.
3.5
~~~
ZOOKEEPER-2778 - I already accepted the patch, but I’d like to kindly ask you
to create a separate pull request for the master branch which I can backport to
3.5 after committing it. This
For what it's worth, builds 2732 and 2733 ran concurrently on H19, and
both failed for what I think are resource-conflict reasons. It would
probably help to modify the PreCommit-ZOOKEEPER-github-pr-build queue
so that it doesn't attempt concurrent builds on the same
(uncontainerized) host.
On
Thanks for the guidance. Feel free to assign ZOOKEEPER-2778 to me (I
don't seem to be able to do it myself). I've updated that pull
request against 3.5 to address all reviewer comments. When it looks
ready to land, I'll port it to master as well.
I have updated ZOOKEEPER-1636 and
Hi Michael!
Thanks for the great help to get 3.5 out of the door. We're getting closer
with each commit.
You asked a lot of questions in your email, which I'm trying to answer, but
I believe the best approach is to deal with one problem at a time.
Especially in email communication is not ideal
I think it's mostly a problem in CI, where other processes on the same
machine may compete for the port range, producing spurious Jenkins
failures. The only failures I'm seeing locally are unrelated SSL
issues.
On Thu, Nov 22, 2018 at 3:45 AM Enrico Olivelli wrote:
>
> Il giorno gio 22 nov 2018
Il giorno gio 22 nov 2018 alle ore 12:44 Michael K. Edwards
ha scritto:
>
> I'm glad to be able to help.
>
> It appears as though some of the "flaky tests" result from another
> process stealing a server port between the time that it is assigned
> (in org.apache.zookeeper.PortAssignment.unique())
I'm glad to be able to help.
It appears as though some of the "flaky tests" result from another
process stealing a server port between the time that it is assigned
(in org.apache.zookeeper.PortAssignment.unique()) and the time that it
is bound. This happened, for example, in
Thank you very much Michael
I am following and reviewing your patches
Enrico
Il giorno gio 22 nov 2018 alle ore 10:14 Michael K. Edwards
ha scritto:
>
> Hmm. Jira's a bit of a boneyard, isn't it? And timeouts in flaky
> tests are a problem.
>
> I scrubbed through the open bugs and picked the
Hmm. Jira's a bit of a boneyard, isn't it? And timeouts in flaky
tests are a problem.
I scrubbed through the open bugs and picked the ones that looked to me
like they might deserve attention for 3.5.5 or soon thereafter.
They're all on my watchlist:
Looks like we're really close. Can I help?
I think this is the list of release blockers:
14 matches
Mail list logo
