Re: switching to git?

2016-09-01 Thread Flavio Junqueira
> On 01 Sep 2016, at 15:37, Chris Nauroth wrote: > > I’m not familiar with the Kafka workflow, but another point of interest is > that Apache Yetus can support pre-commit triggered from GitHub pull requests. Yeah, the Kafka queue I pointed to below is exactly for

Re: switching to git?

2016-08-31 Thread Patrick Hunt
Hm, the kafka workflow looks pretty thorough. Includes jenkins integration which is promising. Patrick On Tue, Aug 30, 2016 at 8:16 AM, Benjamin Reed wrote: > i like kafka's contributor work flow! > https://cwiki.apache.org/confluence/display/KAFKA/ >

Re: switching to git?

2016-08-30 Thread Rakesh Radhakrishnan
+1 Rakesh On Fri, Aug 26, 2016 at 11:05 PM, Benjamin Reed wrote: > i'm starting to get back into zk development :) i'm a bit distressed that > we are still using svn and patches managed by jiras. i've gotten extremely > spoiled by gerritt and phabricator over the years! > >

Re: switching to git?

2016-08-30 Thread Benjamin Reed
i like kafka's contributor work flow! https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes i'd like to head toward that. of course there are other options as well, but as pat points out the first phase is moving to git. On Tue, Aug 30, 2016 at 5:37 AM, Flavio Junqueira

Re: switching to git?

2016-08-30 Thread Flavio Junqueira
> On 30 Aug 2016, at 07:42, Benjamin Reed wrote: > > i'm curious, can we get the qa > bot to trigger off a pull request? Yes, we can. See this Kafka build queue: https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/

Re: switching to git?

2016-08-30 Thread Benjamin Reed
i agree that we should take it one step at a time, which is why i've kept the discussion focused on the git switch. i'm curious, can we get the qa bot to trigger off a pull request? if not, would the qa bot be able to pull from a git url in a jira? (the more i think about it, the more i realize

Re: switching to git?

2016-08-29 Thread Patrick Hunt
On Mon, Aug 29, 2016 at 8:48 AM, Benjamin Reed wrote: > gerritt is pretty amazing. after you upload a patch, the whole life cycle > of review, verification, and committer committing can happen on the web. in > practice it means that reviewing and committing small correct

Re: switching to git?

2016-08-29 Thread Jordan Zimmerman
Having just tried to get a patch and review board to work correctly, I heartily give this a +1. PRs are SO much easier. -JZ > On Aug 29, 2016, at 5:22 PM, Chris Nauroth wrote: > > +1 > > --Chris Nauroth > > On 8/26/16, 10:35 AM, "Benjamin Reed"

Re: switching to git?

2016-08-29 Thread Chris Nauroth
+1 --Chris Nauroth On 8/26/16, 10:35 AM, "Benjamin Reed" wrote: i'm starting to get back into zk development :) i'm a bit distressed that we are still using svn and patches managed by jiras. i've gotten extremely spoiled by gerritt and phabricator over the years!

Re: switching to git?

2016-08-29 Thread Benjamin Reed
gerritt is pretty amazing. after you upload a patch, the whole life cycle of review, verification, and committer committing can happen on the web. in practice it means that reviewing and committing small correct changes becomes two clicks of a button. but, this is not what i'm proposing. talking

Re: switching to git?

2016-08-29 Thread Camille Fournier
I'm confused what is the actual work that needs to happen to finalize this and who is going to do that work? Ben are you volunteering or is there nothing left to do? On Aug 28, 2016 10:54 PM, "Patrick Hunt" wrote: > :-) > > In order to make it "official" my recommendation

Re: switching to git?

2016-08-28 Thread Patrick Hunt
:-) In order to make it "official" my recommendation would be for you to start a VOTE thread on dev@ after a couple more days, if there are no objections here that is. Regards, Patrick On Sat, Aug 27, 2016 at 1:38 PM, Benjamin Reed wrote: > haha! i'm just seconding your

Re: switching to git?

2016-08-27 Thread Benjamin Reed
haha! i'm just seconding your original proposal from many years ago! On Fri, Aug 26, 2016 at 6:15 PM, Patrick Hunt wrote: > I really love it when the new guy shows up and immediately requests tool > changes. ;-) > > afaik given we have a git mirror already, moving to git from

Re: switching to git?

2016-08-26 Thread Patrick Hunt
I really love it when the new guy shows up and immediately requests tool changes. ;-) afaik given we have a git mirror already, moving to git from an infra perspective is pretty straightforward. Definitely some impact in some other areas (like cutting a release) but we should be able to chase

Re: switching to git?

2016-08-26 Thread Michael Han
+1! On Fri, Aug 26, 2016 at 11:34 AM, Edward Ribeiro wrote: > +1 :+D > > Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" < > r...@itevenworks.net> > escreveu: > > > On 26 August 2016 at 10:35, Benjamin Reed wrote: > > > > > i'm starting to get

Re: switching to git?

2016-08-26 Thread Edward Ribeiro
+1 :+D Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" escreveu: > On 26 August 2016 at 10:35, Benjamin Reed wrote: > > > i'm starting to get back into zk development :) i'm a bit distressed that > > we are still using svn and patches managed by

Re: switching to git?

2016-08-26 Thread Raúl Gutiérrez Segalés
On 26 August 2016 at 10:35, Benjamin Reed wrote: > i'm starting to get back into zk development :) i'm a bit distressed that > we are still using svn and patches managed by jiras. i've gotten extremely > spoiled by gerritt and phabricator over the years! > > as a first step to

switching to git?

2016-08-26 Thread Benjamin Reed
i'm starting to get back into zk development :) i'm a bit distressed that we are still using svn and patches managed by jiras. i've gotten extremely spoiled by gerritt and phabricator over the years! as a first step to more efficient workflows for contributors and committers can we move to git? i