Re: Rust crate approval

2018-07-05 Thread Ehsan Akhgari
On Mon, Jul 2, 2018 at 4:05 PM, Lars Bergstrom wrote: > Cool! I was just worried, especially since hyper and tokio/mio are > *already* vendored in-tree (though openssl is not yet). It appears they're > used for network access in some test tools and an audio ipc server > prototype. So we're not ta

Please consider the impact of IPC messages triggered from JS APIs

2018-07-04 Thread Ehsan Akhgari
Hi everyone, This is a quick note to remind you of the adverse effects of IPC messages that can be sent from the content process to the parent process especially from web content Javascript accessible APIs. Let's say you have a JS callable function foo() which sends the IPC message MsgBar to the

Re: Update on rustc/clang goodness

2018-05-31 Thread Ehsan Akhgari
On Wed, May 30, 2018 at 5:02 PM, Anthony Jones wrote: > On Thursday, 31 May 2018 02:44:51 UTC+12, Tom Ritter wrote: > > Oh. Are we doing this rustc inlining development on a particular old > > version of clang? I'm not even close to getting CFI ready but I'm > > basically working off llvm trun

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-09 Thread Ehsan Akhgari
Hi Masayuki, First of all, thank you for taking on this task. I have a few questions. * What does the backwards compatibility story for these changes look like? Would we end up for example throwing exceptions or returning a different value from execCommand/queryCommandState/etc for one of the ex

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-09 Thread Ehsan Akhgari
On Thu, Apr 5, 2018 at 11:08 PM Masayuki Nakano wrote: > On 4/6/2018 2:50 AM, Ehsan Akhgari wrote: > > Hi Masayuki, > > > > First of all, thank you for taking on this task. I have a few questions. > > > > * What does the backwards compatibility story for these

Re: Intent to unprefix: ::-moz-selection.

2018-04-09 Thread Ehsan Akhgari
::-moz-selection seems like a fairly popular feature. PublicWWW claims it's seen on a million sites: https://publicwww.com/websites/%22%3A%3A-moz-selection%22/ After this change, is it feasible to detect the usage of the prefixed pseudo-element so that existing code that uses ::-moz-selection wou

Re: CPU core count game!

2018-04-09 Thread Ehsan Akhgari
On Sat, Mar 31, 2018 at 10:12 AM Steve Fink wrote: > Yes, sorry, a couple of people pointed that out to me privately. And I > did get that mixed up; I was assuming processors, despite the page > specifically pointing out "physical cores". > > I still think there's something to be kept in mind her

Re: Changes to tab min-width

2017-10-05 Thread Ehsan Akhgari
On 10/04/2017 12:43 PM, Jeff Griffiths wrote: Om my system ( retina macbook pro ) 70 is starting to look like a better compromise for tab readability. I think 70 is better than 50, but I noticed that if a foreground tab starts to play audio and we need to show the audio icon alongside the tab c

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-04 Thread Ehsan Akhgari
On 10/04/2017 03:17 AM, Jan Keromnes wrote: TL;DR -- We wrote a static analysis bot for MozReview ("clangbot") and it's about to complain about any patches that would introduce new C/C++ code defects to Firefox. This is fantastic to see, thank you for making it happen! __

Re: Device orientation/motion events privacy issues

2017-09-22 Thread Ehsan Akhgari
On 09/22/2017 11:33 AM, Blair MacIntyre wrote: What's the reason for this? I don't know for sure, but it may be necessary for things like AR/VR to have higher resolution than that. The reason is to limit the frequency of sensor data the web application receives to allow it to guesstimate the c

Re: Device orientation/motion events privacy issues

2017-09-22 Thread Ehsan Akhgari
On 09/22/2017 10:20 AM, James Willcox wrote: On Fri, Sep 22, 2017 at 8:39 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: Hi everyone, A couple of weeks ago, this proof of concept attack circled its way around Twitter: https://krausefx.github.io/whats-th

Re: Device orientation/motion events privacy issues

2017-09-22 Thread Ehsan Akhgari
On 09/22/2017 09:53 AM, Tom Ritter wrote: On Fri, Sep 22, 2017 at 8:39 AM, Ehsan Akhgari wrote: * Ensure that we don't leak this information when fingerprinting resisting is turned on for the Tor Browser if we don't already. Tor sets device.sensors.enabled to false, which shou

Device orientation/motion events privacy issues

2017-09-22 Thread Ehsan Akhgari
Hi everyone, A couple of weeks ago, this proof of concept attack circled its way around Twitter: https://krausefx.github.io/whats-the-user-doing/ This simple web app, once loaded on mobile, with a disturbing degree of accuracy, can tell what the user is doing with their phone, for example, using

Quantum Flow Engineering Newsletter #25

2017-09-21 Thread Ehsan Akhgari
[You can read a version of this with better formatting on my blog: https://ehsanakhgari.org/blog/2017-09-21/quantum-flow- engineering-newsletter-25] Hi everyone, The Quantum Flow project started as a cross-functional effort to study and fix the most serious performance issues of Firefox affecting

Re: Coding style: Argument alignment

2017-09-19 Thread Ehsan Akhgari
On 09/09/2017 12:12 PM, Mats Palmgren wrote: On 8/31/17 6:50 PM, Ehsan Akhgari wrote: On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed. I have edited the Style Guide to reflect this. Fwiw, I disagree with this decision. Here's a more

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-19 Thread Ehsan Akhgari
On 09/11/2017 06:46 PM, Eric Rahm wrote: Thanks everyone! This got a bit derailed but it's clear that a unified style for binary operators is desired. I received several emails off-list in support of my original proposal, a few people reiterated their preference for operators on the newline

Re: Canonical cinnabar repository

2017-09-18 Thread Ehsan Akhgari
y will make the SHA's incompatible with doing a direct conversion of hg which is a disadvantage. I'm not sure what's more valuable. -Jeff On Mon, Sep 18, 2017 at 2:21 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: > On 09/18/2017 01:16 PM,

Re: Canonical cinnabar repository

2017-09-18 Thread Ehsan Akhgari
it seems like a very bad choice to have to choose one of these two alternatives. The CVS history is extremely valuable to people dealing with code that still has a lot of its root back in the old days. Losing it seems like a step backwards to me. -Jeff On Mon, Sep 18, 2017 at 2:21 PM, Ehsan

Re: Canonical cinnabar repository

2017-09-18 Thread Ehsan Akhgari
On 09/18/2017 01:16 PM, Bobby Holley wrote: On Mon, Sep 18, 2017 at 8:25 AM, Andrew McCreight wrote: On Mon, Sep 18, 2017 at 7:05 AM, Kartikaya Gupta wrote: I've tried using cinnabar a couple of times now and the last time I tried, this was the dealbreaker for me. My worfklow often involves

Re: Intent to unship: Blocking Top-level Navigations to a data: URI

2017-09-15 Thread Ehsan Akhgari
Hi Christoph, On 09/15/2017 01:08 PM, Christoph Kerschbaumer wrote: Hey Everyone, we plan to prevent web pages from navigating the top-level window to a data: URI. Historically data: URIs caused confusion for end users; mostly because end users are not aware that data: URIs can encode untrust

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-15 Thread Ehsan Akhgari
On 09/14/2017 05:37 PM, Boris Zbarsky wrote: On 9/14/17 5:33 PM, Ehsan Akhgari wrote: I think either of these two ideas would be good, but I think unshipping in 57 is premature without having an understanding of how much the Web depends on this for UA sniffing. OK. Do you have any

Quantum Flow Engineering Newsletter #24

2017-09-14 Thread Ehsan Akhgari
[You can read a version of this with better formatting on my blog: https://ehsanakhgari.org/blog/2017-09-15/quantum-flow-engineering-newsletter-24 ] Hi everyone, I hope you're not tired of reading these newsletters so far. If not, I applaud your patience with me in the past few months. But next

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-14 Thread Ehsan Akhgari
On 09/13/2017 10:34 AM, Mike Taylor wrote: On 9/12/17 5:04 PM, Boris Zbarsky wrote: We could also delay the removal to after 57 to mitigate 57 risk Or remove it for non-RELEASE_OR_BETA builds for a release or two to see what shakes out in Nightly/DevEdition reports. I think either of these

Quantum Flow Engineering Newsletter #23

2017-09-07 Thread Ehsan Akhgari
Hi everyone, As was announced earlier today, Firefox 57 will be merged to the Beta channel on September 21, which is two weeks from today. That wraps up the long development cycle that has gone on for maybe about a ye

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Ehsan Akhgari
On 09/07/2017 11:16 AM, Emilio Cobos Álvarez wrote: On 09/07/2017 04:01 PM, Andrew McCreight wrote: I don't know if it rises to the level of something that should be in the style guide, but I find the names very useful as a form of lightweight documentation. Sure, if you are naming your Foo arg

Re: Firefox and clang-cl

2017-09-07 Thread Ehsan Akhgari
On 09/07/2017 10:12 AM, Ben Kelly wrote: On Thu, Sep 7, 2017 at 10:09 AM, Nathan Froyd wrote: On Thu, Sep 7, 2017 at 10:04 AM, Ben Kelly wrote: On Mon, Aug 14, 2017 at 10:44 AM, Tristan Bourvon wrote: Here's the RFC of the overflow builtins: http://clang-developers.42468.n3.nabble.com/RFC

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-07 Thread Ehsan Akhgari
On 09/07/2017 07:23 AM, Jean-Yves Avenard wrote: On Thu, Sep 7, 2017 at 3:03 AM, Eric Rahm wrote: As I said, I was hoping to avoid rehashing this point, but the general consensus from the last rather contentious post [1] was that changing from the prevalent style of the codebase for primarily a

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-07 Thread Ehsan Akhgari
On 09/07/2017 04:17 AM, Mike Hommey wrote: On Thu, Sep 07, 2017 at 12:47:51AM -0700, Chris Peterson wrote: On 2017-09-06 8:06 PM, Ehsan Akhgari wrote: The interesting points to consider is the data that Nick alluded to in the previous discussion about the existing prevalent style. Also, the

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-06 Thread Ehsan Akhgari
On 09/06/2017 09:03 PM, Eric Rahm wrote: As I said, I was hoping to avoid rehashing this point, but the general consensus from the last rather contentious post [1] was that changing from the prevalent style of the codebase for primarily aesthetic reasons was hard to justify (points about readab

Re: Kris Maglione and Andrew McCreight are now XPConnect Peers

2017-09-06 Thread Ehsan Akhgari
On 09/06/2017 07:47 PM, Bobby Holley wrote: XPConnect is not exactly a fun module. When I took the reins from mrbkap 4.5 years ago, Peter wiped a tear from his eye and said "Congratulations, Blake." Still, it's at the heart of Gecko, and needs ongoing attention from deep hackers. With the old ha

Re: Telemetry Histogram Expiry

2017-09-06 Thread Ehsan Akhgari
I don't think this probe is needed any more. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1397371 to remove it. On Wed, Sep 6, 2017 at 1:55 AM, wrote: > The following histograms will be expiring on 2017-09-20, and should be > removed from the codebase, or have their expiry versions update

Re: Stylesheet wait timeout?

2017-09-01 Thread Ehsan Akhgari
FWIW I filed https://bugzil.la/1396097 for adding a console warning which would have warned about this specific case. On 09/01/2017 12:37 PM, Boris Zbarsky wrote: On 8/31/17 3:00 PM, Michael Froman wrote: If I disable Ghostery, it no long appears to happen for me. YMMV. Michael, Thank you

Re: Eiminating nsIDOM* interfaces and brand checks

2017-09-01 Thread Ehsan Akhgari
On 09/01/2017 01:18 PM, Boris Zbarsky wrote: That has the unfortunate side-effect of allocating a new JS string for every call, but we can probably optimize it if it becomes necessary. We could add a hasClassName if we wanted. I'm kind of missing what's better about this compared to the other

Re: Eiminating nsIDOM* interfaces and brand checks

2017-09-01 Thread Ehsan Akhgari
On 09/01/2017 11:01 AM, Boris Zbarsky wrote: Anyway, we need a replacement. Some possible options: 1) Use "obj instanceof Whatever". The problem is that we'd like to maybe kill off the cross-global instanceof behavior we have now for DOM constructors. 2) Introduce chromeonly "is" methods

Re: Stylesheet wait timeout?

2017-09-01 Thread Ehsan Akhgari
On 09/01/2017 09:54 AM, Boris Zbarsky wrote: On 9/1/17 7:02 AM, Gervase Markham wrote: Restarting with no extensions causes my browser to feel a whole lot faster (I'd love to know why that is, but that's a separate issue!) Worth trying to bisect on the extensions to figure this out... Or alter

Quantum Flow Engineering Newsletter #22

2017-08-31 Thread Ehsan Akhgari
Hi everyone, With around three weeks left in the development cycle for Firefox 57, everyone seems to be busy getting the last fixes in to shape up this long-awaited release. On the Quantum Flow project, we have kept up with the triage of the incoming bug reports that are tagged as [qf], and as we

Re: Coding style: Argument alignment

2017-08-31 Thread Ehsan Akhgari
On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed. I have edited the Style Guide to reflect this. Thanks everyone! -e On Tue, Aug 29, 2017 at 11:40 PM, Martin Thomson > wrote: On Wed, Aug 30, 2017 at 12:07 PM, L. David B

Re: refcounting - which types to use ?

2017-08-26 Thread Ehsan Akhgari
On 08/24/2017 06:04 AM, jyaven...@mozilla.com wrote: On Thursday, August 24, 2017 at 11:56:53 AM UTC+2, James Cheng wrote: How could I make it compile error? I did write RefPtr xxx = yyy; xxx.forget(); You need to run the static analyser. The documentation about MOZ_MUST_USE_TYPE is explaine

Quantum Flow Engineering Newsletter #21

2017-08-24 Thread Ehsan Akhgari
Hi everyone, We're now about mid-way through the Firefox 57 development cycle. The progress of Quantum Flow bugs has been steady, we now have 65 open [qf:p1] bugs at the time of this writing and 283 fixed bugs. There are

Re: Firefox and clang-cl

2017-08-22 Thread Ehsan Akhgari
On 08/20/2017 09:19 PM, Zachary Turner via dev-platform wrote: On Monday, August 14, 2017 at 1:47:02 PM UTC-7, Hans Wennborg wrote: Yes, we want to do LTO+PGO builds eventually. (In particular, we'd like to use ThinLTO for more manageable build times.) That requires switching to using the lld li

Re: Quantum Flow Engineering Newsletter #20

2017-08-18 Thread Ehsan Akhgari
e exactly how much. Olli may be able to provide more information about that. Cheers, Ehsan > Thanks! > > -Ryan > > On Fri, Aug 18, 2017 at 1:26 AM, Ehsan Akhgari > wrote: > >> Hi everyone, >> >> It is hard to believe that we've gotten to the twentieth of

Quantum Flow Engineering Newsletter #20

2017-08-17 Thread Ehsan Akhgari
Hi everyone, It is hard to believe that we've gotten to the twentieth of these newsletters. That also means that we're very quickly approaching the finish line for this sprint. We only have a bit more than five more weeks to go before Firefox 57 merges to beta. It may be a good time to start to

Re: disabled non-e10s tests on trunk

2017-08-16 Thread Ehsan Akhgari
On 08/15/2017 04:29 PM, jma...@mozilla.com wrote: I would propose running these above tests on windows7-opt (we don't have these running yet in windows 10, although we are close), and only running specific tests which are not run in e10s mode, turning them off December 29th, 2017. Keep in mind

Re: Firefox and clang-cl

2017-08-14 Thread Ehsan Akhgari
On 08/14/2017 01:12 PM, tha...@chromium.org wrote: Hi, we (Chromium) are also happy to answer questions if there's interest. We've looked at most of these issues in some detail. Thanks Nico, much appreciated! (For the record, we have already gotten a lot of help from the Google compiler folk

Firefox and clang-cl

2017-08-12 Thread Ehsan Akhgari
Hi everyone, As you may have heard by now, Chromium has started to switch their Windows builds to use clang-cl instead of MSVC [1]. This has improved their Speedometer v2 benchmark score on x86 (but not on x86-64) by about 30% according to AWFY [2]. Over the past few days, several people have rea

Quantum Flow Engineering Newsletter #19

2017-08-10 Thread Ehsan Akhgari
Hi everyone, As usual, I have some quick updates to share about what we've been up to on improving the performance of the browser in the past week or so. Let's first look at our progress on the Speedometer benchmark. Our performance goal for Firefox 57 was to get within 20% of Chrome's benchmark

Re: Phabricator and confidential reviews

2017-08-09 Thread Ehsan Akhgari
On 08/08/2017 08:30 PM, Mark Côté wrote: First I want to double check that this is truly useful. I am not sure how often CCed users are involved with confidential bugs' patches (I might be able to ballpark this with some Bugzilla searches, but I don't think it would be easy to get a straight

Re: More Rust code

2017-08-08 Thread Ehsan Akhgari
On 08/08/2017 11:32 AM, Jeff Muizelaar wrote: On Mon, Aug 7, 2017 at 6:12 PM, Mike Hommey wrote: Note that the tp5n main_startup_fileio reflects the resulting size of xul.dll, which also impacts the installer size: 32-bits 64-bits MSVC (PGO): 37904383 40803170

Re: disabled non-e10s tests on trunk

2017-08-08 Thread Ehsan Akhgari
On 08/08/2017 06:51 PM, Blake Kaplan wrote: L. David Baron wrote: Has there been any additional effort to deal with tests that have been disabled under e10s? This change means we've essentially turned off a decent number of tests. IIRC, the last time we talked about this, there was interest i

Quantum Flow Engineering Newsletter #18

2017-08-04 Thread Ehsan Akhgari
Hi everyone, This has been a busy week. A lot of fixes have landed, setting up the Firefox 57 cycle for a good start. On the platform side, a notable change that will be in the upcoming Nightly is the fix for document.cookie using synchronous IPC. This super popular API call slows down various

Re: Actually-Infallible Fallible Allocations

2017-08-02 Thread Ehsan Akhgari
On 08/01/2017 08:16 PM, Jim Blandy wrote: I have to ask: does anyone recall the benchmarks that showed that bounds checks or vector reallocations were a measurable performance hit in this code? Extra needless bounds checks certainly have shown up in profiles, for an example see https://bugzilla.

Quantum Flow Engineering Newsletter #17

2017-07-27 Thread Ehsan Akhgari
Hi everyone, Next week, Nightly will switch to the 57 branch, beginning the development cycle of what will be the last train leaving the station towards Firefox 57. Around 5 months ago, I started writing the first on

Re: Extensions and Gecko specific APIs

2017-07-26 Thread Ehsan Akhgari
On 07/26/2017 04:58 AM, David Teller wrote: Well, at least there is the matter of feature detection, for people who want to write code that will work in more than just Firefox. moz-prefixing makes it clear that the feature can be absent on some browsers. Until the day that said other browser gets

Quantum Flow Engineering Newsletter #16

2017-07-20 Thread Ehsan Akhgari
Hi everyone, It has been almost a month and a half since the last time that I talked about our progress in fighting sync IPC issues. So I figured it's time to prepare another Sync IPC Analysis

Re: Linting for common causes of oranges in mochitests (need ideas)

2017-07-07 Thread Ehsan Akhgari
FWIW years ago I decided to act on trying to detect some of the patterns indicated on that page automatically, see https://bugzilla.mozilla.org/show_bug.cgi?id=649012. It didn't use linting (because we didn't really have any linting support back then) but the idea is the same, just with a diff

Re: Intent to unship: moz*Frames attributes of HTMLVideoElement

2017-07-07 Thread Ehsan Akhgari
On 07/07/2017 03:41 AM, Anne van Kesteren wrote: On Fri, Jul 7, 2017 at 8:51 AM, Jet Villegas wrote: Depending on what you find, we may have to keep this API around :-/ Yeah, I would expect us to follow the "normal" deprecation and remove path to be more confident in the eventual unshipping: Y

Re: Intent to unship: tree pseudo-element selectors from web content (::-moz-tree-*)

2017-07-07 Thread Ehsan Akhgari
On 07/07/2017 12:29 AM, Xidorn Quan wrote: On Fri, Jul 7, 2017, at 02:24 PM, Jet Villegas wrote: It looks like there may be a lot more of these: https://stackoverflow.com/a/25397485 How about we just stub out the Stylo impls instead of unshipping the pseudo in content? I'm not unshipping this

Quantum Flow Engineering Newsletter #15

2017-07-06 Thread Ehsan Akhgari
Hi everyone, Last week many of you attended the Mozilla All Hands at San Francisco. I didn't attend the All Hands myself but from the activity on Bugzilla it looks like it was a productive week. :-) The intention behind the work week this time was to do focused work leveraging the face to face

Re: C++ performance test harness?

2017-07-05 Thread Ehsan Akhgari
On 07/05/2017 08:36 AM, Emilio Cobos Álvarez wrote: On 07/05/2017 10:19 AM, Henri Sivonen wrote: Do we have a gtest analog for local performance testing? That is, something that makes it easy to microbenchmark libxul methods? For CSS parsing there is a benchmark using MOZ_GTEST_BENCH[1]. From

Re: Switching to per-channel profiles

2017-06-27 Thread Ehsan Akhgari
On 06/27/2017 01:36 PM, Milan Sreckovic wrote: I don't know how common this workflow is for others, but I do find I often need to use release/beta to "fix" experimental preferences when things go wrong. For features that are behind a preference, in nightly, if I set the preference, which leads

Re: Quantum Flow Engineering Newsletter #14

2017-06-26 Thread Ehsan Akhgari
On 06/26/2017 09:52 AM, Armen Zambrano Gasparnian wrote: On Friday, 23 June 2017 10:05:42 UTC-4, Ehsan Akhgari wrote: On Fri, Jun 23, 2017 at 4:19 AM, Chris Peterson wrote: On 6/23/17 12:17 AM, Ehsan Akhgari wrote: But to speak of a more direct measurement of performance, let's lo

Re: Quantum Flow Engineering Newsletter #14

2017-06-23 Thread Ehsan Akhgari
On Fri, Jun 23, 2017 at 4:19 AM, Chris Peterson wrote: > > > On 6/23/17 12:17 AM, Ehsan Akhgari wrote: > > But to speak of a more direct measurement of performance, let's look at > our progress on Speedometer V2 > <https://github.com/WebKit/webkit/tree/master

Quantum Flow Engineering Newsletter #14

2017-06-23 Thread Ehsan Akhgari
Hi everyone, We have about 13 more weeks before the train of Firefox 57 leaves the station. Next week many of you will be at the upcoming work week, so I thought it may be a good time to have some retrospection over our progress so far, just so that you can get a good sense of how to extrapolate

Re: Intent to unship: HTML scoped style sheets (

2017-06-21 Thread Ehsan Akhgari
On 06/20/2017 01:20 AM, Cameron McCormack wrote: On Tue, Jun 20, 2017, at 01:08 PM, Jared Wein wrote: We use a scoped stylesheet for styling the popup for [1]. We chose this route to limit performance impact as well as limit our temporary stylesheet from affecting other parts of the browser UI.

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Ehsan Akhgari
On 06/21/2017 06:19 AM, Chris Cooper wrote: On Tuesday, June 20, 2017 at 1:28:50 PM UTC-4, Ehsan Akhgari wrote: My understanding is that the slowdown cannot be reproduced on local developer machines, but can be reproduced on loaner machines from infra. Huh. That's interesting and even

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Ehsan Akhgari
On 06/20/2017 04:42 PM, Gregory Szorc wrote: On Tue, Jun 20, 2017 at 10:28 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com&g

Re: Using the accesskey attribute with HTML elements in browser chrome

2017-06-20 Thread Ehsan Akhgari
On 06/20/2017 04:36 PM, Brian Grinstead wrote: On Jun 19, 2017, at 6:58 PM, Ehsan Akhgari wrote: On 06/19/2017 04:28 PM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Ehsan Akhgari
On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari wrote: On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine

Re: Errors found by cppcheck

2017-06-20 Thread Ehsan Akhgari
n here is a good one. We have used a similar mechanism to run valgrind for example and it has worked successfully in the past. I wonder if this is something that Sylvestre's team would be interested to take a look at? Cheers, Ehsan On Sun, Jun 18, 2017 at 3:08 PM, Ehsan Akhgari mailto:e

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Ehsan Akhgari
On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine, but differently on infrastructure), but we haven't tracked that down yet. From comment 104 it seems th

Re: Using the accesskey attribute with HTML elements in browser chrome

2017-06-19 Thread Ehsan Akhgari
On 06/19/2017 04:28 PM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the differences between the attribute in HTML and XUL that I've found so far: 1) In XUL (https://developer

Re: Errors found by cppcheck

2017-06-18 Thread Ehsan Akhgari
Is it possible to run cppcheck in a mode where we select which checks it runs? If yes, we could look at the list of true positives that people have found (and continue to find) in bug 1370292 and create an opt-in set of checks that rare valuable ones to have turned on by default, and leave the

Re: Shipping Headless Firefox on Linux

2017-06-16 Thread Ehsan Akhgari
On 06/16/2017 10:31 AM, Dan Mosedale wrote: 2017-06-16 6:22 GMT-07:00 Ehsan Akhgari <mailto:ehsan.akhg...@gmail.com>>: On 06/15/2017 04:37 PM, Nathan Froyd wrote: Would it be feasible to use headless mode for mochitests (or reftests, etc. etc.)? Ru

Re: Shipping Headless Firefox on Linux

2017-06-16 Thread Ehsan Akhgari
On 06/15/2017 04:37 PM, Nathan Froyd wrote: On Thu, Jun 15, 2017 at 2:02 PM, Brendan Dahl wrote: Headless will run less of the platform specific widget code and I don't recommend using it for platform specific testing. It is targeted more at web developers and testing regular content pages. The

Quantum Flow Engineering Newsletter #13

2017-06-15 Thread Ehsan Akhgari
Hi everyone, I'm back with some more updates on another week worth of work on improving various performance aspects of Firefox. Similar to the past weeks, Speedometer remains a big focus area for performance work. In addition to the many already

Re: Changing .idl files

2017-06-14 Thread Ehsan Akhgari
On 06/14/2017 09:02 AM, Benjamin Smedberg wrote: On Tue, Jun 13, 2017 at 8:40 PM, Nicholas Nethercote wrote: (3) Do extensions use it? If so, changing it probably isn't possible. This can be imperfectly determined by searching through addons/ in DXR. There is no rule that we can't break old-

Quantum Flow Engineering Newsletter #12

2017-06-08 Thread Ehsan Akhgari
Hi everyone, It has been a few weeks since I have given an update about our progress on reducing the amount of slow synchronous IPC messages that we send across our processes. This hasn't been because there hasn't been a lot to talk about, quite to the contrary, so much great work has happened he

Re: Intent to unship: window.showModalDialog

2017-06-08 Thread Ehsan Akhgari
There was some recent activity around this in https://bugzilla.mozilla.org/show_bug.cgi?id=840640. Tim, what's the latest status on this? Are you still working on it? On 06/08/2017 09:08 AM, Mike Taylor wrote: On 6/7/17 5:23 PM, Blake Kaplan wrote: 3 years ago (!) sicking commented in bug

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Ehsan Akhgari
On 06/01/2017 08:51 PM, Mike Hommey wrote: Hi, For some reason, the default when building on Linux had stayed -Os. I just landed a change[1] to this default to now use -O2 instead (on autoland at the moment). This is going to give better performance to local builds (although that might make the

Quantum Flow Engineering Newsletter #11

2017-06-01 Thread Ehsan Akhgari
Hi everyone, Keeping track of ongoing progress and how much more work different areas need is important. I've found the new Firefox Health Dashboards that Harald Kirschner and the team have worked on extremely helpful. You can see the status of the ongoing work

Re: Improving visibility of compiler warnings

2017-05-25 Thread Ehsan Akhgari
On 05/25/2017 02:14 PM, Gregory Szorc wrote: On Thu, May 25, 2017 at 5:31 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: What was the motivation behind this change? Was there a complaint from a significant number of developers about it being difficult fixing co

Re: Improving visibility of compiler warnings

2017-05-25 Thread Ehsan Akhgari
On 05/19/2017 02:44 PM, Gregory Szorc wrote: `mach build` attempts to parse compiler warnings to a persisted "database." You can view a list of compiler warnings post build by running `mach warnings-list`. The intent behind this feature was to make it easier to find and fix compiler warnings. Aft

Quantum Flow Engineering Newsletter #10

2017-05-18 Thread Ehsan Akhgari
Hi everyone, Let's start this week's updates with looking at the ongoing efforts to improve the usefulness of the background hang reports data. With Ben Miroglio's help, we confirmed that we aren't blowing up telemetry ping si

Re: Gecko Profiler Win64 stability

2017-05-18 Thread Ehsan Akhgari
I secretly demoed this today in a live demo tutorial demonstrating the Gecko Profiler over Vidyo on the latest Win64 Nightly. Thanks for improving things so much, David! On 05/18/2017 03:04 PM, David Major wrote: Hi, The Gecko Profiler used to be notoriously unstable on 64-bit Windows. (If

Re: Have you run 'mach bootstrap' lately?

2017-05-12 Thread Ehsan Akhgari
On 05/12/2017 06:59 PM, Dustin Mitchell wrote: Yep, this caused problems in automation (we ended up setting I_PREFER_A_SUBOPTIMAL_MERCURIAL_EXPERIENCE_THANK_YOu or whatever the env var was). I agree that a quick warn-and-continue would be fine. Especially for git users. ;-) Speaking of naggin

Re: Quantum Flow Engineering Newsletter #9

2017-05-12 Thread Ehsan Akhgari
On 05/12/2017 12:29 PM, Tom Ritter wrote: On Fri, May 12, 2017 at 1:27 AM, Ehsan Akhgari wrote: I realized we haven't had a performance mini-story for a while -- I sort of dropped the ball on that. Running over this bug made me want to talk about a pretty well known sort of slowness

Re: Intent to Ship throttling of tracking timeouts

2017-05-11 Thread Ehsan Akhgari
On Thu, May 11, 2017 at 11:32 PM, Bill McCloskey wrote: > On Thu, May 11, 2017 at 8:12 PM, Boris Zbarsky wrote: > > > On 5/11/17 10:30 PM, Eric Shepherd (Sheppy) wrote: > > > >> So part of private browsing and not a developer-facing feature, then? > >> > > > > No, as I understand this is being a

Quantum Flow Engineering Newsletter #9

2017-05-11 Thread Ehsan Akhgari
Hi everyone, It's been 10 weeks since I have started writing these newsletters (the number in the title isn't an off by one error, there was a one week hiatus due to a work week!). We still have quite a bit of work ahead of us, but we have also accomplished a good amount. Finding a good metric f

Re: Intent to ship: SharedArrayBuffer and Atomics

2017-05-11 Thread Ehsan Akhgari
On 05/11/2017 09:09 AM, Lars Hansen wrote: On Thu, May 11, 2017 at 3:00 PM, Bobby Holley wrote: On Thu, May 11, 2017 at 2:48 PM, Lars Hansen wrote: On Thu, May 11, 2017 at 10:55 AM, Martin Thomson wrote: On Thu, May 11, 2017 at 5:57 PM, Lars Hansen wrote: We do think there are archite

Re: Running mochitest on packaged builds with the sandbox

2017-05-09 Thread Ehsan Akhgari
and it is only then when they start to search for relevant documentation in a place related to sandboxing. Now let's go back to discussing the actual topic of the thread. Thanks for indulging the momentary digression from the topic at hand. :-) Cheers, Ehsan Cheers, Alex On Tue,

Re: Running mochitest on packaged builds with the sandbox

2017-05-09 Thread Ehsan Akhgari
Hi Alex, Apologies for hijacking the thread, but since you asked, right now debugging mochitest that you want to get some logging out of with a sandboxed content process is super painful. I last hit it when I was debugging a memory leak which typically requires getting refcount leak logs and

Re: Notification() deprecation question

2017-05-08 Thread Ehsan Akhgari
AFAIK this was discussed at the spec level in https://github.com/whatwg/notifications/issues/26 and the conclusion was to *not* deprecate the construcutor for the non-persistent notifications. Perhaps something has changed afterwards? On 05/08/2017 03:09 AM, Chris Mills wrote: Hi there, I

Re: Mixing nsresult and Result code

2017-05-08 Thread Ehsan Akhgari
I think these seem like valuable additions to nscore.h. It would be helpful to extend these facilities that would allow more code to use the Result-based programming model. (I'm not too much of a fan of the NS_TRY name, but can't think of a better name myself... :/ ) On 05/07/2017 03:34 PM

Re: Future of out-of-tree spell checkers?

2017-05-07 Thread Ehsan Akhgari
(Sorry for the continued laggy responses here...) On 04/27/2017 03:38 AM, Henri Sivonen wrote: For a while we've been trying to make it difficult for semi-legit-but-not-quite-malware parties to load crappy code into Firefox (I'm thinking of crappy antivirus software, adware, etc.). Removing bi

Quantum Flow Engineering Newsletter #8

2017-05-05 Thread Ehsan Akhgari
Hi everyone, I hope you are still not tired of reading these! :-) If not, time for another quick update about the ongoing performance related work. There are two important changes that have landed in Nightly. The first one is that Nightly (on Windows 32-bit builds) sends native stacktraces wit

Re: Ambient Light Sensor API

2017-04-27 Thread Ehsan Akhgari
On 04/27/2017 08:09 AM, Frederik Braun wrote: On 27.04.2017 13:56, smaug wrote: On 04/25/2017 04:38 PM, Ehsan Akhgari wrote: On 04/24/2017 06:04 PM, Martin Thomson wrote: I think that 60Hz is too high a rate for this. I suggest that we restrict this to top-level, foreground, and secure

Quantum Flow Engineering Newsletter #7

2017-04-27 Thread Ehsan Akhgari
Hi everyone, It's time for another quick update about the recent Quantum Flow work. I want to start by shedding some light into the performance of synchronous IPC caused by JavaScript. Here is a breakdown report

Re: Future of out-of-tree spell checkers?

2017-04-26 Thread Ehsan Akhgari
On 04/26/2017 07:02 AM, Henri Sivonen wrote: On Tue, Apr 25, 2017 at 9:02 PM, Bill McCloskey wrote: On Tue, Apr 25, 2017 at 5:41 AM, Henri Sivonen wrote: What problem did you mean to address by code signing? The reason I suggested code signing is because loading libvoikko would provide an ea

Re: Ambient Light Sensor API

2017-04-26 Thread Ehsan Akhgari
hat have an event handler for this or some such which bug 1359124 was filed for. On Wed, Apr 26, 2017 at 5:28 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 04/25/2017 08:26 PM, Salvador de la Puente wrote: So the risk is not that high since if the image

Re: Ambient Light Sensor API

2017-04-26 Thread Ehsan Akhgari
<http://evil.com> for further >> processing? >> How it is possible for evil.com <http://evil.com> to get access to protected resources? >> >> On Tue, Apr 25, 2017 at 8:04 PM, Ehsan Akhgari mailto:ehsan.akhg...@

<    1   2   3   4   5   6   7   8   9   10   >