Re: Unified compilation is going to ride the train

2015-01-13 Thread Ehsan Akhgari
I have started to work on removing support for non-unified builds over in bug 1121000.x On Thu, Nov 27, 2014 at 8:12 PM, Mike Hommey m...@glandium.org wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively

Re: Unified compilation is going to ride the train

2014-12-02 Thread Ryan VanderMeulen
On 11/27/2014 9:28 PM, Ehsan Akhgari wrote: Another point in favor of dropping support for non-unified builds is that it frees up some infrastructure resources that is currently used to test those builds, and also makes the builds in some configurations where we build non-unified by default

Re: Unified compilation is going to ride the train

2014-12-02 Thread Ehsan Akhgari
On 2014-12-01 10:22 PM, Karl Tomlinson wrote: On Fri, 28 Nov 2014 00:46:07 -0800, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources,

Re: Unified compilation is going to ride the train

2014-12-01 Thread Karl Tomlinson
On Fri, 28 Nov 2014 00:46:07 -0800, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources, mostly) won't be ensured. Do you think this is

Re: Unified compilation is going to ride the train

2014-11-28 Thread L. David Baron
On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources, mostly) won't be ensured. Do you think this is important enough to keep non-unified builds around? Another

Re: Unified compilation is going to ride the train

2014-11-28 Thread Mike Hommey
On Fri, Nov 28, 2014 at 11:57:56AM +0900, ISHIKAWA,chiaki wrote: On 2014/11/28 10:12, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year

Re: Unified compilation is going to ride the train

2014-11-28 Thread Mike Hommey
On Fri, Nov 28, 2014 at 12:46:07AM -0800, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources, mostly) won't be ensured. Do you think

Re: Unified compilation is going to ride the train

2014-11-28 Thread Mike Hommey
On Fri, Nov 28, 2014 at 06:29:49PM +0900, Mike Hommey wrote: On Fri, Nov 28, 2014 at 12:46:07AM -0800, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes

Re: Unified compilation is going to ride the train

2014-11-28 Thread Jonathan Kew
On 28/11/14 08:46, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources, mostly) won't be ensured. Do you think this is important enough to

Re: Unified compilation is going to ride the train

2014-11-28 Thread Nicolas B. Pierron
On 11/28/2014 11:06 AM, Jonathan Kew wrote: On 28/11/14 08:46, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right includes in the right sources, mostly) won't be

Re: Unified compilation is going to ride the train

2014-11-28 Thread Ehsan Akhgari
On 2014-11-28 6:17 AM, Nicolas B. Pierron wrote: On 11/28/2014 11:06 AM, Jonathan Kew wrote: On 28/11/14 08:46, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified build *will* be broken, and code purity (right

Re: Unified compilation is going to ride the train

2014-11-28 Thread ISHIKAWA,chiaki
On 2014/11/28 18:26, Mike Hommey wrote: On Fri, Nov 28, 2014 at 11:57:56AM +0900, ISHIKAWA,chiaki wrote: On 2014/11/28 10:12, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of

Re: Unified compilation is going to ride the train

2014-11-28 Thread Jonathan Kew
On 28/11/14 14:36, Ehsan Akhgari wrote: The question is: what do we gain from doing that, technical purity aside? Note that as Mike mentioned, even with doing both unified and non-unified builds, you may still get build failures when adding/removing .cpp files, so keeping support for

Re: Unified compilation is going to ride the train

2014-11-28 Thread Nicolas B. Pierron
On 11/28/2014 03:36 PM, Ehsan Akhgari wrote: On 2014-11-28 6:17 AM, Nicolas B. Pierron wrote: On 11/28/2014 11:06 AM, Jonathan Kew wrote: On 28/11/14 08:46, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The downside from doing so, though, is that non-unified

Re: Unified compilation is going to ride the train

2014-11-28 Thread Ehsan Akhgari
On 2014-11-28 11:02 AM, Jonathan Kew wrote: On 28/11/14 14:36, Ehsan Akhgari wrote: The question is: what do we gain from doing that, technical purity aside? Note that as Mike mentioned, even with doing both unified and non-unified builds, you may still get build failures when adding/removing

Re: Unified compilation is going to ride the train

2014-11-28 Thread Ehsan Akhgari
On 2014-11-28 11:18 AM, Nicolas B. Pierron wrote: On 11/28/2014 03:36 PM, Ehsan Akhgari wrote: On 2014-11-28 6:17 AM, Nicolas B. Pierron wrote: On 11/28/2014 11:06 AM, Jonathan Kew wrote: On 28/11/14 08:46, L. David Baron wrote: On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: The

Unified compilation is going to ride the train

2014-11-27 Thread Mike Hommey
Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year later, it's time to revisit this decision, and since afaik we haven't had problems specific to unified compilation

Re: Unified compilation is going to ride the train

2014-11-27 Thread Ehsan Akhgari
On 2014-11-27 8:12 PM, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year later, it's time to revisit this decision, and since afaik we haven't

Re: Unified compilation is going to ride the train

2014-11-27 Thread Ehsan Akhgari
On 2014-11-27 9:16 PM, Ehsan Akhgari wrote: On 2014-11-27 8:12 PM, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year later, it's time to

Re: Unified compilation is going to ride the train

2014-11-27 Thread ISHIKAWA,chiaki
On 2014/11/28 10:12, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year later, it's time to revisit this decision, and since afaik we haven't had