Re: Should &&/|| really be at the end of lines?

Hi On 16/02/17 23:56, Jeff Gilbert wrote: I don't visually like ||/&& at start of line, but I can't fault the reasoning, so I'm weakly for it. I don't think it's important enough to change existing code though. Disclaimer: I'm now biased about this. I've been writing C and C++ code for now m

Re: Should &&/|| really be at the end of lines?

On 17/02/17 00:17, Jeff Gilbert wrote: If there are so many parens that we require an editor to disambiguate them, it's too dense. Add whitespace or decompose the expression until readable. I'd love to know how adding any whitespaces could make any logical expressions clearer that what I post

Re: Should &&/|| really be at the end of lines?

On 17/02/17 23:18, gsquel...@mozilla.com wrote: Hi again Nick, Someone made me realize that I didn't fully read your message, sorry for that. I now see that as well as &&/||, you have grepped for other operators, and shown that the overwhelming usage is to put all of them at the end of lines

Re: The future of commit access policy for core Firefox

> On 12 Mar 2017, at 9:40 pm, Ehsan Akhgari wrote: > And I still don't understand what the proposal means with rebases in > practice. What if, after automation tries to land your change after you > got your final r+ the final rebase fails and you need to do a manual > rebase? Do you need to get

Re: The future of commit access policy for core Firefox

minutes to 3.5 days…. How is that making our tree safer? JY > On 15 Mar 2017, at 4:15 pm, Mike Hoye wrote: > > > > On 2017-03-14 7:10 PM, Jean-Yves Avenard wrote: >> /me just loves when a new set of “rules” are put in place to prevent a >> problem that has never e

Re: windows build anti-virus exclusion list?

Hi.  I have received the new Dell XPS 15 9560 and got very puzzled as to why compiling central was so slow on this machine.  This is comparing against a Gigabyte Aero 14 with a gen 6 intel CPU (2.6Ghz i7-6600HQ) vs Dell's 7th gen (2.8Ghz i7-7700HQ) On the Aero 14, compiling central takes 24 minu

Re: Rationalising Linux audio backend support

On Fri, Mar 31, 2017 at 3:49 PM, Chris Coulson wrote: > The Firefox package in Ubuntu is maintained by 1 contributor in his > spare time and myself who is only able to do the minimum in order to > provide updates, so Ubuntu flavors that don't ship Pulseaudio need to > step up to maintain this code

Re: 64-bit Firefox progress report: 2017-07-18

Hi On Wed, Jul 19, 2017 at 9:01 AM, Mike Hommey wrote: > What's the plan for eligible people that still want to keep 32-bit > Firefox? Are they going to have to stop auto upgrades, which would get > them automatically on 64-bits and upgrade manually? This is especially > going to be a problem for

Re: Response.body streams landing on trunk, default off

> On 14 Aug 2017, at 4:14 pm, Ben Kelly wrote: > > FYI, the Fetch API side of streams has landed and is now in nightly. > Please test and file bugs. Thanks! > > Ben Awesome thank you. JY ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Coding style: Placement of binary operators when breaking a long line

On Thu, Sep 7, 2017 at 3:03 AM, Eric Rahm wrote: > As I said, I was hoping to avoid rehashing this point, but the general > consensus from the last rather contentious post [1] was that changing from > the prevalent style of the codebase for primarily aesthetic reasons was > hard to justify (points

Re: Coding style question: Meaningless argument names in declarations

not answering your question yet, but... On Thu, Sep 7, 2017 at 2:07 PM, Emilio Cobos Álvarez wrote: > > enum class Operation { > // .. > }; that should be: enum class Operation { // ... }; https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structur

Re: Canonical cinnabar repository

On Mon, Sep 18, 2017 at 4:05 PM, Kartikaya Gupta wrote: > > I've tried using cinnabar a couple of times now and the last time I > tried, this was the dealbreaker for me. My worfklow often involves > moving a branch from one machine to another and the extra hassle that > results from mismatched SH

Re: Intent to require `mach try` for submitting to Try

On Tue, Sep 19, 2017 at 7:21 PM, Eric Rescorla wrote: > I've also had cinnabar fail badly at various times, and then it's been > pretty unclear what > the service level guarantees for that were. > > time to try again maybe? I use git with cinnabar on windows, linux and mac, and I haven't had any

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

Hi Do you have ways to prevent running this code on some external frameworks? Whenever we modify a gtest this causes hundreds of errors about not using a default constructor … (which shouldn’t be an error anyway) > On 9 Oct 2017, at 4:33 pm, Jan Keromnes wrote: > > > C/C++ was our top priori

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

With all this talk… I’m eagerly waiting for the iMac Pro. Best of all worlds really: - High core count - ECC RAM - 5K 27” display - Great graphic card - Super silent… I’ve been using a Mac Pro 2013 (the trash can one), Xeon E5 8 cores, 32 GB ECC RAM, connected to two 27” screens (one 5K with DP

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

With all this talk… I’m eagerly waiting for the iMac Pro. Best of all worlds really: - High core count - ECC RAM - 5K 27” display - Great graphic card - Super silent… I’ve been using a Mac Pro 2013 (the trash can one), Xeon E5 8 cores, 32 GB ECC RAM, connected to two 27” screens (one 5K with DP

Re: Building mozilla-central with clang + icecream

> On 7 Nov 2017, at 2:48 am, zbranie...@mozilla.com wrote: > > I tried to build m-c today with clang 5.0 and icecream using the following > mozconfig: > > > ``` > mk_add_options MOZ_MAKE_FLAGS="-j$(icecc-jobs)" > > mk_add_options 'export CCACHE_PREFIX=icecc' > mk_add_options "export RUSTC_WR

Using icecream distributed compiler with a mac...

Hi there. Last week I spent a bit of time getting icecream working and usable with mac builds (on mac). The generated binary can be used with a debugger, all stack traces are good. The repository with the various required files and the steps to follow are available there. https://github.com/jyav

Re: Faster gecko builds with IceCC on Mac and Linux

Sorry for resuming an old thread. But I would be interested in knowing how long that same Lenovo P710 takes to compile *today*…. In the past 6 months, compilation times have certainly increased massively. Anyhow, I’ve received yesterday the iMac Pro I ordered early December. It’s a 10 cores Xeo

Re: Faster gecko builds with IceCC on Mac and Linux

> On 16 Jan 2018, at 7:02 pm, Ralph Giles wrote: > > On my Lenovo P710 (2x2x6 core Xeon E5-2643 v4), Fedora 27 Linux > > debug -Og build with gcc: 12:34 > debug -Og build with clang: 12:55 > opt build with clang: 11:51 I didn’t succeed in booting linux unfortunately. so I can’t compare… 12 mi

Re: Faster gecko builds with IceCC on Mac and Linux

> On 16 Jan 2018, at 8:19 pm, Jean-Yves Avenard wrote: > > > >> On 16 Jan 2018, at 7:02 pm, Ralph Giles > <mailto:gi...@mozilla.com>> wrote: >> >> On my Lenovo P710 (2x2x6 core Xeon E5-2643 v4), Fedora 27 Linux >> >> debug -Og buil

Re: Faster gecko builds with IceCC on Mac and Linux

> On 17 Jan 2018, at 8:14 pm, Ralph Giles wrote: > > Something simple with the jobserver logic might work here, but I think we > want to complete the long-term project of getting a complete dependency > graph available before looking at that kind of optimization. Just get every person needing

Re: Faster gecko builds with IceCC on Mac and Linux

Hi > On 17 Jan 2018, at 12:38 am, Gregory Szorc wrote: > > On an EC2 c5.17xlarge (36+36 CPUs) running Ubuntu 17.10 and using Clang 5.0, > 9be7249e74fd does a clobber but configured `mach build` in 7:34. Rust is very > obviously the long pole in this build, with C++ compilation (not linking) >

Re: Faster gecko builds with IceCC on Mac and Linux

Hi So I got this to work under all platforms (OS X , Ubuntu 17.10 and Windows 10) Stock speed, no OC of any type. macOS: 7m32s Windows 10: 12m20s Linux Ubuntu 17.10 (had to install kernel 4.15): 6m04s So not much better than the iMac Pro 10 cores… > On 2 Feb 2018, at 7:54 pm, Jean-Y

Re: Please try out clang-cl and lld-link on Windows

Thank you David for this awesome work... 8:26.77 Your build was successful! on windows !! Who would have known we would ever get there... (I had to uninstall my local install of LLVM nightly, run ./mach bootstrap again.. The wiki should be amended with this, it gives confusing results otherwie

Re: PSA: new helper class for MozPromise in DOM code

Hi > On 26 Apr 2018, at 10:12 pm, Ben Kelly wrote: > > Hi all, > > I pushed a new helper class to inbound today to make it easier to work with > MozPromise in DOM code. Specifically, it allows you to auto-disconnect a > Thenable request when the global dies. > > The class is called DOMMozProm

Re: Removing tinderbox-builds from archive.mozilla.org

Hi On 12/05/2018 04:47, Boris Zbarsky wrote: Just to be clear, when doing a bisect, one _can_ just deal with local builds.  But the point is that then it takes tens of minutes per build as you point out.  So a bisect task that might otherwise take 10-15 minutes total (1 minute per downloaded

Intent to ship: media-capabilities

Media Capabilities allow for web sites to better determine what content to serve to the end user. Currently a media element offers the canPlayType method (https://html.spec.whatwg.org/multipage/media.html#dom-navigator-canplaytype-dev

Re: Intent to ship: media-capabilities

Hi > On 14 May 2018, at 6:47 pm, Tom Ritter wrote: > > It seems like this will reveal a lot of information about the user's > hardware. Does the Resist Fingerprinting preference disable the API or > report standardized results? If not, can we get that bug on file (and > if it's easy, point out e

Re: Intent to ship: media-capabilities

Hi > On 14 May 2018, at 6:53 pm, Boris Zbarsky wrote: > > On 5/14/18 11:19 AM, Jean-Yves Avenard wrote: >> The proposed spec is available at https://wicg.github.io/media-capabilities/ >> <https://wicg.github.io/media-capabilities/> > > I have some

Re: PSA: No more mozilla::Move

> On 2 Jun 2018, at 9:56 am, Emilio Cobos Álvarez wrote: > > Hi, just a quick PSA: > > In bug 1465585 I switched all uses of mozilla::Move to std::move, and > removed the former. > > The reasoning for that is that it allows compilers to detect misuses of > std::move and warn about them (-Wpes

Re: PSA: No more mozilla::Move

> On 2 Jun 2018, at 3:45 pm, Jean-Yves Avenard wrote: >> >> Beware of some local mac builds maybe being broken. That should be fixed >> by bug 1270217 (thanks jwatt!). > > > FWIW, this breaks build with clang 6.0.0 on mac… > > such as: > 0:04.70 >

Re: Coding style: brace initialization syntax

> On 5 Jun 2018, at 12:54 pm, bposteln...@mozilla.com wrote: > > I would like to resurrect this thread since it would help us a lot for bug > 1453795 to come up to a consensus on when to use bracelets and when to use > parenthesis. Also I must point out a thing here, that was also mentioned he

Re: Coding style: Making the `e` prefix for enum variants not mandatory?

On 29/06/2018 16:58, Boris Zbarsky wrote: On 6/29/18 10:30 AM, Nathan Froyd wrote: Given the language-required qualification for `enum class` and a more Rust-alike syntax, I would feel comfortable with saying CamelCase `enum class` is the way to go. For what it's worth, I agree.  The point o

Re: PSA: pay attention when setting multiple reviewers in Phabricator

On Mon, Jul 2, 2018 at 5:01 PM, Andreas Tolfsen wrote: > Also sprach Marco Bonardo: > > > When asking for review to multiple reviewers, and all of them must accept > > your revision, you must mark them as blocking reviews, either in the > > Phabricator ui or appending "!" at the end of the review

Re: Intent to ship: media-capabilities

uTube. On mac in particular it would allow to re-enable the free vp9 codec (which has been disabled due to performance reason) Kind regards Jean-Yves On Mon, May 14, 2018 at 5:19 PM, Jean-Yves Avenard wrote: > Media Capabilities allow for web sites to better determine what content to > s

Re: open socket and read file inside Webrtc

Hi On 05/07/2018 10:16, amantell...@gmail.com wrote: I want to open a file inside webrtc core part. If you could extend the reasons on the why it would allow us to help you. What is your ultimate objective? why do you think you need to open a file inside webrtc core? Is it because you w

Re: PSA: pay attention when setting multiple reviewers in Phabricator

Hi On 05/07/2018 19:19, Mark Côté wrote: This is, however, something we can address with our new custom commit-series-friendly command-line tool. We are also working towards the superior solution of automatically selecting reviewers based on module owners and peers and enforcing this in Lan

Re: Intent to ship: block audible autoplay media intervention

Hi On 05/07/2018 17:10, Mounir Lamouri wrote: FWIW, WebKit uses the audio track availability and Blink intends to do this at some point. There are fundamental technical issues to resolve before this can be achieved. And at this stage, I'm not convinced it could ever be achieved, nor if th

Re: Compile webrtc from source in firefox

On 05/07/2018 10:17, amantell...@gmail.com wrote: Hi, I don't understand which webrtc code is used by firefox builder. I need to modify the webrtc part and recompile it to be used by firefox. any help? Firefox use its own copy, the code is found in media/webrtc

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

Hi That’s great info, thank you. There’s one place where we could gain heaps is in the media stack. Currently, each content process allocate a thread-pool with at least 8 threads for use with the media decoders, each threads a default stack size of 256kB. (https://searchfox.org/mozilla-central/s

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

Hi > On 11 Jul 2018, at 10:10 pm, Kris Maglione wrote: > Thanks. Boris added this as a blocker. > > It looks like it will be helpful, but unfortunately won't give us the 2MB > simple arithmetic would suggest. On Windows, at least, (and probably > elsewhere, but need to confirm) thread stacks a

Re: PSA: Automated code analysis now also in Phabricator

Hi > On 17 Jul 2018, at 3:22 pm, Jan Keromnes wrote: > > TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential > defects in pending patches for Firefox. > > Last year, we announced Code Review Bot (“reviewbot”, née “clangbot”), a > Taskcluster bot that analyzes every patch

Re: PSA: Major preference service architecture changes inbound

Hi I believe that this change may be the caused of https://bugzilla.mozilla.org/show_bug.cgi?id=1477254 That is, the pref value set in all.js no longer overrides the default value set in StaticPrefs. The problem occurs mostly with e10s on,

Intent to ship MediaSource SourceBuffer.changeType

Summary: enable by default changeType method on MediaSource’s Source Buffer, allowing to change content type (codecs and/or container) on the fly… The method has been availably since 61 behind the preference media.mediasource.experimental.enabled Bug: https://bugzilla.mozilla.org/show_bug.cgi?i

Re: Intent to ship MediaSource SourceBuffer.changeType

Hi > On 6 Aug 2018, at 9:12 pm, Nils Ohlmeier wrote: > > Which version of Firefox are you planing to ship this? > > Thanks > Nils Sorry, my bad. 63.. The feature was introduced in 61. smime.p7s Description: S/MIME cryptographic signature ___ dev-

Re: Intent to ship MediaSource SourceBuffer.changeType

> On 6 Aug 2018, at 10:30 pm, Boris Zbarsky wrote: > > On 8/6/18 5:37 AM, Jean-Yves Avenard wrote: >> enable by default changeType method on MediaSource’s Source Buffer > > To be clear, this is enabling by default on all channels, right? yes > >> The meth

Re: Intent to ship MediaSource SourceBuffer.changeType

> On 7 Aug 2018, at 5:24 pm, Boris Zbarsky wrote: > > OK. Do you have any signals at all from Safari and Edge? Even just knowing > "not opposed in current form but no concrete plans to implement" would be > useful, compared to them suddenly coming back with requests for changes in > the sp

Re: About static analyzers on some various projects

On Friday, September 25, 2015 at 7:29:19 AM UTC+10, Ehsan Akhgari wrote: > On 2015-09-24 1:41 PM, Sylvestre Ledru wrote: > > = Static analyzers = > > For now, we are running: > > * Coverity, a proprietary tool with a great (but slow) web interface. As > > Firefox is Free software, the service is pr

Re: Proposal: use nsresult& outparams in constructors to represent failure

On Thursday, April 21, 2016 at 11:15:10 AM UTC+10, Nicholas Nethercote wrote: > The only disadvantage I can see is that it looks a bit strange at first. But > if > we started using it that objection would quickly go away. > > I have some example patches that show what this code pattern looks like

Re: Proposal: use nsresult& outparams in constructors to represent failure

On Tuesday, April 26, 2016 at 3:39:53 AM UTC+10, Botond Ballo wrote: > That's why we have explicit operator bool() in C++11. That only allows Indeed. explicit operator was implied. Here is an example of definition: https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaData.h#201

Re: Generating Visual Studio project files by default

On Wednesday, May 25, 2016 at 9:00:48 AM UTC+10, Gregory Szorc wrote: > This change was tracked in bug 1275297. Bug 1275419 tracks a follow-up to > allow disabling their generation. so when is xcode support coming too ? :) ___ dev-platform mailing list d

Intent to ship: MediaError::message attribute

Hi As of December 13th 2016, I intend to turn MediaError::message attribute on by default on all platforms. It has been developed behind the dom.MediaError.message.enabled preference. Other UAs shipping this or intending to ship it are chrome and edge (that I know of). This feature was fir

Re: PSA: Constructors callable with one argument should be marked as explicit/implicit

Hi On Friday, December 19, 2014, Ehsan Akhgari wrote: > That should be it! The plugin is transparent, unless it finds an error in > which case you'll get a normal error diagnostic. > > That is weird then. Because I have a patch that fails the Linux64 static analysis test. But I can't reproduce

Re: Intent to ship: media-capabilities

in bug 1480190 JY > On 4 Jul 2018, at 2:16 am, Jean-Yves Avenard wrote: > > Hi > > The code is now in central and in the last nightly. > > It's currently disabled by default behind the pref > media.media-capabilities.enabled > > The bug tracking fingerpr

Re: Intent to ship: media-capabilities

It appears that I hadn’t provided all the information earlier… So here it is again: Summary: Media Capabilities allow for web sites to better determine what content to serve to the end user. Currently a media element offers the canPlayType method (https://html.spec.whatwg.org/multipage/media.ht

Re: PSA: mercurial-setup becomes vcs-setup and adds support for git

Hi. This is awesome, upgrading and configuring cinnabar had always been a sore point But I just noticed that it appears to pull from git-cinnabar master branch… I had to run bootstrap on android yesterday, which upgraded git-cinnabar (requiring a git upgrade) and had to run it again today. whic

Re: WebRender on in Firefox Nightly for Windows 10 Nvidia

What an achievement… Congrats to you and the team…. JY > On 12 Sep 2018, at 10:07 pm, Jeff Muizelaar wrote: > > In bug 1490742 I have enabled WebRender in Nightly on non-laptop > Windows 10 Nvidia (~17% of our Nightly audience). This is a rewrite of > much the graphics backend in Firefox. We e

Re: Windows launcher process enabled by default on Nightly

Hi On 27/09/2018 5:19 PM, Aaron Klotz wrote: Hi everybody, Yesterday evening bug 1488554 [1] merged to mozilla-central, thus enabling the launcher process by default on Windows Nightly builds. This change is at the build config level. Can we have something to entirely disable that new feat

Re: Windows launcher process enabled by default on Nightly

Hi On 2/10/2018 5:05 AM, Aaron Klotz wrote: For various reasons we don't want to put escape hatches into any builds that we ship. For local builds, if it would ease developer concerns over this feature, we can look into it. I have filed bug 1495628 for that purpose. Seems that we can bui

Re: Intent to implement and ship: WebP image support

On 11/10/2018 6:03 PM, Tom Ritter wrote: Are we bringing in a new third party library for this? (Seems like yes?) Who else uses it/audits it? Does anyone else fuzz it? Is it in OSS-fuzz? Are we fuzzing it? How does upstream behave? Do they cut releases or do they just have continual developm

Re: Upcoming changes to our C++ Coding Style

Hi > On 21 Nov 2018, at 3:54 am, Ehsan Akhgari wrote: > > > You will break the blame on VCS with this change > > Yes and no. Of course, just like many tree-wide mass changes in the past > (e.g. the MPL2 header update), this will remain in the log. > > Mercurial and Git both support a -w argum

Re: Dogfooding WebRender

> On 27 Nov 2018, at 12:18 pm, Wellington Torrejais da Silva > wrote: > > Hi, > > Nice! I don't have Windows 10, but when you will need to test in Linux > distributions, here I'm. Thanks You can already enable webrender on mac and linux:set gfx.webrender.enabled to true. smime.p7s D

Re: Automatic changes during the dev workflow [was: Re: Upcoming changes to our C++ Coding Style]

Hi > On 14 Dec 2018, at 7:57 pm, Sylvestre Ledru wrote: > > I think we should aim at option b) (updated automatically by bots after > submission to Phabricator) > > I don’t particularly fancy this idea. Finding yourself with different code on Phabricator and locally is a good way to shoot y

Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

> On 25 Apr 2019, at 8:49 am, Bobby Holley wrote. >> > > I think the tradeoff boils down to (a) how many developers are using > non-e10s debugging, with what frequency, versus (b) how much ongoing > maintenance work is required across various components to keep non-e10s > working. We all have

Change to preferences via StaticPrefs, tremoval of gfxPrefs

Dear all. /TLDR; Wherever you used to use gfxPrefs, soon you will have to use StaticPrefs./ In a couple of days, once /Bug 1550422 //lands I will be retiring gfxPrefs. All features originally found in gfxPrefs are now available in Static

Re: Change to preferences via StaticPrefs, tremoval of gfxPrefs

Hi On 16/05/2019 1:54 am, Nicholas Alexander wrote: Forgive my rank ignorance here, but as an outsider this surprises me: I expect "Gecko preferences" to be (eventually) consistent across processes.  Is this just not the case, and it's common for prefs to vary between the main and content/gfx

Re: Change to preferences via StaticPrefs, tremoval of gfxPrefs

On 16/05/2019 9:02 am, Botond Ballo wrote: Will SpecialPowers.pushPrefEnv(), which currently does propagate the prefs at least between the content and parent processes, continue to work? A lot of tests rely on this. Yes of course. The changes was to add changes so that process other than the

Re: Change to preferences via StaticPrefs, tremoval of gfxPrefs

fs instead), at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:6529 All the best Jean-Yves On 15/05/2019 11:02 pm, Jean-Yves Avenard wrote: Dear all. /TLDR; Wherever you used to use gfxPrefs, soon you will have to use StaticPrefs./ In a couple of days, on

Re: Change to preferences via StaticPrefs, tremoval of gfxPrefs

Hi. Thanks for the kind words. > On 11 Jun 2019, at 9:49 pm, Kartikaya Gupta wrote: > > IIRC another difference between prefs in all.js and gfxPrefs was that if a > pref was not listed in all.js, you couldn't use it in the > {test-,ref-,}pref(...) annotations in reftest.list files. Can you co

Re: Visual Studio Code integration with `clangd` for C/C++ development

Hi. I don't know if that's related, but when recently VSCode started to show clangd as a recommended extension for the project. Which I installed. This broke several features for me (and I use VSCode all the time). One in particular was the inability to switch between code and header (Ctrl-K Ctrl

Re: Visual Studio Code integration with `clangd` for C/C++ development

rview Something that will automatically attach any new process to the debugger. When will it be ready ? :D Jean-Yves On Wed, Sep 16, 2020 at 5:00 PM Andi-Bogdan Postelnicu wrote: > > > On 16 Sep 2020, at 04:14, Botond Ballo wrote: > > On Tue, Sep 15, 2020 at 6:55 PM Jean-Y