Re: Intent to unship: rowspan=0

2018-03-02 Thread Manish Goregaokar
Chrome decided not to do colspan after seeing that we unshipped it. २ मार्च, २०१८ ११:१३ म.पू. रोजी, "L. David Baron" ने लिहिले: > I would consider the lack of support in other browsers, and the > extra complexity in our codebase as a reasonably compelling reason. > Also perhaps that we've alread

Re: Intent to unship: rowspan=0

2018-03-02 Thread L. David Baron
I would consider the lack of support in other browsers, and the extra complexity in our codebase as a reasonably compelling reason. Also perhaps that we've already (long ago, I think) unshipped support for colspan=0 for similar reasons. Table height calculation is among the least interoperable lon

Re: Intent to unship: rowspan=0

2018-03-02 Thread Manish Goregaokar
Looks like there's no compelling reason to unship. Retracting. -Manish Goregaokar On Wed, Feb 28, 2018 at 9:25 AM, Manish Goregaokar wrote: > > Is the only reason that no one else supports it? > > Yes. (which makes me suspect that nobody uses it) > > > However, as mentioned, Chrome *has* added

Re: Intent to unship: rowspan=0

2018-02-28 Thread Manish Goregaokar
> Is the only reason that no one else supports it? Yes. (which makes me suspect that nobody uses it) However, as mentioned, Chrome *has* added support, it's not stable yet. -Manish Goregaokar On Wed, Feb 28, 2018 at 5:19 AM, Boris Zbarsky wrote: > On 2/28/18 2:02 AM, Manish Goregaokar wrote

Re: Intent to unship: rowspan=0

2018-02-28 Thread Boris Zbarsky
On 2/28/18 2:02 AM, Manish Goregaokar wrote: Oh, you're asking for it to continue to work with semantic HTML? I'm saying that this feature is there for actual data tables. And that the suggestion that Grid is a replacement is not actually helpful given that. That won't work, you'd need to

Re: Intent to unship: rowspan=0

2018-02-28 Thread Henri Sivonen
On Wed, Feb 28, 2018 at 12:28 AM, Manish Goregaokar wrote: > You can already achieve this behavior with `rowspan=`, In terms of letting HTML validation produce useful results, telling authors to use a bogus large number is worse than having a special value (zero). If you use 0 and the table makes

Re: Intent to unship: rowspan=0

2018-02-27 Thread Manish Goregaokar
Oh, you're asking for it to continue to work with semantic HTML? That won't work, you'd need to create a new table with grid stuff. In that case we probably shouldn't unship? -Manish Goregaokar On Tue, Feb 27, 2018 at 8:38 PM, Boris Zbarsky wrote: > On 2/27/18 11:22 PM, Manish Goregaokar wrote

Re: Intent to unship: rowspan=0

2018-02-27 Thread Boris Zbarsky
On 2/27/18 11:22 PM, Manish Goregaokar wrote: What does that have to do with anything? Given that we're the only browser implementing it until chrome (and likely webkit?) ships it in a few months, it's as if it is a new feature for the web, hence the suggestion to use Grid. Please explain to

Re: Intent to unship: rowspan=0

2018-02-27 Thread Manish Goregaokar
> Have we tried doing actual telemetry here? No, though we could. I'm skeptical given that no other browser implemented it. > What does that have to do with anything? Given that we're the only browser implementing it until chrome (and likely webkit?) ships it in a few months, it's as if it is a

Re: Intent to unship: rowspan=0

2018-02-27 Thread Boris Zbarsky
On 2/27/18 5:28 PM, Manish Goregaokar wrote: You can already achieve this behavior with `rowspan=` Only if you can guarantee that this number is in fact larger than the number of rows in your rowgroup, yes? And even then, is it exactly equivalent? and we should encourage developers to use

Re: Intent to unship: rowspan=0

2018-02-27 Thread Manish Goregaokar
Yeah. Implementing it in servo is not a big deal -- we already (perhaps accidentally) account for it in cell placement, we just don't handle it for cell sizing, and that's an easy patch On Feb 27, 2018 3:50 PM, "Emilio Cobos Álvarez" wrote: > On 02/28/2018 12:28 AM, Manish Goregaokar wrote: > >>

Re: Intent to unship: rowspan=0

2018-02-27 Thread Emilio Cobos Álvarez
On 02/28/2018 12:28 AM, Manish Goregaokar wrote: Yeah, it's specced: https://html.spec.whatwg.org/multipage/tables.html#attr-tdth-rowspan Opened bug with same text here: https://bugzilla.mozilla.org/show_bug.cgi?id=1441710 Thanks! I think the reasoning is in the email? Is there something mo

Re: Intent to unship: rowspan=0

2018-02-27 Thread Manish Goregaokar
Yeah, it's specced: https://html.spec.whatwg.org/multipage/tables.html#attr-tdth-rowspan Opened bug with same text here: https://bugzilla.mozilla.org/show_bug.cgi?id=1441710 I think the reasoning is in the email? Is there something more specific you're looking for? Thanks, -Manish Goregaokar

Re: Intent to unship: rowspan=0

2018-02-27 Thread Emilio Cobos Álvarez
Hi Manish, Can you open / link to a bug for this work? Also, is it on the spec? If so, probably spec issues need to be filed if we really want it to get dropped? A bit of reasoning (I do know why from IRC, but you should probably explain) about why would be helpful, too. It is indeed unfor

Re: Intent to unship: rowspan=0

2018-02-27 Thread Manish Goregaokar
(Of course, this is contingent on the Chrome people agreeing to unship this as well) -Manish Goregaokar On Tue, Feb 27, 2018 at 2:28 PM, Manish Goregaokar wrote: > Gecko (and previously Presto) support setting `rowspan=0` in > non-quirksmode documents to mean "up to the end of the rowgroup" (fo