Re: Connection TTL

2018-05-25 Thread Clebert Suconic
You disable by setting it to -1 on the client with a -1 on the property for TTL. (If you can’t find it let me know. I’m on the iPhone and I can’t remember the exact name.) There is a packet sent by the client configuring it to -1. And there could be a time where the server will use The default

[GitHub] activemq-artemis pull request #2111: ARTEMIS-1882 fix failing SecurityTest

2018-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2111 ---

[GitHub] activemq-artemis issue #2109: ARTEMIS-1888 - Add forceSSLParameters flag to ...

2018-05-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2109 @cschneider tuesday right after the holiday... if I'm taking longer than that i will use cherry pick. if you have a strong feeling about it.. I can just push it now. ---

[GitHub] activemq-artemis issue #2109: ARTEMIS-1888 - Add forceSSLParameters flag to ...

2018-05-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2109 Can I merge this after 2.6.1? it's adding a property to configuration.. so it doesn't really make it a micro release. I could cherry-pick commits but if I leave this out

[GitHub] activemq-artemis issue #2112: Custom serialization mechanism for ActiveMQMes...

2018-05-25 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2112 Looks like you need to rebase this PR or something. There's a hand-ful of commits in here that have already been merged. ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @tabish121 I wanted to keep 2.6.1 a cut of master if possible. If it can't wait till tuesday.. sure I can cherry-pick.. I'm just trying to avoid it *if possible*. ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @clebertsuconic It is ok to merge this? ---

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866 Make Quorum vote result wa...

2018-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2089 ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @tabish121 @franz1981 actually I already defined the payload for 2.6.1.. there's just one commit that I will need to carry on which is an issue with AMQP and clustering.

[GitHub] activemq-artemis pull request #2112: Custom serialization mechanism for Acti...

2018-05-25 Thread tmccore
GitHub user tmccore opened a pull request: https://github.com/apache/activemq-artemis/pull/2112 Custom serialization mechanism for ActiveMQMessages Custom serialization mechanism for ActiveMQMessages, which would override default serialization. You can merge this pull request into

Re: [HEADS-UP] ActiveMQ Artemis release in week.

2018-05-25 Thread Clebert Suconic
I have the payload for 2.6.1 pretty much defined here: https://github.com/apache/activemq-artemis/compare/2.6.0...2.6.x I just want to include the work I'm doing now on some Bridge working and AMQP, which will be cherry-picked into 2.6.x: https://issues.apache.org/jira/browse/ARTEMIS-1858

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @clebertsuconic yes sure :+1: ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 Doesn't that sort of defeat the point of using source control ? ---

[GitHub] activemq-artemis pull request #2109: ARTEMIS-1888 - Add forceSSLParameters f...

2018-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2109 ---

[GitHub] activemq-artemis issue #2109: ARTEMIS-1888 - Add forceSSLParameters flag to ...

2018-05-25 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2109 It's fine to wait for next week ---

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
We ended up putting that code here https://github.com/JMSComponents/custom-serdes-jms After some lengthy debates on chat, but be great if we are looking to re add back Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce"

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
Here is original thread on this http://activemq.2283324.n4.nabble.com/DISCUSS-Custom-Object-Serialisation-Support-tt4726741.html#a4727019 Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce" Date: 25/05/2018 20:37

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread Clebert Suconic
When you talk about serialization, you're talking about ObjectMessages or there's something else you have in mind? What about add a custom new JMSType to the type you choose. Also. I believe this could be a nice point to bring up to JakartaEE. a new ObjectType with pluggable serialization

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread Justin Bertram
The idea sounds interesting. However, the contribution would have to reviewed in detail before it could be merged into the code-base. To be clear, any contribution must follow the established coding standards and any new functionality needs to come with tests to ensure it functions as expected

Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread Jasmeet Ajmani
Hi, We would like to use custom serialization on ActiveMQMessages and the current build of Artemis does not support this. Would you accept a fork to your repository on GitHub which would allow the use of custom serialization via a Java property. Thanks.

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread Arthur Naseef
Just a thought that I hope helps... Please be careful about serialization and deserialization of objects. Lots of security issues arise when using object serialization/deserialization in practice. Also, compatibility issues creep up. Sending a text format over the wire, such as JSON, is

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
Damn phone Comparabilty = compatibility  Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce" Date: 25/05/2018 22:59 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: Custom serialization mechanism for

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
So our one in our org is avro. This is about enabling users to choose their own.  Java serialisation is one of the worst for comparibility but annoyingly the default. And one of the worst perfomance wise. This is why its so good to provide this customisation, as users anyhow many time do their

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
We implemented a similar idea, but made it jms agnostic. There is some historic thread around this on the mail list. Be def good to compare and if now more than one user needing this to re look at artemis having this. Sent from my Samsung Galaxy smartphone. Original message

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
Ill resend back a new pr with this support next week if there is renewed interest. Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce" Date: 25/05/2018 20:40 (GMT+00:00) To: dev@activemq.apache.org Cc: Martin

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
Typo but important one. I think = i dont think Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce" Date: 25/05/2018 21:35 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: Custom serialization mechanism for

Re: Custom serialization mechanism for ActiveMQMessages

2018-05-25 Thread michael.andre.pearce
@Clebert I think jms spec defines or cares how it should serialize especially over the wire, this is left to implementation, just that class should be serializable. This is just implementation detail, keeping to the api method spec, so doesnt need a new jms type. Sent from my Samsung Galaxy