Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Looks like compatibility tests are failing.
---
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@jbertram I will remove the dependency from PooledJMS. But I can mention it
in the docs? Or I remove it at all?
---
I don't expect username and password to affect inactivity timeouts.
Inactivity timeouts should only occur when the TCP connection between the
client and broker is somehow excessively slow or stuck (e.g. if packets are
not crossing the network properly).
Versions of the client and server should
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Yeah. I will fix it later today.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, probably best to just close this PR based on
@michaelandrepearce's feedback. If you want, you could remove the dependencies
and make it a pure Spring Boot example and
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@jbertram , @michaelandrepearce I've removed PooledJMS completely. Now
users would rely only on amqp-starter for this sample. I couldn't found out
what is the Travis issue. If
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, you should squash all of your commits so there's just one.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Seems OK. I would have thought that the channelVersion would get set when
the session was re-created on the backup (e.g. in
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Itâs a simple fix. I will have to adjust counts.
As for everything else. Do u think this is ok ?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, I'd remove it completely from everything.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2243
@michaelandrepearce for future PRs, the Adjust checkstyle commit could have
been squashed to the previous commit.
There's no need to keep checkstyle commits separately,
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2248
ARTEMIS-2030 only use interrupt during shutdown on RA
You can merge this pull request into a Git repository by running:
$ git pull
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209819327
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@franz1981 are you providing an alternative fix? If not why not lets merge
this and later you can provide an alternative to replace this solution?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
@jbertram it's not.. there's a different packet on reconnect sessions. So
that's not called.
---
I fixed the compatibility issue, and a few other PRs merged.
Does anyone see anything else blocking it.. or can we cut activemq
artemis 2.6.3 tomorrow?
On Fri, Aug 10, 2018 at 10:06 AM Clebert Suconic
wrote:
>
> I will have to postpone to Monday...
>
> I have started working on a compatibility
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
Hi @jbertram! Done!
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2246
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2247
---
Hi Clebert
Theres an NPE introduced in
https://github.com/apache/activemq-artemis/commit/bf282e5e7d133e898f0dc4d08f4df87722fc5a91
I have commented on the PR that was merged that introduced it. So needs to be
fixed before release.
Sent from my Samsung Galaxy smartphone.
Original
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2242
2022
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis 2022
Alternatively you can
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2242
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2241#discussion_r209509591
--- Diff: examples/features/standard/spring-boot-integration/pom.xml ---
@@ -0,0 +1,94 @@
+http://maven.apache.org/POM/4.0.0;
+
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@clebertsuconic @mtaylor seems also
MessageBodyTest.testBytesMessage is broker due to this change, and any PR
build is failing now.
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2243
Artemis-2022 create count messages with group by filter
You can merge this pull request into a Git repository by running:
$ git pull
Github user ArthurFritz commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
@michaelandrepearce You're welcome.
Would you know the expected date of version 2.6.3 ?
---
GitHub user mberndt123 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2244
fix tyop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mberndt123/activemq-artemis patch-1
Alternatively you can review and
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2244
Nice spot, could you just change the commit message to prefix it with
NO-JIRA thanks.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
Not atm afaik, as efforts are for bug fix release atm.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2245
---
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
HI @michaelandrepearce! Thanks for your review.
Regarding the sample and the differences between JMS Pool and Spring
Caching feature, I'm going to edit the README file to
Github user ArthurFritz closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2237
---
Github user ArthurFritz commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
Ok, thanks.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
@ArthurFritz thanks for the contribution :)
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
@ArthurFritz as your branch just had the changes i suggested, but also an
additonal but un-needed extra merge commit, i merged from the branch i had of
yours,
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2243
---
Github user ArthurFritz commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
Cool, is there an expected date for 2.7.0?
---
Github user mberndt123 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2244
Done
---
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2245
ARTEMIS-2027: handle aborted AMQP deliveries
Fixes handling of aborted deliveries to ensure the receiver processes the
delivery (and any subsequent ones) appropriately. Unit tested only
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2237
This is a feature not a bug fix, 2.6.3 is a bug fix release only. This
would be in next feature release 2.7.0
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2245
Merged to 2.6.x in commit c1c2d01bc525411d46cef1c7589e4a1e71e42b02
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini my point more here is if you need Pooled Connection Factory
and it has valid use, then we should look to migrate and support it from
ActiveMQ 5.x to ActiveMQ
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658786
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658818
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2244
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2246
failed test:
Failed tests:
ConnectionFactoryPropertiesTest.testCompareConnectionFactoryAndResourceAdapterProperties:86->compare:97->Assert.fail:88
in ActiveMQ Connection
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2238
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2247#discussion_r209666896
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -638,13 +638,9 @@
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
IMO, the JMS pool from 5.x should not be migrated to Artemis. It belongs
in it's own project with it's own release cycle. Also, it makes sense for it
to *not* be in the ActiveMQ
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671517
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@ protected
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671702
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java
---
@@ -131,6
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658044
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2247
ARTEMIS-2029 Fixing wire checks after reconnects
You can merge this pull request into a Git repository by running:
$ git pull
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
It's good now.. I found a change I added by mistake
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209618198
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209626842
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209621351
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2246
ARTEMIS-2024 Enable SharedClientID on ConnectionFactory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@jbertram my issues are as follows:
The code broken out doesn't attribute the original contributors over time,
people who contribute have a right to keep their
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
I can't speak the contributor rights and licensing issues as I've not
looked into the fine print on that, but I would say that the comparison to CMS
and NMS isn't a good one since those
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
Justification behind use of JMS Pool:
> The JMS pool provides configuration capabilities not available in the
CachingConnectionFactory and prevent certain not ideal uses
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
The point with the example is essentially backing by adding the depenency
that this is acceptable.
To me its not.
---
Github user ricardozanini commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
I'm not in position to decide, but I could remove it and them add to the
docs that one could use it for it's own use case.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2248
---
64 matches
Mail list logo
