[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192884 ## File path:

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192884 ## File path:

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195219 ## File path:

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195219 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251200460 ## File path:

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251200554 ## File path:

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457643382 It should be a nice step for a future optimization that would allow to use 1 core just to retrieve

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192771 ## File path:

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192771 ## File path:

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195297 ## File path:

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195297 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251200460 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251200661 ## File path:

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457811530 @michaelandrepearce > whats the compatibility of using the c++ c11 features I don't know ,

[GitHub] franz1981 edited a comment on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-457833622 @clebertsuconic @michaelandrepearce Please review it another time guys: I've included a change on how

[GitHub] michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457835398 Thanks for explanation in os compatibility, that reduces my worry. Just out of interest what os

[GitHub] franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

2019-01-26 Thread GitBox
franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-457833622 @clebertsuconic @michaelandrepearce Please review it another time guys: I've included a change on how

[GitHub] franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-457819129 @michaelandrepearce > Have you got any stats to share on this, especially on running on standardish spec server? Im

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195297 ## File path:

[GitHub] michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457835398 Thanks for explanation in os compatibility, that reduces my worry. Just out of interest

[GitHub] michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457835398 Thanks for explanation in os compatibility, that reduces my worry. Just out of interest

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-26 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192720 ## File path:

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457834119 On our CI (that's using a x86_64) it has passed without any issue :+1:

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457865466 @michaelandrepearce > We will need 32 bit support. I remember there being someone in the community on a

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457865466 @michaelandrepearce > We will need 32 bit support. I remember there being someone in the

[GitHub] franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884054 On my box I'm getting the same performance of the master version for single producer/single

[GitHub] franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884054 On my box I'm getting the same performance of the master version for single producer/single

[GitHub] franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884054 On my box I'm getting the same performance of the master version for single producer/single

[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884054 On my box I'm getting the same performance of the master version for single producer/single consumer

[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884911 @michaelandrepearce @clebertsuconic If any of these commits will improve scalability

[GitHub] franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 edited a comment on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884911 @michaelandrepearce @clebertsuconic If any of these commits will not improve scalability

[GitHub] franz1981 opened a new pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-26 Thread GitBox
franz1981 opened a new pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524 This is an automated message from the Apache Git