GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2184
ARTEMIS-1954 Fixing RedeployTest and moving JMS Parsing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2185
Thank you.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2186
I have been only doing git cherry-pick -x on 2.6.x
you have two options:
Do the following:
```sh
git fetch upstream
git checkout upstream/2.6
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2186
I cherry-pick manually.. can you close this PR please?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
These double quotes were added to deal with directories with space.. they
were working fine at the time...
Can you run artemis-distribution/src/test/scripts/validate
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
Usually the property on window-size is dependent on the semantic of the
client.
Like a client is processing big DB operations..so the client will have the
information
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
I just wanted to know the results of the test on windows as I donât have
a box now.
I will merge this.
This is probably 2.6.x as well and I will merge it.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204860714
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204881984
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2194
ARTEMIS-1989 Replication catch up leaking files
Related commit that broke this at
https://github.com/hornetq/hornetq/commit/837694e70573069cf78d1911975bef95925b6f29
You can merge
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2192
in what situation was this a bug?
Did you run the entire testsuite?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2188
I had to fix a checkstyle... I'm merging it with an ammend
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2189
@JiriOndrusek close this please. I cherry-picked directly into 2.6.x
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205093692
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -1109,9 +1109,7
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205094364
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -1109,9 +1109,7
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205096243
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -1109,9 +1109,7
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
The PR should been on master.. and we cherry-pick it into 2.6.x
I used some git-fu to merge it into master.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
Ohhh.. nice one.. I just looked at what was the semantics changed.. nice
one
it would be nice to add some docs.. a paragraph would do.
If you don't
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2175#discussion_r205168250
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/AtomicBooleanFieldUpdater.java
---
@@ -0,0 +1,154
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
@michaelandrepearce I created
https://issues.apache.org/jira/browse/ARTEMIS-1991 to track the doc.
Marked as blocker just so it appears on the top of the list before
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
@michaelandrepearce this is broken... can you rebase and check what's
happening?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
this is so weird.. I have no idea what changed.. but I can't build on
artemis-features.
Probably the double xsd on tools? I 've tried debugging... and I can
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
Please donât close it. If you donât have time I will do it. Itâs
just I wanted to figure out
Can you reopen please ?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
I already know this is because of AtomicBooleanFieldUpdater. Something is
causing confusion on OSGI.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
Would be possible a test? without a test I don't know how to validate the
change TBH.
At least were you able to run the whole testsuite.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2193
@graben I wasn't sure what to do with this since there's no test.. I have
no idea how to validate it yet.
do you have any parallels to compare what would be
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@franz1981 make a test that will exercise the loop. Try to get a
synchronize on Queue...
if the test hangs.. it's a bug... use a timeout tag on the test.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2200
@michaelandrepearce let me see if it builds and I will merge it.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@michaelandrepearce would be too much of a hack to add a -Ptravis profile
and add a property to ignore those tests?
Those tests run at least daily on my CI and they never
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2198
@michaelandrepearce What did you do to fix the karaf verification? i lost
some sleep the other trying to figure it out and I'm now curious.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@franz1981 so are you adding a test?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2198
@michaelandrepearce Ok.. there's an issue with packaging in Karaf for Util
depending on how you use. I'm sure it will arise again.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@michaelandrepearce there are no changes around the journal...
We already have a profile that will ignore a lot of tests.. and anyone
running the full testsuite would still
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2193
ok.. merging .. thanks for clarifying.. I have hard a hard time following
so many emails :)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2193
pulled it into 2.6.x
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2202
tests?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2204
bringing this into 2.6.x
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2197
bringing this into 2.6.x
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1950
This needs some work on the model before it can be merged.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1950
The test added is also wrong.. a sender should block while there are no
credits instead of holding runnables on the server.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1950
Actually the test is very nice.. I'm doing some refactoring on this.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1950
@michaelandrepearce @gaohoward merged with an additional fix.
if there's any change you like I can add an additional PR. if you could
review please?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2205
I pulled a direct commit into 2.6.x, please close this PR.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@franz1981 please watch the examples. On my private CI an example failed on
your branch.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r206733019
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2209
ARTEMIS-856 Fixing MessageRedistributionTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce I need you to take a look into this please.
MessageRedistributionFix is broken, up to the point I can't complete a
whole testsuite on my intern
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce : But please don't merge it yet.. I'm running a whole
testsuite on the CI before we can merge this... just let me know what you think
first.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce Can you look into
ExclusiveTest::testExclusiveTopicSharedConsumerFailover
It's failing even without my changes.. and after my changes.. I cou
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2209#discussion_r207215079
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -544,6 +560,7 @@ public boolean
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2211
@michaelandrepearce Let me run my internal CI.. if all good will merge it
in 2 hours (time to have the whole run)
---
Github user clebertsuconic closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2209
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
This is replaced by #2211
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2211
@michaelandrepearce I still have the following tests failing with these
changes
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/825081cfc095d52541ebc5631f031059618d871d#commitcomment-29950139
Really ? :)
Thanks a lot. I would have probably spent a long time looking for something
more conple
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@franz1981 can you rebase here? what to do with this?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
I hope I have fixed the MultiThread now...
As a test... can you please rebase? (just to validate my changes I just
pushed)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@cshannon Green!!!
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
just one nit-pick.. this test should be on QueueImplTest, away from
timing... (integration-tests)
can you move it?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2202
@RoddieKieley any chance you can add a test?
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2214
ARTEMIS-2011 Fixing incompatibility of AddressSettings encode betweenâ¦
⦠versions
To fix this I added a retry on AddressSettings using code that's closer to
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/#discussion_r208296624
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
---
@@ -224,8 +224,10
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2221
@gemmellr I'm a bit out of context on the test change you need to make.. I
tried to do it myself but I didn't have the context of your changes. can y ou
cherry-pick it t
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@franz1981 I have moved this into 2.6.x but I had to manually make the
changes.. can you check 2.6.x please?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2228
shouldn't you also protected get? I don't think it's thread safe.
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2234
ARTEMIS-2021 NetworkHealthCheck should only restart servers when net
failures happened
You can merge this pull request into a Git repository by running:
$ git pull https
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@morefuntang / @franz1981 what's the status here?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2232
Itâs already on 2.6.x
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2236
2.6.x is bug fixes only... this has to go on master.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2236
even if it was going on 2.6.x, we first send to master, than cherry-pick
into 2.6.x
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2235
@mtaylor / @andytaylor no JIRA?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2235
I will push -f without this commit.. it should have had a JIRA
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2235
will leave it as it is.
---
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/d9bc05d11265e7ea2e41212994b9955497a70a86#commitcomment-30047074
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java:
In
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209466147
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
The Failure on your PR check is because you missed calling checkEncode().
It's currently private but we can open it to protected.
but don't worry.. I will
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@mtaylor this test is failing after this:
org.apache.activemq.artemis.tests.integration.jms.jms2client.BodyTest.testBodyConversion
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209621351
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658818
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2247
ARTEMIS-2029 Fixing wire checks after reconnects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2246
failed test:
Failed tests:
ConnectionFactoryPropertiesTest.testCompareConnectionFactoryAndResourceAdapterProperties:86->compare:97->Assert.fail:88
in ActiveMQ Conn
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2247#discussion_r209666896
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -638,13 +638,9
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
It's good now.. I found a change I added by mistake
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Yeah. I will fix it later today.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Itâs a simple fix. I will have to adjust counts.
As for everything else. Do u think this is ok ?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
@jbertram it's not.. there's a different packet on reconnect sessions. So
that's not called.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2243
@michaelandrepearce for future PRs, the Adjust checkstyle commit could have
been squashed to the previous commit.
There's no need to keep checkstyle commits separ
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2248
ARTEMIS-2030 only use interrupt during shutdown on RA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2246
@jmesnil TBH: I thinks it's dumb to use clientID on a standalone CF.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2246
@michaelandrepearce on the connection.. yeah! On the connectionFactory.
.that's a broker-specific extension. you set it on the CF as an utility for the
user.
That&#
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210009695
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210016477
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210016740
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210022817
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30181128
@michalxo try building from the root project.. mvn clean; mvn install from
the root.
All my CIs
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30185630
hmmm... you meant 2.6.x... I will revert the commit in there.
---
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30185652
not very orthodox.. but I removed the commit with a push -f (I don't this
very often)
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2254
compatibility fixes and replication fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2254#discussion_r211409599
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java
---
@@ -0,0 +1,76
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2254#discussion_r211410036
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java
---
@@ -0,0 +1,76
1 - 100 of 2940 matches
Mail list logo
