Review Request 21116: iptables host check warning shows on centos 5.9 even if iptables are stopped

2014-05-06 Thread Jonathan Hurley
NFO] BUILD SUCCESS [INFO] [INFO] Total time: 6.073s [INFO] Finished at: Tue May 06 11:55:02 EDT 2014 [INFO] Final Memory: 7M/81M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21281: Exclude PyDev Config Files From Rat Checks

2014-05-10 Thread Jonathan Hurley
--- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 4.050s [INFO] Finished at: Fri May 09 16:51:30 EDT 2014 [INFO] Final Memory: 7M/81M Thanks, Jonathan Hurley

Re: Review Request 21116: iptables host check warning shows on centos 5.9 even if iptables are stopped

2014-05-10 Thread Jonathan Hurley
--- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 6.073s [INFO] Finished at: Tue May 06 11:55:02 EDT 2014 [INFO] Final Memory: 7M/81M [INFO] -------- Thanks, Jonathan Hurley

Re: Review Request 21280: pig.properties should set pig.location.check.strict to false

2014-05-10 Thread Jonathan Hurley
://reviews.apache.org/r/21280/diff/ Testing --- Server Python -- Ran 203 tests in 0.485s OK -- Total run:548 Total errors:0 Total failures:0 OK Thanks, Jonathan

Re: Review Request 21116: iptables host check warning shows on centos 5.9 even if iptables are stopped

2014-05-11 Thread Jonathan Hurley
--- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 8.384s [INFO] Finished at: Wed May 07 15:55:39 EDT 2014 [INFO] Final Memory: 7M/81M [INFO] ---- Thanks, Jonathan Hurley

Review Request 21284: All Services Fail To Deploy Due To Agent Parsing Exception

2014-05-12 Thread Jonathan Hurley
], ambari_server_host=[-1], nagios_server_host=[1], all_ping_ports=[8670:0-2]} Notice the ambari-server-host which was added in that commit; it’s value is “-1” which would not parse correctly in manifestGenerator.py Thanks, Jonathan Hurley

Review Request 21336: remove the property dfs.datanode.du.pct from our configs since it is not being used

2014-05-12 Thread Jonathan Hurley
= -- Ran 203 tests in 0.471s OK -- Total run:550 Total errors:0 Total failures:0 Thanks, Jonathan Hurley

Review Request 21284: All Services Fail To Deploy Due To Agent Parsing Exception

2014-05-14 Thread Jonathan Hurley
], ambari_server_host=[-1], nagios_server_host=[1], all_ping_ports=[8670:0-2]} Notice the ambari-server-host which was added in that commit; it’s value is “-1” which would not parse correctly in manifestGenerator.py Thanks, Jonathan Hurley

Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-14 Thread Jonathan Hurley
CESS [INFO] [INFO] Total time: 13:03.096s [INFO] Finished at: Tue May 13 14:49:13 EDT 2014 [INFO] Final Memory: 20M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21284: All Services Fail To Deploy Due To Agent Parsing Exception

2014-05-15 Thread Jonathan Hurley
- [INFO] Total time: 13:50.095s [INFO] Finished at: Fri May 09 17:50:31 EDT 2014 [INFO] Final Memory: 24M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-15 Thread Jonathan Hurley
123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
visit: https://reviews.apache.org/r/21403/#review43052 ------- On May 15, 2014, 9:36 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21403/ > ---

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
.org/media/uploaded/files/2014/05/15/a35e7641-4030-4d1c-b18b-a9fbd3e32b6f__AMBARI-5749.patch Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
- Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
CESS [INFO] [INFO] Total time: 13:35.615s [INFO] Finished at: Wed May 14 13:56:57 EDT 2014 [INFO] Final Memory: 22M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
CESS [INFO] [INFO] Total time: 13:35.615s [INFO] Finished at: Wed May 14 13:56:57 EDT 2014 [INFO] Final Memory: 22M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
CESS [INFO] [INFO] Total time: 13:35.615s [INFO] Finished at: Wed May 14 13:56:57 EDT 2014 [INFO] Final Memory: 22M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
CESS [INFO] [INFO] Total time: 13:35.615s [INFO] Finished at: Wed May 14 13:56:57 EDT 2014 [INFO] Final Memory: 22M/123M [INFO] Thanks, Jonathan Hurley

Re: Review Request 21403: Store cluster installed state as part of the Cluster resource

2014-05-16 Thread Jonathan Hurley
- Thanks, Jonathan Hurley

Re: [VOTE] Apache Ambari 2.5.0 RC2

2017-03-28 Thread Jonathan Hurley
+1 for RC2 - verified source compared to Git as well as checksums. On Mar 28, 2017, at 11:18 AM, Roman Shaposhnik mailto:ro...@shaposhnik.org>> wrote: On Mon, Mar 27, 2017 at 5:57 PM, Aravindan Vijayan mailto:avija...@hortonworks.com>> wrote: Thanks for letting me know Yusaku. I have created an

Re: [VOTE] Apache Ambari 2.5.0 RC2

2017-03-28 Thread Jonathan Hurley
ature, verified that .git artifacts no longer >> exist. >> >> Yusaku >> >> >> >> >> On 3/28/17, 9:47 AM, "Jonathan Hurley" wrote: >> >>> +1 for RC2 - verified source compared to Git as well as checksums. >>>

Re: In-memory Persistence Type

2017-05-23 Thread Jonathan Hurley
I believe that this database type is only ever used for unit tests. > On May 18, 2017, at 1:57 PM, Anita Jebaraj wrote: > > Hello everyone, > > I came across the below piece of code in AmbariServer.java, > Can someone point me to some documentation on In-memory Persistence type or >

Re: [VOTE] Migrate to gitbox

2017-12-08 Thread Jonathan Hurley
+1 > On Dec 7, 2017, at 6:48 PM, Vivek Ratnavel wrote: > > Hi all, > > I am starting this vote to migrate Apache Ambari project from git-wip > repository to gitbox, which allows a deeper integration with github > features. Moving to gitbox will allow committers to merge, close or edit > pull re

Re: [DISCUSS] Future code review and commit process

2018-01-04 Thread Jonathan Hurley
This model is quite different from the model which many of us have been using years. As such, I think we need to define a bit more structure so that we keep the project tidy and under control. A few points: * Since this new flow model requires a branch for a commit, we should enforce a nam

Re: [DISCUSS] Future code review and commit process

2018-01-04 Thread Jonathan Hurley
Yes, I mis-read the original email from Vivek. You have to work in your own fork of Ambari. Every pull request is done between the public branch and a branch in your local forked repo, right? > On Jan 4, 2018, at 11:32 AM, Attila Doroszlai > wrote: > >> * Since this new flow model requires

Re: [DISCUSS] Future code review and commit process

2018-01-04 Thread Jonathan Hurley
Thanks for the clarifications. This sounds like the "Forking Workflow" as opposed to the "Feature Branch Workflow". I'm fine with that since it lets non-commiters help. We should try to capture all of these scenarios in a wiki page which we can then all agree upon. Things which we need to cove

Re: [DISCUSS] Future code review and commit process

2018-01-08 Thread Jonathan Hurley
this case, if you want to merge a feature branch with trunk, then you select feature branch as base branch and trunk as head branch. I have attached a screen-shot for reference. [cid:ii_jc13wnyl0_160c3724ae47072e] I agree with you on creating a wiki page to cover all the scenarios. ​ Than

Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA

2018-01-09 Thread Jonathan Hurley
+1 - we definitely don't want these in the comments section! > On Jan 9, 2018, at 12:49 PM, Nate Cole wrote: > > +1 > > On 1/9/18, 11:56 AM, "Sandor Molnar" wrote: > >+1 > >I believe this is a really good idea. > >Sandor > >From: Vivek Ratnavel >Reply-To: "dev@ambari.a

Re: Add reviewers to PR as a non-committer?

2018-01-17 Thread Jonathan Hurley
We have a very active project with potentially dozens of new PRs coming in every day - I don't think relying on the community to look is a very sustainable model. Is there no way to add reviewers without tagging them? There seems to be a way to filter by reviews needing attention - seems silly t

Re: Add reviewers to PR as a non-committer?

2018-01-17 Thread Jonathan Hurley
/pull/20297 On Wed, Jan 17, 2018 at 12:00 PM, Jonathan Hurley wrote: We have a very active project with potentially dozens of new PRs coming in every day - I don't think relying on the community to look is a very sustainable model. Is there no way to add reviewers without tagging them? There s

Re: Feature Branch Merging and PR

2018-01-18 Thread Jonathan Hurley
It's a bit odd though to create a PR every time you have to update a branch. Depending on what you're working on, it may be fast-forwards each time. To create a PR each time seems like overkill. > On Jan 18, 2018, at 10:16 AM, Robert Levas wrote: > > I have been doing the following…. I am not

Re: Feature Branch Merging and PR

2018-01-18 Thread Jonathan Hurley
> > On 1/18/18, 12:27 PM, "Jonathan Hurley" wrote: > >It's a bit odd though to create a PR every time you have to update a > branch. Depending on what you're working on, it may be fast-forwards each > time. To create a PR each time seems like overkill. &g

Removal of old/defunct branches

2018-01-24 Thread Jonathan Hurley
Hi committers and contributors, Ambari seems to have a bunch of branches that are dead and don't seem to serve any useful purposes. These include: origin/AMBARI-12885 origin/trunk remote/branch-2.4 remote/branch-2.5 trunkj trunkpwd They all seem to be either wrong (including the name of the ori

Re: Removal of old/defunct branches

2018-01-25 Thread Jonathan Hurley
ambari-yarnapps audit_logging branch-embedded-views branch-rbac-sso branch-yarnapps-dev side-navigation-feature-branch Please let me know if there are any objections to removing the above branches as well. > On Jan 24, 2018, at 1:59 PM, Jonathan Hurley wrote: > > Hi commi

Re: [DISCUSS] Splitting the repos - ambari-metrics and ambari-logsearch

2018-01-26 Thread Jonathan Hurley
+1 - I definitely think that splitting their off is a great idea. > On Jan 26, 2018, at 10:20 AM, Nate Cole wrote: > > +1 > > On 1/26/18, 12:19 AM, "Siddharth Wagle" wrote: > >Hi devs, > > >We had a brief discussion about the release management of Ambari w.r.t to > the new work tha

Re: Removal of old/defunct branches

2018-02-06 Thread Jonathan Hurley
Last call before the following branches are removed: ambari-websocket ambari-yarnapps audit_logging branch-embedded-views branch-rbac-sso branch-yarnapps-dev side-navigation-feature-branch These have not seen a commit in roughly 2 years or more ... On Jan 25, 2018, at 9:15 AM, Jonathan Hurley

Re: trim Jenkins build logs

2018-02-15 Thread Jonathan Hurley
+1 as well. Could we also set a property so that it doesn't try to weave every since class? Can we scope it only to the ORM classes? > On Feb 15, 2018, at 11:16 AM, Yusaku Sako wrote: > > +1 on changing log level. Good idea. > > Yusaku > > On 2/15/18, 8:02 AM, "Doroszlai, Attila" wrote: >

Re: [VOTE] Remove Groovy Shell and Groovy Client Modules from Ambari

2018-02-26 Thread Jonathan Hurley
+1 for removal. > On Feb 26, 2018, at 12:38 PM, Sandor Molnar wrote: > > +1, Remove ambari-shell and ambari-client modules > > On 2/26/18, 6:00 PM, "Doroszlai, Attila" wrote: > >+1 for removing ambari-shell and ambari-client modules. > >On Mon, Feb 26, 2018 at 5:38 PM, Robert Levas

New Branches Appearing

2018-02-27 Thread Jonathan Hurley
Hi committers and contributors, I noticed today that Ambari has had a few new branches created which don't seem to be proper feature branches. They are: my_trunk vbrodetskyi-branch-2.6 We recently went through and cleaned out a whole bunch of stale branches and we want to keep our branch list

Re: IDE setup required on branch-feature-AMBARI-14714

2018-03-01 Thread Jonathan Hurley
I think this is something that should get voted on before it goes back into trunk. In general, it's risky to have to depend on 3rd party plugins to have a working, compiling project. If the contributors of FreeBuilder ever decide to abandon the project or if Eclipse or IntelliJ become incompatib

Re: New Branches Appearing

2018-03-05 Thread Jonathan Hurley
Anyone want to claim these branches? If not, I'd like to remove them. > On Feb 27, 2018, at 9:48 AM, Jonathan Hurley wrote: > > Hi committers and contributors, > > I noticed today that Ambari has had a few new branches created which don't > seem to be prope

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Jonathan Hurley
0 - I am indifferent as well, but I remain cautious about integrating 3rd party build assistants into our ecosystem. Unlike using a library, this is something that is required for our IDEs to be compatible with. A change to an IDE or even JDK version could potentially cause the JAR to no longer

Re: trim Jenkins build logs

2018-03-08 Thread Jonathan Hurley
; Thanks, >> Yusaku >> >> On 3/6/18, 11:26 AM, "Doroszlai, Attila" wrote: >> >>Yusaku, could you please make the change, or ask someone with access >>to Jenkins to do it? >> >>Thanks. >> >>-Attila >> >

Re: [VOTE] add FreeBuilder to Ambari

2018-03-21 Thread Jonathan Hurley
I agree - you can move mine to a -1 ... I'm having plenty of problems with FreeBuilder in Eclipse. > On Mar 20, 2018, at 8:20 PM, Doroszlai, Attila wrote: > > Let's close this vote: > > +1: Balazs Bence Sari, Attila Doroszlai > 0: Nate Cole, Jonathan Hurley >

Re: why stack_root does not exist

2018-03-23 Thread Jonathan Hurley
The only scripts which should use /usr/hdp as a hard coded value are those which belong specifically to the HDP stack. Otherwise it's a bug and needs to be corrected. > On Mar 22, 2018, at 9:34 PM, xiang@sky-data.cn wrote: > > But i find some python script use "/usr/hdp" as hard code, is th

Rogue Branches Showing Up Again

2018-04-11 Thread Jonathan Hurley
Hi committers, It looks like we have some rogue branches showing up again (perhaps the result of our trial and error with the new pull request model). In any event, here are the branches I am nominating for removal. If you don't want one of these removed, please respond to this email: AMBARI-2

Re: pull requests without description

2018-04-11 Thread Jonathan Hurley
Agreed - the reviews without +1's are most concerning. We can't be committing without proper reviews. I think the only exceptions are: - reverts - merges from a main branch to a feature branch > On Apr 11, 2018, at 11:28 AM, Robert Levas wrote: > > +1 > > On 4/11/18, 10:50 AM, "Doroszlai, At

Re: Rogue Branches Showing Up Again

2018-04-19 Thread Jonathan Hurley
mmit) or "Squash and Merge" (in the case of multiple commits) is enough. If you do an action through Github like a Revert, please double check that you have not created a branch in origin. On 4/11/18, 10:37 AM, "Jonathan Hurley" wrote: Hi committers, I

Re: [VOTE] Apache Ambari 2.6.2 RC0

2018-04-27 Thread Jonathan Hurley
+1 for 2.6.2 On 4/27/18, 1:01 AM, "Swapan Shridhar" wrote: Hi All, I have created an apache-ambari-2.6.2 release candidate. GIT source tag (release-2.6.2-rc0) : https://github.com/apache/ambari/commits/release-2.6.2-rc0 Staging site: http://home.apache.org/~swapa

Github Commits without IDs

2018-06-01 Thread Jonathan Hurley
Hi committers, I’ve noticed a few commits going into Apache lately that are not following the format of [AMBARI-] – The title of my Jira This makes it difficult to correlate a commit to the actual Jira which it was for. As an example of the current git log (red text has no Jira): 75489756d

Re: Unable to ignore and proceed when a rolling upgrade task fails

2018-06-07 Thread Jonathan Hurley
Ambari does actually give you the options to Ignore and Proceed if the failed task is marked as skippable in the upgrade pack XML file. Can you provide the specifics of the upgrade in terms of stack version, service/component experiencing the problem, etc? On 6/7/18, 2:59 AM, "Abhey Rana" wro

Re: [VOTE] Apache Ambari 2.7.1 RC0

2018-08-23 Thread Jonathan Hurley
+1 for RC0 - SHA verified - Performed build - Compared files against git for diffs (none besides build artifacts) On 8/21/18, 3:25 PM, "Olivér Szabó" wrote: Hi All, I have created an apache-ambari-2.7.1 release candidate. GIT source tag: (release-2.7.1-rc0) : https://g

New Ambari Module

2018-09-26 Thread Jonathan Hurley
Hi Developers, A new maven module has been created via https://issues.apache.org/jira/browse/AMBARI-24685 to allow us to provide a plugin framework for stack/mpack authors who need to provide their own compiled classes to Ambari. For areas such as upgrade pre-checks and server-side configurati

Re: Stack Advisor during Rolling upgrade

2018-10-12 Thread Jonathan Hurley
Stack upgrades do not invoke the service advisor. If you need to set configurations, you either need to do so in the config-upgrade.xml for the stack, or provide a custom class which extends AbstractUpgradeServerAction and specify that class as part of the upgrade.xml. On 10/12/18, 8:23 AM, "

Ambari trunk Snapshot Versioning

2018-10-17 Thread Jonathan Hurley
It looks like Ambari’s trunk pom.xml has not been updated with a proper version in at least 4 years. It currently still lists trunk as 2.0.0.0-SNAPSHOT: https://github.com/apache/ambari/blob/trunk/pom.xml#L24 This poses several problems as we try to make our artifacts more 3rd-party friendly sin

Re: Contributor Access to Apache Ambari

2018-12-03 Thread Jonathan Hurley
I've added the user vjasani to the Contributors role of the project in Jira. This should allow assignment of issues. On 12/3/18, 3:57 AM, "Doroszlai Attila" wrote: Hi Vivek, Someone needs to assign vjasani to the Ambari project in Apache Jira to be able to take issues.

Re: Ambari 2.7.6 Maintenance Release

2021-09-27 Thread Jonathan Hurley
+1 to the proposal and release of Ambari 2.7.6 in order to support users who either have their own stacks or are using a stack not behind a paywall. On Mon, Sep 20, 2021 at 9:24 AM Szabolcs Beki wrote: > Hello Ambari Devs and PMCs, > > It has been quite a long time since the last Ambari release.

Re: [VOTE] Move Apache Ambari to Attic

2022-01-10 Thread Jonathan Hurley
+1 to retire Ambari to the attic... Bittersweet, but it is time. On Mon, Jan 10, 2022 at 1:36 PM Jayush Luniya wrote: > Hi all, > > Following the process outlined here, https://attic.apache.org/process.html > , > I'm calling a vote to move Apache Ambari to the Attic. Over the past 2 > years we w

Review Request 27485: Add alerts for ZKFC down

2014-11-01 Thread Jonathan Hurley
: 11.033 s [INFO] Finished at: 2014-11-01T15:16:32-04:00 [INFO] Final Memory: 10M/81M [INFO] Thanks, Jonathan Hurley

Re: Review Request 27530: HostComponent requests that include Nagios are not performant

2014-11-03 Thread Jonathan Hurley
handles this for 1.7.0 - Jonathan Hurley On Nov. 3, 2014, 12:32 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27396: Pushing component logs to HDFS from ambari-agent

2014-11-03 Thread Jonathan Hurley
x27;s not running HDFS (GlusterFS for example)? ambari-agent/src/main/python/ambari_agent/loghandler/hdfsapi.py <https://reviews.apache.org/r/27396/#comment100938> command_args (spelling) - Jonathan Hurley On Nov. 3, 2014, 3:30 p.m., Cabir Zoun

Re: Review Request 26726: Broken Dashboard page after upgrade to ambari-1.7.0 version

2014-11-04 Thread Jonathan Hurley
> On Oct. 15, 2014, 9:12 a.m., Jonathan Hurley wrote: > > Ship It! Has this been commmitted? If so, can you close it out? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 27532: Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433

2014-11-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27532/#review59765 --- Ship it! Ship It! - Jonathan Hurley On Nov. 3, 2014, 2:27 p.m

Review Request 27582: Alerts: NameNode Health HA Alert Check

2014-11-04 Thread Jonathan Hurley
"state" : "CRITICAL", "text" : "Active['c6402.ambari.apache.org:50070'], Standby[], Unknown['c6401.ambari.apache.org:50070']" "state" : "OK", "text" : "Active['c6402.ambari.apache.org:50070'], Standby['c6401.ambari.apache.org:50070'], Unknown[]" New tests added as well... Thanks, Jonathan Hurley

Re: Review Request 27582: Alerts: NameNode Health HA Alert Check

2014-11-04 Thread Jonathan Hurley
g:50070']" "state" : "CRITICAL", "text" : "Active['c6402.ambari.apache.org:50070'], Standby[], Unknown['c6401.ambari.apache.org:50070']" "state" : "OK", "text" : "Active['c6402.ambari.apache.org:50070'], Standby['c6401.ambari.apache.org:50070'], Unknown[]" New tests added as well... Thanks, Jonathan Hurley

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Jonathan Hurley
72> Hungarian anyone? - Jonathan Hurley On Nov. 4, 2014, 4:55 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Jonathan Hurley
> On Nov. 4, 2014, 6:22 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java, > > line 106 > > <https://reviews.apache.org/r/27590/diff/1/?file=749671#file749671line106> &

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Jonathan Hurley
cluster_version ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql <https://reviews.apache.org/r/27607/#comment101270> When starting the sequence at 1, the initial value for cluster_version and host_version will be 2. I always disliked that. - Jonathan Hurley

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Jonathan Hurley
ws.apache.org/r/27607/#comment101517> SQL says this is NOT NULL - Jonathan Hurley On Nov. 5, 2014, 5:02 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
BT stack alert implementation. Installed a BT 0.8 cluster with all services, verified alerts are working correctly. Thanks, Jonathan Hurley

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
--- Added test cases found for issues during BT stack alert implementation. Installed a BT 0.8 cluster with all services, verified alerts are working correctly. Thanks, Jonathan Hurley

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
itions and 1 agent alert definition. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27688/#review60257 ------- O

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
n Nov. 6, 2014, 12:48 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27688/ > --- > > (Up

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Jonathan Hurley
be readable for all of the other tables? :) ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java <https://reviews.apache.org/r/27607/#comment101644> Formatting is off here. - Jonathan Hurley On Nov. 6, 2014, 5:03 p.m., Alejandro Fernandez

Re: Review Request 27726: Views: Instance Data API doesn't work in threads

2014-11-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27726/#review60348 --- Ship it! Ship It! - Jonathan Hurley On Nov. 7, 2014, 12:43 p.m

Re: Review Request 27740: ambari cluster HS2 health check causing errors in logs

2014-11-07 Thread Jonathan Hurley
x27;s for trunk, then alert_hive_thrift_port.py uses the hive_check function. You should also verify that your changes also work on the new alerts framework. You can verify this alert by executing http://localhost:8080/api/v1/clusters/c1/alerts?Alert/name=hive_server_process - Jonathan Hurley O

Re: Review Request 27740: ambari cluster HS2 health check causing errors in logs

2014-11-07 Thread Jonathan Hurley
nabled=security_enabled) If this code change is for trunk, you'll need to update the new alert scripts as well. If it's not for trunk, then you can close the issue. - Jonathan Hurley On Nov. 7, 2014, 3:04 p.m., Andre

Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-09 Thread Jonathan Hurley
ler/internal/AlertResourceProviderTest.java ef014a9 Diff: https://reviews.apache.org/r/27790/diff/ Testing --- New tests added to ensure the renderer converts the flattened alert data correctly. Thanks, Jonathan Hurley

Re: Review Request 27802: Rest api's for host component logs.

2014-11-10 Thread Jonathan Hurley
/main/resources/key_properties.json <https://reviews.apache.org/r/27802/#comment101969> Our direction has been to move away from this file and define these keys statically in the provider. Alerts and Views does this. ambari-server/src/main/resources/properties.json <https://reviews.ap

Re: Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-10 Thread Jonathan Hurley
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27790/#review60599 --- On Nov. 9, 2014, 9:14 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-10 Thread Jonathan Hurley
atcher.java <https://reviews.apache.org/r/27810/#comment101981> SNMPv2 PDU types are not supported by this. Should this be a determination based on the supplied properties? - Jonathan Hurley On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote: > > --

Re: Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version

2014-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27841/#review60714 --- Ship it! Ship It! - Jonathan Hurley On Nov. 10, 2014, 6:14 p.m

Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Jonathan Hurley
] [INFO] Total time: 25:19 min [INFO] Finished at: 2014-11-11T10:32:33-05:00 [INFO] Final Memory: 29M/195M [INFO] Thanks, Jonathan Hurley

Re: Review Request 27700: Allow for server-side commands

2014-11-11 Thread Jonathan Hurley
Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27700/ > --- > > (Updated Nov. 10, 2014, 9:05 a.m.) > > > Review request for Ambari, dilli dorai,

Review Request 27884: Alerts: Provide Grouped Summary Structure On Alerts Endpoint

2014-11-11 Thread Jonathan Hurley
org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java afe9798 ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java 18f206e ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a Diff: https://reviews.apache.org/r/27884/diff/ Testing --- New test added to cover the new renderer. Thanks, Jonathan Hurley

Re: Review Request 27884: Alerts: Provide Grouped Summary Structure On Alerts Endpoint

2014-11-11 Thread Jonathan Hurley
nition.java 18f206e ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a Diff: https://reviews.apache.org/r/27884/diff/ Testing --- New test added to cover the new renderer. Thanks, Jonathan Hurley

Re: Review Request 27901: Format DDL scripts CREATE TABLE statements

2014-11-11 Thread Jonathan Hurley
numentally easier to read! Where's my +2 button? - Jonathan Hurley On Nov. 11, 2014, 9:09 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-12 Thread Jonathan Hurley
> On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, > > line 30 > > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30> > > > >

Re: Review Request 27913: Views: support validation

2014-11-12 Thread Jonathan Hurley
ambari-server/src/main/java/org/apache/ambari/server/view/validation/InstanceValidationResultImpl.java <https://reviews.apache.org/r/27913/#comment102435> Gson is thread-safe to reuse, but costly to instantiate. I would say make this static and just reuse the Gson instance that's

Re: Review Request 27913: Views: support validation

2014-11-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27913/#review60999 --- Ship it! Ship It! - Jonathan Hurley On Nov. 12, 2014, 11:38 a.m

Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code

2014-11-12 Thread Jonathan Hurley
/BaseBlueprintProcessorTest.java 7eb28df ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 48b9077 Diff: https://reviews.apache.org/r/27929/diff/ Testing --- Updated tests to reflect the removed code. Thanks, Jonathan Hurley

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-12 Thread Jonathan Hurley
> On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, > > line 30 > > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30> > > > >

Re: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code

2014-11-12 Thread Jonathan Hurley
[INFO] Thanks, Jonathan Hurley

Re: Review Request 27396: Pushing component logs to HDFS from ambari-agent

2014-11-13 Thread Jonathan Hurley
> On Nov. 3, 2014, 3:53 p.m., Jonathan Hurley wrote: > > What happens when this agent code is installed in a cluster that's not > > running HDFS (GlusterFS for example)? > > Cabir Zounaidou wrote: > Presently, the command will fail and will not push the log

Re: Review Request 27802: Rest api's for host component logs.

2014-11-13 Thread Jonathan Hurley
<https://reviews.apache.org/r/27802/#comment102779> It seems like you might need this to handle the incoming config commands. Why did you remove it? - Jonathan Hurley On Nov. 12, 2014, 8:01 p.m., Cabir Zounaidou wrote: > > --

Review Request 27993: Alerts: Remove All Nagios References From Agent Code

2014-11-13 Thread Jonathan Hurley
] Thanks, Jonathan Hurley

Review Request 27999: Remove Nagios SSL Configuration From Ambari Scripts

2014-11-13 Thread Jonathan Hurley
credential store: Enter choice, (1-4): 4 Setting up Ambari kerberos JAAS configuration to access secured Hadoop daemons... Enter ambari server's kerberos principal name (amb...@example.com): Enter choice, (1-4): 5 Invalid choice ``` Thanks, Jonathan Hurley

Re: Review Request 28031: API: null value in request results in "null" string value on resource

2014-11-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28031/#review61442 --- Ship it! Ship It! - Jonathan Hurley On Nov. 14, 2014, 6:15 a.m

Review Request 28105: Alerts: Remove Flume Alerts From Host Components

2014-11-16 Thread Jonathan Hurley
and hdfs file sync). Verifed that start/stopping/killing the agent processes was correctly reflected in the UI. mvn clean test as well. Thanks, Jonathan Hurley

Re: Review Request 28095: Add Kerberos State to Ambari database

2014-11-17 Thread Jonathan Hurley
shouldn't all of its components across the various hosts become ENABLED as well? ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql <https://reviews.apache.org/r/28095/#comment103570> The MySQL script defaults this value to `OFF`, should this script as well? - Jonathan Hur

  1   2   3   4   5   6   7   8   9   10   >