webbery opened a new issue #14: How to keep selection range when DOM change for
unchangeable article?
URL: https://github.com/apache/incubator-annotator/issues/14
Hi, this may be an enchancement. Because I have no idea how to impliment it.
I have selected a range while other annotated p
tilgovi commented on issue #14: How to keep selection range when DOM change for
unchangeable article?
URL:
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339200333
Thanks for raising this issue.
Right now there is very little in this repository other than some
webbery commented on issue #14: How to keep selection range when DOM change for
unchangeable article?
URL:
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339517953
I use annotator.js of open annotator. But I do not update annotation
simultaneously. If selection save
tilgovi commented on issue #14: How to keep selection range when DOM change for
unchangeable article?
URL:
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339520195
You are looking for a different repository:
https://github.com/openannotation/annotator
--
webbery commented on issue #14: How to keep selection range when DOM change for
unchangeable article?
URL:
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339524307
Yes, I have used that repository in my nodejs project. And I'm not sure that
my new idea can be impleme
Treora opened a new pull request #15: Hackathon produce
URL: https://github.com/apache/incubator-annotator/pull/15
Some unfinished code, but possibly a usable basis to start building things
with. Implements TextQuoteSelector (anchoring as well as describing), a
tentatively named 'AnySelect
BigBlueHat commented on issue #15: Hackathon produce
URL:
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340585136
This is great work, all! I'm ? to merge this code if @tilgovi and others
are--and I'll do so tomorrow (or so) if I've not heard any reason not to.
@
tilgovi commented on issue #15: Hackathon produce
URL:
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340588195
There's lots to do for this to be ready for others to consume, but it's
moving in a good direction. ?
--
BigBlueHat commented on issue #15: Hackathon produce
URL:
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340759042
Thanks @tilgovi. Let's make this our next level up, and we can begin to help
folks understand this approach (documentation, add the demo to the site, etc),
BigBlueHat closed pull request #15: Hackathon produce
URL: https://github.com/apache/incubator-annotator/pull/15
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (f
BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
When I select content in the left-hand box in the demo, the selection jumps
outside of the box and sometimes leaves earlier selections in place. Double
cl
tilgovi commented on issue #14: How to keep selection range when DOM change for
unchangeable article?
URL:
https://github.com/apache/incubator-annotator/issues/14#issuecomment-343777264
@webbery thank you again for bringing up your needs here. I'm going to close
this issue because there i
tilgovi closed issue #14: How to keep selection range when DOM change for
unchangeable article?
URL: https://github.com/apache/incubator-annotator/issues/14
This is an automated message from the Apache Git Service.
To respon
tilgovi commented on issue #13: fragment.js should have a license header
URL:
https://github.com/apache/incubator-annotator/issues/13#issuecomment-343777441
pegjs/pegjs#491
This is an automated message from the Apache Git Ser
tilgovi commented on issue #16: Firefox selection weirdness in the demo
URL:
https://github.com/apache/incubator-annotator/issues/16#issuecomment-343777537
I can't reproduce this in the same environment.
I'll close this for now, but am happy to work this out with you if it
continues
tilgovi closed issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on
BigBlueHat opened a new pull request #17: Demo tweaks
URL: https://github.com/apache/incubator-annotator/pull/17
Fixed the "big" demo link and tweaked a few other things to make the demo a
wee bit nicer.
This is an automated
BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
When I select content in the left-hand box in the demo, the selection jumps
outside of the box and sometimes leaves earlier selections in place. Double
cl
BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL:
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344268089
Here's what it looks like for me after double-clicking the first `,` in the
selection area. You'll note in this case it *does* prop
BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL:
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344268822
Double clicking the `.` at the end of the sentence shows the same
situation--the highlight appearing in the content below the demo
BigBlueHat opened a new issue #18: Adding the demo to the site
URL: https://github.com/apache/incubator-annotator/issues/18
Right now the demo in this repo is as much a dev environment as it is a
demo--which is great! ?
However, I'd also like to package up the demo code (occasionall
Treora commented on issue #16: Firefox selection weirdness in the demo
URL:
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344278340
@BigBlueHat: just to check, might you have the [Precise
links](https://addons.mozilla.org/en-US/firefox/addon/precise-links/) extension
BigBlueHat closed issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
This is an automated message from the Apache Git Service.
To respond to the message, please log
BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL:
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344359101
@Treora I did indeed (at least in Firefox). Thank you!
That was indeed the cause, as disabling it removed the "bug."
T
tilgovi commented on issue #17: Demo tweaks
URL:
https://github.com/apache/incubator-annotator/pull/17#issuecomment-346895581
I'm gonna merge this. We should discuss the workflow we want going forward,
but I think it's okay to push pretty quickly ahead right now.
-
tilgovi closed pull request #17: Demo tweaks
URL: https://github.com/apache/incubator-annotator/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
uskudarli opened a new issue #19: [incubator-annotator] capitalization error in
imported module name asyncGenerator
URL: https://github.com/apache/incubator-annotator/issues/19
After installation of
[incubator-annotator](https://github.com/apache/incubator-annotator)
when the d
bjonnh opened a new issue #20: Upstream bug in babel?
URL: https://github.com/apache/incubator-annotator/issues/20
I had to edit
node_modules/\@babel/runtime/helpers/builtin/es6/wrapAsyncGenerator.js
and change the AsyncGenerator.js include to asyncGenerator.js
I?couldn't find tha
bjonnh opened a new issue #21: Ability to use multiple layers of annotation.
URL: https://github.com/apache/incubator-annotator/issues/21
This kind of thing cannot be represented in a DOM easily, unless we have a
tree and a way for each tree to just represent the index of the annotations in
BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.
URL:
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348224795
The way this has been done in the past (afaik) is to keep references to the
groups of DOM nodes that represent a single annot
BigBlueHat opened a new issue #2: Make `asf-site` the new `master`?
URL: https://github.com/apache/incubator-annotator-website/issues/2
Right now the default git branch is `master`. The site, however, is
published out of `asf-site`.
Do we want to:
a) use `asf-site` as our "prod" s
tilgovi commented on issue #20: Upstream bug in babel?
URL:
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348292387
Thank you! That does look like an upstream bug.
This is an automated message from the
tilgovi commented on issue #20: Upstream bug in babel?
URL:
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348292626
I think I might disable the runtime transformation for now. I'm having some
other issues with it, too.
---
tilgovi closed issue #19: [incubator-annotator] capitalization error in
imported module name asyncGenerator
URL: https://github.com/apache/incubator-annotator/issues/19
This is an automated message from the Apache Git Servi
tilgovi commented on issue #19: [incubator-annotator] capitalization error in
imported module name asyncGenerator
URL:
https://github.com/apache/incubator-annotator/issues/19#issuecomment-348292908
Look like @bjonnh diagnosed this is #20. I'm going to close this so we can
track it in one
tilgovi commented on issue #21: Ability to use multiple layers of annotation.
URL:
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348294295
This is helpful context for whomever wants to implement a highlighter, but
we haven't got one yet. The demo adds `mark` do docum
tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL:
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348294655
I might prefer option (a). Opening a PR from master is pretty lightweight
and maybe a good signal for "publish the website (y/n)?
---
tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL:
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348294864
Oh, asf-site is the default branch as far as GitHub is concerned and I've no
way to change that. Maybe let's just delete master then.
BigBlueHat commented on issue #2: Make `asf-site` the new `master`?
URL:
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348302736
Ah. Seems you're right. ? to deleting `master`...which I think Infra needs
to do. Correct @Humbedooh?
tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL:
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348305222
Nope. I just did it. ?
This is an automated message from the Apache
tilgovi closed issue #2: Make `asf-site` the new `master`?
URL: https://github.com/apache/incubator-annotator-website/issues/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on
BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.
URL:
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348328566
I think let's leave it open and begin planning/coding a highlighter. It's a
super hard piece of this puzzle, and having that
BigBlueHat closed issue #20: Upstream bug in babel?
URL: https://github.com/apache/incubator-annotator/issues/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and us
BigBlueHat commented on issue #20: Upstream bug in babel?
URL:
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348328835
Cool. I'll close this as needing to be upstreamed. @bjonnh you up for doing
that? ?
--
BigBlueHat opened a new issue #22: Build a highlighter
URL: https://github.com/apache/incubator-annotator/issues/22
This does eek into the realm of UX, so I want to proceed cautiously here.
However, juggling the "mixed tree" environment discussed in #21 is likely to be
a near everyday occu
BigBlueHat commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348329370
Additionally, this might help inform things the browsers need to
change/tweak/add about how the DOM itself works and interacts.
--
Laurian commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348344479
Many years ago, there was a xpointerlib.mozdev.org a Firefox add-on used for
Annotea, that would insert into DOM elements to highlight annotations, while
Laurian commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348344479
Many years ago, there was http://xpointerlib.mozdev.org a Firefox add-on
used for Annotea, that would insert into DOM elements to highlight annotations,
tilgovi commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348372006
Worth taking inspiration from https://github.com/nickstenning/marks too
This is an automa
tilgovi commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348372088
Nice part about inserting `mark` tags is that it's super boring and the
browser styles it.
--
tilgovi commented on issue #22: Build a highlighter
URL:
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348373026
I take that back. I would rather not commit to any tag choice at all right
now and just spend some time mulling over what problem(s) really need solving.
tilgovi commented on issue #20: Upstream bug in babel?
URL:
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348724191
This should be fixed now!
This is an automated message from the Apache Git Service.
To
tilgovi commented on issue #19: [incubator-annotator] capitalization error in
imported module name asyncGenerator
URL:
https://github.com/apache/incubator-annotator/issues/19#issuecomment-348724205
This should be fixed now!
tilgovi opened a new issue #23: Build infrastructure
URL: https://github.com/apache/incubator-annotator/issues/23
Set up build infrastructure for outputting ESM and CJS builds for the
supported node/browser platforms.
This is
tilgovi commented on issue #13: fragment.js should have a license header
URL:
https://github.com/apache/incubator-annotator/issues/13#issuecomment-356065694
Also, need to fix the license header in the fragment.pegjs file. I
inappropriately added a comment at the top. I think, instead, that
tilgovi opened a new issue #24: LICENSE and NOTICE in packages
URL: https://github.com/apache/incubator-annotator/issues/24
If packages are to be published to NPM, I think they should each have their
own copy of LICENSE and NOTICE. It's possible we should concatenate all the
NOTICE files i
tilgovi commented on issue #23: Build infrastructure
URL:
https://github.com/apache/incubator-annotator/issues/23#issuecomment-356066429
I have WIP on this. Working locally. I'm just working out the last kinks.
This is an aut
tilgovi closed issue #23: Build infrastructure
URL: https://github.com/apache/incubator-annotator/issues/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
tilgovi commented on issue #23: Build infrastructure
URL:
https://github.com/apache/incubator-annotator/issues/23#issuecomment-356690706
Closed by 4f7d0ec6b3e9567f6d38f573cf3e5ade98c3965b
This is an automated message from the
blahah opened a new issue #25: error: context not equal to range's container
URL: https://github.com/apache/incubator-annotator/issues/25
Hi, I'm trying to use annotator to allow generating an annotation from any
arbitrary selection in a web page.
I'm having an issue with `describeTe
Treora commented on issue #25: error: context not equal to range's container
URL:
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358286276
As you may be aware, annotator's code is still very immature, and the most
relevant part of the error message is the 'not impleme
BigBlueHat commented on issue #25: error: context not equal to range's container
URL:
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358332423
I did some digging and it seems like the demo code limits which nodes can be
used in a way the underlying library code does n
Treora commented on issue #25: error: context not equal to range's container
URL:
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358412575
> I'm not sure if this isWithinNode() method is solely for the demo's
selection box, or if something like that is always needed w
tilgovi commented on issue #25: error: context not equal to range's container
URL:
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358420732
Now that the build is in place, I'm comfortable importing dom-anchor-*
libraries. I'll do that ASAP and then ping back this issu
tilgovi closed issue #13: Fragment identifier license chore
URL: https://github.com/apache/incubator-annotator/issues/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHu
tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372542013
@BigBlueHat how do you think we should handle this? Do we want to treat the
packages as sub-projects and put LICENSE + NOTICE in each one? Or t
BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372695059
Given that npm distribution is still source code distribution, the LICENSE +
NOTICE in each sub-project is likely the most correct.
A
BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372695106
@Humbedooh @jimjag is there someone we should reach out to within the ASF
who could better answer this question?
--
tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372765120
That sounds right to me. Even the Babel-transipled source is source to me
and I got help from a Babel maintainer yesterday to preserve license
djKooks opened a new issue #26: Documentation link error
URL: https://github.com/apache/incubator-annotator/issues/26
Hello,
The link `development documentation` README file seems not connected. Could
you look on?
Also, is there any document which describes this project more clear
BigBlueHat opened a new issue #27: yarn install errors on a clean checkout
URL: https://github.com/apache/incubator-annotator/issues/27
I just did a clean checkout, and when I run `yarn` (or `yarn install`), I
get this:
```
yarn install v1.2.1
error An unexpected error occurred: "p
BigBlueHat closed issue #27: yarn install errors on a clean checkout
URL: https://github.com/apache/incubator-annotator/issues/27
This is an automated message from the Apache Git Service.
To respond to the message, please log
BigBlueHat commented on issue #27: yarn install errors on a clean checkout
URL:
https://github.com/apache/incubator-annotator/issues/27#issuecomment-374220124
**/me** reads the README and upgrades to yarn 1.5.1
...which, of course, fixes the problem...
--
BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-374380205
Here's the official ASF stuff:
https://apache.org/dev/licensing-howto.html#assembling-license-and-notice
Pretty easy to copy/paste.
BigBlueHat closed issue #26: Documentation link error
URL: https://github.com/apache/incubator-annotator/issues/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
BigBlueHat commented on issue #26: Documentation link error
URL:
https://github.com/apache/incubator-annotator/issues/26#issuecomment-376955642
@djKooks I updated the README to clarify that the "development
documentation" is a `localhost` only resource atm. Hopefully that makes things
cle
BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-376959263
@tilgovi @apache/annotator-committers I've added LICENSE to all packages and
NOTICE to just (for now) `packages/fragment-identifier` based o
tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL:
https://github.com/apache/incubator-annotator/issues/24#issuecomment-376985238
My read is that we should have a NOTICE file even if it contains nothing but
our header. Per the ASL, the content of that NOTICE file would the
BigBlueHat closed issue #24: LICENSE and NOTICE in packages
URL: https://github.com/apache/incubator-annotator/issues/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHu
BigBlueHat opened a new issue #28: Failing during `yarn start`
URL: https://github.com/apache/incubator-annotator/issues/28
The tests reference a `../lib` directory which is absent (perhaps
auto-generated at runtime or something?) and it causes the following errors:
```
ERROR in ./pac
tilgovi commented on issue #28: Failing during `yarn start`
URL:
https://github.com/apache/incubator-annotator/issues/28#issuecomment-376990184
I just noticed this, too. I've got some WIP to address it. I'll assign
myself.
For the moment, you can always run build and then test and t
tilgovi commented on issue #28: Failing during `yarn start`
URL:
https://github.com/apache/incubator-annotator/issues/28#issuecomment-376990241
Although, that won't work in the webpack tests, I think.
This is an automated mes
BigBlueHat opened a new issue #29: Extract NOTICE related content from LICENSE
file in fragment-identifier
URL: https://github.com/apache/incubator-annotator/issues/29
Because
https://github.com/apache/incubator-annotator/commit/4766340e970815c3cb39d2b5a2e05bd56783e4c9#commitcomment-283369
tilgovi closed issue #28: Failing during `yarn start`
URL: https://github.com/apache/incubator-annotator/issues/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
tilgovi commented on issue #28: Failing during `yarn start`
URL:
https://github.com/apache/incubator-annotator/issues/28#issuecomment-395918540
Closed in c1f7fa1dfd84c27537cc20d244cfd48eb65462cd
This is an automated message f
Treora opened a new pull request #30: Remove reselect/memoisation.
URL: https://github.com/apache/incubator-annotator/pull/30
Simplifies the code a lot, to help speed up development. similar
optimisations could be reintroduced again later.
--
tilgovi closed pull request #30: Remove reselect/memoisation.
URL: https://github.com/apache/incubator-annotator/pull/30
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull re
BigBlueHat opened a new issue #31: Incorporate Web Annotation testing tools
URL: https://github.com/apache/incubator-annotator/issues/31
This will ease testing (by us or others) of the Web Annotation JSON
documents that we (and others) pass to the client libraries we're currently
building.
BigBlueHat closed issue #29: Extract NOTICE related content from LICENSE file
in fragment-identifier
URL: https://github.com/apache/incubator-annotator/issues/29
This is an automated message from the Apache Git Service.
To r
JakeHartnell commented on issue #18: Adding the demo to the site
URL:
https://github.com/apache/incubator-annotator/issues/18#issuecomment-395992344
Working on it!
This is an automated message from the Apache Git Service.
To
BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL:
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395993696
Plan confirmed with @tilgovi to create a validation tool in `scripts/` as a
command line tool (using mocha.js) built from
https:/
JCCR commented on issue #31: Incorporate Web Annotation testing tools
URL:
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395997106
I can work on this.
This is an automated message from the Apache Git Se
BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL:
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395997800
@JCCR awesome! Would love your help. I'm getting the basics in today, I
hope, but let's chat! Find me in `#annotator` on Freednode
JakeHartnell opened a new pull request #3: Include demo
URL: https://github.com/apache/incubator-annotator-website/pull/3
Closes #18 in the incubator-annotator repo.
This is an automated message from the Apache Git Service.
To
JCCR commented on issue #31: Incorporate Web Annotation testing tools
URL:
https://github.com/apache/incubator-annotator/issues/31#issuecomment-396013903
@BigBlueHat
Can do asynchronously!
Would have liked to jump in and chat but I'm AFK today.
On Sat, Jun 9, 2018, 1:49 PM BigB
JakeHartnell commented on issue #18: Adding the demo to the site
URL:
https://github.com/apache/incubator-annotator/issues/18#issuecomment-396014071
I added a webpack build to the incubator-annotator-website. It includes the
demo from here, but styles it with Semantic UI. Going to be worki
BigBlueHat opened a new pull request #32: Initial incorporation of Annotation
Schema MUSTs
URL: https://github.com/apache/incubator-annotator/pull/32
Fixes #31.
Plenty more schemas where these came from. Hopefully this sets the stage for
similar testings of the SHOULDs, Collection
BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL:
https://github.com/apache/incubator-annotator/issues/31#issuecomment-396015369
@JCCR PR #32 will *technically* close this issue, however, there's much more
room here for improving this code.
It currentl
JakeHartnell opened a new pull request #4: Include demo
URL: https://github.com/apache/incubator-annotator-website/pull/4
Adds webpack build, closed #3 in favour of this thanks to feedback from
@BigBlueHat.
This is an automa
tilgovi commented on a change in pull request #32: Initial incorporation of
Annotation Schema MUSTs
URL: https://github.com/apache/incubator-annotator/pull/32#discussion_r194245895
##
File path: test/mocha.opts
##
@@ -4,3 +4,4 @@
--recursive
--watch-extensions mjs
packa
1 - 100 of 364 matches
Mail list logo
