Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2018-01-18 Thread Mandy Chessell
> On Jan. 18, 2018, 8:51 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 76 (patched) > > > > > > should this.name=name put into a else{}? after we check

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195710 --- jdbc/connectors/JDBCConnection.java Lines 10 (patched)

Jenkins build is back to normal : Atlas-master-UnitTests #268

2018-01-18 Thread Apache Jenkins Server
See

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 0

2018-01-18 Thread Graham Wallis
Hi Madhan Just an observation - although all the currently enabled UTs and ITs are passing there were (last time I looked) 31 tests that are disabled. I wouldn't consider these a blocker to the alpha release but I think we shouldn't lose sight of the fact that either the tests or the runtime

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Mandy Chessell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195714 --- jdbc/README.md Lines 8 (patched)

Re: Review Request 65178: ATLAS-2370: load solr resources on Windows

2018-01-18 Thread Sarath Subramanian
> On Jan. 16, 2018, 9:24 a.m., Sarath Subramanian wrote: > > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > > Line 126 (original), 137 (patched) > > > > > > remove getClassLoader() method if

Re: Review Request 65178: ATLAS-2370: load solr resources on Windows

2018-01-18 Thread Graham Wallis
> On Jan. 16, 2018, 5:24 p.m., Sarath Subramanian wrote: > > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > > Line 126 (original), 137 (patched) > > > > > > remove getClassLoader() method if

Review Request 65218: ATLAS-2377: invalid URI format

2018-01-18 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65218/ --- Review request for atlas. Repository: atlas Description --- ATLAS-2377:

Re: Review Request 65198: [ATLAS-2371]: Basic search issue with IndexSerializer

2018-01-18 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65198/#review195736 --- Ship it! Ship It! - Apoorv Naik On Jan. 17, 2018, 10:46

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-18 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65220/ --- (Updated Jan. 18, 2018, 6:37 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-18 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195709 ---

[VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 1

2018-01-18 Thread Keval Bhatt
Atlas team, Apache Atlas 1.0.0-alpha release candidate #1 is now available for a vote within dev community. Links to the release artifacts are given below. Please review and vote. The vote will be open for at least 72 hours or until the required number of votes are obtained. [ ] +1 approve

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 1

2018-01-18 Thread Madhan Neethiraj
David, > The overnight build is failing on UTs and ITs today. While validating a release, please use Atlas sources from the tag created for the release. I added the following note Apache Atlas wiki page which lists highlight of each release

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-18 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65220/ --- (Updated Jan. 18, 2018, 9:38 p.m.) Review request for atlas, Madhan Neethiraj

Add me as a contributor for Apache Atlas project

2018-01-18 Thread vishal suvagia
Dear Atlas community,                                 I would like to contribute to Apache Atlas project.                                  Request to kindly add me as a contributor for Apache Atlas, my apache-id is vishalsuvagia. Thanks and Regards, Vishal Suvagia.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2018-01-18 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195700 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2018-01-18 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195697 ---

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 18, 2018, 10:09 a.m.) Review request for atlas and Mandy

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2018-01-18 Thread Mandy Chessell
> On Jan. 18, 2018, 8:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java > > Lines 81 (patched) > > > > > > should this.type=type put after we check if type!=null?

Re: Review Request 65178: ATLAS-2370: load solr resources on Windows

2018-01-18 Thread Graham Wallis
> On Jan. 16, 2018, 5:24 p.m., Sarath Subramanian wrote: > > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > > Line 126 (original), 137 (patched) > > > > > > remove getClassLoader() method if