Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/267
Looks good, and pretty straightforward. Could you add a test for the rebind
issue described in BROOKLYN-314
---
If your project is set up for it, you can reply to this email and have your
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/270
Tested catalog deletions will YAML similar to following:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72585644
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java ---
@@ -39,4 +43,22 @@ public static InetAddress
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/288
Tested alongside https://github.com/apache/brooklyn-ui/pull/30 and this
resolves the issue on Windows 10 on both IE and Edge. Behaviour on Chrome on OS
X remains unchanged
LGTM
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-ui/pull/30
Tested alongside https://github.com/apache/brooklyn-server/pull/288 and
this resolves the issue on Windows 10 on both IE and Edge. Behaviour on Chrome
on OS X remains unchanged
LGTM
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r75093029
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,88
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r75093209
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,88
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/276
Manually tested successfully with the following YAML:
```
name: Simple Netcat Server & Effector
location: aws-ec2:eu-west-1
services:
-
GitHub user nakomis reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1168
Uses externally accessible address for main uri of controller
Previously, if deploying to BYON AWS instances, the internal IP address was
being displayed in the main.uri for the
Github user nakomis closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-186160816
/bump @sjcorbett @grkvlt @aledsage Any input on @ahgittin's comments?
---
If your project is set up for it, you can reply to this email and have
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/112
Configurable removal strategies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-server
configurable-removal
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-library/pull/31
Adds configurable removal strategies, deprecates old removal strategy
Depends on https://github.com/apache/brooklyn-server/pull/112 to be merged
at the same time
You can merge this pull
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/112#issuecomment-208827153
Depended on by https://github.com/apache/brooklyn-library/pull/31 to be
merged at the same time
---
If your project is set up for it, you can reply to this
Github user nakomis closed the pull request at:
https://github.com/apache/brooklyn-library/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/112#issuecomment-208879479
Hadn't twigged that I wouldn't need to change the config key. Much nice
without all the deprecation. Have close
https://github.com/apache/brooklyn-li
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-library/pull/33#issuecomment-217438089
I was a little late getting to this, but it looks like @tbouron, @geomacy,
and @duncangrant have already raised the concerns I had
Still not
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/112#discussion_r62474640
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/112#issuecomment-217823728
PR Comments addressed. @neykov would be interesting to hear your thoughts
for making it more YAML friendly - perhaps for a future update?
---
If your project
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/143
Adds class renames for downstream Clocker project
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-server clocker
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/144
Allows for multiple deserialization class renames files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-server
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/145#issuecomment-220266139
A future improvement would be for
`AbstractSoftwareProcessWinRmDriver.rebootAndWait` to set a sensor to indicate
that the machine is rebooting, which could be
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197284
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java
---
@@ -60,6 +62,31 @@ public void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197677
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -345,7 +346,7 @@ protected void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197753
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -126,7 +127,11 @@ public void markUsed(String key
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64198015
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionHelpers.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64203063
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java
---
@@ -60,6 +62,31 @@ public void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64203567
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -345,7 +346,7 @@ protected void
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/157
This looks sensible, but it would be nice to tidy it up as follows:
- Rename `brooklyn-invoke-command-credssp.ps1` to
`invoke-command-credssp.ps1`
- Rename `custom-enable
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/150
@bostko Can you give some more information about why
`-NoRebootOnCompletion` in conjunction with `INSTALL_REBOOT_REQUIRED` isn't
appropriate here? On the face of it, it seems
Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/150
@bostko I've been trying to reproduce the issue manually, by provisioning a
windows VM, installing ADDS remotely using pywinrm with
`-NoRebootOnCompletion`, then reconnecti
Github user nakomis closed the pull request at:
https://github.com/apache/brooklyn-server/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r65900017
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java
---
@@ -321,12 +332,22
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r65900734
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java
---
@@ -49,15 +50,28 @@ public
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/150
A couple of minor comments, but other than that, LGTM. We should probably
refactor the away the `winrm.computerName` config key, and instead set the
`hostname` sensor correctly during (or
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/150
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r66244197
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java
---
@@ -321,12 +332,21
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/150
The latest changes looks sensible. Is there any (external) documentation
saying what exceptions we may see during `rebootAndWait`, or are the exceptions
used (`WebServiceException` and
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/191#discussion_r66404956
--- Diff:
core/src/test/java/org/apache/brooklyn/enricher/stock/TransformingEnricherTest.java
---
@@ -225,17 +226,38 @@ public void
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/191
One comment, but other than that, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/157
@bostko Ideally, *all* of the scripts and config file should be copied some
path relative to `C:\brooklyn-managed-processes\install`. If they're copied to
the temp folder, there
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/193#discussion_r66480033
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
---
@@ -0,0 +1,153
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/193#discussion_r66480706
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
---
@@ -0,0 +1,153
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/193#discussion_r66481067
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
---
@@ -0,0 +1,153
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/194
Prevents premature resolving of external config
If external config is resolved too early, it can lead to resolved values
being persisted (security flaw). Also, changes to the external
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/194
This is in addition to the changes in
https://github.com/apache/brooklyn-server/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r67360931
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2422,7 +2437,7 @@ protected
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/194
PR comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-docs/pull/78
Adds details of setting up a HA master-slave pair
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-docs ha-supplemental
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-docs/pull/78
PR comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/157
The install scripts are run in the INSTALLDIR, and not the RUNDIR (the
launch script is run in RUNDIR), which would be a good pattern to keep. As it
will require a change to
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/157
Great, thanks @bostko
There are now a couple of outstanding issues
([BROOKLYN-306](https://issues.apache.org/jira/browse/BROOKLYN-306) and
[BROOKLYN-308](https://issues.apache.org
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/227#discussion_r69290194
--- Diff:
core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java ---
@@ -182,27 +211,38 @@ public static boolean setEnablement
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/227
One comment unrelated to this PR. Other than that, code looks good. Is
there an documentation that explains the explicit precedence?
---
If your project is set up for it, you can reply to
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/144
Not needed for classic, so #492 should suffice, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nakomis closed the pull request at:
https://github.com/apache/brooklyn-server/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-docs/pull/151
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/564
@neykov It looks like @bostko has addressed the bulk of the issues. Are you
happy to merge this now?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-docs/pull/158
Minor fix to Azure ARM docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-docs fix/azure-arm-docs
Alternatively you
Github user nakomis closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-docs/pull/164
Adds documentation for bundling catalog resources in a zip file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-docs
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/625
Updates BasicExternalConfigSupplierRegistry to use ClassLoaderUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-docs/pull/164
DO NOT MERGE. zip uploading is currently WIP feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/625#discussion_r110842541
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BasicExternalConfigSupplierRegistry.java
---
@@ -103,12 +103,13 @@ private
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-dist/pull/89
Adds tests for OSGI loading of external config providers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-dist osgi
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/625
Tests added at https://github.com/apache/brooklyn-dist/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-docs/pull/172
I think it would be worth changing the wording to make it clearer that
you're not talking about the user *setting* the default to a new value, but
instead modifying the underlying object
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697661
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697711
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698963
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698151
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698765
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115699050
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697990
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698327
--- Diff: guide/blueprints/catalog/index.md ---
@@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when
an entity is instantiated
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-docs/pull/181
Adds instructions for configuring brooklyn to use the system proxy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-docs
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/677
Adds EBS Location Customizers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-server ebs-volume-customizer
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/680
Adds JcloudsLocationCustomizer hook to allow node / config configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/680
@bostko If declared in the YAML, then the property must be known *before*
the machine is provisioned. The hook allows for a customizer to configure the
ssh / winrm config tool with runtime
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/680#discussion_r116485510
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java
---
@@ -118,4 +123,17
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/677
@drigodwin description an example added
@sjcorbett the classes sit adjacent to existing cloud-specific classes such
as `SoftLayerSameVlanLocationCustomizer` and
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/677
@neykov I did look at that, but the `availabilityZone: us-west-1a` field
gets automagically pulled into the provisioning properties (grr!), so it's
always going to be cloud-spe
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/677
@neykov Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nakomis closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-docs/pull/164
Closing in favour of #180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/700
Adds getLastConstructorProps to RecordingWinRmTool
Adds `getLastConstructorProps()` to `RecordingWinRmTool`, in line with
`RecordingSshTool`
You can merge this pull request into a Git
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/800
AutoScalerPolicy to resize to limits on expunge
Currently, if a user resizes a cluster with an `AutoScalerPolicy` such that
the pool size is now outside the min and max pool size for the
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/800
On second thoughts, these tests seem a little fragile and may have
non-deterministic failures. Please DO NOT MERGE (yet)
---
If your project is set up for it, you can reply to this email
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/800
Should now be good to go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/803
Adds cluster.max.size to dynamic cluster
Adds cluster.max.size to dynamic cluster, and prevents the cluster from
being manually increased beyond that size
You can merge this pull request
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/803
PR comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/800
PR comment addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/858
Fixes broken
ClassLoaderFromStackOfBrooklynClassLoadingContextTest.testLoadClassFromBundle
test
Updates test jars to fix broken
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r156407339
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/DynamicClusterTest.java ---
@@ -1398,14 +1398,18 @@ public void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r156406908
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -799,6 +795,12 @@ protected Entity replaceMember
Github user nakomis commented on the issue:
https://github.com/apache/brooklyn-server/pull/916
@aledsage regarding resizing up to `maxSize`, I'd favour @sjcorbett's
approach of throwing the `InsufficientCapacityException` and leaving it up to
the consumer to re-try. Reques
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-docs/pull/249
Updates ulimit docs for Centos 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/brooklyn-docs ulimit-docs-update
Alternatively
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/953
Defers reading of config in SshCommandSensor
This allows DSL to be used in the command, env and execution dir as
a management context will then be available
You can merge this pull
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/954
Changes access of `StringPredicates` classes
This allows them to be used in YAML, via $brooklyn:object
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/956
SSH Sensor value-on-error
Adds `value.on.error` config key to SshCommandSensor to allow a value
to be specified for use when an exception occurs when executing the
ssh command
You
1 - 100 of 118 matches
Mail list logo