[GitHub] calcite-avatica-go pull request #26: [CALCITE-2493] Update dependencies

Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/26 ---

[jira] [Created] (CALCITE-2495) Rework URL->File conversion in tests

Vladimir Sitnikov created CALCITE-2495: -- Summary: Rework URL->File conversion in tests Key: CALCITE-2495 URL: https://issues.apache.org/jira/browse/CALCITE-2495 Project: Calcite Issue

Calcite-Master - Build # 800 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #800) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/800/ to view the results.

Calcite-Master - Build # 799 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #799) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/799/ to view the results.

Calcite contributions

Hello, I've found a simplification issue a while ago; written an ignored test for it - and opened a new jira to have the fix its own ticket: https://issues.apache.org/jira/browse/CALCITE-2327 - because it was not connected to the actual ticket. * I've submitted a patch to disable this

Re: Calcite contributions

On Tue, Aug 28, 2018 at 6:09 PM Vladimir Sitnikov wrote: > Initial analysis by Alexey was not right, so he implemented a wrong > solution. That happens when people try to fix unfamiliar codebases. I am completely out of line here, but this statement sounds pretty detrimental to any potential

[jira] [Created] (CALCITE-2494) RexFieldAccess should implement equals/hashCode

Vladimir Sitnikov created CALCITE-2494: -- Summary: RexFieldAccess should implement equals/hashCode Key: CALCITE-2494 URL: https://issues.apache.org/jira/browse/CALCITE-2494 Project: Calcite

Calcite-Master - Build # 798 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #798) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/798/ to view the results.

[GitHub] calcite-avatica-go pull request #27: [CALCITE-2335] Add support for Go modul...

Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/27 ---

[GitHub] calcite-avatica-go pull request #27: [CALCITE-2335] Add support for Go modul...

GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica-go/pull/27 [CALCITE-2335] Add support for Go modules and test against Go 1.11 You can merge this pull request into a Git repository by running: $ git pull

Re: Calcite contributions

Zoltan>...because unfortunately this new patch still contains an bug. Could I please correct you a bit? The patch did solve the issue that is represented in the issue description. The patch did pass all the tests you had by that moment. So "still contains a bug" is more like "there are

Re: Maven wrapper

Is it worthwhile to share the details of that situation with the community (or are the specifics you provided all that's really relevant)? Asking to better understand if there is some legitimate criticism of what Maven lets you do, or if it's something we can make better in Calcite itself.

Re: graphql query to sql query with Calcite ?

Hi Eugen, You can have a look at RelBuilderTest to see how to instantiate a RelBuilder. To create a Calcite Schema you may also take inspiration from the following method: org.apache.calcite.test.CalciteAssert#addSchema Best, Stamatis Στις Τρί, 28 Αυγ 2018 στις 10:31 π.μ., ο/η Eugen Stan

Re: Maven wrapper

Just to clarify: I was always +1 re Maven wrapper. PS. Hopefully it is a small step forward to Gradle wrapper :) Vladimir

Re: Calcite contributions

Michael> But the default in those cases should hopefully be to work with the Michael>original contributor to make any necessary changes or in some cases explain Please clarify if you mean that BOTH trivial and non-trivial cases to be handled in exactly the same way. Vladimir

Re: Calcite contributions

I do think it would have been more productive if this discussion had happened earlier. I generally expect for non-trivial PRs that the first version have issues (certainly most/all of mine do.) As committers/PMC members, we do have a role as gatekeepers and we shouldn't merge PRs with issues. But

Re: Maven wrapper

I was originally -0 which I will change to +0 (I could probably be convinced to be +1). I don't see any major issue in including since it's just two files that we can easily remove later if we choose to. If we do this, we definitely should have the default instructions use mvnw as Julian suggested

[jira] [Created] (CALCITE-2496) EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero

Sergey Nuyanzin created CALCITE-2496: Summary: EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero Key: CALCITE-2496 URL: https://issues.apache.org/jira/browse/CALCITE-2496

code review: CALCITE-2485. Wrong single projection in Elastic adapter

Hello, Can somebody pls take a look at PR801 (CALCITE-2485 ). It is a fix for ES adapter bug (bad logic for single element projections). Thank you, Andrei.

Re: Maven wrapper

> On Aug 28, 2018, at 8:10 AM, Josh Elser wrote: > > Is it worthwhile to share the details of that situation with the community > (or are the specifics you provided all that's really relevant)? Asking to > better understand if there is some legitimate criticism of what Maven lets > you do, or

Re: [jira] [Comment Edited] (CALCITE-2495) Rework URL->File conversion in tests

>> Can someone please test this on Windows before we submit? was able to pass mvn clean install on Windows however made several changes to do that all mentioned in comments for the PR https://github.com/apache/calcite/pull/807 On Tue, Aug 28, 2018 at 8:11 PM Vladimir Sitnikov (JIRA) wrote: > >

Re: Calcite contributions

Vladimir, I think Michael is being a bit too nice. Your behavior was extremely rude. It does seem that you were technically correct in this case. But we require civility in this community. Julian > On Aug 28, 2018, at 11:11 AM, Michael Mior wrote: > > I understand that when there are

calcite document issue

Hi: 你们好! (I'm work using java ) first , calcite is complex ,but document is so lack ; calcite-core has many classes, i think should add class UML , the core concept introduce , develop document ; i look over the source code, my brain has no clue ; more deep , more doc ;

Re: Calcite contributions

I understand that when there are issues with trivial fixes, it's sometimes much easier to just fix them yourself. I think it's still beneficial if people are willing to work with the original contributor to fix things, but I understand not everyone will be able to invest that time. If an alternate

Re: Giving the Calcite logo some love

The drop shadow is kind of the point (see birefringence[1]). But I agree that it makes the logo difficult to read. Julian [1] https://en.wikipedia.org/wiki/Birefringence > On Aug 28, 2018, at 11:44 AM, Vladimir Sitnikov > wrote: > >

Re: Calcite contributions

Michael>I still think Michael>this should be communicated to the original contributor along with a link Michael>to the fix. This at least gives the person an opportunity to learn. I have linked the original PR and the fix, and it did help Zoltan to note an alternative implementation. Julian>Your

Calcite Jenkins fails due to spaces in folder names

Hi, Jenkins jobs fail due to %20 in the file path. CI failure holds -SNAPSHOT releases from being published. The good news is it looks like there's a solution. https://stackoverflow.com/a/17870390/1261287 suggests Paths.get (uri).toFile(), however that fails for "file:test.txt" kind of URLs

Re: JDK 8 syntax

Excellent. Can you commit the fix please, Vova? > On Aug 28, 2018, at 10:34 AM, Vova Vysotskyi wrote: > > Hi all, > > Janino issue with > this "strange" default method was fixed, so now we can revert the temporary > fix made in CALCITE-2261

Re: Giving the Calcite logo some love

Stamatis>From the discussion so far, I came also with a few quick drafts How about making text separate from the shape? E.g. shape on the left, text on the right. Michael>without the drop shadow on the text +1 Vladimir

Re: Giving the Calcite logo some love

I like all the logos that Daniel proposed, but I slightly prefer the second batch. >From the discussion so far, I came also with a few quick drafts: https://svgur.com/s/85N https://svgur.com/s/864 https://svgshare.com/i/84s.svg I can further improve them if there is any interest. Best,

Re: calcite document issue

If you have specific suggestions on where the documentation should be extended or improved, we would welcome those (especially if they come with a pull request :) As it is, it's unclear what documentation you're suggesting be added. -- Michael Mior mm...@apache.org Le mar. 28 août 2018 à

Re: JDK 8 syntax

Sure, I'll prepare the fix, just wanted to share good news :) Kind regards, Volodymyr Vysotskyi On Tue, Aug 28, 2018 at 8:41 PM Julian Hyde wrote: > Excellent. Can you commit the fix please, Vova? > > > On Aug 28, 2018, at 10:34 AM, Vova Vysotskyi wrote: > > > > Hi all, > > > > Janino issue

Re: Giving the Calcite logo some love

Personally, I would prefer those without the drop shadow on the text, but I like them as well :) -- Michael Mior mm...@apache.org Le mar. 28 août 2018 à 14:40, Stamatis Zampetakis a écrit : > I like all the logos that Daniel proposed, but I slightly prefer the second > batch. > > From the

[jira] [Created] (CALCITE-2497) Update Janino version to 3.0.9

Volodymyr Vysotskyi created CALCITE-2497: Summary: Update Janino version to 3.0.9 Key: CALCITE-2497 URL: https://issues.apache.org/jira/browse/CALCITE-2497 Project: Calcite Issue

Calcite-Master - Build # 801 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #801) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/801/ to view the results.

Re: JDK 8 syntax

Hi all, Janino issue with this "strange" default method was fixed, so now we can revert the temporary fix made in CALCITE-2261 and update Janino version to 3.0.9. Kind regards, Volodymyr

Re: Calcite contributions

My thought was that the least that should be done is post a note that the issue has been fixed. However (others can correct me if I'm wrong), it seems that you did do this before Zoltan sent out his earlier email. In any case, while it's true that both of the issue and the PR were "inactive", I

Re: Calcite contributions

Michael>One of the other side effects in this case Michael>seems to be (without having examined the technical merit of either Michael>solution) that the fix which was ultimately committed still didn't solve Michael>the original issue. I'm afraid you did are wrong here. My first commit implemented

[jira] [Created] (CALCITE-2498) geode adapter quotes booleans as strings ('true' / 'false')

Andrei Sereda created CALCITE-2498: -- Summary: geode adapter quotes booleans as strings ('true' / 'false') Key: CALCITE-2498 URL: https://issues.apache.org/jira/browse/CALCITE-2498 Project: Calcite

Re: Giving the Calcite logo some love

How about something like the following: https://svgur.com/s/83y Minimal presence of drop-shadow just to keep a bit the birefringence effect and text next to the shape. Στις Τρί, 28 Αυγ 2018 στις 9:54 μ.μ., ο/η Julian Hyde έγραψε: > The drop shadow is kind of the point (see

Re: Giving the Calcite logo some love

Stamatis>How about something like the following: There's left-to-right vs right-to-left issue, however I would claim that the direction of improvement is right+up. For instance: BTC price is good when plots go to the right and go upward. https://svgur.com/s/83y is slanted backward. That creates

[DISCUSS] Towards Avatica-Go 3.1.0

Hi all, I'd like to start a vote for Avatica-Go 3.1.0 over the next few days. Some key things I'd like to address in this release: - Go 1.11 was released a few days ago and now includes support for dependency management using "Go modules" (done). Some history: The Go community released a

[GitHub] calcite-avatica-go pull request #28: [CALCITE-2335] Set module version to v3

Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/28 ---

Re: [DISCUSS] Towards Avatica-Go 3.1.0

Thanks for driving this, Francis. Apache release policy and Calcite release practice have both changed recently: * Calcite no longer releases a .zip, only a .tar.gz; and we no longer release an .md5[1]. If you want to drop the .zip feel free; if not, that’s fine also. * Apache policy now says

Re: [DISCUSS] Towards Avatica-Go 3.1.0

True. But you will run into grief from the Apache release police if you do. I would strongly recommend following the recommendation. :) > On Aug 28, 2018, at 4:23 PM, Michael Mior wrote: > > Looks like a great plan. Thanks Francis :) > > Also, while I think we should drop the .md5 (and I

Re: [DISCUSS] Towards Avatica-Go 3.1.0

I will also be including the transition plan in the release notes and the news item for the release. The JIRA case is CALCITE-2335. I believe zip archives were removed, but I will check to confirm. I will also check to confirm if we are still releasing a .md5 for Avatica-Go. MD5 is easily

Re: Calcite contributions

Again, I’m going to speak more strongly than Michael. Vladimir, Even if you are right, that doesn’t give you the right to be uncivil. Over-riding Zoltan’s PR, for which he had asked for a review, but not received, was not OK. If you had just said “Hey Zoltan, I think I’ve come up with a

Re: Calcite contributions

Thanks for clarifying. It seems like this is a case where there's a broader discussion to be had about the merits of the optimization (completely separate from the issue at hand). 1) I'm not opposed to developing a fix that's better than one which was already proposed although I think it would be

[GitHub] calcite-avatica-go pull request #28: [CALCITE-2335] Set module version to v3

GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica-go/pull/28 [CALCITE-2335] Set module version to v3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Boostport/calcite-avatica-go

joins and low selectivity optimization

Hello, I’m looking for a way to improve performance of a join query. Suppose one joins two heterogeneous sources t1 and t2 with some predicates. Further assume that cardinality of one of the predicates is very low (compared cardinality of the second one). (How) Is it possible to convert second

Re: joins and low selectivity optimization

As far as I am aware, the optimizer has no access to data, only metadata. The traditional way to solve such problems would be to select among different join algorithms which perform better for varying cardinalities of each side of the join. Unfortunately, I think you're likely to have a tough time

Re: joins and low selectivity optimization

If I recall correctly, Hive does this kind of optimization. It’s pretty important you have a date dimension table and your fact table is partitioned on date. Example: select * from sales join date_dim on sales.date_id = date_dim.id where sales.product_name = ‘foo' and

Re: joins and low selectivity optimization

Thank you, Michael and Julian, for your answers. Even if optimizers don't have access to data can they have access to table statistics ? If I remember correctly Oracle CBO is estimating selectivity based on column distribution (histograms) and some formulas for density

[jira] [Created] (CALCITE-2499) Drop support for dep

Francis Chuang created CALCITE-2499: --- Summary: Drop support for dep Key: CALCITE-2499 URL: https://issues.apache.org/jira/browse/CALCITE-2499 Project: Calcite Issue Type: Task

Re: joins and low selectivity optimization

Sure, Calcite makes use of stats in its cost formulas. And you are correct that “metadata” is what Calcite calls statistics. But you have to be careful to only treat statistics as approximate. If the statistics were gathered using an “ANALYZE TABLE” command a month ago they may be out of date,

Re: [DISCUSS] Towards Avatica-Go 3.1.0

I just checked the release script for avatica-go. It looks like md5 and zip archives were removed sometime ago, so this should not be a problem. On 29/08/2018 9:26 AM, Julian Hyde wrote: True. But you will run into grief from the Apache release police if you do. I would strongly recommend

[GitHub] calcite-avatica-go pull request #29: [CALCITE-2500] Test against Avatica 1.1...

GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica-go/pull/29 [CALCITE-2500] Test against Avatica 1.12.0 and Phoenix 5.0.0 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] calcite-avatica-go pull request #29: [CALCITE-2500] Test against Avatica 1.1...

Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/29 ---

[jira] [Created] (CALCITE-2501) Release Avatica Go 3.1.0

Francis Chuang created CALCITE-2501: --- Summary: Release Avatica Go 3.1.0 Key: CALCITE-2501 URL: https://issues.apache.org/jira/browse/CALCITE-2501 Project: Calcite Issue Type: Task

[jira] [Created] (CALCITE-2500) Test against Avatica 1.12 and Phoenix 5.0

Francis Chuang created CALCITE-2500: --- Summary: Test against Avatica 1.12 and Phoenix 5.0 Key: CALCITE-2500 URL: https://issues.apache.org/jira/browse/CALCITE-2500 Project: Calcite Issue

Re: Giving the Calcite logo some love

The designs I have seen so far look really good! Would it also make sense to design a variant for Avatica as well? This is what the current Avatica logo looks like: https://calcite.apache.org/avatica/img/logo.png Francis On 29/08/2018 7:08 AM, Vladimir Sitnikov wrote: Stamatis>How about

Re: [DISCUSS] Towards Avatica-Go 3.1.0

Also, it’s helpful that you are publishing the transition plan up-front. Do you plan to include it in the release notes, or perhaps reference a JIRA case? Users of avatica-go may not be subscribed to this list, but they still need to be aware of the transition plan. > On Aug 28, 2018, at 4:05

Re: [DISCUSS] Towards Avatica-Go 3.1.0

Looks like a great plan. Thanks Francis :) Also, while I think we should drop the .md5 (and I don't see a good reason not to), SHOULD NOT indicates that it's a recommendation, not a requirement. -- Michael Mior mm...@apache.org Le mar. 28 août 2018 à 19:13, Julian Hyde a écrit : > Thanks

[GitHub] calcite-avatica-go pull request #26: [CALCITE-2493] Update dependencies

GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica-go/pull/26 [CALCITE-2493] Update dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/Boostport/calcite-avatica-go update-dependencies

Calcite-Master - Build # 797 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #797) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/797/ to view the results.

Re: graphql query to sql query with Calcite ?

Hello Julian, Thank you for the pointers. It is very helpful and I have started working on the project. I'm currently discovering Calcite API. Any ideas on where I can find documentation to create an In memory schema so I can pass it to RelBuilder ? I did not find much on the website. I'll use