[GitHub] F21 closed pull request #33: [CALCITE-2579] Implement live reloading of tests when source files change during development

2019-01-06 Thread GitBox
F21 closed pull request #33: [CALCITE-2579] Implement live reloading of tests when source files change during development URL: https://github.com/apache/calcite-avatica-go/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] F21 opened a new pull request #34: [CALCITE-2763] Fix handling of nils (nulls) when executing queries and scanning query results

2019-01-06 Thread GitBox
F21 opened a new pull request #34: [CALCITE-2763] Fix handling of nils (nulls) when executing queries and scanning query results URL: https://github.com/apache/calcite-avatica-go/pull/34 This is an automated message from

[GitHub] F21 closed pull request #35: [CALCITE-2771] Test against avatica HSQLDB 1.13.0

2019-01-06 Thread GitBox
F21 closed pull request #35: [CALCITE-2771] Test against avatica HSQLDB 1.13.0 URL: https://github.com/apache/calcite-avatica-go/pull/35 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] F21 opened a new pull request #36: [CALCITE-2775] Upgrade dependencies and regenerate protobufs

2019-01-07 Thread GitBox
F21 opened a new pull request #36: [CALCITE-2775] Upgrade dependencies and regenerate protobufs URL: https://github.com/apache/calcite-avatica-go/pull/36 This is an automated message from the Apache Git Service. To respond

[GitHub] F21 closed pull request #36: [CALCITE-2775] Upgrade dependencies and regenerate protobufs

2019-01-07 Thread GitBox
F21 closed pull request #36: [CALCITE-2775] Upgrade dependencies and regenerate protobufs URL: https://github.com/apache/calcite-avatica-go/pull/36 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jszeluga commented on issue #1014: [CALCITE-2804] fix casting to timestamps because of malformed dimensi…

2019-02-18 Thread GitBox
jszeluga commented on issue #1014: [CALCITE-2804] fix casting to timestamps because of malformed dimensi… URL: https://github.com/apache/calcite/pull/1014#issuecomment-464883858 Ah ok finally got it This is an automated

[GitHub] zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

2019-02-23 Thread GitBox
zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259598356 ## File path:

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

2019-02-23 Thread GitBox
asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259602022 ## File path:

[GitHub] julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

2019-02-23 Thread GitBox
julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259599740 ## File path:

[GitHub] MGelbana opened a new pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::'

2019-02-24 Thread GitBox
MGelbana opened a new pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::' URL: https://github.com/apache/calcite/pull/1066 Initial support for PostgreSQL OID types (oid, regproc, repoper..etc) is also included in the form of two test cases and

[GitHub] hsyuan commented on a change in pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way

2019-02-25 Thread GitBox
hsyuan commented on a change in pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way URL: https://github.com/apache/calcite/pull/1048#discussion_r260093386 ## File path:

[GitHub] stutigupta028 closed pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table

2019-02-25 Thread GitBox
stutigupta028 closed pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table URL: https://github.com/apache/calcite/pull/1052

[GitHub] chunweilei opened a new pull request #1069: [CALCITE-2875] fix some misspellings in RelOptListener

2019-02-25 Thread GitBox
chunweilei opened a new pull request #1069: [CALCITE-2875] fix some misspellings in RelOptListener URL: https://github.com/apache/calcite/pull/1069 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asereda-gs opened a new pull request #1068: [CALCITE-2863] ElasticSearch Adapter. "select *" may return empty tionary

2019-02-25 Thread GitBox
asereda-gs opened a new pull request #1068: [CALCITE-2863] ElasticSearch Adapter. "select *" may return empty tionary URL: https://github.com/apache/calcite/pull/1068 In some circumstances (eg. order by clause) `select *` would return `{}`.

[GitHub] XuQianJin-Stars opened a new pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-25 Thread GitBox
XuQianJin-Stars opened a new pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067 Returns the maximum depth of a JSON document. Returns NULL if the argument is NULL. An error occurs if the argument is not a valid JSON document.

[GitHub] XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-26 Thread GitBox
XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 ``` JSON_LENGTH(**json_doc**[, *path*]) ``` Returns the length of a JSON document, or, if a *path* argument is given, the length of the

[GitHub] michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG

2019-02-26 Thread GitBox
michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG URL: https://github.com/apache/calcite/pull/1061 This is an automated message from the Apache Git Service. To respond to

[GitHub] michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function

2019-02-26 Thread GitBox
michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function URL: https://github.com/apache/calcite/pull/979 This is an automated message from the Apache Git Service. To

[GitHub] kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests

2019-02-26 Thread GitBox
kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-467508536 I thinked this was merged already. @vlsi do you plan to do any more changes?

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257631585 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257630221 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257633928 ## File path:

[GitHub] kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

2019-02-26 Thread GitBox
kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954#issuecomment-467511558 I completely missed this - there was another PR for CALCITE-2722 I'll just close this now...

[GitHub] kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

2019-02-26 Thread GitBox
kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954 This is an automated message from the Apache Git Service. To respond

[GitHub] beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views

2019-02-26 Thread GitBox
beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526#issuecomment-467524517 Yeah, totally fine This is an automated message from the Apache

[GitHub] michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-26 Thread GitBox
michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#discussion_r260360783 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -2712,6 +2714,48

[GitHub] michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-26 Thread GitBox
michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#issuecomment-467500637 I noted one minor correction that should be made and if you can also rebase that change and the others into a single commit, this should

[GitHub] michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-26 Thread GitBox
michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-467501655 What is the `with wapper` here? This is an automated message from the

[GitHub] beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views

2019-02-26 Thread GitBox
beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261213393 ## File path:

[GitHub] zabetak merged pull request #1059: [CALCITE-2859] Centralize Calcite system properties

2019-02-28 Thread GitBox
zabetak merged pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-28 Thread GitBox
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468251438 @XuQianJin-Stars Sorry for the delaying, will take a look soon. This

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261217611 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-28 Thread GitBox
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468268420 > Hi @XuQianJin-Stars, could you please address Michael's comment? By looking into MySQL's JSON_LENGTH spec[1], I also think it's no

[GitHub] vlsi commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

2019-02-28 Thread GitBox
vlsi commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261129603 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -0,0

[GitHub] zabetak commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

2019-02-28 Thread GitBox
zabetak commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261139530 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261213916 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-28 Thread GitBox
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468267253 Hi @XuQianJin-Stars, could you please address Michael's comment? By looking into MySQL's JSON_LENGTH spec[1], I also think it's no need

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261215687 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-28 Thread GitBox
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468221805 hi @michaelmior @zhztheplayer Thank you very much. I hope that you can take the time to review this PR. best qianjin

[GitHub] zhztheplayer merged pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in…

2019-02-27 Thread GitBox
zhztheplayer merged pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1060 This is an automated message from the Apache Git Service. To

[GitHub] zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

2019-02-27 Thread GitBox
zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260662520 ## File path:

[GitHub] yuqi1129 opened a new pull request #1072: [CALCITE-2879] Improve filter condition in Join

2019-02-27 Thread GitBox
yuqi1129 opened a new pull request #1072: [CALCITE-2879] Improve filter condition in Join URL: https://github.com/apache/calcite/pull/1072 Close apache/calcite#1013 This is an automated message from the Apache Git Service.

[GitHub] michaelmior merged pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-27 Thread GitBox
michaelmior merged pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] zabetak merged pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

2019-02-28 Thread GitBox
zabetak merged pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950

[GitHub] kgyrtkirk opened a new pull request #1076: [CALCITE-2421] Generalize simplification of self-comparisions

2019-02-28 Thread GitBox
kgyrtkirk opened a new pull request #1076: [CALCITE-2421] Generalize simplification of self-comparisions URL: https://github.com/apache/calcite/pull/1076 This change enables to rewrite comparisions between the same operands to a form which relys on the nullability check of the original

[GitHub] zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to

[GitHub] zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to

[GitHub] zhztheplayer closed pull request #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi…

2019-02-28 Thread GitBox
zhztheplayer closed pull request #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi… URL: https://github.com/apache/calcite/pull/984 This is an automated message from the Apache Git Service. To

[GitHub] zhztheplayer commented on issue #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi…

2019-02-28 Thread GitBox
zhztheplayer commented on issue #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi… URL: https://github.com/apache/calcite/pull/984#issuecomment-468300249 Going to close this PR -- let's wait for coming into consensus in JIRA.

[GitHub] hsyuan opened a new pull request #1077: [CALCITE-2818] EXTRACT returns wrong results for DATE and TIMESTAMP values before epoch

2019-02-28 Thread GitBox
hsyuan opened a new pull request #1077: [CALCITE-2818] EXTRACT returns wrong results for DATE and TIMESTAMP values before epoch URL: https://github.com/apache/calcite/pull/1077 JIRA: https://issues.apache.org/jira/browse/CALCITE-2818

[GitHub] zhztheplayer commented on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-02-28 Thread GitBox
zhztheplayer commented on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to you

[GitHub] zhztheplayer closed pull request #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

2019-02-28 Thread GitBox
zhztheplayer closed pull request #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897 This is an automated message from the Apache Git Service. To

[GitHub] zhztheplayer commented on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

2019-02-28 Thread GitBox
zhztheplayer commented on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly, closing temporarily.

[GitHub] zhztheplayer edited a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

2019-02-28 Thread GitBox
zhztheplayer edited a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly for now, closing temporarily.

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-02-28 Thread GitBox
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1036 should be merged depending on result of discussion on

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419 ## File path:

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-02-28 Thread GitBox
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1022 should be merged depending on result of discussion on

[GitHub] asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi

2019-02-28 Thread GitBox
asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi URL: https://github.com/apache/calcite/pull/1036#issuecomment-468429549 If we go JNDI route (see [dev

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378248 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378619 ## File path:

[GitHub] risdenk commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
risdenk commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260897241 ## File path:

[GitHub] siddharthteotia commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
siddharthteotia commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-467987770 ping? cc @laurentgo , @vladimirdolzhenko I am not sure exactly who

[GitHub] julianhyde commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261350210 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-02-28 Thread GitBox
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1036 should be merged depending on result of discussion on

[GitHub] siddharthteotia commented on issue #1029: [CALCITE-2824] Fix invalid usage of RexExecutorImpl

2019-02-28 Thread GitBox
siddharthteotia commented on issue #1029: [CALCITE-2824] Fix invalid usage of RexExecutorImpl URL: https://github.com/apache/calcite/pull/1029#issuecomment-468441305 @vlsi , @laurentgo , I am not sure how exactly we can test test this. The code change here avoids the direct casing of

[GitHub] risdenk commented on issue #811: Add LGTM code quality badges

2019-02-28 Thread GitBox
risdenk commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468460341 Not sure how I feel about this one. Based on https://issues.apache.org/jira/browse/INFRA-17226 LGTM can't be integrated with the build. Since INFRA is

[GitHub] risdenk commented on issue #811: Add LGTM code quality badges

2019-02-28 Thread GitBox
risdenk commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468472598 Closing this PR due to no immediate need to move forward. If LGTM and Apache legal due to Github permissions end up working together we can look at this

[GitHub] risdenk closed pull request #811: Add LGTM code quality badges

2019-02-28 Thread GitBox
risdenk closed pull request #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

2019-02-28 Thread GitBox
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468449888 @vlsi ... we use this initially only to get some random ordering (not possibly the

[GitHub] vlsi commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand

2019-02-28 Thread GitBox
vlsi commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand URL: https://github.com/apache/calcite/pull/784#issuecomment-468457409 Yes it is good and committable. This is an automated

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261429146 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261428663 ## File path:

[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

2019-02-28 Thread GitBox
vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468458376 Where do you get MultiJoins in the first place?

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261430620 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261429313 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261430446 ## File path:

[GitHub] siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

2019-02-28 Thread GitBox
siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#issuecomment-468497873 ping @vlsi , @julianhyde, @laurentgo

[GitHub] siddharthteotia commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
siddharthteotia commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261386852 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-28 Thread GitBox
julianhyde commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261393964 ## File path:

[GitHub] julianhyde commented on issue #811: Add LGTM code quality badges

2019-02-28 Thread GitBox
julianhyde commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468467926 I'm -0 on this. Doesn't seem to be worth the effort. The PR submitter works for the company, so we would be free advertising for them. But our

[GitHub] hsyuan opened a new pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread GitBox
hsyuan opened a new pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078 JIRA: https://issues.apache.org/jira/browse/CALCITE-896

[GitHub] jcamachor opened a new pull request #1079: [CALCITE-2883] HepPlanner subprogram may loop till getting out of memory

2019-02-28 Thread GitBox
jcamachor opened a new pull request #1079: [CALCITE-2883] HepPlanner subprogram may loop till getting out of memory URL: https://github.com/apache/calcite/pull/1079 This is an automated message from the Apache Git Service.

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260918529 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260918775 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

2019-02-27 Thread GitBox
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468028636 ping? cc @laurentgo , @vladimirdolzhenko

[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

2019-02-27 Thread GitBox
vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468033965 @siddharthteotia , this PR adds extremely specific feature, and I don't see how the behavior is

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952365 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952927 ## File path:

[GitHub] vlsi commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative URL: https://github.com/apache/calcite/pull/1073#discussion_r26091 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1652,7 +1658,7

[GitHub] risdenk commented on issue #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

2019-02-27 Thread GitBox
risdenk commented on issue #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#issuecomment-468005422 @vlsi - planning to merge still? This is an

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260919177 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260919310 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] laurentgo merged pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

2019-02-27 Thread GitBox
laurentgo merged pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058 This is an automated message from the Apache Git Service. To respond to

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260949061 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952125 ## File path:

[GitHub] vlsi removed a comment on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
vlsi removed a comment on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-468032131 LGTM This is an automated

[GitHub] risdenk commented on issue #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions

2019-02-27 Thread GitBox
risdenk commented on issue #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions URL: https://github.com/apache/calcite/pull/997#issuecomment-468004277 Closing since JIRA closed This is an automated message

[GitHub] vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

2019-02-27 Thread GitBox
vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260938059 ## File path: core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java

  1   2   3   4   >