GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/9
CLOUDSTACK-5943: added doc for the Palo Alto Networks firewall integration
I have added documentation for the Palo Alto Networks firewall integration.
This change should also be cherry
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
I have squash merged the changes that @ustcweizhou requested. Would you
mind reviewing again so we can get this important fix into 4.10. Thanks...
@rafaelweingartner, it looks like I
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@rafaelweingartner the only change was to remove the extra gateway
verification if it was a 'guest' network because this is now handled by the
code in #1871.
```
+
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1966
I can't see what branch this is opened against on my phone. What version of
ACS is this opened against and which version do you have a problem in. The
reason I ask is because #1741 was add
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
This has the required reviews and both @remibergsma (sbp) and us (cloud.ca)
have been using this fix in production.
---
If your project is set up for it, you can reply to this email and have
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/2003
fixed an issue if the dev is not in the databag
Defend against the specified dev not being in the databag.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@ustcweizhou the `else` case did not change from the original code:
https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L49
@karuturi I have updated
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I have to admit, I am not sure how the IP was found when looping through
the list initially, but then when trying to update the index for the IP that
was found, it is not there. The only way I
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
On the Jira ticket, Wei Zhou mentioned that this could potentially happen
if you have two different public IP ranges. So if you associate a public IP
which is in a different range than the
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov we are still trying to understand how the IP was found when
looping through the `dbag` but it is not associated with the expected dev when
we try to update the index which it was
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov I have a suspicion that the ip_association.json is a
transient file which may be short lived. I am not sure because I have not seen
it either, but it was the file being processed
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
This `ips.json` file confuses the hell out of me. From what I can tell
both `eth2` and `eth3` both have the ip `10.1.35.83` twice for each (for a
total of the IP being configured 4 times over
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
So... Looking at this with a different perspective. If there is a bug
elsewhere which would cause an IP to be duplicated in the `dbag`, the old
implementation would have cleaned up this bug and
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Ya, I am not sure where the problem is stemming from. The fact that my
code is not defensive around this problem is a problem. That is for sure. But
given my understanding of the moving parts
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Does anyone know what `first_i_p` represents in the `ips.json` dbag? I am
assuming it is the Source NAT IP, but I can't find it represented anywhere in
the code (other than in a test).
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I am considering changing my implementation to be the same as the old
implementation (which removed the IP from the dbag in the initial loop of the
merge), but if `source_nat` is present and it
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Thanks @remibergsma. I am going to use `source_nat` as it better
represents what it is I am trying to establish and it seems to always be in the
object where `first_i_p` does not always seem to
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov alright, this is ready for you to start testing. Can you
kick off CI on this as well?
I will be doing testing of this locally as well.
This implementation is
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I think #2011 fixes the observed issue, but this PR improves the IP
ordering fix originally added to the strongswan pr. This implementation
ensures (again) that duplicate public ips will not be
Github user swill commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/11#issuecomment-43383883
One other note: I deleted the 'managing_networks.rst' file after verifying
that it did not include any additional detail to what was in '
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/11
Split the 'networking and traffic' section into includes and cleaned up
formatting
I created a 'networking' folder and split the 'networking2' file up i
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/12
Fixed the formatting of lists and notes and such for all files
I fixed the following:
- extra line breaks in all lists
- correctly wrapped 'note' blocks
- put 2 l
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/13
added better instructions to the 'contribute' section of the README
these instructions describe how to modify the documentation and create a
pull request for the changes to be
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-rn/pull/12
improved the 'contribute' instructions
I added the contribution workflow to the README.rst file so it is easier
for people to know how to contribute to the documentation.
You
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-install/pull/12
improved the 'contribute' instructions in the README.rst
this update makes it easier for people to understand the flow for updating
the documentation.
You can merge this pu
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs/pull/3
Added instructions for how to contribute
I removed the README.md file because it did not have anything useful in it
and we might as well keep the documentation files in RST. I created a
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-install/pull/13
cleaned up formatting in all the files
In addition to cleaning up the formatting in all the files, I also removed
the deprecated 'managing_networks.rst' file.
I di
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/14
updated the conf file so the local theme is the same as the online theme
this helps document contributors know exactly what the themed doc will look
like online.
You can merge this
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs/pull/4
fixed the formatting in all the files and added the license to each file
I updated the formatting to match the other documentation projects.
You can merge this pull request into a Git
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-docs-rn/pull/14
updated formatting to be consistent with the rest of the docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudops/cloudstack-docs
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/141
Added the CONTRIBUTING.md doc to the project root
Added instructions for how contributors should submit code changes via
GitHub Pull Requests.
You can merge this pull request into a Git
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-179964783
Should Jenkins and CI checks be succeeding or is it because the tests do
not have access to a Swift instance to test and succeed?
The code looks good to me
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-www/pull/21
developer page: fixed some repo links and new tab for external links
Fixed repo links as they were broken before.
I also changed the external links on this page to be opened in new
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218354565
Can you re-push to try to get Jenkins green. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218356331
Sorry to do this to you @rhtyd, but I just merged like 10 PRs and we now
have merge conflicts. Can you resolve the merge conflicts and re-push. When
you resolve
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356736
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 3
Errors: 0
Duration: 6h 24m 57s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356820
These connectivity issues are unrelated to this PR. I will merge this
now...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218358102
thank you sir. can you repush right away again. jenkins already failed
and I like to make sure everything is green before i merge stuff. thx...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218359137
Thank you. I am really trying to avoid that, but lets see what happens. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218362729
Can someone with a VMware environment validate this PR is functional? I
don't think running CI is going to give us anything on this one since I only
have KVM
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-218365187
@NuxRo can you close and reopen this PR to force Jenkins to kick off a run.
It has been hung in this state for days. I know you can't easily `amend` and
force
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218365323
@remibergsma just a reminder to squash and re-push so we can get jenkins
green. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218365435
@jburwell can I get your final review on this one? I think that is the
only thing we are missing on this one. Thx...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-218365520
I am going to merge this one. I am confident with the change and I have
verification from @remibergsma, so I think we are good to go on this one.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218366133
@DaanHoogland can you force push this one again so we can kick off Jenkins
again. It has been stuck in this state for a week. Thx...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218366572
@sudhansu7 can you force push again to kick off Jenkins and Travis again?
Thx...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-218366880
Bump... @sanju1010 can you please follow up on @DaanHoogland's comments.
This one is ready to go otherwise, so it would be great if you could follow up
with
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-218367016
#1515 has now been merged (sorry for the delay). Once you have a chance to
fix the merge conflicts, I can get this merged. Thx...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218367282
@anshul1886 can you please review and address the comments in this PR?
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218367555
### CI RESULTS
```
Tests Run: 94
Skipped: 0
Failed: 2
Errors: 0
Duration: 7h 45m 13s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218367932
I reran the tests that failed and they succeeded the second time, so CI is
in a good place on this one. I need one more code review on this one.
@marcaurele can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218456049
Thank you sir. Unfortunately travis failed this time. Would you mind
trying it again. Thanks...
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218456885
@mike-tutkowski unfortunately it failed again. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218458113
the travis logs seem to indicate that something is not working...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218462063
@anshul1886 I think the ask is that it get extracted as a method and a test
be written for it. @pedro-martins and @alexandrelimassantana, I feel that this
might be
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218465085
I have seen this happen periodically and it does not seem to be
consistently telling us the truth. This happens sometimes when only a single
line of code changes, so
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218465795
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 32m 05s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218466093
I need one more code review and this one should be ready to merge.
@kiwiflyer did you have a chance to review this one?
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218464050
@nvazquez this seems to have broken travis for everyone. We have this
issue showing up in pretty much all travis runs right now `ContextSuite
context
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218469220
@serg38 I had a bunch of people re-push PRs last night and this morning to
get everything green and 3 or 4 are failing with this.
Here are a couple off the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641
### CI RESULTS
```
Tests Run: 7
Skipped: 0
Failed: 4
Errors: 0
Duration: 0h 37m 50s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982
The added test fails, but lots of tests failed. I will rebuild my
environment and test again to see if anything changes.
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218489998
Can you create a new PR to fix this and we will get it tested right away.
Thanks for being on top of this. ð
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218489553
I think we are definitely having issues with it not cleaning correctly. I
have seen a couple cases where we get the "unable to update index" when it
tri
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218500189
Thank you, I will merge it assuming Jenkins and Travis come back clean.
Thx... ð
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116
@DaanHoogland well a timeout in combination with a connection is not being
able to be established seems relevant since it is related to the code that has
changed
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981
I am testing now... ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040
@DaanHoogland it finished!!! :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246
@nvazquez I don't think #1539 is related to this PR. I think this one has
completely separate issues...
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071
No worries. ð I am really short on sleep, but I was pretty confident.
:P
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218577635
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 06m 23s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 24
Errors: 10
Duration: 10h 46m 24s
```
**Summary of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 12m 09s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831
I think this one is pretty much ready. I have one code review on this one.
Can I get one more person to look over this for me? Thanks...
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-218591057
@syed can you have a look at this one.
I am not sure why, but I am having a lot of trouble with this PR. I have
not been able to get a test run to actually
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132
The additional run of these tests in a new environment gives the same
results. I think this needs some work still...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071
@rafaelweingartner yes, it will be forward merged. Sorry I only just got
around to answering your question. I need one more code review on this one.
Thanks
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484
I think this one is good to go...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648555
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 6h 07m 12s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825
This one is ready other than Jenkins. @PaulAngus, can you please either
force push the PR or close and reopen it so it kicks off Jenkins so we can get
this PR all
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913
Thanks for the hard work @remibergsma. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126
Thank you sir. I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198
Thanks gents. I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218649383
@dsclose can you force push or close and reopen the PR to kick off travis
and jenkins again? Thanks...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701
I need some code review on this one. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-218651517
Does this require a change to the system VM template? I am pulling this in
for testing now...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451
Sorry for the delay getting to this. I think this probably works in all
cases, but I suspect it will not clean up correctly always. Because this was
working
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r63011147
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218742950
Once I get #1539 merged, I will ask you to re-push since we are working to
fix the issue that is causing Travis to fail in that PR right now. Thx...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218743823
Can I get one more review on this one?
@remibergsma are you choosing not to squash because you are not the
original author of some of the commits? If that is
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r63012011
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1503#issuecomment-218745932
@DaanHoogland & @olivierlemasle thanks for the heads up guys. I will get
CI run against this today...
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218774260
@rhtyd I have had a couple independant reports of CPU going to 100% with
this patch and the problem not existing if they revert this PR (along with
#1534
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218789994
@nvazquez, @rhtyd's commit has been merged as part of his larger PR at
#1502, so we can close this PR since the result of this PR has already been
merged. T
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218790646
@PaulAngus I just pushed a fix for the Travis problems you experienced.
Can you please re-push this PR so we can try to get it all green so we can get
it merged
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218791773
Can I get one more code review on this one??? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218792730
@dsclose we have pushed fixes to both Jenkins and Travis today. Can you
please do a force push or close and reopen this PR in order to kick off Jenkins
and Travis
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-218793268
@NuxRo I have pushed fixes to both Jenkins and Travis this morning. Can
you close and reopen the PR to kick off the Jenkins and Travis runs again.
Thanks
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218794307
@remibergsma can you re-push this one. Jenkins and Travis should be fixed
now, so we should be able to get this green with a new push.
I am missing one
1 - 100 of 1169 matches
Mail list logo
