Where should the Span contribution be placed?

2018-03-07 Thread Claude Warren
I would like to submit a contribution of an interface and a couple of classes that implement the concept of a Span. A span has a starting point and a length and can return the size. It is constructed from either a starting point and length, or starting point and size. It has methods to

Re: Where should the Span contribution be placed?

2018-03-07 Thread Bernd Eckenfels
Hello Claude, I agree, your mentioned classessound like theywould fit in Commons Collection or maybe Commons Lang (or IO), depending on your focus. Whats your typical usecase for it? Thanks for considering contribution. Make sure to check out

Re: Where should the Span contribution be placed?

2018-03-07 Thread Matt Sicker
There's a Range class in commons lang that sounds related, so I'd suggest that library as a potential home. Or it might be possible to extend Range if it makes sense? On 7 March 2018 at 12:12, Claude Warren wrote: > I would like to submit a contribution of an interface and a

Re: Prepare commons to JDK 9

2018-03-07 Thread Ralph Goers
> On Mar 7, 2018, at 2:47 AM, Stephen Colebourne wrote: > > 1) Moving to Java 9 as a base would be a terrible choice. Java 9 is a > six-month release which is about to be replaced by Java 10, which will > then be replaced by Java 11. Thus, Java 8 is the only sensible >

Re: [VFS] FILE_OR_FOLDER breaking tests

2018-03-07 Thread Otto Fowler
FileType normalisePath In UriParser is an issue as well, trying to derive a FOLDER or FILE by the name doesn’t work if the system is FILE_OR_FOLDER…. On March 6, 2018 at 15:17:50, Otto Fowler (ottobackwa...@gmail.com) wrote: protected void addBaseTests() throws Exception {

Re: Prepare commons to JDK 9

2018-03-07 Thread Stephen Colebourne
On 7 March 2018 at 18:56, Ralph Goers wrote: > Actually, you really do need to use a multi-release jar to include a > module-info class file. Otherwise it may be sitting alongside of classes > compiled for an earlier java release and various tools will fail because

[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

2018-03-07 Thread pranet
GitHub user pranet opened a pull request: https://github.com/apache/commons-io/pull/56 Removed redundant isDirectory() check There is already a call to validateListFilesParameters() which checks that directory.isDirectory() is true You can merge this pull request into a Git

[GitHub] commons-collections pull request #36: The verification of unsupported iterat...

2018-03-07 Thread oscarlvp
GitHub user oscarlvp opened a pull request: https://github.com/apache/commons-collections/pull/36 The verification of unsupported iterator methods was not complete. In particular there is a verification for unsupported `add` and `set` methods in iterators. The verification misses

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-07 Thread cdeneux
Github user cdeneux commented on the issue: https://github.com/apache/commons-pool/pull/4 Hi @garydgregory, I have just updated the PR with a unit test validating the correct freeing of eviction objects. Regards, Christophe ---

Re: Prepare commons to JDK 9

2018-03-07 Thread Stephen Colebourne
1) Moving to Java 9 as a base would be a terrible choice. Java 9 is a six-month release which is about to be replaced by Java 10, which will then be replaced by Java 11. Thus, Java 8 is the only sensible baseline right now. 2) Compiling a single jar file such that it works on Java 8 but has a

Re: [io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-07 Thread sebb
On 7 March 2018 at 04:24, Gary Gregory wrote: > On Tue, Mar 6, 2018 at 4:32 PM, sebb wrote: > >> On 6 March 2018 at 23:22, Gary Gregory wrote: >> > On Tue, Mar 6, 2018 at 4:13 PM, sebb wrote: >> > >> >> On 6

Re: Prepare commons to JDK 9

2018-03-07 Thread Gilles
Hi. On Wed, 7 Mar 2018 09:47:00 +, Stephen Colebourne wrote: 1) Moving to Java 9 as a base would be a terrible choice. Java 9 is a six-month release which is about to be replaced by Java 10, which will then be replaced by Java 11. Thus, Java 8 is the only sensible baseline right now.

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-07 Thread Rob Tompkins
@Gary: I dug this up. It looks likes Sebb had a conversation with the japicmp community and brought this erroneous stack trace to light there. https://github.com/siom79/japicmp/issues/195 Thoughts? -Rob > On Mar 6, 2018, at 7:47 PM, Rob Tompkins