[GitHub] cordova-plugin-dialogs pull request: [Windows] Separated CSS from ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/74#issuecomment-219912095 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-dialogs pull request: [Windows] Separated CSS from ...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/74#issuecomment-219912245 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-dialogs pull request: [Windows] Separated CSS from ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/74#issuecomment-219913055 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: Adding links to the top ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/163#issuecomment-219916062 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: Should the README design...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/152#issuecomment-219918834 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-219924763 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Insert Content-Type to ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/139#issuecomment-219929526 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Allow custom fileKey in...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/131#issuecomment-219930989 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: Fix for CB-9753 : index out of b...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-219920751 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-10883: Added getPermissionEnt...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/173#issuecomment-219921421 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-ios pull request: Removed the check for valid targets

2016-05-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-ios/pull/224 Removed the check for valid targets This check does not serve any real purpose. But, if you already have a simulator which is not in the array, this will just stop the run. If you dont

[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/130#issuecomment-219932199 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-219915534 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: [CB-10795] Exclude curre...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/154#issuecomment-219918251 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-10883: Added getPermissionEnt...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/173#issuecomment-219919804 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-10883: Added getPermissionEnt...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/173#issuecomment-219923484 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-dialogs pull request: Added options to customize ke...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/69#issuecomment-219911103 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-dialogs pull request: add support for html message ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/68#issuecomment-219911438 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-dialogs pull request: Added options to customize ke...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/69#issuecomment-219910803 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-10577 Check if URL points to ...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/162#issuecomment-219921199 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request: Fix/file locations for Chrome

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/159#issuecomment-219922265 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Multipart related

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/142#issuecomment-219926760 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-219928043 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-219916544 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-219919340 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: Fix IllegalArgumentException

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/160#issuecomment-219921752 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request: Add the option to the installati...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/156#issuecomment-219922851 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-dialogs pull request: Added options to customize ke...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/69#issuecomment-219912592 Cordova CI Build has completed successfully. **Commit** -

Re: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-17 Thread Joe Bowser
On Tue, May 17, 2016 at 5:35 PM, Richard Knoll wrote: > Does that mean the plan is to provide a mapping from old file locations to > new ones? For example, if I have this in my plugin.xml: > > > > Will the new cordova-android automatically convert the target value to

[GitHub] cordova-plugin-inappbrowser pull request: Fix for - Stretched tool...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/166#issuecomment-219914446 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: send back loaderror when...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/156#issuecomment-219917725 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-219920275 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: CB-11118: Add support f...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/143#issuecomment-219925927 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...

2016-05-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/440#discussion_r63474049 --- Diff: cordova-lib/src/plugman/install.js --- @@ -134,15 +134,15 @@ function checkEngines(engines) { var engine = engines[i];

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

2016-05-17 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63490344 --- Diff: appium-tests/helpers/cameraHelper.js --- @@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) { },

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

2016-05-17 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/251#discussion_r63492190 --- Diff: src/cli.js --- @@ -234,17 +234,24 @@ function cli(inputArgs) { var args = nopt(knownOpts, shortHands, inputArgs); -

[GitHub] cordova-plugin-file-transfer pull request: CB-10974 Cordova file t...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

2016-05-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/251#discussion_r63491435 --- Diff: src/cli.js --- @@ -234,17 +234,24 @@ function cli(inputArgs) { var args = nopt(knownOpts, shortHands, inputArgs);

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

2016-05-17 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/251#discussion_r63492417 --- Diff: src/cli.js --- @@ -234,17 +234,24 @@ function cli(inputArgs) { var args = nopt(knownOpts, shortHands, inputArgs); -

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

2016-05-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/251#discussion_r63491154 --- Diff: src/cli.js --- @@ -234,17 +234,24 @@ function cli(inputArgs) { var args = nopt(knownOpts, shortHands, inputArgs);

cordova-electron

2016-05-17 Thread Toplak Daniel
Hi, is there any progress/status on this project: https://github.com/stevengill/cordova-electron Grüße / Regards Daniel Toplak Head of Mobile Development

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-17 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-coho/pull/122 CB-11279 Support arbitrary repositories for 'coho nightly' This PR adds the following features to `coho nightly` command: - it now accepts `--repo` flag to specify repos to build

[GitHub] cordova-plugin-camera pull request: CB-11232 Appium tests: fixed e...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/214#issuecomment-219779616 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63556380 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -yield

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63557500 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -yield

[GitHub] cordova-plugin-dialogs pull request: Secure prompt text fields for...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/71#issuecomment-219909354 Cordova CI Build has completed successfully. **Commit** -

RE: [Vote] Tools Release

2016-05-17 Thread Mefire O .
I vote +1 -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, May 16, 2016 2:48 PM To: dev@cordova.apache.org Subject: Re: [Vote] Tools Release Bump On May 13, 2016 8:21 AM, "Steven Gill" wrote: > Please review and vote on this

[GitHub] cordova-plugin-camera pull request: fixed some bad formatting that...

2016-05-17 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/207#issuecomment-219800529 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request: fixed some bad formatting that...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-219803203 @infil00p Let's get this in - I get a prompt in Android Studio without this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-219804680 OK, I pushed this in. Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/440#discussion_r63577980 --- Diff: cordova-lib/src/plugman/install.js --- @@ -134,15 +134,15 @@ function checkEngines(engines) { var engine = engines[i];

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-17 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63578645 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos -yield

[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-medic pull request: CB-11283: Adding Instructions for Jenk...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/48 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: Improving Android build output and v...

2016-05-17 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/305#issuecomment-219825870 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219826243 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219826350 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219828553 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219830920 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219832541 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219833742 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219835018 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

2016-05-17 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/13#issuecomment-219835277 @riknoll, thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

RE: [DISCUSS] Cordova tools release

2016-05-17 Thread Richard Knoll
Hey everyone, This current tools release has been causing a lot of trouble with our various CI setups. We recently resolved the cordova-fetch issue that was breaking buildbot, but we are still facing build failures because cordova-common hasn't been published [1]. The Travis build for

[GitHub] cordova-plugin-device-orientation pull request: Dummy commit to te...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/28#issuecomment-219843855 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request: Improving Android build output and v...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation pull request: Dummy commit to te...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/28#issuecomment-219846393 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device-orientation pull request: add Android suppor...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/19#issuecomment-219846447 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device-orientation pull request: Dummy commit to te...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/28#issuecomment-219846344 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-splashscreen pull request: CB-10866: Adding engine ...

2016-05-17 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219847832 @stewshka the `cordovaDependencies` object is used by Cordova, not npm, so it isn't really covered in the npm docs. You can find our documentation on

[GitHub] cordova-plugin-device-orientation pull request: Dummy commit to te...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/28#issuecomment-219848970 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-device-orientation pull request: add Android suppor...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/19#issuecomment-219850020 Cordova CI Build has completed successfully. **Commit** -

Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-17 Thread Joe Bowser
Hey I know people have been waiting for this for a very long time, but I wrote up a proposal to change the project so it's an Android Studio project. Given that Android Studio is on 2.1.1, I think it's time we moved forward and changed things around. Proposal PR is here:

[GitHub] cordova-plugin-battery-status pull request: be sure to remove list...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/34#issuecomment-219852094 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-17 Thread Parashuram N
I think the proposal is great. Our gradle is pretty big, and it does make sense to just do the defaults. +1 (personally speaking) to this – will save soo much of my time as I depend on this for my react-native-cordova-plugin adapter. Your changes will make life so much easier ☺ How do the

[GitHub] cordova-plugin-battery-status pull request: Add battery temperatur...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/28#issuecomment-219853884 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-battery-status pull request: Alignment with W3C Bat...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/24#issuecomment-219853951 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-battery-status pull request: install cordova-parame...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/21#issuecomment-219853973 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/36 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: save data and metadata to disk...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-battery-status pull request: be sure to remove list...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/34#issuecomment-219853741 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status pull request: CB-10645 The battery s...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219853851 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-battery-status pull request: add JIRA issue tracker...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/27#issuecomment-219853919 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-battery-status pull request: CB-10645 The battery s...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219856145 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219856568 This isn't a regression, and this PR has been open for quite a while so I'm going to merge this. That being said, I will create a JIRA because we can

[GitHub] cordova-plugin-battery-status pull request: Add battery temperatur...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/28#issuecomment-219857413 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status pull request: add JIRA issue tracker...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/27#issuecomment-219858564 Cordova CI Build has completed successfully. **Commit** -

RE: [Vote] Tools Release

2016-05-17 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified

[GitHub] cordova-plugin-battery-status pull request: Alignment with W3C Bat...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/24#issuecomment-219859757 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-battery-status pull request: install cordova-parame...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/21#issuecomment-219861093 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/36#issuecomment-219862255 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request: [CB-8076] Provide error supp...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/122#issuecomment-219862951 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts pull request: [CB-8076] Provide error supp...

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/122#issuecomment-219863341 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-contacts pull request: CB-10935: fix an issue of ca...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/109#issuecomment-219864298 Cordova CI Build has completed successfully. **Commit** -

  1   2   >