[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132415968 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -1123,4 +1163,22 @@ public GroupScan applyFi

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132409360 --- Diff: exec/java-exec/src/test/resources/parquet/unsupported_metadata/corrupted_metadata.requires_replace.txt --- @@ -0,0 +1,41 @@ +{ +

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132408285 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -188,6 +188,10 @@ public void setExpandedFully() {

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132408041 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,9 @@ private PruneStatus p

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132406353 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java --- @@ -452,33 +458,202 @@ public void test

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132405168 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/MetadataVersion.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to th

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132405399 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -268,11 +276,15 @@ private FileSelection exp

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132414323 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -209,9 +211,10 @@ public ParquetGroupScan( /

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132413275 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -268,11 +276,15 @@ private FileSelection exp

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132407801 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -222,15 +222,17 @@ public DrillTable isRe

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132414700 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -519,17 +564,16 @@ private void writeFile(ParquetTab

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132410703 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -974,8 +1005,17 @@ private int updateRowGrou

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132411564 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -633,13 +645,22 @@ public long getRowCount()

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132408506 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -132,25 +140,62 @@ public static ParquetTableMetadat

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132406973 --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java --- @@ -639,14 +644,18 @@ protected static void copyDirectoryIntoTempSpac

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132410745 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -974,8 +1005,17 @@ private int updateRowGrou

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 IMHO, Drill Web UI servers more as admin console where query profiles can be seen, storage plugins updated as well as system options etc. We might think of disabling Query page allowing users

[jira] [Created] (DRILL-5714) Fix NPE when mapr-db plugin is used in table function

2017-08-10 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-5714: --- Summary: Fix NPE when mapr-db plugin is used in table function Key: DRILL-5714 URL: https://issues.apache.org/jira/browse/DRILL-5714 Project: Apache Drill

[GitHub] drill pull request #902: DRILL-5714: Fix NPE when mapr-db plugin is used in ...

2017-08-10 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/902 DRILL-5714: Fix NPE when mapr-db plugin is used in table function You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

2017-08-10 Thread cgivre
Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 Hi Arina, I’d also like to add syntax highlighting to the storage plugin page as well. IMHO, it’s really easy to make a small mistake, missing a comma or quote or something, and it can be rea

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 Well, I did not mean we should not enhance Web UI. Storage plugin page enhancement would be definitely a huge plus. It's just I have a feeling that we might consider splitting admin part and

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 @parthchandra I remember once I heard that number of rows sent to Web UI in Drill is limited. From the quick glance I did not see such limitation in code. May I assume it's not true? --- If

[GitHub] drill issue #889: DRILL-5691: enhance scalar sub queries checking for the ca...

2017-08-10 Thread weijietong
Github user weijietong commented on the issue: https://github.com/apache/drill/pull/889 @arina-ielchiieva have passed all the unit tests under java-exec bundle , got some errors which are sure not associated with this change, maybe my branch was old from the master. > TestC

[GitHub] drill issue #889: DRILL-5691: enhance scalar sub queries checking for the ca...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/889 On mine environment all tests pass. I used to have troubles but long time ago. I had to fix issues with timezones, memory usage `MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=1024m"`. Also I am prett

[GitHub] drill issue #902: DRILL-5714: Fix NPE when mapr-db plugin is used in table f...

2017-08-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/902 @paul-rogers, thansk for the code review. Here is short description, hope it would be helpful: The main change is in `MapRDBSubScan` class. The problem was that mapr-db plugin wa

[GitHub] drill issue #874: DRILL-5663: Drillbit fails to start when only keystore pat...

2017-08-10 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/874 LGTM. Are you going to put the fix from DRILL_5712 into a separate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request #903: DRILL-5712: Update the pom files with dependency ex...

2017-08-10 Thread sindhurirayavaram
GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/903 DRILL-5712: Update the pom files with dependency exclusions for commons-codec In java-exec, we are adding a dependency for commons-codec of version 1.10. Other dependencies like hadoop-com

[GitHub] drill issue #874: DRILL-5663: Drillbit fails to start when only keystore pat...

2017-08-10 Thread sindhurirayavaram
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/874 Created a separate pull request for DRILL-5712. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (DRILL-5715) Performance of refactored HashAgg operator regressed

2017-08-10 Thread Kunal Khatua (JIRA)
Kunal Khatua created DRILL-5715: --- Summary: Performance of refactored HashAgg operator regressed Key: DRILL-5715 URL: https://issues.apache.org/jira/browse/DRILL-5715 Project: Apache Drill Issue

filter performance with like

2017-08-10 Thread Padma Penumarthy
I was playing around trying to figure out how to improve performance for simple pattern matching predicates with like. Documented my findings here. https://issues.apache.org/jira/browse/DRILL-5697 Want to find out if folks have any thoughts or feedback on this. Plan is to go with simple character

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

2017-08-10 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/897 I might be mistaken then. But that would make things worse. The UI will wait to return all the records from a query that could return a million records. @cgivre that is what I mean by pagina

[jira] [Created] (DRILL-5716) Queue-based memory assignment for buffering operators

2017-08-10 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5716: -- Summary: Queue-based memory assignment for buffering operators Key: DRILL-5716 URL: https://issues.apache.org/jira/browse/DRILL-5716 Project: Apache Drill Issue