Re: Filter problems in async way

2019-02-18 Thread Ian Luo
Since filter may execute its methods in different threads, first of all we cannot use thread local to pass the information. Because of this, this leads us no room but method parameters, in this case, they are invoker and invocation, to store and extract the extra info when necessary. Based on

Proposal for releasing hessian-lite 3.2.5

2019-02-18 Thread Minxuan Zhuang
Hello Dubbo Community, since the last release of hessian-lite, some issues have been fixed, so I suggest to release version 3.2.5, the branch is: https://github.com/dubbo/hessian-lite/tree/3.2.5 release note: https://github.com/dubbo/hessian-lite/releases/tag/v3.2.5 what do you think?

Bring Authorization to Dubbo OPS

2019-02-18 Thread 柯振旭
HI Dubbo Comunity: There is no authorization or authentication in the current version of dubbo-ops and it's open to all users, so I'm planing to bring authorization to dubbo-ops[1] for the sake of security, here is my thought: 1. provide a simple authorization implementation(for example

Fwd: JDK 12: First Release Candidate available

2019-02-18 Thread Huxing Zhang
Forwarding to Dubbo dev mailing list. Early investigation on JDK 12 support for Dubbo could be started if someone is interested. -- Forwarded message - From: Rory O'Donnell Date: Mon, Feb 18, 2019 at 7:50 PM Subject: JDK 12: First Release Candidate available To: Cc: , Dalibor

Re: Bring Authorization to Dubbo OPS

2019-02-18 Thread Minxuan Zhuang
thanks for your interesting, Dubbo OPS do need an authorization for service governance and service test, I think your advice is fine, please feel free to send a pr On Tue, Feb 19, 2019 at 2:06 PM 柯振旭 wrote: > HI Dubbo Comunity: > There is no authorization or authentication in the current

Re: how to deal with two pull requests to solve the same issue

2019-02-18 Thread Ian Luo
It happens but I believe it's rare. If it does happen, I agree with the ideas Huxing proposed. Regards, -Ian. On Mon, Feb 18, 2019 at 5:39 PM yuhang xiu wrote: > Totally agree with huxing. > In addition, we may be able to remind the authors of the two prs that their > pr is repeated. > This

Re: version of Apache Dubbo OPS(Incubating)

2019-02-18 Thread Ian Luo
Totally agree, the schema MAJOR.MINOR.PATCH is common sense. -Ian. On Mon, Feb 18, 2019 at 5:30 PM Huxing Zhang wrote: > Hi, > > > On Mon, Feb 18, 2019 at 4:11 PM Minxuan Zhuang > wrote: > > > > Hello Dubbo Community, > > The first dubbo ops has been released with version 0.1, usually the >

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-18 Thread Ian Luo
+1. I agree with Xiaobo and Jason. -Ian. On Thu, Feb 14, 2019 at 9:29 AM Jason Joo wrote: > +1 > > Methods with no arguments or little possible values of arguments should > not be applied `ConsistentHashLoadBalance`. Or requests can not be smoothly > distributed when nodes change. > > best

Re: Non-apache releases and old releases

2019-02-18 Thread Huxing Zhang
Hi, On Mon, Feb 18, 2019 at 1:25 PM Mercy wrote: > > Hi, > >Sorry about the unannouced release that is a re-deploy caused by the > incompatible issue of Maven, and it will appear again. Can you explain this issue a bit more? Will this re-deploy cause change to the source files? I checked

Re: how to deal with two pull requests to solve the same issue

2019-02-18 Thread Huxing Zhang
Hi, I remember I've seen this kind of issue before. >From my point of view, I prefer the following precedence: - check the implementation, the code quality requirement should be satisfied. - if the quality looks more or less the same, I usually check if he/she is the first time contributor. I

Re: [DISCUSS] Next Dubbo meetup

2019-02-18 Thread Minxuan Zhuang
+1 for March 23rd +1 for Nanjing On Thu, Feb 14, 2019 at 2:41 PM jun liu wrote: > > Can we make it Mar 23rd? As our venue is available on that day. > > +1 for Mar. 23th, any time is ok for me. > > +1 for hosting in Nanjing. > > Jun > > > On Feb 12, 2019, at 12:20 PM, 王蓉(涂南) wrote: > > > > Mar

Re: [ANN] New PPMC member: Minxuan Zhuang

2019-02-18 Thread Ian Luo
Congratulations! On Mon, Feb 18, 2019 at 5:11 PM Xianjun Ke wrote: > Congratulations > > Imteyaz Khan 于2019年2月18日周一 下午3:54写道: > > > Congratulations > > > > On Monday, February 18, 2019, 柯振旭 wrote: > > > > > Congratulations!! > > > > > > > > > > > > > > > > > > > > > > > > > > > 在 2019-02-18

Re: [DISCUSS] Next Dubbo meetup

2019-02-18 Thread victory
+1 for Nanjing And any weekend is fine for me. Minxuan Zhuang 于2019年2月18日周一 下午5:49写道: > +1 for March 23rd > +1 for Nanjing > > On Thu, Feb 14, 2019 at 2:41 PM jun liu wrote: > > > > Can we make it Mar 23rd? As our venue is available on that day. > > > > +1 for Mar. 23th, any time is ok for me.

Re: dubbo.registry.check=false具体是什么功能呢?看官网的解释不太理解,请教了!

2019-02-18 Thread Ian Luo
这是个顺序问题。check 的引入是为了保证 consumer 的启动不会依赖 provider 的启动,尤其是存在循环依赖的时候强制检查导致无法启动的现象出现。 On Wed, Feb 13, 2019 at 3:19 PM LiZhenNet wrote: > dubbo.registry.check . 是启动时候监测注册中心是否存在。 > dubbo.reference.check=false 用的会比较多, 会在启动时判断服务提供者是否存在,如果是true,当服务提供者列表为空时 > ,会报错提示。 false 则不检查。 > > 一直以来

version of Apache Dubbo OPS(Incubating)

2019-02-18 Thread Minxuan Zhuang
Hello Dubbo Community, The first dubbo ops has been released with version 0.1, usually the apache project releases follow the format: MAJOR.MINOR.PATCH, so I suggest to use version 0.2.0 for the next release.

Re: [ANN] New PPMC member: Minxuan Zhuang

2019-02-18 Thread Xianjun Ke
Congratulations Imteyaz Khan 于2019年2月18日周一 下午3:54写道: > Congratulations > > On Monday, February 18, 2019, 柯振旭 wrote: > > > Congratulations!! > > > > > > > > > > > > > > > > > > 在 2019-02-18 14:00:59,"Chen ZhiGuo" 写道: > > >Congratulations!! > > > > > >在 2019/2/18 13:40,“xxz” 写入: > > > > > >

Re: how to deal with two pull requests to solve the same issue

2019-02-18 Thread Taosheng, Wei
+1 If the pr introduce new feature or modify origin logic, the unit test should be considered! -- Original -- From: Huxing Zhang Date: Mon,Feb 18,2019 5:28 PM To: dev Subject: Re: how to deal with two pull requests to solve the same issue

Re: version of Apache Dubbo OPS(Incubating)

2019-02-18 Thread Huxing Zhang
Hi, On Mon, Feb 18, 2019 at 4:11 PM Minxuan Zhuang wrote: > > Hello Dubbo Community, > The first dubbo ops has been released with version 0.1, usually the > apache project releases follow the format: MAJOR.MINOR.PATCH, so I suggest > to use version 0.2.0 for the next release. +1 to use

Re: Non-apache releases and old releases

2019-02-18 Thread Ian Luo
We should make it public every time when we publish artifacts to the public repository, even there's nothing change from the source but other irrelevant problem like maven issue. Thanks, -Ian. On Mon, Feb 18, 2019 at 5:08 PM Huxing Zhang wrote: > Hi, > > On Mon, Feb 18, 2019 at 1:25 PM Mercy

Re: [ANN] Welcome new committer: Zhongming Hua

2019-02-18 Thread Ian Luo
Congratulations and welcome! On Fri, Feb 15, 2019 at 10:12 AM Huxing Zhang wrote: > Hi Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Zhongming Hua, > a.k.a. CrazyHZM[1], has been voted in as a new Dubbo committer. > > Please join me to say congratulations to him! > >

Re: How to integrate dubbo-registry-nacos into Fescar project?

2019-02-18 Thread Ian Luo
I am confused, why fescar needs to depend on dubbo-registry-nacos. > because fescar 0.2 has been released and supports nacos as a registration and configuration center. It looks like you should depend on nacos directly. -Ian. On Thu, Feb 14, 2019 at 11:07 PM 季敏 wrote: > When will the 2.7.1

Re: [DISCUSS] Next Dubbo meetup

2019-02-18 Thread Ian Luo
+1 to the proposed time and location. On Mon, Feb 18, 2019 at 5:56 PM victory wrote: > +1 for Nanjing > And any weekend is fine for me. > > Minxuan Zhuang 于2019年2月18日周一 下午5:49写道: > > > +1 for March 23rd > > +1 for Nanjing > > > > On Thu, Feb 14, 2019 at 2:41 PM jun liu wrote: > > > > > > Can

Re: [ANNOUNCEMENT] Apache Dubbo Spring Boot Project (Incubating) 2.7.0 has been released

2019-02-18 Thread Ian Luo
Finally we have it :) It is a strongly demanded feature. Thank you Mercy. -Ian. On Fri, Feb 15, 2019 at 4:12 PM Mercy wrote: > Hi community, > > The Apache Dubbo(incubating) team is pleasured to announce that the > Apache Dubbo Spring Boot Project (Incubating) 2.7.0 has just been released. > >

Re: Filter problems in async way

2019-02-18 Thread Ian Luo
Yuhang, Why it's a bad idea to use invocation#attachments to store the temp data? Thanks, -Ian. On Fri, Feb 15, 2019 at 2:55 PM yuhang xiu wrote: > Hi, everyone > > Recently, I found that dubbo does not handle the data generated during the > call process when it is asynchronous. > > For

Re: Filter problems in async way

2019-02-18 Thread yuhang xiu
Hi,ian Several reasons: 1. It seems that the attachment is based on the convention. We need to put the information other than the rpc parameter into the attachment. We need to ensure that the information and the temporary information (start in the timeoutFilter) do not overlap. 2. The attachment