Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread John Blum
Bruce- Regarding... > "... *but it's the AcceptorImpl thread that keeps the JVM from exiting, so I don't really agree that you can create a server with gfsh that doesn't have a CacheServer.*" Well, that is not entirely true, and the last bit is definitely not true. How do you suppose I can do

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread Kirk Lund
It's not the AcceptorImpl thread -- it's actually the main thread in ServerLauncher which keeps the JVM from exiting: "main" #1 prio=5 os_prio=31 tid=0x7ff1f4006800 nid=0x1c03 in Object.wait() [0x7d906000] java.lang.Thread.State: TIMED_WAITING (on object monitor) at

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread John Blum
Damn it! Correction to my previous email... '--disable-default-port' should read '--disable-default-server' in my *Gfsh* `start server` command examples. Apologies, John On Fri, Nov 2, 2018 at 5:41 PM, John Blum wrote: > Bruce- > > Regarding... > > > "... *but it's the AcceptorImpl thread

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread Bruce Schuchardt
Hmm, but it's the AcceptorImpl thread that keeps the JVM from exiting, so I don't really agree that you can create a server with gfsh that doesn't have a CacheServer.  One's got to be created through cache.xml or something. Be that as it may I think the recent talk about this convinces me

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread John Blum
To make this example a bit more concrete for everyone else... gfsh>start server --name=*Server1* --log-level=config Starting a Geode Server in /Users/jblum/pivdev/lab/Server1... Server in /Users/jblum/pivdev/lab/Server1 on 10.99.199.7[*40404*] as Server1 is currently online. Process ID:

Re: [PROPOSAL] --add-opens for Java 11 support

2018-11-02 Thread Dan Smith
I guess I'm ok with documenting the --add-opens workaround in the short term, so that users can start playing with Geode on JDK 11. Maybe we should indicate the JDK 11 support is experimental. I guess in addition to that, we are going to document that users should put Geode on the classpath and

Re: [PROPOSAL] --add-opens for Java 11 support

2018-11-02 Thread Galen O'Sullivan
I did a little more reading, and it sounds like we should create an module-info.java to reserve the proper name for those customers who are using Java 9+. See this article[1] for a description of what can go wrong if people start using the automatic package without us having declared a name. I

Re: Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Jacob Barrett
You can’t restart PR jobs even with access. Concourse will only restart the latest PR, which may not be yours. To restart a PR check you push and empty commit to your branch. -Jake > On Nov 2, 2018, at 10:38 AM, Kirk Lund wrote: > > I want to be able to restart my precheckin jobs.

Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Kirk Lund
I want to be able to restart my precheckin jobs. Specifically, I'd like to restart the UnitTest job on my latest PR precheckin: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/UnitTest/builds/347 It seems to have hit a snag that's unrelated to my PR:

Re: Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Kirk Lund
That's unfortunate, half of the precheckin jobs for my PR started correctly and half of them failed with: /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/response/raise_error.rb:16:in `on_complete': GET https://api.github.com/repos/apache/geode/pulls/2768: 404 - Not Found // See:

Re: [DISCUSS] Cutting 1.8 release branch

2018-11-02 Thread Ryan McMahon
Bill Burcham and I have been working on a data inconsistency issue which involves a lost event across WAN sites during rebalance on the originating site. We are currently performing root cause analysis. Below is a Geode ticket which we will update with more details as we learn more.

Re: [DISCUSS] Cutting 1.8 release branch

2018-11-02 Thread Alexander Murmann
Hi Ryan, I am currently waiting for the failing DUnit tests to pass and then plan to cut the release branch. Does it work for you if the fixes for GEODE-5972 would be merged to the branch after it has been cut? On Fri, Nov 2, 2018 at 9:57 AM Ryan McMahon wrote: > Bill Burcham and I have been

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-11-02 Thread Galen O'Sullivan
I'm with Bill and John on this one. Give the top-level object only and let users move down the object heirarchy. On Thu, Nov 1, 2018 at 9:38 AM John Blum wrote: > Well, ServerLauncher may or may not create a CacheServer instance when it > starts a server. A server can be created without a

Testing tip: Use IgnoredException as an AutoCloseable

2018-11-02 Thread Kirk Lund
The easiest way to use IgnoredException is as an AutoCloseable in a try-with-resource block and by specifying the Exception class: import static org.apache.geode.test.dunit.IgnoredException.addIgnoredException; import org.apache.geode.cache.client.ServerOperationException; @Test public void

Re: Testing tip: Use IgnoredException as an AutoCloseable

2018-11-02 Thread John Blum
With IDE highlighting things as unused, you can either @SuppressWarnings("unused") on the method or statement highlighted or adjust your IDE inspections (perhaps more advisable), which is per project. On Fri, Nov 2, 2018 at 1:27 PM, Kirk Lund wrote: > The easiest way to use IgnoredException is

Re: [PROPOSAL] --add-opens for Java 11 support

2018-11-02 Thread Jinmei Liao
Galen, you are right, --add-opens is necessary for accessing the private fields and methods when doing deep reflection which is used a lot in our serialization code. Let me step back and explain the scope of what we are trying to do here. We all know to be fully java11 compliant, we need to: 1.

Re: [DISCUSS] Cutting 1.8 release branch

2018-11-02 Thread Bruce Schuchardt
Fixes for PRClientServerRegionFunctionExecutionDUnitTest and CreateAsyncEventQueueCommandDUnitTest have been pushed to develop. On 11/2/18 11:05 AM, Alexander Murmann wrote: Hi Ryan, I am currently waiting for the failing DUnit tests to pass and then plan to cut the release branch. Does it

Re: Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Kirk Lund
I just push an empty commit 15 minutes ago to my PR branch and it did not trigger a precheckin. Should I just keep pushing empty commits until something happens? Is there another way to trigger a precheckin? Sorry for all the questions but I seem to be blocked.

Re: Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Jacob Barrett
That should be enough. Let me see what I can do. On Fri, Nov 2, 2018 at 11:13 AM Kirk Lund wrote: > I just push an empty commit 15 minutes ago to my PR branch and it did not > trigger a precheckin. Should I just keep pushing empty commits until > something happens? Is there another way to

Re: Request access to https://concourse.apachegeode-ci.info

2018-11-02 Thread Bruce Schuchardt
I pushed an empty commit not long ago and it took a few minutes for tests to be started On 11/2/18 11:13 AM, Kirk Lund wrote: I just push an empty commit 15 minutes ago to my PR branch and it did not trigger a precheckin. Should I just keep pushing empty commits until something happens? Is