Re: gfsh over http & authentication

2017-02-02 Thread Udo Kohlmeyer
Not sure what the correct polling time would be... But we'd want to avoid the situation where we poll too often. We could launch our own ping-attack. Also, this UX is not UI, so the difference between updating a screen with new information vs checking if the connection is still valid... I'd

Re: JMXMBeanDUnitTest and SSL properties

2017-02-03 Thread Udo Kohlmeyer
When we wrote these tests (many moons ago) we ran into this problem. At that stage we could not establish what that cause of this failure was. BUT we (you and I) noted that behavior and marked it as flaky, in order to make sure it ran and at least tested the functionality. --Udo On 2/3/17

Re: Review Request 55742: [GEODE-2324] and what look like a few other bugs in the same method.

2017-01-31 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55742/#review163664 --- Ship it! Ship It! - Udo Kohlmeyer On Jan. 30, 2017, 7:44

Re: Review Request 56129: GEODE-2368 Need to fix log message in DirectChannel

2017-01-31 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56129/#review163676 --- Ship it! Ship It! - Udo Kohlmeyer On Jan. 31, 2017, 5:03

Re: Nightly build broken

2017-02-07 Thread Udo Kohlmeyer
Looking at some of the failures, it seems it is complaining about not finding diskstores to delete. On 2/7/17 12:53, Kirk Lund wrote: Last night's nightly build is pretty horrible. 121 dunit test failures. Cluster config accounts for 13 of them and we already have a fix for those 13 only.

Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

2017-02-07 Thread Udo Kohlmeyer
stop being so picky... be happy he mentioned you :P On 2/7/17 10:30, Jared Stewart wrote: One more minor edit: "Jared Steward" => “Jared Stewart” On Feb 7, 2017, at 10:27 AM, Anilkumar Gingade wrote: Looks good... -Anil. On Mon, Feb 6, 2017 at 5:38 PM, Dan Smith

Re: Review Request 56242: GEODE-2206: Add junit-quickcheck to geode-core; add a test that uses it.

2017-02-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56242/#review164398 --- Ship it! Ship It! - Udo Kohlmeyer On Feb. 2, 2017, 9:35 p.m

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Udo Kohlmeyer
e except for the temp collection to the sort the fields. - Udo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/#review163741 ----------

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Udo Kohlmeyer
read as two pull requests), but I think it comes > down to the same eventual code in the end. Unless you're seeing something I'm > not? > > Udo Kohlmeyer wrote: > I'm not sure that I'm seeing the autoboxing part that is being referred > to. What I do see is that the ne

Re: Proposal to add new 'export artifacts' GFSH command

2017-01-30 Thread Udo Kohlmeyer
I think stats should always be included by default maybe a '--stats-only' or '--logs-only' flag... On 1/30/17 10:08, Kevin Duling wrote: +1 to the idea of '--include-stats' If --include-stats is offered, there should also be a '--stats-only' flag. That way you can get logs, logs and

Re: Proposal to add new 'export artifacts' GFSH command

2017-01-26 Thread Udo Kohlmeyer
I agree with dan... We need to be able to limit how much data is being collected and sent. In many cases clients don't clean up the files so they might drag a lot of stuff over. On 1/26/17 13:52, Dan Smith wrote: +1 for export artifacts and +1 for zip-file I'm also generally in favor of

Re: To Spring or Not

2017-01-25 Thread Udo Kohlmeyer
/17 10:29, Jacob Barrett wrote: Does JAXB/JAX-RS not provide what yo are looking for to define JSON to Object mapping? On Wed, Jan 25, 2017 at 7:59 AM Udo Kohlmeyer <u...@apache.org> wrote: Hi there, I'm currently working on a proposal on a Data Conversion Service. This service would

Re: Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

2017-02-21 Thread Udo Kohlmeyer
failure, unrelated failure Thanks, Udo Kohlmeyer

Re: for discussion: separate website into its own repo

2017-02-17 Thread Udo Kohlmeyer
+1 for grown up project with multiple repositories. +1 Karen's multiple repos +1 For Dan... On 2/16/17 17:01, Greg Chase wrote: The single repository is from our time as an incubating project. Now we can act like a grown up project  This email encrypted by tiny buttons & fat thumbs, beta

Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

2017-02-17 Thread Udo Kohlmeyer
/test/resources/sample-01.json PRE-CREATION Diff: https://reviews.apache.org/r/56803/diff/ Testing --- pre-checkin = in progress Thanks, Udo Kohlmeyer

Re: Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

2017-02-17 Thread Udo Kohlmeyer
, Udo Kohlmeyer

Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
/test/java/org/apache/geode/redis/StringsJunitTest.java PRE-CREATION gradle/dependency-versions.properties a0b291e55 settings.gradle c0fdb6e4f Diff: https://reviews.apache.org/r/56564/diff/ Testing --- precheckin - running Thanks, Udo Kohlmeyer

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/#review165183 ------- On Feb. 10, 2017, 9:45 p.m., Udo Kohlmeyer wrote: > > --- > This is a

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
settings.gradle c0fdb6e4f Diff: https://reviews.apache.org/r/56564/diff/ Testing --- precheckin - running Thanks, Udo Kohlmeyer

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
--- precheckin - running Thanks, Udo Kohlmeyer

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
settings.gradle c0fdb6e4f Diff: https://reviews.apache.org/r/56564/diff/ Testing --- precheckin - running Thanks, Udo Kohlmeyer

Re: [VOTE] RC2: Apache Geode release - v1.1.0

2017-02-14 Thread Udo Kohlmeyer
+1 CRUD Simple OQL Basic GFSH (start/stop servers, describe regions...) On 2/14/17 05:06, William Markito Oliveira wrote: +1 (binding) Checked build from src Basic gfsh cmds, crud Verified Signatures and hashes. Definitely should fix the incubating references in a subsequent release.

Re: Gradle build for idea

2017-02-14 Thread Udo Kohlmeyer
not need to run gradle command in order to use IDEA. I just imported those modules, and IDEA will sort things out on its own. On Tue, Feb 14, 2017 at 1:20 PM, Udo Kohlmeyer <u...@apache.org> wrote: Hi there, When I run `gradle idea` the following exception is thrown. * What went wrong: Exe

Gradle build for idea

2017-02-14 Thread Udo Kohlmeyer
Hi there, When I run `gradle idea` the following exception is thrown. * What went wrong: Execution failed for task ':geode-core:ideaModule'. > Cannot change dependencies of configuration ':geode-core:antlr' after it has been included in dependency resolution. Is this something that we can

Re: Review Request 56520: GEODE-2460: update dependency versions

2017-02-13 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165350 --- Ship it! Ship It! - Udo Kohlmeyer On Feb. 10, 2017, 11:39

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-13 Thread Udo Kohlmeyer
eviews.apache.org/r/56564/#review165220 ------- On Feb. 10, 2017, 11:22 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail. To re

Re: GeodeRedisAdapter improvments/feedback

2017-02-15 Thread Udo Kohlmeyer
I believe that with delta propagation we could have single collections on a single server, then have a redundant copy on another. I mean the collections would have to be really large to really start warranting distribution across multiple servers. As the perf impact we incur due to network

Re: GeodeRedisAdapter improvments/feedback

2017-02-15 Thread Udo Kohlmeyer
I think we are now straddling into the territory where any distributed storage gains would be negated by the memory we require to make the queries/lookup/operation fast. In addition to the added memory pressure, we still face network latency for every operation. On 2/15/17 15:12, Dan Smith

Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55688/#review162209 --- Ship it! Ship It! - Udo Kohlmeyer On Jan. 18, 2017, 10:58

Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Udo Kohlmeyer
/sockets/ClientServerMiscDUnitTest.java (line 574) <https://reviews.apache.org/r/55688/#comment233459> Would a default constructor not make more sense here? An empty string does indicate that something was supposed to go here. Is it a place holder? - Udo Kohlmeyer On Jan. 18, 2017, 10:

Re: backward-compatibility testing

2017-01-18 Thread Udo Kohlmeyer
+1 Nice work Bruce On 1/18/17 15:11, Bruce Schuchardt wrote: I've extended the distributedTest framework to let us do backward-compatibility testing. Once it is reviewed and committed people will be needed to modify existing tests to run against multiple versions of Geode. Here is the RB

Re: Review Request 55644: GEODE-2277 client cache fails to deserialize a PdxInstance due to InternalGemFireError

2017-01-17 Thread Udo Kohlmeyer
the GatewayReceiverCommand.cmdExecute method... Why would we not have refactored at 700 line long method... made it really hard to follow the flow of the fix. Maybe we need to open a ticket for this refactor. - Udo Kohlmeyer On Jan. 17, 2017, 9:23 p.m., Hitesh Khamesra wrote

Re: Addressing OOM while recovering overflow regions.

2017-01-17 Thread Udo Kohlmeyer
I think that #1 is a good start... I think we should have all regions created before we recover from the files, or at least for the regions that use the diskstore being recovered. When we recover, do we start recovering in reverse? I mean, the latest data *should* be in the last data files,

Re: Native Client Directory Structure

2017-01-16 Thread Udo Kohlmeyer
-1 "geode-native" directory name +1 "geode-client" directory name Maybe the directories for the different clients are by language, so we omit the "geode" prefix i.e geode-client/ c++, net java python If clients are in their own project, then the clients can be

Re: Native Client Directory Structure

2017-01-16 Thread Udo Kohlmeyer
ere been thought to have them in their own repository? Now that we are a TLP, we do have that capability, as seen with the 'geode-examples' repository. --Mark On Mon, Jan 16, 2017 at 10:38 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote:

Re: JIRA versions and multiple repos

2017-01-19 Thread Udo Kohlmeyer
I don't know if I necessarily agree with this "lock-step" simplicity, every repo/project has the same version. That would become WAY too hard to vote on all the time... I can see scenarios where geode-server might add functionality and which clients don't need. Yes, we could version all the

Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-19 Thread Udo Kohlmeyer
/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java 7f510da15 geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java 396eb1d13 Diff: https://reviews.apache.org/r/55736/diff/ Testing --- precheckin - running Thanks, Udo Kohlmeyer

Review Request 55738: GEODE-2329: Refactor JSONFormatter.fromJSON method to reduce duplication

2017-01-19 Thread Udo Kohlmeyer
, Udo Kohlmeyer

Re: Review Request 55738: GEODE-2329: Refactor JSONFormatter.fromJSON method to reduce duplication

2017-01-20 Thread Udo Kohlmeyer
9ee32c913 geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 7fd6cf2c5 Diff: https://reviews.apache.org/r/55738/diff/ Testing --- precheckin - running Thanks, Udo Kohlmeyer

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-20 Thread Udo Kohlmeyer
) --- precheckin - passed Thanks, Udo Kohlmeyer

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-28 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57064/#review167102 --- Ship it! Ship It! - Udo Kohlmeyer On Feb. 28, 2017, 12:03

Re: [DISCUSS] changes to Redis implementation

2017-02-27 Thread Udo Kohlmeyer
I've quickly gone through the changes for the pull request. The most significant change of this pull request is that the collections that initially were regions are single collections (not distributed). That said, this is something that we've been discussing. The one thing that I wonder about

Re: [DISCUSS] changes to Redis implementation

2017-02-27 Thread Udo Kohlmeyer
Feb 27, 2017 at 10:08 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: I've quickly gone through the changes for the pull request. The most significant change of this pull request is that the collections that initially were regions are single collections (not distributed). That said, this

Re: The next release (v1.1.0)

2016-11-23 Thread Udo Kohlmeyer
+1... We all want this project to be the best it can be. On 11/23/16 09:07, Dan Smith wrote: Dor - I don't think any of the active committers are planning on leaving. We're working on this project because we want it to thrive, and graduation is one more thing that will help it grow!

Re: Global scope regions

2016-11-28 Thread Udo Kohlmeyer
I think we need to add --data-policy and --scope to GFSH. --Udo On 11/28/16 15:39, Kirk Lund wrote: Yep, the --type argument in gfsh matches the enum values of org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts for global. On Mon, Nov 28, 2016 at 3:17 PM, Udo

Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting public keys into a NetVie

2016-12-15 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54761/#review159320 --- Ship it! Other than the issue raised, ship it - Udo Kohlmeyer

Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting public keys into a NetVie

2016-12-15 Thread Udo Kohlmeyer
/membership/NetView.java (lines 608 - 610) <https://reviews.apache.org/r/54761/#comment230295> Do we maybe not want to clear the previous entries before putAll? Do we want to keep all previous entries? - Udo Kohlmeyer On Dec. 14, 2016, 10:41 p.m., Bruce Schuchardt

Re: Review Request 54752: GEODE-2213 Deadlock in GMSJoinLeaveJUnitTest

2016-12-15 Thread Udo Kohlmeyer
t.java (line 317) <https://reviews.apache.org/r/54752/#comment230317> I'm questioning the sanity of this test. Realistically this could be a valid address, given they have provided a fully qualified hostname, which should realistically be valid. - Udo Kohlmeyer On Dec. 14, 20

Re: Review Request 54752: GEODE-2213 Deadlock in GMSJoinLeaveJUnitTest

2016-12-15 Thread Udo Kohlmeyer
to be a sane change. - Udo Kohlmeyer On Dec. 14, 2016, 4:41 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Debugging JUnit / DUnit tests

2017-01-13 Thread Udo Kohlmeyer
Have you tried starting the remote with java -agentlib:jdwp=transport=dt_socket,address=127.0.0.1:9001,server=y,suspend=y –jar application.jar and then you should be able to have your Idea connect to it using the "Remote" configuration in your run/debug configurations. Never tried this...

Re: Debugging JUnit / DUnit tests

2017-01-13 Thread Udo Kohlmeyer
=transport=dt_socket,server=y,suspend=y,address=3' On Fri, Jan 13, 2017 at 12:06 PM, John Blum <jb...@pivotal.io> wrote: Yes, this works. I have done this before. Of course, you need to properly coordinate between the debugger and the server starting up. On Fri, Jan 13, 2017 at 11:54 A

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55389/ > --- > > (Updated Jan. 10, 2017, 7:36 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
fore we do variable length. Might be a "nice" improvement. - Udo Kohlmeyer On Jan. 10, 2017, 7:36 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
g/r/55389/#comment232709> Maybe we can have a "getJSONParser(Object input)" method that would return a jsonParser. Then we can merge the two fromJson methods or at least not duplicate the internals. - Udo Kohlmeyer On Jan. 10, 2017, 7:36 p.m.,

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java (line 321) <https://reviews.apache.org/r/55389/#comment232700> Why would this be a static method? - Udo Kohlmeyer On Jan. 10, 2017, 7:36 p.m., Hitesh Khamesra wrote: > >

Review Request 54209: GEODE-1931: CI Failure: LocatorUDPSecurityDUnitTest.testStartTwoLocators

2016-11-30 Thread Udo Kohlmeyer
geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java 3246f85 Diff: https://reviews.apache.org/r/54209/diff/ Testing --- Precheckin - completed Thanks, Udo Kohlmeyer

Re: Review Request 54235: GEODE-2159 add serialVersionUIDs to exception classes not having them

2016-12-01 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54235/#review157623 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 30, 2016, 11:34

User permissions for Galen O'Sullivan

2017-01-05 Thread Udo Kohlmeyer
Hi there, Can someone with the relevant powers and permissions add Galen O'Sullivan as a contributor in Apache Jira? --Udo

Re: IntelliJ builds broken looking for OQLLexerTokenTypes.java

2017-01-05 Thread Udo Kohlmeyer
NOT fix this for me. Question: why should a "./gradlew clean build" from command-line be required to get IntelliJ to work? -Kirk On Tue, Dec 27, 2016 at 1:47 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: I had the same problem. gradle clean build did the trick for me On 12/27

Re: IntelliJ builds broken looking for OQLLexerTokenTypes.java

2017-01-05 Thread Udo Kohlmeyer
to get intellij to automatically run that task that sounds like the way to go. -Dan On Thu, Jan 5, 2017 at 12:47 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: In the newer IntelliJ you can actually have IntelliJ invoke the gradle commands for build/run/build instead of its own in

Re: Server accepts clients before its cache is initialized

2017-01-05 Thread Udo Kohlmeyer
Take this scenario as an example. 1) start server 2) Cache initializes and starts cacheserver 3) run custom code to build up meta structures for custom implementation In this scenario, the cache has initialized and the cacheserver has been started. So clients can start interacting with the

Re: Server accepts clients before its cache is initialized

2017-01-05 Thread Udo Kohlmeyer
server command. On Thu, Jan 5, 2017 at 1:17 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Take this scenario as an example. 1) start server 2) Cache initializes and starts cacheserver 3) run custom code to build up meta structures for custom implementation In this scenario, the cac

Re: Server accepts clients before its cache is initialized

2017-01-05 Thread Udo Kohlmeyer
the embedded services in one or more GemFire/Geode nodes in the cluster. On Thu, Jan 5, 2017 at 1:57 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: +2 On 1/5/17 13:53, Kirk Lund wrote: Ok #3 makes sense then. It's not that the Cache initialization is broken, it's that some peopl

Re: copy files to servers

2017-01-06 Thread Udo Kohlmeyer
In some ways that is a great idea but sometimes too explicit... Do we expect them to have fine grained jars? Also how do we handle dependencies as a single util class might be used by both a cache-listener and a partition listener... is the expectation that we update the dependent util

Re: Off-Heap Annotations

2017-01-03 Thread Udo Kohlmeyer
-Original Message- From: Udo Kohlmeyer [mailto:u...@apache.org] Sent: יום ג 03 ינואר 2017 17:32 To: dev@geode.apache.org Subject: Re: Off-Heap Annotations Hi there Gal, That is not possible. A region is either on-heap or off-heap. --Udo On 1/2/17 13:50, Gal Palmery wrote: Ok, So if I

Re: Off-Heap Annotations

2017-01-03 Thread Udo Kohlmeyer
Hi there Gal, That is not possible. A region is either on-heap or off-heap. --Udo On 1/2/17 13:50, Gal Palmery wrote: Ok, So if I want to have just a certain part of the region off heap and the rest of it on heap - how do I do that? -Original Message- From: Dan Smith

Re: Cluster Config

2017-01-03 Thread Udo Kohlmeyer
+1 I think that the configurations of all locators should be identical, or at least in terms of a few "critical" properties. One would also need to be able to amend some property changes at runtime, to allow for the changing of configuration without taking all the locators offline.

Re: Review Request 55074: GEODE-2253 Locator may fail to respond to a valid request

2017-01-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55074/#review160436 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 28, 2016, 5:15

Re: Review Request 55106: GEODE-1580 ci failure: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock

2017-01-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55106/#review160435 --- Ship it! Ship It! - Udo Kohlmeyer On Jan. 3, 2017, 6:03 p.m

Re: Review Request 55091: GEODE-2257 Client configured to use locator with addPoolServer fails to connect

2016-12-29 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55091/#review160287 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 29, 2016, 11:11

Re: Review Request 55155: GEODE-2155 Auto-reconnect fails with NPE

2017-01-04 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55155/#review160518 --- Ship it! Ship It! - Udo Kohlmeyer On Jan. 3, 2017, 10:55

Review Request 55184: GEODE-1294: Overriding cluster-ssl properties does not work for http-service-ssl

2017-01-04 Thread Udo Kohlmeyer
/internal/net/SSLConfigurationFactoryJUnitTest.java 4f8d5b8a3 Diff: https://reviews.apache.org/r/55184/diff/ Testing --- Thanks, Udo Kohlmeyer

Re: Review Request 55236: GEODE-2271 Reduce pdx type id generation for string fields in JSON

2017-01-06 Thread Udo Kohlmeyer
ine 263) <https://reviews.apache.org/r/55236/#comment231910> Maybe we need a test that confirms that we will only generate 2 type definitions. One where the field exists and one where the field does not exist - Udo Kohlmeyer On Jan. 5, 2017, 11:14 p.m.,

Re: copy files to servers

2017-01-06 Thread Udo Kohlmeyer
I think I can see the benefit of this feature. If you have Geode running in the cloud, it is easier to have a single management tool that can copy resource files to all the servers within the cluster. Although I would not see this a feature I'd promote, as it could really be abused, I

Re: Review Request 54879: GEODE-1893 remove ability to create a locator without all location services

2016-12-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54879/#review159738 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 19, 2016, 11:26

New proposal for type definitons

2016-12-20 Thread Udo Kohlmeyer
Hey there, I've just completed a new proposal on the wiki for a new mechanism that could be used to define a type definition for an object. https://cwiki.apache.org/confluence/display/GEODE/Custom+External+Type+Definition+Proposal+for+JSON Primarily the new type definition proposal will

Re: Review Request 54870: GEODE-2228 FutureResult.get() does not check for cancellation prior to waiting for a result

2016-12-19 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54870/#review159639 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 19, 2016, 7:14

Re: Review Request 54209: GEODE-1931: CI Failure: LocatorUDPSecurityDUnitTest.testStartTwoLocators

2016-12-21 Thread Udo Kohlmeyer
e.org/r/54209/#review157432 --- On Nov. 30, 2016, 5:20 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 54945: GEODE-419: Added test to test fail over to javax properties if ssl enabled but relevant properties are not set

2016-12-21 Thread Udo Kohlmeyer
://reviews.apache.org/r/54945/diff/ Testing --- Added test to test scenario. No code was changed for this. Thanks, Udo Kohlmeyer

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
uld just use that option and pay the extra storage cost. -Dan On Tue, Dec 20, 2016 at 4:53 PM, Udo Kohlmeyer <ukohlme...@gmail.com> wrote: Hey there, I've just completed a new proposal on the wiki for a new mechanism that could be used to define a type definition for an object. https://cw

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
field names from the JSON document so that field order would not generated different pdx types? Also when choosing a pdx field type if we always picked a "wider" type then it would reduce the number of types generated because of different field types. On Thu, Dec 22, 2016 at 10:02 A

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
e of different field types. On Thu, Dec 22, 2016 at 10:02 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Hi there Dan, You are correct, the thought is there to add a flag to the registry to indicate that a definition is custom and thus should not conflict with the existing ids. Even if th

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
pivotal.io wrote: When generating a pdx type for a JSON document couldn't we sort the field names from the JSON document so that field order would not generated different pdx types? Also when choosing a pdx field type if we always picked a "wider" type then it would reduce the number o

Re: New proposal for type definitons

2016-12-28 Thread Udo Kohlmeyer
ed because of different field types. On Thu, Dec 22, 2016 at 10:02 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Hi there Dan, You are correct, the thought is there to add a flag to the registry to indicate that a definition is custom and thus should not conflict with the existing ids. Even if

Re: Review Request 55017: cleaning up code in a few places

2016-12-27 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55017/#review160189 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 23, 2016, 6:10

Re: IntelliJ builds broken looking for OQLLexerTokenTypes.java

2016-12-27 Thread Udo Kohlmeyer
I had the same problem. gradle clean build did the trick for me On 12/27/16 13:45, Bruce Schuchardt wrote: Actually neither refreshing from gradle nor creating a new Intellij project worked. I had to go to the "other" tasks under geode-core in the Gradle window and set

Re: ReflectionBasedAutoSerializer by default?

2017-03-27 Thread Udo Kohlmeyer
+1 I think we should make the default serialization mechanism to be PDX. We should not concern ourselves with Java serialization at all anymore. +1 pdx-read-serialization=true ... I think we should prefer PdxInstance objects over customer POJOs. I think that customers would be ok to run

Re: [gemfire-dev] More detailed Geode Modularization proposal

2017-03-30 Thread Udo Kohlmeyer
r need to interact with each other. But how can this work with Geode modules? On Mar 29, 2017, at 10:00 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Hi there Guys, A more detailed proposal for a more modular Geode is available. Please review and comment, either on this thread or o

More detailed Geode Modularization proposal

2017-03-29 Thread Udo Kohlmeyer
Hi there Guys, A more detailed proposal for a more modular Geode is available. Please review and comment, either on this thread or on confluence. https://cwiki.apache.org/confluence/display/GEODE/Geode+Modularization+-+An+approach Udo

Re: 1.1.0 is done so let's start work on 1.2.0

2017-03-20 Thread Udo Kohlmeyer
Are there any issues that we can think of that we would want to include into 1.2.0? I see no reason to wait. Why not start the process today? --Udo On 3/20/17 15:36, Anthony Baker wrote: Returning to this question: we’ve fixed 119 issues since we released 1.1.0 in February. I’d like to do

Geode Modularization Proposal

2017-03-15 Thread Udo Kohlmeyer
Hi there Guys, The first high-level proposal on Geode modularization has been posted: https://cwiki.apache.org/confluence/display/GEODE/Proposal+for+Geode+Modularization. Please look through this. It is neither a hard or long read BUT it is the precursor to the more detailed proposal. What

Re: Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

2017-04-04 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58158/#review171016 --- Ship it! Ship It! - Udo Kohlmeyer On April 3, 2017, 7:57

Re: Client Commands and SecurityService

2017-04-03 Thread Udo Kohlmeyer
-1 For using singletons Using a Factory pattern you can avoid having to create singletons in addition to caching created commands to avoid the recreation of the instance. The SSLConfigurationFactory is a simple example where you create an instance when required. Once an instance is created,

Re: Client Commands and SecurityService

2017-04-03 Thread Udo Kohlmeyer
to that, the alternative is not that hard to construct and in many cases easier to manage. --Udo On 4/3/17 08:57, Jinmei Liao wrote: Isn't "that instance is reused each invocation" my understanding of a "singleton"? On Mon, Apr 3, 2017 at 11:49 AM, Udo Kohlmeyer <ukohl

Re: Review Request 58155: GEODE-2653: fix a flaky test.

2017-04-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58155/#review171212 --- Ship it! Ship It! - Udo Kohlmeyer On April 5, 2017, 11:44

Re: Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

2017-04-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56586/#review171214 --- Ship it! Ship It! - Udo Kohlmeyer On Feb. 13, 2017, 4:07

Re: Review Request 58187: GEODE-2732 after auto-reconnect a server is restarted on the default port of 40404

2017-04-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58187/#review171213 --- Ship it! Ship It! - Udo Kohlmeyer On April 4, 2017, 8:46

Orphaned Server processes

2017-04-05 Thread Udo Kohlmeyer
Hey there, Current Geode allows a user to start a server without being linked to a Locator. Which in itself is not incorrect, but once started there is no way to connect to that server to manage it. I know that we have taken an opinionated view that member discovery can only now happen

Re: Orphaned Server processes

2017-04-05 Thread Udo Kohlmeyer
cting to the server, I think you can still stop it by specifying --pid or --dir in "stop server" command. On Wed, Apr 5, 2017 at 10:15 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Hey there, Current Geode allows a user to start a server without being linked to a Locator. Whic

Re: Orphaned Server processes

2017-04-05 Thread Udo Kohlmeyer
specifying --pid or --dir in "stop server" command. On Wed, Apr 5, 2017 at 10:15 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: Hey there, Current Geode allows a user to start a server without being linked to a Locator. Which in itself is not incorrect, but once started there is no

  1   2   3   4   >