Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread William Markito
If moving to a feature branch is a better approach, I'm fine as well.. On Thu, Sep 22, 2016 at 3:45 PM, Udo Kohlmeyer wrote: > Correct. Put it on a feature branch awaiting contributions. > > > > On 23/09/2016 8:41 AM, Anthony Baker wrote: > >> By remove, do you mean “put

Re: jvsd

2016-09-22 Thread John Blum
And by Wiki, I mean GitHub's Wiki associated with the (source code) Repository. Between GitHub Wiki and README, README wins every time for reason previously mentioned. On Thu, Sep 22, 2016 at 5:28 PM, John Blum wrote: > Personally, as a engineer, I am more of a fan of the

Re: jvsd

2016-09-22 Thread Joey McAllister
Yeah, I'm with you there. Content for developers should live where developers are most likely to read it, and I don't think the wiki should be in lieu of the READMEs. I'm not a fan of trying to host any sort of documentation geared toward a single audience in more than one place (e.g., a README

Re: jvsd

2016-09-22 Thread Anthony Baker
When the first instruction is `git checkout feature/GEODE-78` I think it’s clear the target audience is not end users. Beyond that, it feels to early to document a feature whose final form may look significantly different than it does today. Anthony > On Sep 22, 2016, at 5:06 PM, Kirk Lund

Re: jvsd

2016-09-22 Thread Kirk Lund
JVSD isn't labeled as Experimental because it isn't even on develop or in part of any Geode release candidate. As far as I know, it exists only on an incomplete and out-of-date feature branch. Hence, my vote is to remove any mention of it from the docs until it merges to develop or at a minimum

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Udo Kohlmeyer
Correct. Put it on a feature branch awaiting contributions. On 23/09/2016 8:41 AM, Anthony Baker wrote: By remove, do you mean “put it on a feature branch awaiting contributions?” hibernate-3.5.5 was released in 2010 and has undergone significant changes since then. Seems reasonable to put

Re: jvsd

2016-09-22 Thread Swapnil Bawaskar
I would vote for including it as an "experimental" feature. On Thu, Sep 22, 2016 at 4:37 PM, Dave Barnes wrote: > Process for handling Experimental docs is still being hammered out. Common > element among working scenarios is isolation from the body of the User > Guide

Re: jvsd

2016-09-22 Thread Kirk Lund
+1 On Thursday, September 22, 2016, Joey McAllister wrote: > If it isn't on develop or planned for release, then I vote for removing it > from the user guide altogether. I like the recommendation to keep this and > similar (non-develop branch) information on the wiki, so

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Dave Barnes
Note: Doc situation is similar to that of JVSD, except there are more docs for Hibernate. On Thu, Sep 22, 2016 at 3:55 PM, William Markito wrote: > If moving to a feature branch is a better approach, I'm fine as well.. > > On Thu, Sep 22, 2016 at 3:45 PM, Udo Kohlmeyer

Re: Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

2016-09-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52179/#review150105 --- Ship it! Ship It! - Dan Smith On Sept. 23, 2016, midnight,

Re: jvsd

2016-09-22 Thread John Blum
Truthfully, I don't think this is any different than API features that have been annotated with "@Experimental" (e.g. LucenceService ). I.e. nothing is going to stop a user from trying

Re: jvsd

2016-09-22 Thread Joey McAllister
If it isn't on develop or planned for release, then I vote for removing it from the user guide altogether. I like the recommendation to keep this and similar (non-develop branch) information on the wiki, so the community can still easily access it. On Thu, Sep 22, 2016 at 4:51 PM Kirk Lund

Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

2016-09-22 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52179/ --- Review request for geode and Dan Smith. Bugs: geode-1894

Re: jvsd

2016-09-22 Thread John Blum
Personally, as a engineer, I am more of a fan of the GitHub README (or even Wiki), rather than a separate site. A lot easier for users to update (submit a PR). On Thu, Sep 22, 2016 at 5:06 PM, Kirk Lund wrote: > +1 > > On Thursday, September 22, 2016, Joey McAllister

Re: jvsd

2016-09-22 Thread John Blum
Who are you "end users"? On Thu, Sep 22, 2016 at 7:37 PM, Anthony Baker wrote: > When the first instruction is `git checkout feature/GEODE-78` I think it’s > clear the target audience is not end users. > > Beyond that, it feels to early to document a feature whose final form

Re: jvsd

2016-09-22 Thread John Blum
+1 *Spring Boot* does this too (in some places, for instance, here [1] and here [2]; and then from the

Hibernate module and Geode 1.0 ?

2016-09-22 Thread William Markito
Folks, We're still building the Hibernate cache module [1] but it's compatible only with a very old version (3.5) and given that the API has completely changed and unless someone in the community wants to help getting this module up-to-date with at least Hibernate 5.x I'd like propose to remove

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Udo Kohlmeyer
+1 to removing until updated to newer version Do we know if anyone in the big-bad world is using it? --Udo On 23/09/2016 8:15 AM, William Markito wrote: Folks, We're still building the Hibernate cache module [1] but it's compatible only with a very old version (3.5) and given that the API

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Anthony Baker
By remove, do you mean “put it on a feature branch awaiting contributions?” hibernate-3.5.5 was released in 2010 and has undergone significant changes since then. Seems reasonable to put this feature on hold until can be brought current. Anthony > On Sep 22, 2016, at 3:31 PM, Udo Kohlmeyer

Re: jvsd

2016-09-22 Thread Dave Barnes
Process for handling Experimental docs is still being hammered out. Common element among working scenarios is isolation from the body of the User Guide proper, so I'll remove the JVSD component from the User Guide's Tools and Modules section. Could go on the Wiki, could go in an appendix. We'll

Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

2016-09-22 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52152/ --- Review request for geode. Repository: geode Description --- - renamed

Re: Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

2016-09-22 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52152/#review150032 --- Ship it! Ship It! - Darrel Schneider On Sept. 22, 2016,

Re: jvsd

2016-09-22 Thread Kirk Lund
I would recommend not mentioning jVSD at all in the Geode 1.0 docs. Right now it's just a Jira ticket and feature branch. I think the docs should only cover what's in Geode 1.0. If there's some doc or wiki page about proposed future features or features currently looking for

Re: Review Request 52067: GEODE-1909: add authorization in GMSAuthenticator

2016-09-22 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52067/#review150034 --- Fix it, then Ship it! One recommendation to consider. Ship It!

Re: jvsd

2016-09-22 Thread Joey McAllister
Bumping this. Any thoughts? On Tue, Sep 20, 2016 at 10:50 AM Dave Barnes wrote: > To what degree should jVSD be mentioned in the docs? The current writeup is > essentially "go get it if you want it, but be warned that it's not fully > baked and we don't support it". > Would

Jenkins build is back to normal : Geode-nightly #600

2016-09-22 Thread Apache Jenkins Server
See

Build failed in Jenkins: Geode-spark-connector #77

2016-09-22 Thread Apache Jenkins Server
See Changes: [hkhamesra] GEODE-1908 DS.connect call not configuring p2p server with SSL. [hkhamesra] GEODE-37 re-merge commit 6a109a7f57a5402af458d593d93c2e328bd3281b [klund] GEODE-1905: Address UnknownPropertyException when

Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

2016-09-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52172/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-1927