Re: Coding practices/standards

I'm having trouble with Spotless. spotlessApply on MS-Windows is changing all of the files it touches to have CRLF line separators. Adding endWithNewline() to the java config in build.gradle doesn't help. If I run geode-core:spotlessApply I end up with over 5000 modified files. Le

[GitHub] incubator-geode pull request #270: GEODE-2014: Upgrade Swagger libraries

GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/270 GEODE-2014: Upgrade Swagger libraries Updated expected jars list after swagger update You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-geode pull request #267: Feature/geode 2015

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode issue #267: Feature/geode 2015

Github user karensmolermiller commented on the issue: https://github.com/apache/incubator-geode/pull/267 +1 on this PR with two minor alterations in the `geode-book/README.md` file: - the markdown is not quite right. Adding appropriate blank lines and indenting the fixed

Re: Review Request 53154: GEODE-2026: fix flaky test

> On Oct. 24, 2016, 4:24 p.m., Scott Jewell wrote: > > Code looks good. > > > > Seems like 30 seconds is one of those things that should normally happen > > very fast, > > but occasionally might be hung up for some reason (i.e. GC), so why not > > wait 200 or something. > > A longer wait max

Re: Review Request 53154: GEODE-2026: fix flaky test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/#review153760 ---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/267 @karensmolermiller I committed a new README.md file with the two changes you suggested. My markdown editors showed the correct formatting before the changes, as well as after the

more spotless problems on Windows

Running geode-core:spotlessCheck complains that all of the .java files have format violations * What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them.

Re: more spotless problems on Windows

The lineEndings setting works great. I've pushed the change to develop On Mon, Oct 24, 2016 at 3:47 PM, Dan Smith wrote: > I think we have a fix for the spotless line ending issue on windows; Bruce > will check it in shortly: > > diff --git a/build.gradle b/build.gradle >

Re: Review Request 53154: GEODE-2026: fix flaky test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/#review153756 --- Ship it! Code looks good. Seems like 30 seconds is one of

Re: more spotless problems on Windows

I think we have a fix for the spotless line ending issue on windows; Bruce will check it in shortly: diff --git a/build.gradle b/build.gradle index a734e05..6e82433 100755 --- a/build.gradle +++ b/build.gradle @@ -88,6 +88,7 @@ subprojects { apply plugin: "com.diffplug.gradle.spotless"

Review Request 53154: GEODE-2026: fix flaky test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/ --- Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken

Re: Coding practices/standards

This is awesome, thank you for taking the time to figure out how to do this smoothly. —Jared > On Oct 24, 2016, at 10:40 AM, Dan Smith wrote: > > Doing a spotlessApply on my feature branch before rebasing didn't help > bring down the number of conflicts. > > I came up with

Re: Coding practices/standards

Doing a spotlessApply on my feature branch before rebasing didn't help bring down the number of conflicts. I came up with this sequence of steps to rebase a feature branch on develop that avoids the need to manually resolve conflicts with the formatting changes. The trick here is to pick up

Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53026/ --- Review request for geode and Dan Smith. Repository: geode Description

Re: Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53026/#review153706 --- Ship it! Ship It! - Dan Smith On Oct. 24, 2016, 4:33 p.m.,

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

> On Oct. 24, 2016, 5:56 p.m., Karen Miller wrote: > > Ship It! Nice addition to the documentation. I also verified that the rat check passes. Note that this patch will merge nicely into the develop branch, but will both be incorrect and cause a conflict in short order when the new paths to

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53107/#review153714 --- Ship it! Ship It! - Karen Miller On Oct. 21, 2016, 10:56

Re: Coding practices/standards

+1 - Nice work. Thx On 24/10/16 10:40 am, Dan Smith wrote: Doing a spotlessApply on my feature branch before rebasing didn't help bring down the number of conflicts. I came up with this sequence of steps to rebase a feature branch on develop that avoids the need to manually resolve conflicts

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53107/#review153718 --- Ship it! Ship It! - Joey McAllister On Oct. 21, 2016, 10:56

[GitHub] incubator-geode issue #269: GEODE-2015: Fix docs paths

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/269 This PR is complete. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [ANNOUNCE] Donation of Geode documentation

I don't see any "search" option with docs? Did we miss it... http://geode.incubator.apache.org/docs/guide/about_geode.html -Anil. On Thu, Sep 29, 2016 at 8:27 PM, Anthony Baker wrote: > I am pleased to announce the donation of Geode documentation to the > Geode community.

Re: [ANNOUNCE] Donation of Geode documentation

Hi Anil, The search functionality on the old version of the docs was a third-party feature held over from GemFire documentation. We'll need to research options that are Apache friendly. Joey On Mon, Oct 24, 2016 at 12:23 PM Anilkumar Gingade wrote: > I don't see any

[GitHub] incubator-geode pull request #269: GEODE-2015: Fix docs paths

Github user joeymcallister closed the pull request at: https://github.com/apache/incubator-geode/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if