Re: Loading groovy as a Jigsaw auto-module

2018-02-22 Thread Jochen Theodorou
Hi, Everything in META-INF/service has to move, unless it is following the SPI structure. But just us moving will not allow Groovy libraries to define extension methods sadly. Am 22.02.2018 um 10:56 schrieb Paul King: After moving the Extensions file, it looks like the only other file in C

Re: Loading groovy as a Jigsaw auto-module

2018-02-22 Thread Paul King
After moving the Extensions file, it looks like the only other file in Cédric's list that causes Java 9's ModuleFinder a problem is Groovy's extension module file: META-INF/services/org.codehaus.groovy.runtime.ExtensionModule I'll also see what is involved in moving that (with a fallback to the cu

Re: Loading groovy as a Jigsaw auto-module

2018-02-14 Thread Jochen Theodorou
Am 14.02.2018 um 03:34 schrieb Paul King: Any objections if I look into moving the Extensions file from META-INF/services to META-INF/groovy (with a fallback to the current one). But not for 2.4.x. in the meantime I know that META-INF/services has been reserved for the normal purposes and ev

Re: Loading groovy as a Jigsaw auto-module

2018-02-13 Thread Paul King
Any objections if I look into moving the Extensions file from META-INF/services to META-INF/groovy (with a fallback to the current one). But not for 2.4.x. Cheers, Paul. On Mon, Dec 4, 2017 at 9:54 PM, Jochen Theodorou wrote: > Normally you specify what a provided service in module is. Thus the

Re: Loading groovy as a Jigsaw auto-module

2017-12-03 Thread Cédric Champeau
If it's only in 2.5, then there's no reason to put automatic module name in 2.5 either, because you wouldn't be able to use it. My understanding is that it only blows up for Extensions because it thinks it's a class name, but it's not. I think the JDK only tries to validate, but doesn't load (which

Re: Loading groovy as a Jigsaw auto-module

2017-12-03 Thread Andres Almiray
Right. My gut feeling tells me META-INF/services should be used as intended, this would mean breaking compatibility by moving existing files that are not service providers, as noted by Cedric. This change should be made in the 3.x branch and beyond IMHO. But it's also true we don't know the exact r

Re: Loading groovy as a Jigsaw auto-module

2017-12-03 Thread Cédric Champeau
So my understanding is that because this file is found in META-INF/services, the JDK interprets its contents as being a service class name provider, which is it not. We have quite a few files in there which are "Groovy services" but nothing related to "Java services": META-INF/services/javax.scrip