Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread Sahil Takiar
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-18 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209742 ---

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Review Request 69078: HIVE-20767

2018-10-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69078/ --- Review request for hive, Ashutosh Chauhan and Vineet Garg. Bugs: HIVE-20767

Re: Review Request 69077: HIVE-20748

2018-10-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69077/ --- (Updated Oct. 19, 2018, 12:17 a.m.) Review request for hive and Ashutosh

Review Request 69077: HIVE-20748 (still pending tests)

2018-10-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69077/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-20748

[jira] [Created] (HIVE-20774) use less calls for GetTables operation

2018-10-18 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-20774: --- Summary: use less calls for GetTables operation Key: HIVE-20774 URL: https://issues.apache.org/jira/browse/HIVE-20774 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-20775) Factor cost of each SJ reduction when costing a follow-up reduction

2018-10-18 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-20775: -- Summary: Factor cost of each SJ reduction when costing a follow-up reduction Key: HIVE-20775 URL: https://issues.apache.org/jira/browse/HIVE-20775

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-18 Thread Vihang Karajgaonkar via Review Board
> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > >

[jira] [Created] (HIVE-20773) Query result cache might contain stale MV data

2018-10-18 Thread Oliver Draese (JIRA)
Oliver Draese created HIVE-20773: Summary: Query result cache might contain stale MV data Key: HIVE-20773 URL: https://issues.apache.org/jira/browse/HIVE-20773 Project: Hive Issue Type: Bug

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

2018-10-18 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review209764 ---

Review Request 69073: HIVE-20772 record per-task CPU counters in LLAP

2018-10-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69073/ --- Review request for hive and Prasanth_J. Repository: hive-git Description

[jira] [Created] (HIVE-20772) record per-task CPU counters in LLAP

2018-10-18 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-20772: --- Summary: record per-task CPU counters in LLAP Key: HIVE-20772 URL: https://issues.apache.org/jira/browse/HIVE-20772 Project: Hive Issue Type: Bug

Re: [ANNOUNCE] New committer: Nishant Bangarwa

2018-10-18 Thread Sankar Hariappan
Congrats Nishant! Best regards Sankar On 15/10/18, 12:45 PM, "Ashutosh Chauhan" wrote: >Apache Hive's Project Management Committee (PMC) has invited Nishant >Bangarwa >to become a committer, and we are pleased to announce that he has accepted. > >Nishant, welcome, thank you for your

Re: [ANNOUNCE] New committer: Nishant Bangarwa

2018-10-18 Thread Lefty Leverenz
Congratulations Nishant! -- Lefty On Mon, Oct 15, 2018 at 3:15 AM Ashutosh Chauhan wrote: > Apache Hive's Project Management Committee (PMC) has invited Nishant > Bangarwa > to become a committer, and we are pleased to announce that he has accepted. > > Nishant, welcome, thank you for your

[jira] [Created] (HIVE-20771) LazyBinarySerDe fails on empty structs.

2018-10-18 Thread Clemens Valiente (JIRA)
Clemens Valiente created HIVE-20771: --- Summary: LazyBinarySerDe fails on empty structs. Key: HIVE-20771 URL: https://issues.apache.org/jira/browse/HIVE-20771 Project: Hive Issue Type: Bug

[GitHub] hive pull request #450: [HIVE-20771] LazyBinarySerDe fails on empty structs.

2018-10-18 Thread cvaliente
GitHub user cvaliente opened a pull request: https://github.com/apache/hive/pull/450 [HIVE-20771] LazyBinarySerDe fails on empty structs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cvaliente/hive HIVE-20771 Alternatively

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 18, 2018, 7:01 a.m.) Review request for hive and Peter Vary.

Question about HMS filter hooks

2018-10-18 Thread Karthik Manamcheri
In HMS, I noticed that all the filter hooks are applied on the client side (in HiveMetaStoreClient.java). Is there any reason why we can't apply the filters on the server-side? Motivation: Some newer apache projects such as Kudu use HMS for metadata storage. Kudu is not

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209735 --- Thanks Laci! 1 serions question 1 mild one and several annoying

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
> On Oct. 18, 2018, 9:13 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1921 (patched) > > > > > > nit: one extra space done. > On Oct. 18, 2018, 9:13 a.m., Peter

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/#review209739 --- Ship it! Ship It! - Antal Sinkovits On okt. 16, 2018, 4:49

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >