Review Request 25412: HIVE-1363: SHOW TABLE EXTENDED LIKE command does not strip single/double quotes

2014-09-05 Thread Chaoyu Tang
or pre-commit test to see if the changes will cause other regression. Thanks, Chaoyu Tang

Re: Review Request 25412: HIVE-1363: SHOW TABLE EXTENDED LIKE command does not strip single/double quotes

2014-09-06 Thread Chaoyu Tang
TABLE EXTENDED IN test_db LIKE `ba*`; 2. six related unit tests are added to show_tables.q and they work as expected 3. submit this patch for pre-commit test to see if the changes will cause other regression. Thanks, Chaoyu Tang

Re: [ANNOUNCE] New PMC Member : Peter Vary

2018-08-01 Thread Chaoyu Tang
Congratulations, Peter. On Wed, Aug 1, 2018 at 2:08 PM, Peter Vary wrote: > Thanks everyone! > > Rajesh Balamohan ezt írta (időpont: 2018. júl. > 31., > Ke 13:41): > > > Congratulations Peter! > > > > ~Rajesh.B > > > > > > On Tue, Jul 31, 2018 at 3:58 PM Marta Kuczora > > > > wrote: > > > > >

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

2018-08-01 Thread Chaoyu Tang
Congratulations Sahil! On Tue, Jul 31, 2018 at 7:40 AM, Rajesh Balamohan wrote: > Congratulations Sahil! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:57 PM Marta Kuczora > > wrote: > > > Congratulations Sahil! > > > > On Mon, Jul 30, 2018 at 9:44 AM Peter Vary > > wrote: > > > > > Congratulat

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

2018-08-01 Thread Chaoyu Tang
Congratulations Vihang. On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan wrote: > Congratulations Vihang! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:35 PM Marta Kuczora > > wrote: > > > Congratulations Vihang! > > > > On Mon, Jul 30, 2018 at 9:44 AM Peter Vary > > wrote: > > > > > Congratu

Re: [ANNOUNCE] New PMC Member : Vineet Garg

2018-08-01 Thread Chaoyu Tang
Congratulations Vineet! On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan < rajesh.balamo...@gmail.com> wrote: > Congratulations Vineet! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:34 PM Marta Kuczora > > wrote: > > > Congratulations Vineet! > > > > On Mon, Jul 30, 2018 at 9:45 AM Peter Vary

Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
testCliDriver_ql_rewrite_gbtoidx is a preexisting one and I think it is not related to this change. Thanks, Chaoyu Tang

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
;queryId:root_20140722084242_98f8d9d7-d110-45c0-8c8b-12da2e5172d9;clientIp:10.20.92.233 --- 2. Precommit tests The test failure testCliDriver_ql_rewrite_gbtoidx is a preexisting one and I think it is not related to this change. Thanks, Chaoyu Tang

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-22 Thread Chaoyu Tang
anything I am missing here. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23820/#review48441 --- On July 23, 2014, 2:27 a.m., Chaoyu Tang wrote: > >

Re: Review Request 23820: HIVE-7445:Improve LOGS for Hive when a query is not able to acquire locks

2014-07-23 Thread Chaoyu Tang
-12da2e5172d9;clientIp:10.20.92.233 --- 2. Precommit tests The test failure testCliDriver_ql_rewrite_gbtoidx is a preexisting one and I think it is not related to this change. Thanks, Chaoyu Tang

Review Request 24284: HIVE-7441:Custom partition scheme gets rewritten with hive scheme upon concatenate

2014-08-04 Thread Chaoyu Tang
fixed the reported issue 2. New added qtests passed 3. Submit the patch and run pre-commit tests to see if there is any regression. Thanks, Chaoyu Tang

Re: Review Request 24284: HIVE-7441:Custom partition scheme gets rewritten with hive scheme upon concatenate

2014-08-05 Thread Chaoyu Tang
://reviews.apache.org/r/24284/diff/ Testing --- 1. Manual tests verified the solution fixed the reported issue 2. New added qtests passed 3. Submit the patch and run pre-commit tests to see if there is any regression. Thanks, Chaoyu Tang

Review Request 24404: HIVE-7635: Query having same aggregate functions but different case throws IndexOutOfBoundsException

2014-08-06 Thread Chaoyu Tang
est/results/clientpositive/having.q.out d912001 Diff: https://reviews.apache.org/r/24404/diff/ Testing --- 1. The fix addressed the failed query with different case in aggregate function name in the query 2. New unit tests passed 3. patch will be submitted for pre-commit tests Thanks, Cha

Re: Review Request 24404: HIVE-7635: Query having same aggregate functions but different case throws IndexOutOfBoundsException

2014-08-07 Thread Chaoyu Tang
out e96342d Diff: https://reviews.apache.org/r/24404/diff/ Testing --- 1. The fix addressed the failed query with different case in aggregate function name in the query 2. New unit tests passed 3. patch will be submitted for pre-commit tests Thanks, Chaoyu Tang

Review Request 27737: HIVE-8784:Querying partition does not work with JDO enabled against PostgreSQL

2014-11-07 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/27737/diff/ Testing --- The test cases provided in this patch have been tested against various DB including Derby, Mysql and PostgreSQL etc. Thanks, Chaoyu Tang

Re: Review Request 27737: HIVE-8784:Querying partition does not work with JDO enabled against PostgreSQL

2014-11-10 Thread Chaoyu Tang
. Thanks, Chaoyu Tang

Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-12 Thread Chaoyu Tang
REATION ql/src/test/results/clientpositive/alter_table_cascade.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27917/diff/ Testing --- 1. qtests alter_table_cascade.q passed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-12 Thread Chaoyu Tang
ssed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-13 Thread Chaoyu Tang
cade.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27917/diff/ Testing --- 1. qtests alter_table_cascade.q passed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-13 Thread Chaoyu Tang
and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-13 Thread Chaoyu Tang
cade.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27917/diff/ Testing --- 1. qtests alter_table_cascade.q passed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-14 Thread Chaoyu Tang
.q PRE-CREATION ql/src/test/results/clientpositive/alter_table_cascade.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27917/diff/ Testing --- 1. qtests alter_table_cascade.q passed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Re: Review Request 27917: HIVE-8839: Support "alter table .. add/replace columns cascade"

2014-11-14 Thread Chaoyu Tang
: https://reviews.apache.org/r/27917/diff/ Testing --- 1. qtests alter_table_cascade.q passed 2. some manual tests with both embedded and remote HMS 3. will submit for pre-commit tests Thanks, Chaoyu Tang

Review Request 28286: HIVE-8863:Cannot drop table with uppercase name after "compute statistics for columns"

2014-11-20 Thread Chaoyu Tang
_with_stats and drop_partition_with_stats passed. submitted the patch for pre-commit tests. Thanks, Chaoyu Tang

Review Request 28403: HIVE-8889:JDBC Driver ResultSet.getXXXXXX(String columnLabel) methods Broken

2014-11-24 Thread Chaoyu Tang
1953e81e52bd7ada7b7ec750205a8e33edfcd9ae Diff: https://reviews.apache.org/r/28403/diff/ Testing --- 1. New test cases in TestJdbcDriver2.java passed 2. pre-committed tests were submitted Thanks, Chaoyu Tang

Review Request 28416: HIVE-4766:Support HS2 client login timeout when the thrift thread max# is reached

2014-11-24 Thread Chaoyu Tang
, Chaoyu Tang

Re: Review Request 28403: HIVE-8889:JDBC Driver ResultSet.getXXXXXX(String columnLabel) methods Broken

2014-11-24 Thread Chaoyu Tang
.java 8cbf9e7092489a2adb0bc2ba6b5ee38e41c041f8 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1953e81e52bd7ada7b7ec750205a8e33edfcd9ae Diff: https://reviews.apache.org/r/28403/diff/ Testing --- 1. New test cases in TestJdbcDriver2.java passed 2. pre-committed tests were submitted Thanks, Chaoyu Tang

Re: Review Request 28403: HIVE-8889:JDBC Driver ResultSet.getXXXXXX(String columnLabel) methods Broken

2014-11-28 Thread Chaoyu Tang
TestJdbcDriver2.java passed 2. pre-committed tests were submitted Thanks, Chaoyu Tang

Review Request 29374: HIVE-9199:Excessive exclusive lock used in some DDLs with DummyTxnManager

2014-12-23 Thread Chaoyu Tang
Diffs - ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java fdf667611cdb68fff0486c9b4287e0c0668ebd06 Diff: https://reviews.apache.org/r/29374/diff/ Testing --- Manually tested in local machine Thanks, Chaoyu Tang

Is the pre-commit build hanging?

2014-12-23 Thread Chaoyu Tang
I wonder if the pre-commit build is hanging at this moment since job #2179 has been running for quite long time. Can any home take a look? Thanks Chaoyu

Re: [ANNOUNCE] New Hive PMC Members - Szehon Ho, Vikram Dixit, Jason Dere, Owen O'Malley and Prasanth Jayachandran

2015-01-29 Thread Chaoyu Tang
Congratulations to everyone. On Thu, Jan 29, 2015 at 10:05 AM, Aihua Xu wrote: > +1. Cong~ everyone! > > On Jan 29, 2015, at 9:43 AM, Philippe Kernévez wrote: > > Congratulations everyone ! > > On Wed, Jan 28, 2015 at 10:15 PM, Carl Steinbach wrote: > >> I am pleased to announce that Szehon Ho

Review Request 31759: HIVE-9620: Cannot retrieve column statistics using HMS API if column name contains uppercase characters

2015-03-04 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/31759/diff/ Testing --- PreCommit tests passed: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2946/testReport Thanks, Chaoyu Tang

Review Request 31825: HIVE-9877:Beeline cannot run multiple statements in the same row

2015-03-06 Thread Chaoyu Tang
databases; #show tables; #do not show databases; #do not have the ; at the end of following cmd show databases {code} Thanks, Chaoyu Tang

Review Request 31978: HIE-9720: Metastore does not properly migrate column stats when renaming a table across databases

2015-03-12 Thread Chaoyu Tang
that the invalid column stats has been cleaned after alter table ..., alter table ... cascade, alter table partition ..., with sqldirect and ORM. 2. new qtest alter_table_invalidate_column_stats.q was added and the patch has been submitted to kick off precommitted build Thanks, Chaoyu Tang

Re: Review Request 31978: HIVE-9720: Metastore does not properly migrate column stats when renaming a table across databases

2015-03-12 Thread Chaoyu Tang
table ... cascade, alter table partition ..., with sqldirect and ORM. 2. new qtest alter_table_invalidate_column_stats.q was added and the patch has been submitted to kick off precommitted build Thanks, Chaoyu Tang

Re: Review Request 31978: HIVE-9720: Metastore does not properly migrate column stats when renaming a table across databases

2015-03-12 Thread Chaoyu Tang
- Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31978/#review76227 --- On March 12, 2015, 10:55 a.m., Chaoyu T

Re: Review Request 31978: HIVE-9720: Metastore does not properly migrate column stats when renaming a table across databases

2015-03-12 Thread Chaoyu Tang
was added and the patch has been submitted to kick off precommitted build Thanks, Chaoyu Tang

Review Request 32190: HIVE-9975:Renaming a nonexisting partition should not throw out NullPointerException

2015-03-17 Thread Chaoyu Tang
ntnegative/alter_rename_partition_failure.q be971f18498693491d0699f7793a39e21b1ed684 ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out f1640be1d2728d971517afdfc4f36efe1e5bb508 Diff: https://reviews.apache.org/r/32190/diff/ Testing --- 1. Manaully tests passed 2. Precommit tests Thank

Review Request 32254: HIVE-10007:Support qualified table name in analyze table compute statistics for columns

2015-03-19 Thread Chaoyu Tang
l/src/test/results/clientpositive/columnstats_tbllvl.q.out 0ef04f5f4b70d84cd6118c2407d29fc555bac116 Diff: https://reviews.apache.org/r/32254/diff/ Testing --- 1. Performed some manullay tests 2. Added new qtests for those cases 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 32254: HIVE-10007:Support qualified table name in analyze table compute statistics for columns

2015-03-19 Thread Chaoyu Tang
753a7d44a4 Diff: https://reviews.apache.org/r/32254/diff/ Testing --- 1. Performed some manullay tests 2. Added new qtests for those cases 3. Precommit build Thanks, Chaoyu Tang

Re: [ANNOUNCE] New Hive Committers - Jimmy Xiang, Matt McCline, and Sergio Pena

2015-03-23 Thread Chaoyu Tang
Congratulations to Jimmy and Sergio! On Mon, Mar 23, 2015 at 2:08 PM, Carl Steinbach wrote: > The Apache Hive PMC has voted to make Jimmy Xiang, Matt McCline, and > Sergio Pena committers on the Apache Hive Project. > > Please join me in congratulating Jimmy, Matt, and Sergio. > > Thanks. > > -

Review Request 32435: HIVE-10027:Use descriptions from Avro schema files in column comments

2015-03-24 Thread Chaoyu Tang
Testing --- 1. Manaul tests all passed 2. New qfile test avro_comments passed 3. Precommit build tests passed Thanks, Chaoyu Tang

Re: Review Request 32435: HIVE-10027:Use descriptions from Avro schema files in column comments

2015-03-26 Thread Chaoyu Tang
/avro/AvroSerDe.java 8ba0692c0a24b876f6087d90aceb744d1dcd94be Diff: https://reviews.apache.org/r/32435/diff/ Testing --- 1. Manaul tests all passed 2. New qfile test avro_comments passed 3. Precommit build tests passed Thanks, Chaoyu Tang

Review Request 32908: HIVE-10231: Compute partition column stats fails if partition col type is date

2015-04-06 Thread Chaoyu Tang
ql/src/test/results/clientpositive/columnstats_part_coltype.q.out PRE-CREATION Diff: https://reviews.apache.org/r/32908/diff/ Testing --- Local manually tests passed A new qfile test columnstats_part_coltype.q passed submitted to prebuild testing. Thanks, Chaoyu Tang

Re: Review Request 32908: HIVE-10231: Compute partition column stats fails if partition col type is date

2015-04-06 Thread Chaoyu Tang
sting --- Local manually tests passed A new qfile test columnstats_part_coltype.q passed submitted to prebuild testing. Thanks, Chaoyu Tang

Review Request 33128: HIVE-10313:Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

2015-04-13 Thread Chaoyu Tang
ql/src/test/results/clientpositive/literal_decimal.q.out b2a23cf Diff: https://reviews.apache.org/r/33128/diff/ Testing --- Manually tests kick off precommit build tests Thanks, Chaoyu Tang

Re: Review Request 33128: HIVE-10313:Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

2015-04-13 Thread Chaoyu Tang
ut b22d00c Diff: https://reviews.apache.org/r/33128/diff/ Testing --- Manually tests kick off precommit build tests Thanks, Chaoyu Tang

Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-14 Thread Chaoyu Tang
33171/diff/ Testing (updated) --- 1. Manaully tests covering various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-15 Thread Chaoyu Tang
ut bc6ab10 ql/src/test/results/clientpositive/partition_timestamp2.q.out 365df69 Diff: https://reviews.apache.org/r/33171/diff/ Testing --- 1. Manaully tests covering various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33128: HIVE-10313:Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

2015-04-15 Thread Chaoyu Tang
, visit: https://reviews.apache.org/r/33128/#review80273 ------- On April 13, 2015, 4:51 p.m., Chaoyu Tang wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 33128: HIVE-10313:Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

2015-04-15 Thread Chaoyu Tang
> On April 15, 2015, 10:26 p.m., Jimmy Xiang wrote: > > ql/src/test/results/clientpositive/literal_decimal.q.out, line 17 > > <https://reviews.apache.org/r/33128/diff/2/?file=925443#file925443line17> > > > > Why does the output changed to null? > >

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-16 Thread Chaoyu Tang
st/results/clientpositive/partition_timestamp2.q.out 365df69 Diff: https://reviews.apache.org/r/33171/diff/ Testing --- 1. Manaully tests covering various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-16 Thread Chaoyu Tang
ab10 ql/src/test/results/clientpositive/partition_timestamp2.q.out 365df69 Diff: https://reviews.apache.org/r/33171/diff/ Testing --- 1. Manaully tests covering various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-17 Thread Chaoyu Tang
s 2000-01-01 01:00:00.0 (add 0 for the nano). so we have to modify the output file. If the initial test was written as: insert overwrite table partition_timestamp_1 partition(dt=timestamp '2000-01-01 01:00:00', region= '1') select * from src tablesample (10 rows); w

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-17 Thread Chaoyu Tang
ecking? Does this mean we can't use the default > > partition name for none dynamic partition? > > Chaoyu Tang wrote: > No, that is basically to allow the default partition (from dynamic > partition) automatically skip the type check. Currently the default partition &

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-17 Thread Chaoyu Tang
d Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-27 Thread Chaoyu Tang
sults/clientpositive/partition_timestamp.q.out bc6ab10 ql/src/test/results/clientpositive/partition_timestamp2.q.out 365df69 Diff: https://reviews.apache.org/r/33171/diff/ Testing --- 1. Manaully tests covering various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-27 Thread Chaoyu Tang
various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-27 Thread Chaoyu Tang
various number literals (Y, S, L, BD) 2. new qfile test (partition_coltype_literals.q) 3. Precommit build Thanks, Chaoyu Tang

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

2015-04-27 Thread Chaoyu Tang
tch. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review81727 --- On April 27, 2015, 9:13 p.m., Chaoyu Tang wrote: > > -

Re: [ANNOUNCE] New Hive Committer - Alex Pivovarov

2015-04-29 Thread Chaoyu Tang
Congratulations, Alex. On Wed, Apr 29, 2015 at 3:37 PM, Jason Dere wrote: > Congrats Alex! > > On Apr 29, 2015, at 12:35 PM, Chao Sun > wrote: > > > Congrats Alex! Well done! > > > > On Wed, Apr 29, 2015 at 12:32 PM, Prasanth Jayachandran < > > pjayachand...@hortonworks.com> wrote: > > > >> Co

Precommit builds failed

2015-05-02 Thread Chaoyu Tang
see following errors from build console: === Started by remote host 0:0:0:0:0:0:0:1 Building in workspace /var/lib/jenkins/jobs/PreCommit-HIVE-TRUNK-Build/workspace > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url h

Re: Invitation for Hive committers to become ORC committers

2016-12-15 Thread Chaoyu Tang
I am interested in. Thanks Chaoyu On Thu, Dec 15, 2016 at 5:13 PM, Rajesh Balamohan wrote: > I would be interested. Thanks. > > ~Rajesh.B > > On Fri, Dec 16, 2016 at 3:31 AM, Mithun Radhakrishnan < > mithun.radhakrish...@yahoo.com.invalid> wrote: > > > I'd be keen. > > Thanks,Mithun > > On Thur

Re: Review Request 55479: Improve canceling response time for acquiring locks

2017-01-12 Thread Chaoyu Tang
9/#comment232768> as I commented before, the DriverState class might provide this method for inspecting this state, which looks better. - Chaoyu Tang On Jan. 12, 2017, 11:21 p.m., Yongzhi Chen wrote: > > --- > This is a

Re: Review Request 55479: Improve canceling response time for acquiring locks

2017-01-13 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55479/#review161552 --- Ship it! Ship It! - Chaoyu Tang On Jan. 13, 2017, 5:14 p.m

Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-19 Thread Chaoyu Tang
-CREATION Diff: https://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-20 Thread Chaoyu Tang
atch after testing. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55731/#review162357 --- On Jan. 19, 2017, 10:29 p.m., Chaoyu Tan

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
it is not necessary to have/call hasStatsInParameters function. > > Chaoyu Tang wrote: > Thanks PengCheng for reviewing the patch. I looked through the code > related to this STATS status and feel a little confusing, here are some > questions I need help from you. To my underst

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-24 Thread Chaoyu Tang
unt and raw_data_size? If so, is there any use of numFiles/totalSize? - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55731/#review162771 -------

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-24 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

2017-01-27 Thread Chaoyu Tang
doop/hive/ql/TestMetaStoreLimitPartitionRequest.java (line 230) <https://reviews.apache.org/r/55498/#comment234716> HMS filter might support the IN clause, but not the LIKE in query predicate. - Chaoyu Tang On Jan. 13, 2017, 3:26 p.m., M

Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section

2017-01-27 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55932/#review163284 --- Ship it! LGTM. +1 - Chaoyu Tang On Jan. 25, 2017, 3:03 p.m

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-31 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163784 --- Ship it! LGTM, +1 - Chaoyu Tang On Jan. 30, 2017, 8:48 p.m

Review Request 56970: HIVE-16019: Query fails when group by/order by on same column with uppercase name

2017-02-22 Thread Chaoyu Tang
/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2430811 ql/src/test/queries/clientpositive/order3.q PRE-CREATION ql/src/test/results/clientpositive/order3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/56970/diff/ Testing --- new qtests. Thanks, Chaoyu Tang

Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
/1/ Testing --- Thanks, Chaoyu Tang

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/57566/diff/2/ Changes: https://reviews.apache.org/r/57566/diff/1-2/ Testing --- Thanks, Chaoyu Tang

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/57566/diff/3/ Changes: https://reviews.apache.org/r/57566/diff/2-3/ Testing --- Thanks, Chaoyu Tang

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-14 Thread Chaoyu Tang
://reviews.apache.org/r/57566/diff/3-4/ Testing --- Thanks, Chaoyu Tang

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

2017-03-15 Thread Chaoyu Tang
Congratulations Eugene! On Wed, Mar 15, 2017 at 11:52 AM, Jimmy Xiang wrote: > Congrats!! > > On Wed, Mar 15, 2017 at 7:31 AM, Sergio Pena > wrote: > > Congratulations Eugene !! > > > > On Wed, Mar 15, 2017 at 5:41 AM, Prasanth Jayachandran < > > pjayachand...@hortonworks.com> wrote: > > > >> C

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-15 Thread Chaoyu Tang
he 2nd transaction to revert the DB changes is no more needed. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57566/#review169037

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-15 Thread Chaoyu Tang
#x27;s location to an existing one, its column and table > > stats disappeared. This is expected as we are now using the new location. > > Could u be talk more about how to reproduce the problem? Thanks. > > Chaoyu Tang wrote: > Hi, PengCheng, thanks for reviewing the patch. The cu

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

2017-04-01 Thread Chaoyu Tang
> On Jan. 27, 2017, 4:22 p.m., Chaoyu Tang wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java > > Lines 193 (patched) > > <https://reviews.apache.org/r/55498/diff/2/?file=1604754#file1604754line193> > > &g

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-06 Thread Chaoyu Tang
ead of Integer.MAX_VALUE? - Chaoyu Tang On April 6, 2017, 6:04 a.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-06 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58086/#review171222 --- Ship it! Ship It! - Chaoyu Tang On April 6, 2017, 4:12 p.m

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-19 Thread Chaoyu Tang
- > > (Updated April 14, 2017, 1:14 p.m.) > > > Review request for hive, Aihua Xu, Chaoyu Tang, and Sergio Pena. > > > Bugs: HIVE-16426 > https://issues.apache.org/jira/browse/HIVE-16426 > > > Repository: hive-git > > > Description

Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-24 Thread Chaoyu Tang
/src/test/results/clientpositive/alter_table_column_stats.q.out PRE-CREATION ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out 85d7dc4 Diff: https://reviews.apache.org/r/58686/diff/1/ Testing --- manual tests qtests Thanks, Chaoyu Tang

Re: ptest not running?

2017-04-26 Thread Chaoyu Tang
It looks the ptest is still having the problem. Either submitting patch in JIRA or manual build could not trigger the tests. On Tue, Apr 25, 2017 at 11:31 PM, Eugene Koifman wrote: > I see HIVE-16445 in it – it was picked up automatically > > On 4/25/17, 5:44 PM, "Vihang Karajgaonkar" wrote: >

Re: Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-28 Thread Chaoyu Tang
, Chaoyu Tang

Re: Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-28 Thread Chaoyu Tang
ply, visit: https://reviews.apache.org/r/58686/#review173359 --- On April 28, 2017, 6:19 p.m., Chaoyu Tang wrote: > > --- > This is an automatically ge

Review Request 58992: HIVE-16572: Rename a partition should not drop its column stats

2017-05-04 Thread Chaoyu Tang
/ Testing --- Manual tests new qtests Thanks, Chaoyu Tang

Re: Welcome new Hive committer, Zhihai Xu

2017-05-07 Thread Chaoyu Tang
Congrats Zhihai!! Chaoyu On Sun, May 7, 2017 at 8:58 AM, Rui Li wrote: > Congrats Zhihai :) > > On Sun, May 7, 2017 at 3:41 PM, Lefty Leverenz > wrote: > > > Congratulations Zhihai! > > > > -- Lefty > > > > > > On Sat, May 6, 2017 at 2:06 AM, Zoltan Haindrich < > > zhaindr...@hortonworks.com >

Re: Review Request 58992: HIVE-16572: Rename a partition should not drop its column stats

2017-05-08 Thread Chaoyu Tang
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58992/#review174165 ------- On May 4, 2017, 2:19 p.m., Chaoyu Tang wrote: > > -

Re: [Announce] New committer: Vineet Garg

2017-05-09 Thread Chaoyu Tang
Congratulations Vineet! On Tue, May 9, 2017 at 6:34 PM, Vaibhav Gumashta wrote: > Congrats Vineet. > > ‹Vaibhav > > On 5/9/17, 1:54 PM, "Deepak Jaiswal" wrote: > > >Congratulations Vineet! > > > >On 5/9/17, 1:51 PM, "Jimmy Xiang" wrote: > > > >Congrats!! > > > >On Tue, May 9, 2017 at 1

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-01 Thread Chaoyu Tang
+1. A nice move which might help HMS to be more easily adopted by more other components. On Sat, Jul 1, 2017 at 12:41 AM, Sushanth Sowmyan wrote: > +1 > > On Jun 30, 2017 17:05, "Owen O'Malley" wrote: > > > On Fri, Jun 30, 2017 at 3:26 PM, Chao Sun wrote: > > > > > and maybe a different projec

Re: [Announce] New committer: Deepesh Khandelwal

2017-07-07 Thread Chaoyu Tang
Congratulations Deepesh! On Fri, Jul 7, 2017 at 4:07 PM, Peter Vary wrote: > Congratulations Deepesh! > > > On Jul 7, 2017, at 8:38 PM, Sergio Pena > wrote: > > > > Congratulations Deepesh !!! > > > > On Wed, Jul 5, 2017 at 7:48 PM, Ashutosh Chauhan > > wrote: > > > >> The Project Management C

Re: [Announce] New committer: Peter Vary

2017-07-07 Thread Chaoyu Tang
Congratulations Peter! On Fri, Jul 7, 2017 at 3:29 PM, Jimmy Xiang wrote: > Congrats!! > > On Fri, Jul 7, 2017 at 11:38 AM, Sergio Pena > wrote: > > Congrats Peter !! > > > > On Fri, Jul 7, 2017 at 12:51 PM, Vaibhav Gumashta < > vgumas...@hortonworks.com > >> wrote: > > > >> Congratulations Pet

Re: [Announce] New committer: Sahil Takiar

2017-07-07 Thread Chaoyu Tang
Congratulations Sahil !!! On Fri, Jul 7, 2017 at 2:38 PM, Sergio Pena wrote: > Congratulations Sahil !!! > > On Wed, Jul 5, 2017 at 7:49 PM, Ashutosh Chauhan > wrote: > > > The Project Management Committee (PMC) for Apache Hive has invited Sahil > > Takiar to become a committer and we are pleas

Re: [Announce] New committer: Teddy Choi

2017-07-07 Thread Chaoyu Tang
Congratulations Teddy! On Fri, Jul 7, 2017 at 4:07 PM, Peter Vary wrote: > Congratulatins Teddy! > > > On Jul 7, 2017, at 9:28 PM, Jimmy Xiang wrote: > > > > Congrats!! > > > > On Fri, Jul 7, 2017 at 11:37 AM, Sergio Pena > wrote: > >> Congratulations Teddy! > >> > >> On Fri, Jul 7, 2017 at 12

  1   2   3   4   5   >