Review Request 68590: HIVE-20493: Unit test getGroupNames for SessionStateUserAuthenticator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68590/ --- Review request for hive, Alexander Kolbasov and Daniel Dai. Repository:

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209313 ---

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209742 ---

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > >

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/ --- (Updated Jan. 2, 2019, 8:32 p.m.) Review request for hive, Adam Holley, Na Li,

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/ --- (Updated Jan. 2, 2019, 8:15 p.m.) Review request for hive, Adam Holley, Na Li,

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211612 ---

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211698 ---

Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/ --- Review request for hive, Adam Holley, Morio Ramdenbourg, and Naveen Gangam.

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211625 ---

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/ --- (Updated Jan. 3, 2019, 1:40 a.m.) Review request for hive, Adam Holley, Na Li,

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/ --- (Updated Jan. 23, 2019, 10:34 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211260 ---

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 220-221 (patched) > > > > > > These two

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211318 --- Ship it! Ship It! - Karthik Manamcheri On Dec. 14, 2018,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 14, 2018, 2:58 a.m., Karthik Manamcheri wrote: > > Ship It! LGTM! Make sure you get someone else to review it as well. Thanks. - Karthik --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211129 ---

Re: Review Request 69664: HIVE-21077 : Database should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > 1. While we are at it, can we make sure that the "create time" exists for everything else (if required)? Such as catalog, partitions.. 2. Out of curiosity.. are there any tests to ensure that the upgrade path works? What if we miss

Re: Review Request 69664: HIVE-21077 : Database should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/#review211677 ---

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

> On Jan. 3, 2019, 6 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4549-4555 (original), 4560-4569 (patched) > > > > > >

Re: Review Request 69664: HIVE-21077 : Database should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > > > Karthik Manamcheri wrote: > 1. While we are at it, can we make sure that the "create time" exists for > everything else (if required)? Such as catalog, partitions.. > 2. Out of curiosity.. are there any tests to ensure

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211846 ---

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

> On Jan. 9, 2019, 11:56 p.m., Yongzhi Chen wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > > Line 228 (original), 227 (patched) > > > >

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

> On Jan. 9, 2019, 11:56 p.m., Yongzhi Chen wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > > Lines 101 (patched) > > > > > >

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

> On Jan. 3, 2019, 1:42 a.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 374 (patched) > > > > > > The

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211436 ---

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212295 ---

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/#review213843 --- Ship it! LGTM. get someone else a little more familiar with

Re: Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69914/#review212633 ---

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/#review212336 --- Ship it! Ship It! - Karthik Manamcheri On Jan. 15, 2019,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212335 ---