Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-04 Thread Stefan Fritsch
On Saturday 04 February 2012, Gregg Smith wrote: This fixes the crash, thanks. Thanks. Committed to trunk and 2.4

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-04 Thread Jim Jagielski
FanTAStic!!! On Feb 4, 2012, at 5:11 AM, Stefan Fritsch wrote: On Saturday 04 February 2012, Gregg Smith wrote: This fixes the crash, thanks. Thanks. Committed to trunk and 2.4

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-03 Thread Stefan Fritsch
On Thursday 02 February 2012, William A. Rowe Jr. wrote: On 2/2/2012 8:36 AM, Jim Jagielski wrote: bb == NULL ?? Looking at his attached screen scrape; no. Which leaves with something like e == NULL or a broken bb. The former :-( Gregg, please add this or try the attached patch which is

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-03 Thread Stefan Fritsch
On Thursday 02 February 2012, Joe Orton wrote: The combination of APR_SUCCESS and DECLINED is unusual; an int return value with OK/DECLINED? Input and output filters should return an apr_status_t. So, if the hook does not return an apr_status_t, core_input_filter() would have to invent some

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-03 Thread Gregg Smith
On 2/3/2012 10:43 AM, Stefan Fritsch wrote: On Thursday 02 February 2012, William A. Rowe Jr. wrote: On 2/2/2012 8:36 AM, Jim Jagielski wrote: bb == NULL ?? Looking at his attached screen scrape; no. Which leaves with something like e == NULL or a broken bb. The former :-( Gregg, please

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-02 Thread Jim Jagielski
bb == NULL ?? On Feb 2, 2012, at 3:40 AM, Gregg Smith wrote: Stefan, On 2/1/2012 12:44 PM, Stefan Fritsch wrote: Try removing the static: --- a/server/mpm/winnt/child.c +++ b/server/mpm/winnt/child.c @@ -736,9 +736,9 @@ static winnt_conn_ctx_t *winnt_get_connection(winnt_conn_ctx_t

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-02 Thread William A. Rowe Jr.
On 2/2/2012 8:36 AM, Jim Jagielski wrote: bb == NULL ?? Looking at his attached screen scrape; no. Which leaves with something like e == NULL or a broken bb.

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-02 Thread Joe Orton
On Sun, Jan 29, 2012 at 08:53:09PM +0100, Stefan Fritsch wrote: + * Insert the network bucket into the core input filter's input brigade. + * This hook is intended for MPMs or protocol modules that need to do special + * socket setup. + * @param c The connection + * @param bb The brigade to

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-01 Thread Rainer Jung
On 31.01.2012 22:30, Stefan Fritsch wrote: On Tuesday 31 January 2012, Gregg Smith wrote: On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-01 Thread Gregg Smith
On 1/31/2012 1:30 PM, Stefan Fritsch wrote: On Tuesday 31 January 2012, Gregg Smith wrote: On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive

Re: [PATCH] trunk/2.4 core output filter is broken

2012-02-01 Thread Stefan Fritsch
On Wednesday 01 February 2012, Gregg Smith wrote: Getting closer Linking... Creating library .\Release/libhttpd.lib and object .\Release/libhttpd.exp mpm_winnt.obj : error LNK2019: unresolved external symbol _winnt_insert_network_bucket referenced in function _winnt_hooks I don't

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-31 Thread Gregg Smith
On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid, aren't we?) OK, patch is attached. This needs

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-31 Thread Rainer Jung
Hi Stefan, On 29.01.2012 20:53, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid, aren't we?) OK, patch is attached.

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-31 Thread Stefan Fritsch
On Tuesday 31 January 2012, Gregg Smith wrote: On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Jim Jagielski
Anyone with Windows willing to sign up to review/test? On Jan 29, 2012, at 2:53 PM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Jim Jagielski
On Jan 29, 2012, at 2:53 PM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid, aren't we?) OK, patch is attached.

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Stefan Fritsch
On Mon, 30 Jan 2012, Jim Jagielski wrote: On Jan 29, 2012, at 2:53 PM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Daniel Ruggeri
On 1/30/2012 7:51 AM, Jim Jagielski wrote: Anyone with Windows willing to sign up to review/test? I don't have a build environment to create something based on the diff, but if someone can create a build , I'll happily do the testing. -- Daniel Ruggeri

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Rainer Jung
On 31.01.2012 00:36, Daniel Ruggeri wrote: On 1/30/2012 7:51 AM, Jim Jagielski wrote: Anyone with Windows willing to sign up to review/test? I don't have a build environment to create something based on the diff, but if someone can create a build , I'll happily do the testing. What's you

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Daniel Ruggeri
On 1/31/2012 12:01 AM, Rainer Jung wrote: What's you runtime env then (Win version and 32 or 64 Bits)? Rainer I have at my immediate disposal Server 2003 32-bit as well as Win7 and Server 2008 64-bit. I may be able to scrounge up some more exotic configurations if needed. My earlier tests to

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Gregg Smith
On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid, aren't we?) OK, patch is attached. This needs

Re: [PATCH] trunk/2.4 core output filter is broken

2012-01-30 Thread Gregg Smith
On 1/30/2012 11:14 PM, Gregg Smith wrote: On 1/29/2012 11:53 AM, Stefan Fritsch wrote: On Wednesday 25 January 2012, Jim Jagielski wrote: Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid,