[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option

2016-02-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2323 Change subject: Comment out replica_preference query option .. Comment out replica_preference query option Change-Id: I5a3134b874a53241706

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3019: Fix unnecessary resets of iterator

2016-02-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2330 Change subject: IMPALA-3019: Fix unnecessary resets of iterator .. IMPALA-3019: Fix unnecessary resets of iterator In order to perform rou

[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option

2016-02-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Comment out replica_preference query option .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2323/2/fe/src/main/java/com/cloudera/impala/analysis/T

[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option

2016-02-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: Comment out replica_preference query option .. Comment out replica_preference query option Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee --- M be/src/scheduli

[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option

2016-02-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: Remove replica_preference query option .. Remove replica_preference query option Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee --- M be/src/scheduling/simple-

[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option

2016-02-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Remove replica_preference query option .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2323/3/common/thrift/ImpalaInternalService.thrift File com

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3019: Fix unnecessary resets of iterator

2016-02-27 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Silvius Rus, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2330 to look at the new patch set (#2). Change subject: IMPALA-3019: Fix unnecessary resets of iterator

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3019: Fix unnecessary resets of iterator

2016-02-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3019: Fix unnecessary resets of iterator .. Patch Set 2: Code-Review+2 Rebased, +2 from Silvius. -- To view, visit http://gerrit.cloudera.org:8080/2330 To

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-TODO: Fix detection of is_cached, is_remote

2016-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2412 Change subject: IMPALA-TODO: Fix detection of is_cached, is_remote .. IMPALA-TODO: Fix detection of is_cached, is_remote The scheduler inc

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3122: Fix detection of is_cached, is_remote

2016-03-02 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Silvius Rus, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2412 to look at the new patch set (#2). Change subject: IMPALA-3122: Fix detection of is_cached, is_remote .

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3122: Fix detection of is_cached, is_remote

2016-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3122: Fix detection of is_cached, is_remote .. Patch Set 2: Code-Review+2 Included Jira number in commit message. +2 from Marcel and Silvius (gatekeeper).

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-03-14 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#15). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-03-14 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#16). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-03-18 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#17). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1661: Netezza compatibility functions: strings

2016-04-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1661: Netezza compatibility functions: strings .. Patch Set 4: Hi Zuo, have you had time to address Sailesh's comments? Let me know if you need help with m

[Impala-CR](cdh5-trunk) Fix typo in load-test-warehouse-snapshot.sh

2016-04-06 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2310 to look at the new patch set (#2). Change subject: Fix typo in load-test-warehouse-snapshot.sh .. Fix typo in load-tes

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#3). Change subject: Add -release switch to buildall.sh help. .. Add -re

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#4). Change subject: Add -release switch to buildall.sh help. .. Add -re

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#5). Change subject: Add -release switch to buildall.sh help, change coverage options. .

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.

2016-04-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add -release switch to buildall.sh help, change coverage options. .. Patch Set 5: Hi Alex, I added the changes we had discussed at the time. I kept the old -code

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next_day date/time UDF

2016-04-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/1943/2/be/src/exprs/expr-test.cc File be/src/exprs

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons .. PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash hand

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 3: (9 comments) Thanks Casey for the review. Can you have another look? http://gerrit

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-11 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#18). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 17: (6 comments) Thanks for the review, please see PS 18. http://gerrit.cloudera.org:8080/#/c/2

[Impala-CR](cdh5-trunk) Fix typo in load-test-warehouse-snapshot.sh

2016-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Fix typo in load-test-warehouse-snapshot.sh .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2310 To unsubscribe, visit http://gerr

[Impala-CR](cdh5-trunk) Fix typo in load-test-warehouse-snapshot.sh

2016-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Fix typo in load-test-warehouse-snapshot.sh .. Patch Set 2: +2 from Alex. -- To view, visit http://gerrit.cloudera.org:8080/2310 To unsubscribe, visit http://ger

[Impala-CR](cdh5-trunk) Fix typo in load-test-warehouse-snapshot.sh

2016-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Fix typo in load-test-warehouse-snapshot.sh .. Patch Set 3: Code-Review+2 +2 from Alex -- To view, visit http://gerrit.cloudera.org:8080/2310 To unsubscribe, vis

[Impala-CR](cdh5-trunk) Fix typo in load-test-warehouse-snapshot.sh

2016-04-11 Thread Lars Volker (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2310 to look at the new patch set (#3). Change subject: Fix typo in load-test-warehouse-snapshot.sh .. Fi

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.

2016-04-11 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#6). Change subject: Add -release switch to buildall.sh help, change coverage options. .

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.

2016-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add -release switch to buildall.sh help, change coverage options. .. Patch Set 5: (5 comments) Sorry, I forgot to hit reply. http://gerrit.cloudera.org:8080/#/c

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-12 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#19). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 18: (8 comments) Thanks for the review, please see PS19. http://gerrit.cloudera.org:8080/#/c/21

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons .. PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash hand

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix parsing of userinfo component in urls

2016-04-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2777 Change subject: IMPALA-1920: Fix parsing of userinfo component in urls .. IMPALA-1920: Fix parsing of userinfo component in urls IMPALA-11

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. IMPALA-1920: Fix userinfo and authority parsing. IMPALA-1170 fixed parsing of host parts in urls under the presen

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons .. PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash hand

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 5: (7 comments) Thanks for the review. Please see PS6. http://gerrit.cloudera.org:808

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2788 Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPALA-3327: Disable metric validation for backend clients A

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPALA-3327: Disable metric validation for backend clients After decoupling the startup of senders and

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPALA-3327: Disable metric validation for backend clients After decoupling the startup of senders and

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash handling support to

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#8). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash handling support to

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/8/be/src/common/init.cc File be/src/co

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 6: (4 comments) Thanks for the comments. Please see PS8. I talked to Casey about writing tests

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next_day date/time UDF

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/1943/3/be/src/exprs/expr-test.cc File be/src/exprs/

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-15 Thread Lars Volker (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2788 to look at the new patch set (#4). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPAL

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3327: Disable metric validation for backend clients .. Patch Set 3: (1 comment) Thanks for the quick review. Please see PS4. http://gerrit.cloudera.org:80

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next_day date/time UDF

2016-04-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1943/4/be/src/exprs/timestamp-functions.cc File be/s

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. Patch Set 2: (4 comments) Thanks for the review, please have a look at PS3. http://gerrit.cloudera.org:8080/#

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. IMPALA-1920: Fix userinfo and authority parsing. IMPALA-1170 fixed parsing of host parts in urls under the presen

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next_day date/time UDF

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://ge

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#9). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash handling support to

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2777 to look at the new patch set (#4). Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. IMPALA-1920: Fi

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. Patch Set 4: Thanks for the review. -- To view, visit http://gerrit.cloudera.org:8080/2777 To unsubscribe, vi

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. Patch Set 3: (1 comment) Thanks for the review. http://gerrit.cloudera.org:8080/#/c/2777/3/be/src/util/url-pa

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. Patch Set 4: Code-Review+2 +2 from Dan. -- To view, visit http://gerrit.cloudera.org:8080/2777 To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3327: Disable metric validation for backend clients .. Patch Set 4: (3 comments) Thanks for the review. I uploaded PS5. http://gerrit.cloudera.org:8080/#/

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-18 Thread Lars Volker (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2788 to look at the new patch set (#6). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPAL

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-19 Thread Lars Volker (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2788 to look at the new patch set (#7). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPAL

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-19 Thread Lars Volker (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2777 to look at the new patch set (#5). Change subject: IMPALA-1920: Fix userinfo and authority parsing. .

[Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.

2016-04-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. .. Patch Set 5: Code-Review+2 +2 from Dan. -- To view, visit http://gerrit.cloudera.org:8080/2777 To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-19 Thread Lars Volker (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2788 to look at the new patch set (#8). Change subject: IMPALA-3327: Disable metric validation for backend clients .. IMPAL

[Impala-CR](cdh5-trunk) IMPALA-3327: Disable metric validation for backend clients

2016-04-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3327: Disable metric validation for backend clients .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2788/4/tests/verifiers/metric_verifier.

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-24 Thread Lars Volker (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#20). Change subject: IMPALA-1740: Add support for skip.header.line.count. ..

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 19: (3 comments) Thanks for the comments, see PS 20. http://gerrit.cloudera.org:8080/#/c/2110/1

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/2110/18/fe/src/main/java/com/cloudera/impala

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-24 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#10). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash handling support to

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 9: (12 comments) Thanks for the review. Please see PS10. http://gerrit.cloudera.org:8080/#/c/

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-25 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#21). Change subject: IMPALA-1740: Add support for skip.header.line.count. .

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 21: Code-Review+2 Rebased, +2 from Marcel. -- To view, visit http://gerrit.cloudera.org:8080/21

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: It hit the same error again, I started another GVM: http://sandbox.jenkins.cloudera.c

[Impala-CR](cdh5-trunk) IMPALA-3426: Replace usage of OptimizeFunctionWithExprs

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2870 Change subject: IMPALA-3426: Replace usage of OptimizeFunctionWithExprs .. IMPALA-3426: Replace usage of OptimizeFunctionWithExprs A GVM r

[Impala-CR](cdh5-trunk) IMPALA-3426: Replace usage of OptimizeFunctionWithExprs

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3426: Replace usage of OptimizeFunctionWithExprs .. Patch Set 1: Who would need to approve that? -- To view, visit http://gerrit.cloudera.org:8080/2870 To

[Impala-CR](cdh5-trunk) IMPALA-3426: Replace usage of OptimizeFunctionWithExprs

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. Change subject: IMPALA-3426: Replace usage of OptimizeFunctionWithExprs .. IMPALA-3426: Replace usage of OptimizeFunctionWithExprs A GVM race between two changes reintrod

[Impala-CR](cdh5-trunk) IMPALA-3426: Replace usage of OptimizeFunctionWithExprs

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3426: Replace usage of OptimizeFunctionWithExprs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2870 To unsubscribe, visit ht

[Impala-CR](cdh5-trunk) IMPALA-3426: Replace usage of OptimizeFunctionWithExprs

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3426: Replace usage of OptimizeFunctionWithExprs .. Patch Set 2: I think we're good without a force push. -- To view, visit http://gerrit.cloudera.org:808

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: Yup, seems like I GVM'd something older. :( -- To view, visit http://gerrit.cloudera

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-27 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2028 to look at the new patch set (#11). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. IMPA

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.p

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 10: (1 comment) Thanks for the review. See PS11. http://gerrit.cloudera.org:8080/#/c/2028/10/

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 11: Casey, do you have time for a final round before I look for someone to +2 it? Thanks. --

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.p

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-27 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#22). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 21: -Code-Review Marcel, as discussed I changed this to prevent https://issues.apache.org/jira/b

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-27 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#23). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 21: See PS23 for the test. -- To view, visit http://gerrit.cloudera.org:8080/2110 To unsubscrib

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-27 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#24). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 24: (3 comments) Thanks for the review. http://gerrit.cloudera.org:8080/#/c/2110/24/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#27). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#28). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 28: Code-Review+2 +2 from Marcel -- To view, visit http://gerrit.cloudera.org:8080/2110 To unsu

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 11: Marcel, Dan, does either of you have time for a final round? -- To view, visit http://ger

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2110 to look at the new patch set (#29). Change subject: IMPALA-1740: Add support for skip.header.line.count. ...

[Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.

2016-04-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. .. Patch Set 29: Code-Review+2 +2 from Marcel -- To view, visit http://gerrit.cloudera.org:8080/2110 To unsu

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-29 Thread Lars Volker (Code Review)
Hello Casey Ching, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2028 to look at the new patch set (#12). Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ...

[Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons

2016-04-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons .. Patch Set 12: Thanks for the review, please see PS12. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-CR](cdh5-trunk) IMPALA-3463: Disable test with inserts on S3

2016-05-01 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2917 Change subject: IMPALA-3463: Disable test with inserts on S3 .. IMPALA-3463: Disable test with inserts on S3 Change-Id: Ied30fe5e0027fe505

[Impala-CR](cdh5-trunk) IMPALA-3458: Fix table creation to test insert with header lines

2016-05-01 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/2919 Change subject: IMPALA-3458: Fix table creation to test insert with header lines .. IMPALA-3458: Fix table creation to test insert with hea

[Impala-CR](cdh5-trunk) IMPALA-3458: Fix table creation to test insert with header lines

2016-05-01 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-3458: Fix table creation to test insert with header lines .. IMPALA-3458: Fix table creation to test insert with header lines For IMPALA-1740 we added a test

  1   2   3   4   >