Re: Release JMeter 3.2 ?

2017-01-16 Thread Philippe Mouawad
Hi,
Thanks.
Notice that for InfluxDB, I changed the annotations to events so that it's
easier for beginners to create the correct dashboard (example use this).
So it may break your existing dashboard on this part.

Thanks
Regards

On Mon, Jan 16, 2017 at 10:55 PM, Maxime Chassagneux <
maxime.chassagn...@gmail.com> wrote:

> Hi Philippe,
>
> I will deploy your nightly build in our permit to operate service tomorrow.
> It's the best way to test it :)
> Let me some days and come back to you quickly.
>
> Thanks.
>
> 2017-01-16 21:57 GMT+01:00 Philippe Mouawad :
>
> > Hello Maxime,
> > I merged some of your PR.
> > Did you have the opportunity to make tests of nightly build ?
> >
> > Your feedback is welcome.
> > Thanks
> > Regards
> >
> > On Fri, Jan 13, 2017 at 10:35 AM, Maxime Chassagneux <
> > maxime.chassagn...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > Pls, could you consider to merge this PR too :
> > >
> > >  - PR-241 : Support variable for all JMS messages (bytes, object, ...)
> > and
> > > sources (file, folder)
> > >  - PR-240 : Improves JMS component robustness
> > >
> > > Thanks .
> > >
> > > 2017-01-12 21:02 GMT+01:00 Philippe Mouawad <
> philippe.moua...@gmail.com
> > >:
> > >
> > > > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > > > felix.schumac...@internetallee.de> wrote:
> > > >
> > > > > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> > > > >
> > > > >> Hello,
> > > > >> What do you think of releasing a 3.2 version ?
> > > > >>
> > > > > I think I said before, that I would like to release often :)
> > > > >
> > > > >>
> > > > >> I see following reasons:
> > > > >>
> > > > >> - There is a regression (See bug 60575)
> > > > >>
> > > > > My fix for 60575 needs tests and review as it changes the contract
> of
> > > the
> > > > > method getSendParameterValuesAsPostBody.
> > > > >
> > > > I reviewed it , it looks ok to me.
> > > > I'll double check.
> > > >
> > > > >
> > > > > It returned true if there were no parameters (and thus none with a
> > > name).
> > > > > (Or if getPostBodyRaw() is true)
> > > > >
> > > > > After the change it returns only true when there are parameters and
> > > none
> > > > > of those have a name. (Or if getPostBodyRaw() is true).
> > > > >
> > > >
> > > >
> > > >
> > > > >
> > > > > This method is used in POST and PUT as well, but I believe the
> change
> > > to
> > > > > be correct in both places. too.
> > > > >
> > > > > - We have 9 enhancements and 12  Bug fixes
> > > > >> - Some nice features (at least as a current user I find them
> > > > >> interesting
> > > > >> :-) ):
> > > > >>- More space in UI and simpler look
> > > > >>- Up to date Browser based on javafx
> > > > >>
> > > > > We might have to warn a bit more about the need for javafx (The
> > default
> > > > > java for SUSE Leap42.2 seems to have no javafx). Without javafx
> > JMeter
> > > > will
> > > > > start, but the results tree view is missing.
> > > > >
> > > >
> > > > I think in this case we should try to fail in a bit cleaner way
> > > >
> > > > >- Or in response assertion
> > > > >>- Replace feature (partial)+ counting
> > > > >>
> > > > >> Maybe we can integrate before next release:
> > > > >>
> > > > >> - PR-247
> > > > >> - PR-246
> > > > >> - PR-245
> > > > >> - PR-237
> > > > >>
> > > > >> And upgrade some dependencies:
> > > > >>
> > > > >> - jodd which has a lot of perf enhancements that we use in
> > JMeter
> > > > (for
> > > > >> resources extractions)
> > > > >> - httpcomponents
> > > > >> - maybe more
> > > > >>
> > > > > I would like to link  the converted pdf tutorials and maybe do a
> bit
> > of
> > > > > minor tweaks to the look and feel of the web pages (less shadows).
> > > > >
> > > > > Should the sect-num number of the tutorials be continued from those
> > in
> > > > the
> > > > > usermanual section?
> > > > >
> > > >
> > > > I think so.
> > > >
> > > >
> > > > >> Besides, we did a lot of code changes related to sonar, let's
> > release
> > > > it.
> > > > >>
> > > > >> A last good thing is that we start to release more often.
> > > > >>
> > > > > +1
> > > > >
> > > > > Felix
> > > > >
> > > > >>
> > > > >>
> > > > >
> > > >
> > > >
> > > > --
> > > > Cordialement.
> > > > Philippe Mouawad.
> > > >
> > >
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>



-- 
Cordialement.
Philippe Mouawad.


Re: Release JMeter 3.2 ?

2017-01-16 Thread Antonio Gomes Rodrigues
About G1, do you have a test case to check it and try to improve tuning?

Antonio

2017-01-16 22:31 GMT+01:00 Philippe Mouawad :

> On Mon, Jan 16, 2017 at 4:33 PM, Antonio Gomes Rodrigues  >
> wrote:
>
> > Hi,
> >
> > One more thing
> >
> > Release 3.2 will need Java 8. Is it the moment to switch to Nashorn
> Engine
> > by default?
> >
> +1 for me but we need to make it clear wherever Javascript is used:
>
>- IfController
>- __javascript function
>- properties reference
>- jmeter.properties
>- changes.xml as Incompatible change
>
>
>
> > Someone have made test with GC G1 to switch to it with the right
> parameter
> > in 3.2 release?
> >
> I've commited some changes and refreshed some old links and code.
> If anybody masters G1 , let him improve tuning.
>
> I didn't test on windows so if somebody can test everything is ok.
>
>
> >
> > Thank
> > Antonio
> >
> > 2017-01-16 10:13 GMT+01:00 Antonio Gomes Rodrigues :
> >
> > > Hi Philippe,
> > >
> > > Thanks to your job
> > >
> > > 2017-01-15 23:20 GMT+01:00 Philippe Mouawad <
> philippe.moua...@gmail.com
> > >:
> > >
> > >> On Thu, Jan 12, 2017 at 9:02 PM, Philippe Mouawad <
> > >> philippe.moua...@gmail.com> wrote:
> > >>
> > >> >
> > >> >
> > >> > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > >> > felix.schumac...@internetallee.de> wrote:
> > >> >
> > >> >> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> > >> >>
> > >> >>> Hello,
> > >> >>> What do you think of releasing a 3.2 version ?
> > >> >>>
> > >> >> I think I said before, that I would like to release often :)
> > >> >>
> > >> >>>
> > >> >>> I see following reasons:
> > >> >>>
> > >> >>> - There is a regression (See bug 60575)
> > >> >>>
> > >> >> My fix for 60575 needs tests and review as it changes the contract
> of
> > >> the
> > >> >> method getSendParameterValuesAsPostBody.
> > >> >>
> > >> > I reviewed it , it looks ok to me.
> > >> > I'll double check.
> > >> >
> > >> >>
> > >> >> It returned true if there were no parameters (and thus none with a
> > >> name).
> > >> >> (Or if getPostBodyRaw() is true)
> > >> >>
> > >> >> After the change it returns only true when there are parameters and
> > >> none
> > >> >> of those have a name. (Or if getPostBodyRaw() is true).
> > >> >>
> > >> >
> > >> >
> > >> >
> > >> >>
> > >> >> This method is used in POST and PUT as well, but I believe the
> change
> > >> to
> > >> >> be correct in both places. too.
> > >> >>
> > >> >> - We have 9 enhancements and 12  Bug fixes
> > >> >>> - Some nice features (at least as a current user I find them
> > >> >>> interesting
> > >> >>> :-) ):
> > >> >>>- More space in UI and simpler look
> > >> >>>- Up to date Browser based on javafx
> > >> >>>
> > >> >> We might have to warn a bit more about the need for javafx (The
> > default
> > >> >> java for SUSE Leap42.2 seems to have no javafx). Without javafx
> > JMeter
> > >> will
> > >> >> start, but the results tree view is missing.
> > >> >>
> > >> >
> > >> > I think in this case we should try to fail in a bit cleaner way
> > >> >
> > >>
> > >> Done through bug  60583
> > >> Still, not fully satisfied with solution as we catch a
> > >> NoClassDefFoundError
> > >> (I'll send a mail on this)
> > >>
> > >>
> > >>
> > >>- Or in response assertion
> > >> >>>- Replace feature (partial)+ counting
> > >> >>>
> > >> >>> Maybe we can integrate before next release:
> > >> >>>
> > >> >>> - PR-247
> > >> >>>
> > >> >>
> > >> If somebody can take it into account. I'm pausing for now.
> > >>
> > >>
> > >>
> > >> > - PR-246
> > >> >>>
> > >> >> Done with some changes.
> > >> We can improve in the future by:
> > >>
> > >>- Using HttpComponents HttpAsyncClient
> > >>- Make some properties configurable
> > >>
> > >>
> > >> - PR-245
> > >> >>>
> > >> >> Done with some changes
> > >>
> > >> > - PR-237
> > >> >>>
> > >> >> Done
> > >>
> > >> >
> > >> >>> And upgrade some dependencies:
> > >> >>>
> > >> >>> - jodd which has a lot of perf enhancements that we use in
> > JMeter
> > >> >>> (for
> > >> >>> resources extractions)
> > >> >>> - httpcomponents
> > >> >>> - maybe more
> > >> >>>
> > >> >> Done
> > >>
> > >> I'd also like to commit :
> > >>
> > >>- https://bz.apache.org/bugzilla/show_bug.cgi?id=60514
> > >>
> > >>
> > >> I would like to link  the converted pdf tutorials and maybe do a bit
> of
> > >> >> minor tweaks to the look and feel of the web pages (less shadows).
> > >> >>
> > >> >> Should the sect-num number of the tutorials be continued from those
> > in
> > >> >> the usermanual section?
> > >> >>
> > >> >
> > >> > I think so.
> > >> >
> > >> >
> > >> >>> Besides, we did a lot of code changes related to sonar, let's
> > release
> > >> it.
> > >> >>>
> > >> >>> A last good thing is that we start to release more often.
> > >> >>>
> > >> >> +1
> > >> >>
> > >> >> Felix
> > >> >>
> > >> >>>
> > >> >>>
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > Cordialement.
>

Re: Release JMeter 3.2 ?

2017-01-16 Thread Maxime Chassagneux
Hi Philippe,

I will deploy your nightly build in our permit to operate service tomorrow.
It's the best way to test it :)
Let me some days and come back to you quickly.

Thanks.

2017-01-16 21:57 GMT+01:00 Philippe Mouawad :

> Hello Maxime,
> I merged some of your PR.
> Did you have the opportunity to make tests of nightly build ?
>
> Your feedback is welcome.
> Thanks
> Regards
>
> On Fri, Jan 13, 2017 at 10:35 AM, Maxime Chassagneux <
> maxime.chassagn...@gmail.com> wrote:
>
> > Hi,
> >
> > Pls, could you consider to merge this PR too :
> >
> >  - PR-241 : Support variable for all JMS messages (bytes, object, ...)
> and
> > sources (file, folder)
> >  - PR-240 : Improves JMS component robustness
> >
> > Thanks .
> >
> > 2017-01-12 21:02 GMT+01:00 Philippe Mouawad  >:
> >
> > > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > > felix.schumac...@internetallee.de> wrote:
> > >
> > > > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> > > >
> > > >> Hello,
> > > >> What do you think of releasing a 3.2 version ?
> > > >>
> > > > I think I said before, that I would like to release often :)
> > > >
> > > >>
> > > >> I see following reasons:
> > > >>
> > > >> - There is a regression (See bug 60575)
> > > >>
> > > > My fix for 60575 needs tests and review as it changes the contract of
> > the
> > > > method getSendParameterValuesAsPostBody.
> > > >
> > > I reviewed it , it looks ok to me.
> > > I'll double check.
> > >
> > > >
> > > > It returned true if there were no parameters (and thus none with a
> > name).
> > > > (Or if getPostBodyRaw() is true)
> > > >
> > > > After the change it returns only true when there are parameters and
> > none
> > > > of those have a name. (Or if getPostBodyRaw() is true).
> > > >
> > >
> > >
> > >
> > > >
> > > > This method is used in POST and PUT as well, but I believe the change
> > to
> > > > be correct in both places. too.
> > > >
> > > > - We have 9 enhancements and 12  Bug fixes
> > > >> - Some nice features (at least as a current user I find them
> > > >> interesting
> > > >> :-) ):
> > > >>- More space in UI and simpler look
> > > >>- Up to date Browser based on javafx
> > > >>
> > > > We might have to warn a bit more about the need for javafx (The
> default
> > > > java for SUSE Leap42.2 seems to have no javafx). Without javafx
> JMeter
> > > will
> > > > start, but the results tree view is missing.
> > > >
> > >
> > > I think in this case we should try to fail in a bit cleaner way
> > >
> > > >- Or in response assertion
> > > >>- Replace feature (partial)+ counting
> > > >>
> > > >> Maybe we can integrate before next release:
> > > >>
> > > >> - PR-247
> > > >> - PR-246
> > > >> - PR-245
> > > >> - PR-237
> > > >>
> > > >> And upgrade some dependencies:
> > > >>
> > > >> - jodd which has a lot of perf enhancements that we use in
> JMeter
> > > (for
> > > >> resources extractions)
> > > >> - httpcomponents
> > > >> - maybe more
> > > >>
> > > > I would like to link  the converted pdf tutorials and maybe do a bit
> of
> > > > minor tweaks to the look and feel of the web pages (less shadows).
> > > >
> > > > Should the sect-num number of the tutorials be continued from those
> in
> > > the
> > > > usermanual section?
> > > >
> > >
> > > I think so.
> > >
> > >
> > > >> Besides, we did a lot of code changes related to sonar, let's
> release
> > > it.
> > > >>
> > > >> A last good thing is that we start to release more often.
> > > >>
> > > > +1
> > > >
> > > > Felix
> > > >
> > > >>
> > > >>
> > > >
> > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Release JMeter 3.2 ?

2017-01-16 Thread Philippe Mouawad
On Mon, Jan 16, 2017 at 4:33 PM, Antonio Gomes Rodrigues 
wrote:

> Hi,
>
> One more thing
>
> Release 3.2 will need Java 8. Is it the moment to switch to Nashorn Engine
> by default?
>
+1 for me but we need to make it clear wherever Javascript is used:

   - IfController
   - __javascript function
   - properties reference
   - jmeter.properties
   - changes.xml as Incompatible change



> Someone have made test with GC G1 to switch to it with the right parameter
> in 3.2 release?
>
I've commited some changes and refreshed some old links and code.
If anybody masters G1 , let him improve tuning.

I didn't test on windows so if somebody can test everything is ok.


>
> Thank
> Antonio
>
> 2017-01-16 10:13 GMT+01:00 Antonio Gomes Rodrigues :
>
> > Hi Philippe,
> >
> > Thanks to your job
> >
> > 2017-01-15 23:20 GMT+01:00 Philippe Mouawad  >:
> >
> >> On Thu, Jan 12, 2017 at 9:02 PM, Philippe Mouawad <
> >> philippe.moua...@gmail.com> wrote:
> >>
> >> >
> >> >
> >> > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> >> > felix.schumac...@internetallee.de> wrote:
> >> >
> >> >> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> >> >>
> >> >>> Hello,
> >> >>> What do you think of releasing a 3.2 version ?
> >> >>>
> >> >> I think I said before, that I would like to release often :)
> >> >>
> >> >>>
> >> >>> I see following reasons:
> >> >>>
> >> >>> - There is a regression (See bug 60575)
> >> >>>
> >> >> My fix for 60575 needs tests and review as it changes the contract of
> >> the
> >> >> method getSendParameterValuesAsPostBody.
> >> >>
> >> > I reviewed it , it looks ok to me.
> >> > I'll double check.
> >> >
> >> >>
> >> >> It returned true if there were no parameters (and thus none with a
> >> name).
> >> >> (Or if getPostBodyRaw() is true)
> >> >>
> >> >> After the change it returns only true when there are parameters and
> >> none
> >> >> of those have a name. (Or if getPostBodyRaw() is true).
> >> >>
> >> >
> >> >
> >> >
> >> >>
> >> >> This method is used in POST and PUT as well, but I believe the change
> >> to
> >> >> be correct in both places. too.
> >> >>
> >> >> - We have 9 enhancements and 12  Bug fixes
> >> >>> - Some nice features (at least as a current user I find them
> >> >>> interesting
> >> >>> :-) ):
> >> >>>- More space in UI and simpler look
> >> >>>- Up to date Browser based on javafx
> >> >>>
> >> >> We might have to warn a bit more about the need for javafx (The
> default
> >> >> java for SUSE Leap42.2 seems to have no javafx). Without javafx
> JMeter
> >> will
> >> >> start, but the results tree view is missing.
> >> >>
> >> >
> >> > I think in this case we should try to fail in a bit cleaner way
> >> >
> >>
> >> Done through bug  60583
> >> Still, not fully satisfied with solution as we catch a
> >> NoClassDefFoundError
> >> (I'll send a mail on this)
> >>
> >>
> >>
> >>- Or in response assertion
> >> >>>- Replace feature (partial)+ counting
> >> >>>
> >> >>> Maybe we can integrate before next release:
> >> >>>
> >> >>> - PR-247
> >> >>>
> >> >>
> >> If somebody can take it into account. I'm pausing for now.
> >>
> >>
> >>
> >> > - PR-246
> >> >>>
> >> >> Done with some changes.
> >> We can improve in the future by:
> >>
> >>- Using HttpComponents HttpAsyncClient
> >>- Make some properties configurable
> >>
> >>
> >> - PR-245
> >> >>>
> >> >> Done with some changes
> >>
> >> > - PR-237
> >> >>>
> >> >> Done
> >>
> >> >
> >> >>> And upgrade some dependencies:
> >> >>>
> >> >>> - jodd which has a lot of perf enhancements that we use in
> JMeter
> >> >>> (for
> >> >>> resources extractions)
> >> >>> - httpcomponents
> >> >>> - maybe more
> >> >>>
> >> >> Done
> >>
> >> I'd also like to commit :
> >>
> >>- https://bz.apache.org/bugzilla/show_bug.cgi?id=60514
> >>
> >>
> >> I would like to link  the converted pdf tutorials and maybe do a bit of
> >> >> minor tweaks to the look and feel of the web pages (less shadows).
> >> >>
> >> >> Should the sect-num number of the tutorials be continued from those
> in
> >> >> the usermanual section?
> >> >>
> >> >
> >> > I think so.
> >> >
> >> >
> >> >>> Besides, we did a lot of code changes related to sonar, let's
> release
> >> it.
> >> >>>
> >> >>> A last good thing is that we start to release more often.
> >> >>>
> >> >> +1
> >> >>
> >> >> Felix
> >> >>
> >> >>>
> >> >>>
> >> >>
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >> >
> >> >
> >> >
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >>
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.


Re: Release JMeter 3.2 ?

2017-01-16 Thread Philippe Mouawad
Hello Maxime,
I merged some of your PR.
Did you have the opportunity to make tests of nightly build ?

Your feedback is welcome.
Thanks
Regards

On Fri, Jan 13, 2017 at 10:35 AM, Maxime Chassagneux <
maxime.chassagn...@gmail.com> wrote:

> Hi,
>
> Pls, could you consider to merge this PR too :
>
>  - PR-241 : Support variable for all JMS messages (bytes, object, ...) and
> sources (file, folder)
>  - PR-240 : Improves JMS component robustness
>
> Thanks .
>
> 2017-01-12 21:02 GMT+01:00 Philippe Mouawad :
>
> > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > felix.schumac...@internetallee.de> wrote:
> >
> > > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> > >
> > >> Hello,
> > >> What do you think of releasing a 3.2 version ?
> > >>
> > > I think I said before, that I would like to release often :)
> > >
> > >>
> > >> I see following reasons:
> > >>
> > >> - There is a regression (See bug 60575)
> > >>
> > > My fix for 60575 needs tests and review as it changes the contract of
> the
> > > method getSendParameterValuesAsPostBody.
> > >
> > I reviewed it , it looks ok to me.
> > I'll double check.
> >
> > >
> > > It returned true if there were no parameters (and thus none with a
> name).
> > > (Or if getPostBodyRaw() is true)
> > >
> > > After the change it returns only true when there are parameters and
> none
> > > of those have a name. (Or if getPostBodyRaw() is true).
> > >
> >
> >
> >
> > >
> > > This method is used in POST and PUT as well, but I believe the change
> to
> > > be correct in both places. too.
> > >
> > > - We have 9 enhancements and 12  Bug fixes
> > >> - Some nice features (at least as a current user I find them
> > >> interesting
> > >> :-) ):
> > >>- More space in UI and simpler look
> > >>- Up to date Browser based on javafx
> > >>
> > > We might have to warn a bit more about the need for javafx (The default
> > > java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter
> > will
> > > start, but the results tree view is missing.
> > >
> >
> > I think in this case we should try to fail in a bit cleaner way
> >
> > >- Or in response assertion
> > >>- Replace feature (partial)+ counting
> > >>
> > >> Maybe we can integrate before next release:
> > >>
> > >> - PR-247
> > >> - PR-246
> > >> - PR-245
> > >> - PR-237
> > >>
> > >> And upgrade some dependencies:
> > >>
> > >> - jodd which has a lot of perf enhancements that we use in JMeter
> > (for
> > >> resources extractions)
> > >> - httpcomponents
> > >> - maybe more
> > >>
> > > I would like to link  the converted pdf tutorials and maybe do a bit of
> > > minor tweaks to the look and feel of the web pages (less shadows).
> > >
> > > Should the sect-num number of the tutorials be continued from those in
> > the
> > > usermanual section?
> > >
> >
> > I think so.
> >
> >
> > >> Besides, we did a lot of code changes related to sonar, let's release
> > it.
> > >>
> > >> A last good thing is that we start to release more often.
> > >>
> > > +1
> > >
> > > Felix
> > >
> > >>
> > >>
> > >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>



-- 
Cordialement.
Philippe Mouawad.


Re: Release JMeter 3.2 ?

2017-01-16 Thread Antonio Gomes Rodrigues
Hi,

One more thing

Release 3.2 will need Java 8. Is it the moment to switch to Nashorn Engine
by default?

Someone have made test with GC G1 to switch to it with the right parameter
in 3.2 release?

Thank
Antonio

2017-01-16 10:13 GMT+01:00 Antonio Gomes Rodrigues :

> Hi Philippe,
>
> Thanks to your job
>
> 2017-01-15 23:20 GMT+01:00 Philippe Mouawad :
>
>> On Thu, Jan 12, 2017 at 9:02 PM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>>
>> >
>> >
>> > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
>> > felix.schumac...@internetallee.de> wrote:
>> >
>> >> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
>> >>
>> >>> Hello,
>> >>> What do you think of releasing a 3.2 version ?
>> >>>
>> >> I think I said before, that I would like to release often :)
>> >>
>> >>>
>> >>> I see following reasons:
>> >>>
>> >>> - There is a regression (See bug 60575)
>> >>>
>> >> My fix for 60575 needs tests and review as it changes the contract of
>> the
>> >> method getSendParameterValuesAsPostBody.
>> >>
>> > I reviewed it , it looks ok to me.
>> > I'll double check.
>> >
>> >>
>> >> It returned true if there were no parameters (and thus none with a
>> name).
>> >> (Or if getPostBodyRaw() is true)
>> >>
>> >> After the change it returns only true when there are parameters and
>> none
>> >> of those have a name. (Or if getPostBodyRaw() is true).
>> >>
>> >
>> >
>> >
>> >>
>> >> This method is used in POST and PUT as well, but I believe the change
>> to
>> >> be correct in both places. too.
>> >>
>> >> - We have 9 enhancements and 12  Bug fixes
>> >>> - Some nice features (at least as a current user I find them
>> >>> interesting
>> >>> :-) ):
>> >>>- More space in UI and simpler look
>> >>>- Up to date Browser based on javafx
>> >>>
>> >> We might have to warn a bit more about the need for javafx (The default
>> >> java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter
>> will
>> >> start, but the results tree view is missing.
>> >>
>> >
>> > I think in this case we should try to fail in a bit cleaner way
>> >
>>
>> Done through bug  60583
>> Still, not fully satisfied with solution as we catch a
>> NoClassDefFoundError
>> (I'll send a mail on this)
>>
>>
>>
>>- Or in response assertion
>> >>>- Replace feature (partial)+ counting
>> >>>
>> >>> Maybe we can integrate before next release:
>> >>>
>> >>> - PR-247
>> >>>
>> >>
>> If somebody can take it into account. I'm pausing for now.
>>
>>
>>
>> > - PR-246
>> >>>
>> >> Done with some changes.
>> We can improve in the future by:
>>
>>- Using HttpComponents HttpAsyncClient
>>- Make some properties configurable
>>
>>
>> - PR-245
>> >>>
>> >> Done with some changes
>>
>> > - PR-237
>> >>>
>> >> Done
>>
>> >
>> >>> And upgrade some dependencies:
>> >>>
>> >>> - jodd which has a lot of perf enhancements that we use in JMeter
>> >>> (for
>> >>> resources extractions)
>> >>> - httpcomponents
>> >>> - maybe more
>> >>>
>> >> Done
>>
>> I'd also like to commit :
>>
>>- https://bz.apache.org/bugzilla/show_bug.cgi?id=60514
>>
>>
>> I would like to link  the converted pdf tutorials and maybe do a bit of
>> >> minor tweaks to the look and feel of the web pages (less shadows).
>> >>
>> >> Should the sect-num number of the tutorials be continued from those in
>> >> the usermanual section?
>> >>
>> >
>> > I think so.
>> >
>> >
>> >>> Besides, we did a lot of code changes related to sonar, let's release
>> it.
>> >>>
>> >>> A last good thing is that we start to release more often.
>> >>>
>> >> +1
>> >>
>> >> Felix
>> >>
>> >>>
>> >>>
>> >>
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>> >
>> >
>> >
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>
>


Re: Release JMeter 3.2 ?

2017-01-16 Thread Antonio Gomes Rodrigues
Hi Philippe,

Thanks to your job

2017-01-15 23:20 GMT+01:00 Philippe Mouawad :

> On Thu, Jan 12, 2017 at 9:02 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> >
> >
> > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > felix.schumac...@internetallee.de> wrote:
> >
> >> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> >>
> >>> Hello,
> >>> What do you think of releasing a 3.2 version ?
> >>>
> >> I think I said before, that I would like to release often :)
> >>
> >>>
> >>> I see following reasons:
> >>>
> >>> - There is a regression (See bug 60575)
> >>>
> >> My fix for 60575 needs tests and review as it changes the contract of
> the
> >> method getSendParameterValuesAsPostBody.
> >>
> > I reviewed it , it looks ok to me.
> > I'll double check.
> >
> >>
> >> It returned true if there were no parameters (and thus none with a
> name).
> >> (Or if getPostBodyRaw() is true)
> >>
> >> After the change it returns only true when there are parameters and none
> >> of those have a name. (Or if getPostBodyRaw() is true).
> >>
> >
> >
> >
> >>
> >> This method is used in POST and PUT as well, but I believe the change to
> >> be correct in both places. too.
> >>
> >> - We have 9 enhancements and 12  Bug fixes
> >>> - Some nice features (at least as a current user I find them
> >>> interesting
> >>> :-) ):
> >>>- More space in UI and simpler look
> >>>- Up to date Browser based on javafx
> >>>
> >> We might have to warn a bit more about the need for javafx (The default
> >> java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter
> will
> >> start, but the results tree view is missing.
> >>
> >
> > I think in this case we should try to fail in a bit cleaner way
> >
>
> Done through bug  60583
> Still, not fully satisfied with solution as we catch a NoClassDefFoundError
> (I'll send a mail on this)
>
>
>
>- Or in response assertion
> >>>- Replace feature (partial)+ counting
> >>>
> >>> Maybe we can integrate before next release:
> >>>
> >>> - PR-247
> >>>
> >>
> If somebody can take it into account. I'm pausing for now.
>
>
>
> > - PR-246
> >>>
> >> Done with some changes.
> We can improve in the future by:
>
>- Using HttpComponents HttpAsyncClient
>- Make some properties configurable
>
>
> - PR-245
> >>>
> >> Done with some changes
>
> > - PR-237
> >>>
> >> Done
>
> >
> >>> And upgrade some dependencies:
> >>>
> >>> - jodd which has a lot of perf enhancements that we use in JMeter
> >>> (for
> >>> resources extractions)
> >>> - httpcomponents
> >>> - maybe more
> >>>
> >> Done
>
> I'd also like to commit :
>
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=60514
>
>
> I would like to link  the converted pdf tutorials and maybe do a bit of
> >> minor tweaks to the look and feel of the web pages (less shadows).
> >>
> >> Should the sect-num number of the tutorials be continued from those in
> >> the usermanual section?
> >>
> >
> > I think so.
> >
> >
> >>> Besides, we did a lot of code changes related to sonar, let's release
> it.
> >>>
> >>> A last good thing is that we start to release more often.
> >>>
> >> +1
> >>
> >> Felix
> >>
> >>>
> >>>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
> >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Release JMeter 3.2 ?

2017-01-15 Thread Philippe Mouawad
On Thu, Jan 12, 2017 at 9:02 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

>
>
> On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
>> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
>>
>>> Hello,
>>> What do you think of releasing a 3.2 version ?
>>>
>> I think I said before, that I would like to release often :)
>>
>>>
>>> I see following reasons:
>>>
>>> - There is a regression (See bug 60575)
>>>
>> My fix for 60575 needs tests and review as it changes the contract of the
>> method getSendParameterValuesAsPostBody.
>>
> I reviewed it , it looks ok to me.
> I'll double check.
>
>>
>> It returned true if there were no parameters (and thus none with a name).
>> (Or if getPostBodyRaw() is true)
>>
>> After the change it returns only true when there are parameters and none
>> of those have a name. (Or if getPostBodyRaw() is true).
>>
>
>
>
>>
>> This method is used in POST and PUT as well, but I believe the change to
>> be correct in both places. too.
>>
>> - We have 9 enhancements and 12  Bug fixes
>>> - Some nice features (at least as a current user I find them
>>> interesting
>>> :-) ):
>>>- More space in UI and simpler look
>>>- Up to date Browser based on javafx
>>>
>> We might have to warn a bit more about the need for javafx (The default
>> java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter will
>> start, but the results tree view is missing.
>>
>
> I think in this case we should try to fail in a bit cleaner way
>

Done through bug  60583
Still, not fully satisfied with solution as we catch a NoClassDefFoundError
(I'll send a mail on this)



   - Or in response assertion
>>>- Replace feature (partial)+ counting
>>>
>>> Maybe we can integrate before next release:
>>>
>>> - PR-247
>>>
>>
If somebody can take it into account. I'm pausing for now.



> - PR-246
>>>
>> Done with some changes.
We can improve in the future by:

   - Using HttpComponents HttpAsyncClient
   - Make some properties configurable


- PR-245
>>>
>> Done with some changes

> - PR-237
>>>
>> Done

>
>>> And upgrade some dependencies:
>>>
>>> - jodd which has a lot of perf enhancements that we use in JMeter
>>> (for
>>> resources extractions)
>>> - httpcomponents
>>> - maybe more
>>>
>> Done

I'd also like to commit :

   - https://bz.apache.org/bugzilla/show_bug.cgi?id=60514


I would like to link  the converted pdf tutorials and maybe do a bit of
>> minor tweaks to the look and feel of the web pages (less shadows).
>>
>> Should the sect-num number of the tutorials be continued from those in
>> the usermanual section?
>>
>
> I think so.
>
>
>>> Besides, we did a lot of code changes related to sonar, let's release it.
>>>
>>> A last good thing is that we start to release more often.
>>>
>> +1
>>
>> Felix
>>
>>>
>>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.


Re: VRT listener with JavaFX html view don't work with openjdk 8 [was Re: Release JMeter 3.2 ?]

2017-01-13 Thread Milamber

Hello Philippe,

Works better now the VRT is available and the HTML render works 
(fallback to old render)  (just 1 WARN line + stacktrace each time I had 
a VRT listener into the JMeter tree)


Thanks

Milamber

On 13/01/2017 13:51, Philippe Mouawad wrote:

Thanks.
Can you test new build which will be available in 10 minutes from now ?
Thanks

On Fri, Jan 13, 2017 at 1:56 PM, Milamber  wrote:


Done

https://bz.apache.org/bugzilla/show_bug.cgi?id=60583




On 13/01/2017 11:21, Philippe Mouawad wrote:


Hi Milamber,
Can you create a bugzilla for this ?
Thanks

On Fri, Jan 13, 2017 at 12:10 PM, Milamber  wrote:

 - Up to date Browser based on javafx

The listener View Result Tree don't appear in the menu if you start
JMeter
with openjdk8 (openjdk is the default JVM on Linux distros)

If you try to open a script JMX which include a VRT listerner a error box
display too.

Seems to be like a regression (on Linux platform)? Isn't possible to
fallback to old html render if the javafx class isn't found?


The error into jmeter.log:

2017/01/13 10:55:11 WARN  - jmeter.gui.util.MenuFactory: Configuration
error, probably corrupt or missing third party library(jar) ? Could not
create class:org.apache.jmeter.visualizers.ViewResultsFullVisualizer.
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
  at java.lang.Class.forName0(Native Method)
  at java.lang.Class.forName(Class.java:264)
  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
teComboRender(ViewResultsFullVisualizer.java:340)
  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
teLeftPanel(ViewResultsFullVisualizer.java:308)
  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init
(ViewResultsFullVisualizer.java:229)
  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.(ViewResultsFullVisualizer.java:138)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Nativ
e
Method)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
ConstructorAccessorImpl.java:62)
  at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
legatingConstructorAccessorImpl.java:45)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:4
23)
  at java.lang.Class.newInstance(Class.java:442)
  at org.apache.jmeter.gui.util.MenuFactory.initializeMenus(MenuF
actory.java:497)
  at org.apache.jmeter.gui.util.MenuFactory.(MenuFactory.
java:168)
  at org.apache.jmeter.control.gui.WorkBenchGui.createPopupMenu(W
orkBenchGui.java:119)
  at org.apache.jmeter.gui.tree.JMeterTreeNode.createPopupMenu(JM
eterTreeNode.java:156)
  at org.apache.jmeter.gui.action.EditCommand.doAction(EditComman
d.java:46)
  at org.apache.jmeter.gui.action.ActionRouter.performAction(Acti
onRouter.java:80)
  at org.apache.jmeter.gui.action.ActionRouter.access$000(ActionR
outer.java:40)
  at org.apache.jmeter.gui.action.ActionRouter$1.run(ActionRouter
.java:62)
  at java.awt.event.InvocationEvent.dispatch(InvocationEvent.
java:311)
  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
  at java.awt.EventQueue.access$500(EventQueue.java:97)
  at java.awt.EventQueue$3.run(EventQueue.java:709)
  at java.awt.EventQueue$3.run(EventQueue.java:703)
  at java.security.AccessController.doPrivileged(Native Method)
  at java.security.ProtectionDomain$JavaSecurityAccessImpl.doInte
rsectionPrivilege(ProtectionDomain.java:76)
  at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
  at org.GNOME.Accessibility.AtkWrapper$5.dispatchEvent(AtkWrappe
r.java:700)
  at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDis
patchThread.java:201)
  at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispat
chThread.java:116)
  at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
patchThread.java:105)
  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
java:101)
  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
java:93)
  at java.awt.EventDispatchThread.run(EventDispatchThread.java:82
)
Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
  at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
  ... 34 more



On 12/01/2017 19:39, Philippe Mouawad wrote:

Hello,

What do you think of releasing a 3.2 version ?

I see following reasons:

  - There is a regression (See bug 60575)
  - We have 9 enhancements and 12  Bug fixes
  - Some nice features (at least as a current user I find them
interesting
  :-) ):
 - More space in UI and simpler look
 - Up to date B

Re: VRT listener with JavaFX html view don't work with openjdk 8 [was Re: Release JMeter 3.2 ?]

2017-01-13 Thread Philippe Mouawad
Thanks.
Can you test new build which will be available in 10 minutes from now ?
Thanks

On Fri, Jan 13, 2017 at 1:56 PM, Milamber  wrote:

>
> Done
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60583
>
>
>
>
> On 13/01/2017 11:21, Philippe Mouawad wrote:
>
>> Hi Milamber,
>> Can you create a bugzilla for this ?
>> Thanks
>>
>> On Fri, Jan 13, 2017 at 12:10 PM, Milamber  wrote:
>>
>> - Up to date Browser based on javafx
>>> The listener View Result Tree don't appear in the menu if you start
>>> JMeter
>>> with openjdk8 (openjdk is the default JVM on Linux distros)
>>>
>>> If you try to open a script JMX which include a VRT listerner a error box
>>> display too.
>>>
>>> Seems to be like a regression (on Linux platform)? Isn't possible to
>>> fallback to old html render if the javafx class isn't found?
>>>
>>>
>>> The error into jmeter.log:
>>>
>>> 2017/01/13 10:55:11 WARN  - jmeter.gui.util.MenuFactory: Configuration
>>> error, probably corrupt or missing third party library(jar) ? Could not
>>> create class:org.apache.jmeter.visualizers.ViewResultsFullVisualizer.
>>> java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
>>> java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
>>>  at java.lang.Class.forName0(Native Method)
>>>  at java.lang.Class.forName(Class.java:264)
>>>  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
>>> teComboRender(ViewResultsFullVisualizer.java:340)
>>>  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
>>> teLeftPanel(ViewResultsFullVisualizer.java:308)
>>>  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init
>>> (ViewResultsFullVisualizer.java:229)
>>>  at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.>> t>(ViewResultsFullVisualizer.java:138)
>>>  at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Nativ
>>> e
>>> Method)
>>>  at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
>>> ConstructorAccessorImpl.java:62)
>>>  at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
>>> legatingConstructorAccessorImpl.java:45)
>>>  at java.lang.reflect.Constructor.newInstance(Constructor.java:4
>>> 23)
>>>  at java.lang.Class.newInstance(Class.java:442)
>>>  at org.apache.jmeter.gui.util.MenuFactory.initializeMenus(MenuF
>>> actory.java:497)
>>>  at org.apache.jmeter.gui.util.MenuFactory.(MenuFactory.
>>> java:168)
>>>  at org.apache.jmeter.control.gui.WorkBenchGui.createPopupMenu(W
>>> orkBenchGui.java:119)
>>>  at org.apache.jmeter.gui.tree.JMeterTreeNode.createPopupMenu(JM
>>> eterTreeNode.java:156)
>>>  at org.apache.jmeter.gui.action.EditCommand.doAction(EditComman
>>> d.java:46)
>>>  at org.apache.jmeter.gui.action.ActionRouter.performAction(Acti
>>> onRouter.java:80)
>>>  at org.apache.jmeter.gui.action.ActionRouter.access$000(ActionR
>>> outer.java:40)
>>>  at org.apache.jmeter.gui.action.ActionRouter$1.run(ActionRouter
>>> .java:62)
>>>  at java.awt.event.InvocationEvent.dispatch(InvocationEvent.
>>> java:311)
>>>  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
>>>  at java.awt.EventQueue.access$500(EventQueue.java:97)
>>>  at java.awt.EventQueue$3.run(EventQueue.java:709)
>>>  at java.awt.EventQueue$3.run(EventQueue.java:703)
>>>  at java.security.AccessController.doPrivileged(Native Method)
>>>  at java.security.ProtectionDomain$JavaSecurityAccessImpl.doInte
>>> rsectionPrivilege(ProtectionDomain.java:76)
>>>  at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
>>>  at org.GNOME.Accessibility.AtkWrapper$5.dispatchEvent(AtkWrappe
>>> r.java:700)
>>>  at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDis
>>> patchThread.java:201)
>>>  at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispat
>>> chThread.java:116)
>>>  at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
>>> patchThread.java:105)
>>>  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
>>> java:101)
>>>  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
>>> java:93)
>>>  at java.awt.EventDispatchThread.run(EventDispatchThread.java:82
>>> )
>>> Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
>>>  at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>>>  at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>>>  at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>>>  ... 34 more
>>>
>>>
>>>
>>> On 12/01/2017 19:39, Philippe Mouawad wrote:
>>>
>>> Hello,
 What do you think of releasing a 3.2 version ?

 I see following reasons:

  - There is a regression (See bug 60575)
  - We have 9 enhancements and 12  Bug fixes
  - Some nice features (at least as a current us

Re: VRT listener with JavaFX html view don't work with openjdk 8 [was Re: Release JMeter 3.2 ?]

2017-01-13 Thread Milamber


Done

https://bz.apache.org/bugzilla/show_bug.cgi?id=60583



On 13/01/2017 11:21, Philippe Mouawad wrote:

Hi Milamber,
Can you create a bugzilla for this ?
Thanks

On Fri, Jan 13, 2017 at 12:10 PM, Milamber  wrote:


- Up to date Browser based on javafx
The listener View Result Tree don't appear in the menu if you start JMeter
with openjdk8 (openjdk is the default JVM on Linux distros)

If you try to open a script JMX which include a VRT listerner a error box
display too.

Seems to be like a regression (on Linux platform)? Isn't possible to
fallback to old html render if the javafx class isn't found?


The error into jmeter.log:

2017/01/13 10:55:11 WARN  - jmeter.gui.util.MenuFactory: Configuration
error, probably corrupt or missing third party library(jar) ? Could not
create class:org.apache.jmeter.visualizers.ViewResultsFullVisualizer.
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
 at java.lang.Class.forName0(Native Method)
 at java.lang.Class.forName(Class.java:264)
 at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
teComboRender(ViewResultsFullVisualizer.java:340)
 at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
teLeftPanel(ViewResultsFullVisualizer.java:308)
 at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init
(ViewResultsFullVisualizer.java:229)
 at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.(ViewResultsFullVisualizer.java:138)
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
 at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
ConstructorAccessorImpl.java:62)
 at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
legatingConstructorAccessorImpl.java:45)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
 at java.lang.Class.newInstance(Class.java:442)
 at org.apache.jmeter.gui.util.MenuFactory.initializeMenus(MenuF
actory.java:497)
 at org.apache.jmeter.gui.util.MenuFactory.(MenuFactory.
java:168)
 at org.apache.jmeter.control.gui.WorkBenchGui.createPopupMenu(W
orkBenchGui.java:119)
 at org.apache.jmeter.gui.tree.JMeterTreeNode.createPopupMenu(JM
eterTreeNode.java:156)
 at org.apache.jmeter.gui.action.EditCommand.doAction(EditComman
d.java:46)
 at org.apache.jmeter.gui.action.ActionRouter.performAction(Acti
onRouter.java:80)
 at org.apache.jmeter.gui.action.ActionRouter.access$000(ActionR
outer.java:40)
 at org.apache.jmeter.gui.action.ActionRouter$1.run(ActionRouter
.java:62)
 at java.awt.event.InvocationEvent.dispatch(InvocationEvent.
java:311)
 at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
 at java.awt.EventQueue.access$500(EventQueue.java:97)
 at java.awt.EventQueue$3.run(EventQueue.java:709)
 at java.awt.EventQueue$3.run(EventQueue.java:703)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.security.ProtectionDomain$JavaSecurityAccessImpl.doInte
rsectionPrivilege(ProtectionDomain.java:76)
 at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
 at org.GNOME.Accessibility.AtkWrapper$5.dispatchEvent(AtkWrappe
r.java:700)
 at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDis
patchThread.java:201)
 at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispat
chThread.java:116)
 at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
patchThread.java:105)
 at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
java:101)
 at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
java:93)
 at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
 at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
 ... 34 more



On 12/01/2017 19:39, Philippe Mouawad wrote:


Hello,
What do you think of releasing a 3.2 version ?

I see following reasons:

 - There is a regression (See bug 60575)
 - We have 9 enhancements and 12  Bug fixes
 - Some nice features (at least as a current user I find them
interesting
 :-) ):
- More space in UI and simpler look
- Up to date Browser based on javafx
- Or in response assertion
- Replace feature (partial)+ counting

Maybe we can integrate before next release:

 - PR-247
 - PR-246
 - PR-245
 - PR-237

And upgrade some dependencies:

 - jodd which has a lot of perf enhancements that we use in JMeter (for
 resources extractions)
 - httpcomponents
 - maybe more

Besides, we did a lot of code changes related to sonar, let's re

Re: VRT listener with JavaFX html view don't work with openjdk 8 [was Re: Release JMeter 3.2 ?]

2017-01-13 Thread Philippe Mouawad
Hi Milamber,
Can you create a bugzilla for this ?
Thanks

On Fri, Jan 13, 2017 at 12:10 PM, Milamber  wrote:

>- Up to date Browser based on javafx
>>
>
> The listener View Result Tree don't appear in the menu if you start JMeter
> with openjdk8 (openjdk is the default JVM on Linux distros)
>
> If you try to open a script JMX which include a VRT listerner a error box
> display too.
>
> Seems to be like a regression (on Linux platform)? Isn't possible to
> fallback to old html render if the javafx class isn't found?
>
>
> The error into jmeter.log:
>
> 2017/01/13 10:55:11 WARN  - jmeter.gui.util.MenuFactory: Configuration
> error, probably corrupt or missing third party library(jar) ? Could not
> create class:org.apache.jmeter.visualizers.ViewResultsFullVisualizer.
> java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
> java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
> teComboRender(ViewResultsFullVisualizer.java:340)
> at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.crea
> teLeftPanel(ViewResultsFullVisualizer.java:308)
> at org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init
> (ViewResultsFullVisualizer.java:229)
> at org.apache.jmeter.visualizers.ViewResultsFullVisualizer. t>(ViewResultsFullVisualizer.java:138)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
> ConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
> legatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.Class.newInstance(Class.java:442)
> at org.apache.jmeter.gui.util.MenuFactory.initializeMenus(MenuF
> actory.java:497)
> at org.apache.jmeter.gui.util.MenuFactory.(MenuFactory.
> java:168)
> at org.apache.jmeter.control.gui.WorkBenchGui.createPopupMenu(W
> orkBenchGui.java:119)
> at org.apache.jmeter.gui.tree.JMeterTreeNode.createPopupMenu(JM
> eterTreeNode.java:156)
> at org.apache.jmeter.gui.action.EditCommand.doAction(EditComman
> d.java:46)
> at org.apache.jmeter.gui.action.ActionRouter.performAction(Acti
> onRouter.java:80)
> at org.apache.jmeter.gui.action.ActionRouter.access$000(ActionR
> outer.java:40)
> at org.apache.jmeter.gui.action.ActionRouter$1.run(ActionRouter
> .java:62)
> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.
> java:311)
> at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
> at java.awt.EventQueue.access$500(EventQueue.java:97)
> at java.awt.EventQueue$3.run(EventQueue.java:709)
> at java.awt.EventQueue$3.run(EventQueue.java:703)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.security.ProtectionDomain$JavaSecurityAccessImpl.doInte
> rsectionPrivilege(ProtectionDomain.java:76)
> at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
> at org.GNOME.Accessibility.AtkWrapper$5.dispatchEvent(AtkWrappe
> r.java:700)
> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDis
> patchThread.java:201)
> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispat
> chThread.java:116)
> at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
> patchThread.java:105)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
> java:101)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.
> java:93)
> at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
> Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 34 more
>
>
>
> On 12/01/2017 19:39, Philippe Mouawad wrote:
>
>> Hello,
>> What do you think of releasing a 3.2 version ?
>>
>> I see following reasons:
>>
>> - There is a regression (See bug 60575)
>> - We have 9 enhancements and 12  Bug fixes
>> - Some nice features (at least as a current user I find them
>> interesting
>> :-) ):
>>- More space in UI and simpler look
>>- Up to date Browser based on javafx
>>- Or in response assertion
>>- Replace feature (partial)+ counting
>>
>> Maybe we can integrate before next release:
>>
>> - PR-247
>> - PR-246
>> - PR-245
>> - PR-237
>>
>> And upgrade some dependencies:
>>
>> - jodd which has a lot of perf enhancements that we use in JMeter (for
>> resources extractions)
>> - httpcomponents
>> 

VRT listener with JavaFX html view don't work with openjdk 8 [was Re: Release JMeter 3.2 ?]

2017-01-13 Thread Milamber

   - Up to date Browser based on javafx


The listener View Result Tree don't appear in the menu if you start 
JMeter with openjdk8 (openjdk is the default JVM on Linux distros)


If you try to open a script JMX which include a VRT listerner a error 
box display too.


Seems to be like a regression (on Linux platform)? Isn't possible to 
fallback to old html render if the javafx class isn't found?



The error into jmeter.log:

2017/01/13 10:55:11 WARN  - jmeter.gui.util.MenuFactory: Configuration 
error, probably corrupt or missing third party library(jar) ? Could not 
create class:org.apache.jmeter.visualizers.ViewResultsFullVisualizer. 
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel 
java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel

at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at 
org.apache.jmeter.visualizers.ViewResultsFullVisualizer.createComboRender(ViewResultsFullVisualizer.java:340)
at 
org.apache.jmeter.visualizers.ViewResultsFullVisualizer.createLeftPanel(ViewResultsFullVisualizer.java:308)
at 
org.apache.jmeter.visualizers.ViewResultsFullVisualizer.init(ViewResultsFullVisualizer.java:229)
at 
org.apache.jmeter.visualizers.ViewResultsFullVisualizer.(ViewResultsFullVisualizer.java:138)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at 
org.apache.jmeter.gui.util.MenuFactory.initializeMenus(MenuFactory.java:497)
at 
org.apache.jmeter.gui.util.MenuFactory.(MenuFactory.java:168)
at 
org.apache.jmeter.control.gui.WorkBenchGui.createPopupMenu(WorkBenchGui.java:119)
at 
org.apache.jmeter.gui.tree.JMeterTreeNode.createPopupMenu(JMeterTreeNode.java:156)
at 
org.apache.jmeter.gui.action.EditCommand.doAction(EditCommand.java:46)
at 
org.apache.jmeter.gui.action.ActionRouter.performAction(ActionRouter.java:80)
at 
org.apache.jmeter.gui.action.ActionRouter.access$000(ActionRouter.java:40)
at 
org.apache.jmeter.gui.action.ActionRouter$1.run(ActionRouter.java:62)
at 
java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)

at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at 
java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)

at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
at 
org.GNOME.Accessibility.AtkWrapper$5.dispatchEvent(AtkWrapper.java:700)
at 
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at 
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at 
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at 
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)

at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
Caused by: java.lang.ClassNotFoundException: javafx.embed.swing.JFXPanel
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 34 more



On 12/01/2017 19:39, Philippe Mouawad wrote:

Hello,
What do you think of releasing a 3.2 version ?

I see following reasons:

- There is a regression (See bug 60575)
- We have 9 enhancements and 12  Bug fixes
- Some nice features (at least as a current user I find them interesting
:-) ):
   - More space in UI and simpler look
   - Up to date Browser based on javafx
   - Or in response assertion
   - Replace feature (partial)+ counting

Maybe we can integrate before next release:

- PR-247
- PR-246
- PR-245
- PR-237

And upgrade some dependencies:

- jodd which has a lot of perf enhancements that we use in JMeter (for
resources extractions)
- httpcomponents
- maybe more

Besides, we did a lot of code changes related to sonar, let's release it.

A last good thing is that we start to release more often.





Re: Release JMeter 3.2 ?

2017-01-13 Thread Maxime Chassagneux
Hi,

Pls, could you consider to merge this PR too :

 - PR-241 : Support variable for all JMS messages (bytes, object, ...) and
sources (file, folder)
 - PR-240 : Improves JMS component robustness

Thanks .

2017-01-12 21:02 GMT+01:00 Philippe Mouawad :

> On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
> > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> >
> >> Hello,
> >> What do you think of releasing a 3.2 version ?
> >>
> > I think I said before, that I would like to release often :)
> >
> >>
> >> I see following reasons:
> >>
> >> - There is a regression (See bug 60575)
> >>
> > My fix for 60575 needs tests and review as it changes the contract of the
> > method getSendParameterValuesAsPostBody.
> >
> I reviewed it , it looks ok to me.
> I'll double check.
>
> >
> > It returned true if there were no parameters (and thus none with a name).
> > (Or if getPostBodyRaw() is true)
> >
> > After the change it returns only true when there are parameters and none
> > of those have a name. (Or if getPostBodyRaw() is true).
> >
>
>
>
> >
> > This method is used in POST and PUT as well, but I believe the change to
> > be correct in both places. too.
> >
> > - We have 9 enhancements and 12  Bug fixes
> >> - Some nice features (at least as a current user I find them
> >> interesting
> >> :-) ):
> >>- More space in UI and simpler look
> >>- Up to date Browser based on javafx
> >>
> > We might have to warn a bit more about the need for javafx (The default
> > java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter
> will
> > start, but the results tree view is missing.
> >
>
> I think in this case we should try to fail in a bit cleaner way
>
> >- Or in response assertion
> >>- Replace feature (partial)+ counting
> >>
> >> Maybe we can integrate before next release:
> >>
> >> - PR-247
> >> - PR-246
> >> - PR-245
> >> - PR-237
> >>
> >> And upgrade some dependencies:
> >>
> >> - jodd which has a lot of perf enhancements that we use in JMeter
> (for
> >> resources extractions)
> >> - httpcomponents
> >> - maybe more
> >>
> > I would like to link  the converted pdf tutorials and maybe do a bit of
> > minor tweaks to the look and feel of the web pages (less shadows).
> >
> > Should the sect-num number of the tutorials be continued from those in
> the
> > usermanual section?
> >
>
> I think so.
>
>
> >> Besides, we did a lot of code changes related to sonar, let's release
> it.
> >>
> >> A last good thing is that we start to release more often.
> >>
> > +1
> >
> > Felix
> >
> >>
> >>
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Release JMeter 3.2 ?

2017-01-12 Thread Philippe Mouawad
On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
>
>> Hello,
>> What do you think of releasing a 3.2 version ?
>>
> I think I said before, that I would like to release often :)
>
>>
>> I see following reasons:
>>
>> - There is a regression (See bug 60575)
>>
> My fix for 60575 needs tests and review as it changes the contract of the
> method getSendParameterValuesAsPostBody.
>
I reviewed it , it looks ok to me.
I'll double check.

>
> It returned true if there were no parameters (and thus none with a name).
> (Or if getPostBodyRaw() is true)
>
> After the change it returns only true when there are parameters and none
> of those have a name. (Or if getPostBodyRaw() is true).
>



>
> This method is used in POST and PUT as well, but I believe the change to
> be correct in both places. too.
>
> - We have 9 enhancements and 12  Bug fixes
>> - Some nice features (at least as a current user I find them
>> interesting
>> :-) ):
>>- More space in UI and simpler look
>>- Up to date Browser based on javafx
>>
> We might have to warn a bit more about the need for javafx (The default
> java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter will
> start, but the results tree view is missing.
>

I think in this case we should try to fail in a bit cleaner way

>- Or in response assertion
>>- Replace feature (partial)+ counting
>>
>> Maybe we can integrate before next release:
>>
>> - PR-247
>> - PR-246
>> - PR-245
>> - PR-237
>>
>> And upgrade some dependencies:
>>
>> - jodd which has a lot of perf enhancements that we use in JMeter (for
>> resources extractions)
>> - httpcomponents
>> - maybe more
>>
> I would like to link  the converted pdf tutorials and maybe do a bit of
> minor tweaks to the look and feel of the web pages (less shadows).
>
> Should the sect-num number of the tutorials be continued from those in the
> usermanual section?
>

I think so.


>> Besides, we did a lot of code changes related to sonar, let's release it.
>>
>> A last good thing is that we start to release more often.
>>
> +1
>
> Felix
>
>>
>>
>


-- 
Cordialement.
Philippe Mouawad.


Re: Release JMeter 3.2 ?

2017-01-12 Thread Felix Schumacher

Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:

Hello,
What do you think of releasing a 3.2 version ?

I think I said before, that I would like to release often :)


I see following reasons:

- There is a regression (See bug 60575)
My fix for 60575 needs tests and review as it changes the contract of 
the method getSendParameterValuesAsPostBody.


It returned true if there were no parameters (and thus none with a 
name). (Or if getPostBodyRaw() is true)


After the change it returns only true when there are parameters and none 
of those have a name. (Or if getPostBodyRaw() is true).


This method is used in POST and PUT as well, but I believe the change to 
be correct in both places. too.



- We have 9 enhancements and 12  Bug fixes
- Some nice features (at least as a current user I find them interesting
:-) ):
   - More space in UI and simpler look
   - Up to date Browser based on javafx
We might have to warn a bit more about the need for javafx (The default 
java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter 
will start, but the results tree view is missing.

   - Or in response assertion
   - Replace feature (partial)+ counting

Maybe we can integrate before next release:

- PR-247
- PR-246
- PR-245
- PR-237

And upgrade some dependencies:

- jodd which has a lot of perf enhancements that we use in JMeter (for
resources extractions)
- httpcomponents
- maybe more
I would like to link  the converted pdf tutorials and maybe do a bit of 
minor tweaks to the look and feel of the web pages (less shadows).


Should the sect-num number of the tutorials be continued from those in 
the usermanual section?


Besides, we did a lot of code changes related to sonar, let's release it.

A last good thing is that we start to release more often.

+1

Felix