moresandeep merged pull request #538:
URL: https://github.com/apache/knox/pull/538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r809173808
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
CAIWan1998 opened a new pull request #539:
URL: https://github.com/apache/knox/pull/539
Maven will run all tests in a single forked VM by default. This can be
problematic if there are a lot of tests or some very memory-hungry ones. We can
fork more test VM by setting `1.5C`.
===
mpkorstanje commented on pull request #539:
URL: https://github.com/apache/knox/pull/539#issuecomment-1047250716
Would advise against merging. This user has been spamming the same nonsense
commit on several projects.
--
This is an automated message from the Apache Git Service.
To respond
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811831331
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811834368
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811837591
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811837591
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811838405
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811839946
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811844702
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811845186
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/VirtualGroupMapper.java
##
@@ -
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811854091
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811858355
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Parser.java
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Founda
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811858355
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Parser.java
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Founda
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811838405
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
lmccay commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812251950
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Parser.java
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundati
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812316559
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Parser.java
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Founda
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812346700
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812348613
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812348933
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812350963
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
moresandeep commented on pull request #539:
URL: https://github.com/apache/knox/pull/539#issuecomment-1048235769
@CAIWan1998 we have a process for opening PRs please open a JIRA explain the
problem and the solution you have then open a PR with details as per PR
template.
--
This is an
moresandeep closed pull request #539:
URL: https://github.com/apache/knox/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
smolnar82 merged pull request #399:
URL: https://github.com/apache/knox/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r812796744
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,37 @@
*/
pac
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813186144
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##
@@ -17,12 +17,34 @@
*/
pac
pzampino opened a new pull request #540:
URL: https://github.com/apache/knox/pull/540
## What changes were proposed in this pull request?
Added some defensive logic in redirecting.jsp to avoid NullPointerException
in some cases.
## How was this patch tested?
Manual test
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813791683
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813792217
##
File path:
gateway-provider-identity-assertion-common/src/test/java/org/apache/knox/gateway/identityasserter/common/filter/VirtualGroupMapperTest.java
##
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813792540
##
File path:
gateway-provider-identity-assertion-common/src/test/java/org/apache/knox/gateway/identityasserter/common/filter/VirtualGroupMapperTest.java
##
zeroflag commented on pull request #537:
URL: https://github.com/apache/knox/pull/537#issuecomment-1049771263
> It's difficult for me to tell, but is there any testing of the combined
(old/new) mapping configuration syntax?
Yes, in the `CommonIdentityAssertionFilterTest` there is one
zeroflag edited a comment on pull request #537:
URL: https://github.com/apache/knox/pull/537#issuecomment-1049771263
> It's difficult for me to tell, but is there any testing of the combined
(old/new) mapping configuration syntax?
Yes, in the `CommonIdentityAssertionFilterTest` there
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813791683
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r813791683
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814122509
##
File path:
gateway-provider-identity-assertion-common/src/test/java/org/apache/knox/gateway/identityasserter/filter/CommonIdentityAssertionFilterTest.java
###
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814151484
##
File path:
gateway-provider-identity-assertion-common/src/test/java/org/apache/knox/gateway/identityasserter/filter/CommonIdentityAssertionFilterTest.java
###
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814235328
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814261998
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814262730
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814266523
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
pzampino commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814269836
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r814273246
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/plang/Ast.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation
pzampino merged pull request #540:
URL: https://github.com/apache/knox/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kn
zeroflag merged pull request #537:
URL: https://github.com/apache/knox/pull/537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kn
Flamingo93 opened a new pull request #541:
URL: https://github.com/apache/knox/pull/541
## What changes were proposed in this pull request?
[Trino](https://trino.io/docs/current/) is a distributed SQL query engine
designed to query large data sets distributed over one or more heterogeneo
smolnar82 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1057274206
@Flamingo93 - the screenshot you attached does not show proof that Trino UI
is accessible via Knox (https://trino_ui_host:9084/ui). Could you please attach
the correct one?
smolnar82 commented on a change in pull request #541:
URL: https://github.com/apache/knox/pull/541#discussion_r818007439
##
File path:
gateway-service-definitions/src/main/resources/services/trinoui/365/service.xml
##
@@ -0,0 +1,29 @@
+
+
+
Review comment:
Missing the
moresandeep commented on a change in pull request #541:
URL: https://github.com/apache/knox/pull/541#discussion_r818010392
##
File path:
gateway-service-definitions/src/main/resources/services/trinoui/365/service.xml
##
@@ -0,0 +1,29 @@
+
+
+
Review comment:
Good point
smolnar82 opened a new pull request #542:
URL: https://github.com/apache/knox/pull/542
## What changes were proposed in this pull request?
The following enhancements were added by this change:
- the simple `GET` API is extended to handle custom metadata information
- the `getUse
smolnar82 opened a new pull request #543:
URL: https://github.com/apache/knox/pull/543
## What changes were proposed in this pull request?
Changing Knox's default behavior when a user exceeds the configured token
limit: if `REMOVE_OLDEST` is configured, Knox will remove the oldest to
smolnar82 merged pull request #543:
URL: https://github.com/apache/knox/pull/543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
pzampino commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r821130144
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -395,11 +397,22 @@ public Response d
smolnar82 commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r821569577
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -395,11 +397,22 @@ public Response
moresandeep opened a new pull request #544:
URL: https://github.com/apache/knox/pull/544
## What changes were proposed in this pull request?
This PR adds a new identity assertion provider `NoDoAsProvider` that does
not add doAs parameter at the end of the query string. This is needed for
moresandeep commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1061927588
@Flamingo93 checking in if you need any help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
pzampino commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822052638
##
File path:
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoDoAsHttpServletRequestWrapp
pzampino commented on pull request #542:
URL: https://github.com/apache/knox/pull/542#issuecomment-1062211753
> May be i am misunderstanding, but using GET to add metadata seems odd.
As I understand it, you're GETting a token with the specified metadata.
--
This is an automated mes
moresandeep commented on pull request #544:
URL: https://github.com/apache/knox/pull/544#issuecomment-1062496263
Thanks for the review @pzampino and I do agree with you, i'll make the
changes and update the PR.
--
This is an automated message from the Apache Git Service.
To respond to th
smolnar82 commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r822601006
##
File path:
gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java
##
@@ -1006,7 +1007,7 @@ publi
smolnar82 commented on pull request #542:
URL: https://github.com/apache/knox/pull/542#issuecomment-1062876217
@pzampino - all of your review comments are addressed/fixed. Could you
please take another look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond
moresandeep commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822777101
##
File path:
gateway-provider-identity-assertion-no-doas/src/test/java/org/apache/knox/gateway/identityasserter/filter/IdentityAssertionNoDoAsHttpServletRequestW
pzampino commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822794727
##
File path:
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoImpersonationHttpServletReq
pzampino commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r822835650
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -405,11 +408,43 @@ public Response d
pzampino commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r822835650
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -405,11 +408,43 @@ public Response d
moresandeep commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822856365
##
File path:
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoImpersonationHttpServlet
moresandeep commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822856365
##
File path:
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoImpersonationHttpServlet
smolnar82 commented on a change in pull request #542:
URL: https://github.com/apache/knox/pull/542#discussion_r823151868
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -405,11 +408,43 @@ public Response
smolnar82 merged pull request #542:
URL: https://github.com/apache/knox/pull/542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
smolnar82 opened a new pull request #545:
URL: https://github.com/apache/knox/pull/545
## What changes were proposed in this pull request?
Implemented the changes described in
[KNOX-2714](https://issues.apache.org/jira/browse/KNOX-2714).
## How was this patch tested?
TO
moresandeep merged pull request #544:
URL: https://github.com/apache/knox/pull/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
Flamingo93 closed pull request #541:
URL: https://github.com/apache/knox/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
Flamingo93 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1066254493
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Flamingo93 edited a comment on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1066254493
>
@moresandeep @smolnar82 I have updated the screenshot and added metadata in
service.xml, thank you for your guidance and advice.
--
This is an automated messag
smolnar82 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1067200487
I restarted the failed Tavis job, let's wait for a green build before
merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
smolnar82 merged pull request #541:
URL: https://github.com/apache/knox/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
pzampino commented on a change in pull request #545:
URL: https://github.com/apache/knox/pull/545#discussion_r827007168
##
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java
##
@@ -14
smolnar82 commented on a change in pull request #545:
URL: https://github.com/apache/knox/pull/545#discussion_r827708026
##
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/TokenStateServiceMessages.java
##
@@ -246,4 +246,7 @@
@Message(l
pzampino commented on a change in pull request #545:
URL: https://github.com/apache/knox/pull/545#discussion_r828001269
##
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java
##
@@ -14
smolnar82 merged pull request #545:
URL: https://github.com/apache/knox/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
zeroflag opened a new pull request #546:
URL: https://github.com/apache/knox/pull/546
## What changes were proposed in this pull request?
CommonIdentityAssertionFilter puts the same group multiple times as shown in
the audit log:
```
22/02/17 17:40:38
||b28adfe1-90ea-4fb5-
pjfanning opened a new pull request #547:
URL: https://github.com/apache/knox/pull/547
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull req
zeroflag closed pull request #546:
URL: https://github.com/apache/knox/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kn
zeroflag closed pull request #546:
URL: https://github.com/apache/knox/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kn
pjfanning opened a new pull request #548:
URL: https://github.com/apache/knox/pull/548
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull req
petersomogyi opened a new pull request #549:
URL: https://github.com/apache/knox/pull/549
## What changes were proposed in this pull request?
Add rewrite rule for Named Queue Logs on HBase Master UI.
## How was this patch tested?
Copied the rewrite.xml file to a cluster,
zeroflag merged pull request #546:
URL: https://github.com/apache/knox/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kn
smolnar82 merged pull request #549:
URL: https://github.com/apache/knox/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@k
pjfanning opened a new pull request #550:
URL: https://github.com/apache/knox/pull/550
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull req
Flamingo93 opened a new pull request, #551:
URL: https://github.com/apache/knox/pull/551
## What changes were proposed in this pull request?
[HiveServer2](https://cwiki.apache.org/confluence/display/hive/hiveserver2+overview)
is a service that enables clients to execute queries against H
Flamingo93 commented on PR #551:
URL: https://github.com/apache/knox/pull/551#issuecomment-1088246225
Hi @smolnar82 , I meet the problem that Java8 workflows cannot pass. Can you
tell me how to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the messag
smolnar82 commented on PR #551:
URL: https://github.com/apache/knox/pull/551#issuecomment-1088322010
@Flamingo93 - I've just re-triggered the build 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
smolnar82 merged PR #551:
URL: https://github.com/apache/knox/pull/551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 closed pull request #535: Improve MAVEN build Performance
URL: https://github.com/apache/knox/pull/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
smolnar82 commented on PR #535:
URL: https://github.com/apache/knox/pull/535#issuecomment-1088575416
Closing this one as I did not hear back for 2 months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
smolnar82 commented on PR #547:
URL: https://github.com/apache/knox/pull/547#issuecomment-1088578838
My 2 cents:
- this change contains 2 upgrades in fact:
- shiro
- log4j2
Please make them committed separately.
- I'd love to see some details on the tests you were executi
pjfanning commented on PR #547:
URL: https://github.com/apache/knox/pull/547#issuecomment-1088584990
@smolnar82 I reverted the log4j change - I added it because the CI didn't
kick off for my initial commit. I'm relying on the CI build test the changes.
I'm not a Knox user. I'm involved with
smolnar82 commented on PR #547:
URL: https://github.com/apache/knox/pull/547#issuecomment-1088593483
@pjfanning - I got it.
In this case, please give me some time to checkout this PR and execute some
sanity checks (at least PAM/LDAP authentication on the Shiro side).
--
This is an auto
smolnar82 commented on PR #548:
URL: https://github.com/apache/knox/pull/548#issuecomment-1088594605
@pjfanning - please give me some time to check out this PR and execute some
sanity checks using this newer version of PostgreSQL.
--
This is an automated message from the Apache Git Servi
smolnar82 commented on PR #550:
URL: https://github.com/apache/knox/pull/550#issuecomment-1088595202
@pjfanning - please give me some time to checkout this PR and execute some
sanity checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
1 - 100 of 4034 matches
Mail list logo
