Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109959 --- Ship it! Please update testing done with latest patch. -

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/ --- (Updated Dec. 11, 2015, 12:55 p.m.) Review request for lens. Changes ---

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Dec. 11, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1295 > > > > > > Should we not persist opHandleToSessionHandle

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 535 > > > > > > If closeQuery() is not called before this, which happens

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > lines 803-804 > > > > > > Please log the closing of session . Not required in

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109927 --- Deepak, can you mark the review issues as fixed/dropped

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Dec. 7, 2015, 7:56 a.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 803 > > > > > > If sessions are getting closed at query finish, there

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/ --- (Updated Dec. 2, 2015, 10:40 a.m.) Review request for lens. Changes ---

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review108103 --- Deepak Barr, Is there any update on this for review comments? -

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 13, 2015, 6:57 a.m., Pranav Agarwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1258 > > > > > > If we indeed decide to change the semantic of this

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 26, 2015, 9:14 a.m., Amareshwari Sriramadasu wrote: > > Deepak Barr, Is there any update on this for review comments? Sorry, I was occupied with something else. Will resume work on this. From the review comments, I am thinking we should do the following - 1. For sync queries (CLI),

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 4, 2015, 3:51 p.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1249 > > > > > > What happens to skipped(open) sessions ? do we need to

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 13, 2015, 6:57 a.m., Pranav Agarwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1245 > > > > > > In my opinion we shouldn't change the default behavior

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 13, 2015, 6:57 a.m., Pranav Agarwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1245 > > > > > > In my opinion we shouldn't change the default behavior

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 9, 2015, 12:57 p.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1260 > > > > > > Add test cases for not closeable? didn't get you ?

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review105671 ---

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 4, 2015, 3:51 p.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1249 > > > > > > What happens to skipped(open) sessions ? do we need to

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Nov. 4, 2015, 3:51 p.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1249 > > > > > > What happens to skipped(open) sessions ? do we need to

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review105069 ---

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review105035 --- Can you add unit test? - Amareshwari Sriramadasu On Nov. 3,