[jira] [Updated] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-02-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7638: - Attachment: LUCENE-7638.patch I pushed a new patch that changes how we build boolean graph query

[jira] [Commented] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-02-05 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853329#comment-15853329 ] Jim Ferenczi commented on LUCENE-7638: -- Thanks [~mikemccand]. Just to be clear this patch creates a

[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries

2017-02-21 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875705#comment-15875705 ] Jim Ferenczi commented on LUCENE-7699: -- It looks good [~mattweber] In analyzeGraphPhrase you check

[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries

2017-02-22 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877731#comment-15877731 ] Jim Ferenczi commented on LUCENE-7699: -- Thanks [~mattweber] The new patch looks great. I'll merge

[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries

2017-02-22 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878200#comment-15878200 ] Jim Ferenczi commented on LUCENE-7699: -- Thanks [~mattweber] ! > Apply graph articulation points

[jira] [Commented] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882616#comment-15882616 ] Jim Ferenczi commented on LUCENE-7708: -- The CJKBigramFilter is working correctly because it sets the

[jira] [Created] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7708: Summary: Track PositionLengthAttribute abuse Key: LUCENE-7708 URL: https://issues.apache.org/jira/browse/LUCENE-7708 Project: Lucene - Core Issue Type: Bug

[jira] [Updated] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7708: - Attachment: LUCENE-7708.patch Here is one patch for the ShingleFilter. When outputUnigrams is

[jira] [Updated] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7708: - Attachment: LUCENE-7708.patch Thanks Steve ! I pushed a new patch that solves the tests

[jira] [Comment Edited] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883672#comment-15883672 ] Jim Ferenczi edited comment on LUCENE-7708 at 2/24/17 10:49 PM: Thanks

[jira] [Closed] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi closed LUCENE-7708. Resolution: Fixed > Track PositionLengthAttribute abuse > --- > >

[jira] [Commented] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-02-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883672#comment-15883672 ] Jim Ferenczi commented on LUCENE-7708: -- Thanks [~sar...@syr.edu] and [~mikemccand] ! > Track

[jira] [Commented] (LUCENE-7707) Only assign ScoreDoc#shardIndex if it was already assigned to non default (-1) value

2017-02-23 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880708#comment-15880708 ] Jim Ferenczi commented on LUCENE-7707: -- +1, this will make the merge more flexible. If we really

[jira] [Commented] (LUCENE-7707) Only assign ScoreDoc#shardIndex if it was already assigned to non default (-1) value

2017-02-23 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880859#comment-15880859 ] Jim Ferenczi commented on LUCENE-7707: -- bq. Plus I think it's very unlikely someone today is

[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries

2017-02-22 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878289#comment-15878289 ] Jim Ferenczi commented on LUCENE-7699: -- Only 6.5 since the articulation points parsing is a breaking

[jira] [Commented] (LUCENE-7702) Remove GraphQuery

2017-02-22 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878291#comment-15878291 ] Jim Ferenczi commented on LUCENE-7702: -- [~mattweber] no need, it takes time because I re-run the

[jira] [Commented] (LUCENE-7702) Remove GraphQuery

2017-02-22 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878414#comment-15878414 ] Jim Ferenczi commented on LUCENE-7702: -- Merged to 6x, [~mattweber] can you close the issue ? >

[jira] [Commented] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-02-13 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863338#comment-15863338 ] Jim Ferenczi commented on LUCENE-7638: -- Sure, thanks [~mikemccand] and [~mattweber] ! > Optimize

[jira] [Resolved] (LUCENE-7579) Sorting on flushed segment

2017-02-13 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7579. -- Resolution: Fixed > Sorting on flushed segment > -- > >

[jira] [Resolved] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-02-13 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7638. -- Resolution: Fixed > Optimize graph query produced by QueryBuilder >

[jira] [Updated] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7638: - Attachment: LUCENE-7638.patch > Optimize graph query produced by QueryBuilder >

[jira] [Updated] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7638: - Description: The QueryBuilder creates a graph query when the underlying TokenStream contains

[jira] [Created] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7638: Summary: Optimize graph query produced by QueryBuilder Key: LUCENE-7638 URL: https://issues.apache.org/jira/browse/LUCENE-7638 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824337#comment-15824337 ] Jim Ferenczi commented on LUCENE-7638: -- For pure phrase query it's a good fit because it's a

[jira] [Commented] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824358#comment-15824358 ] Jim Ferenczi commented on LUCENE-7638: -- [~mattweber] I don't think we lose minimum should match

[jira] [Comment Edited] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824337#comment-15824337 ] Jim Ferenczi edited comment on LUCENE-7638 at 1/16/17 5:44 PM: --- {quote}

[jira] [Commented] (SOLR-9935) When hl.method=unified add support for hl.fragsize param

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825674#comment-15825674 ] Jim Ferenczi commented on SOLR-9935: I guess you can David. I'll create the first RC later today but if

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825920#comment-15825920 ] Jim Ferenczi commented on LUCENE-7579: -- Thanks Mike ! Yes branch_6.x: 6.5 is the target. > Sorting

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825856#comment-15825856 ] Jim Ferenczi commented on LUCENE-7579: -- [~mikemccand] I think the branch for the backport in the 6x

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825928#comment-15825928 ] Jim Ferenczi commented on LUCENE-7579: -- I've modified the version check for sorted segments

[jira] [Comment Edited] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826085#comment-15826085 ] Jim Ferenczi edited comment on LUCENE-7638 at 1/17/17 2:00 PM: --- Thanks for

[jira] [Commented] (LUCENE-7638) Optimize graph query produced by QueryBuilder

2017-01-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826085#comment-15826085 ] Jim Ferenczi commented on LUCENE-7638: -- Thanks for taking a look @mattweber and [~mikemccand]

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

2017-01-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804338#comment-15804338 ] Jim Ferenczi commented on LUCENE-7620: -- It looks good [~dsmiley] ! I've started to work on something

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

2017-01-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805199#comment-15805199 ] Jim Ferenczi commented on LUCENE-7620: -- {quote} By choosing a lengthGoal on the low side; maybe "too

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

2017-01-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806121#comment-15806121 ] Jim Ferenczi commented on LUCENE-7620: -- I think the two methods to create the break iterator are

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

2017-01-07 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807423#comment-15807423 ] Jim Ferenczi commented on LUCENE-7620: -- That makes sense. The tests looks good, . I think it's

[jira] [Commented] (LUCENE-7605) AnalyzingInfixSuggesterTest.testRandomNRT() failures: FixedBitSet cannot be cast to SimpleTextBits

2016-12-28 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782561#comment-15782561 ] Jim Ferenczi commented on LUCENE-7605: -- The patch looks good, thanks [~jpountz] and sorry for the

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-27 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780577#comment-15780577 ] Jim Ferenczi commented on LUCENE-7579: -- I have a candidate branch for the backport in 6.x:

[jira] [Commented] (LUCENE-7055) Better execution path for costly queries

2016-12-26 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15777952#comment-15777952 ] Jim Ferenczi commented on LUCENE-7055: -- I like the new cost estimation and the lazy scorer but maybe

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-27 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781152#comment-15781152 ] Jim Ferenczi commented on LUCENE-7579: -- Thanks @jpountz ! I pushed another iteration that hopefully

[jira] [Commented] (LUCENE-7055) Better execution path for costly queries

2016-12-26 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778113#comment-15778113 ] Jim Ferenczi commented on LUCENE-7055: -- {quote} I think this problem was solved with the two-phase

[jira] [Commented] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928198#comment-15928198 ] Jim Ferenczi commented on LUCENE-7708: -- [~elyograg] one shingle filter problem is fixed in

[jira] [Resolved] (LUCENE-7747) QueryBuilder should build side-paths query (graph query) lazily

2017-03-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7747. -- Resolution: Fixed Fix Version/s: master (7.0) Thanks [~mikemccand] ! > QueryBuilder

[jira] [Reopened] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi reopened LUCENE-7708: -- Lucene Fields: (was: New) > Track PositionLengthAttribute abuse >

[jira] [Resolved] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7708. -- Resolution: Fixed > Track PositionLengthAttribute abuse > ---

[jira] [Commented] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928511#comment-15928511 ] Jim Ferenczi commented on LUCENE-7708: -- Thanks [~dsmiley]. I updated the status. > Track

[jira] [Created] (LUCENE-7747) QueryBuilder should build side-paths query (graph query) lazily

2017-03-16 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7747: Summary: QueryBuilder should build side-paths query (graph query) lazily Key: LUCENE-7747 URL: https://issues.apache.org/jira/browse/LUCENE-7747 Project: Lucene -

[jira] [Updated] (LUCENE-7747) QueryBuilder should build side-paths query (graph query) lazily

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7747: - Attachment: LUCENE-7747.patch Here is a patch that builds an lazy iterator over the different

[jira] [Comment Edited] (LUCENE-7747) QueryBuilder should build side-paths query (graph query) lazily

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927898#comment-15927898 ] Jim Ferenczi edited comment on LUCENE-7747 at 3/16/17 12:05 PM: Here is a

[jira] [Updated] (LUCENE-7579) Sorting on flushed segment

2017-03-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7579: - Fix Version/s: 6.5 master (7.0) > Sorting on flushed segment >

[jira] [Updated] (LUCENE-7747) QueryBuilder should build side-paths query (graph query) lazily

2017-03-17 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7747: - Priority: Blocker (was: Major) Fix Version/s: 6.5 > QueryBuilder should build

[jira] [Updated] (LUCENE-7708) Track PositionLengthAttribute abuse

2017-03-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7708: - Fix Version/s: 6.5 master (7.0) > Track PositionLengthAttribute abuse >

[jira] [Commented] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977463#comment-15977463 ] Jim Ferenczi commented on LUCENE-7791: -- Ok I'll merge to 6.x first, add the tests to master in order

[jira] [Updated] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7791: - Fix Version/s: 6.5.1 6.6 master (7.0) > AIOOBE on

[jira] [Resolved] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7791. -- Resolution: Fixed > AIOOBE on flush+sort > > > Key:

[jira] [Commented] (LUCENE-7791) AIOOBE on flush+sort

2017-04-21 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978372#comment-15978372 ] Jim Ferenczi commented on LUCENE-7791: -- I don't know what happened but the fix for NormsValueWriter

[jira] [Commented] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977769#comment-15977769 ] Jim Ferenczi commented on LUCENE-7791: -- Ok this is now merged to 6.x and 6.5 and the fix will be

[jira] [Commented] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976777#comment-15976777 ] Jim Ferenczi commented on LUCENE-7791: -- Great catch indeed ! {quote} Also, check for range of

[jira] [Updated] (LUCENE-7791) AIOOBE on flush+sort

2017-04-20 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7791: - Attachment: LUCENE-7791.patch Ok I see it now. The code assumes that size==maxDoc and that's of

[jira] [Resolved] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-04 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7914. -- Resolution: Fixed Thanks [~rcmuir] and [~jpountz] ! > Add safeguards to RegExp.toAutomaton

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-04 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Fix Version/s: 7.1 master (8.0) > Add safeguards to RegExp.toAutomaton and

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-10 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Fix Version/s: (was: 7.1) 7.0 > Add safeguards to RegExp.toAutomaton and

[jira] [Commented] (LUCENE-7848) QueryBuilder.analyzeGraphPhrase does not handle gaps correctly

2017-07-13 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085610#comment-16085610 ] Jim Ferenczi commented on LUCENE-7848: -- Dawid, sorry for the delay {code} spanNear([field:SPECIAL,

[jira] [Commented] (LUCENE-7893) SynonymGraphFilterFactory proximity search error

2017-07-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076177#comment-16076177 ] Jim Ferenczi commented on LUCENE-7893: -- I am not able to replicate with 6.6 nor master. In my

[jira] [Moved] (SOLR-11022) SynonymGraphFilterFactory proximity search error

2017-07-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi moved LUCENE-7893 to SOLR-11022: - Affects Version/s: (was: 6.6) 6.6

[jira] [Commented] (LUCENE-7893) SynonymGraphFilterFactory proximity search error

2017-07-06 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077354#comment-16077354 ] Jim Ferenczi commented on LUCENE-7893: -- Ok I checked the Solr code and the problem is that the slop

[jira] [Commented] (LUCENE-7799) Classic query parser should allow autoGeneratePhraseQueries=true when splitOnWhitespace=false

2017-04-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980913#comment-15980913 ] Jim Ferenczi commented on LUCENE-7799: -- There is an option called

[jira] [Commented] (LUCENE-7799) Classic query parser should allow autoGeneratePhraseQueries=true when splitOnWhitespace=false

2017-04-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981973#comment-15981973 ] Jim Ferenczi commented on LUCENE-7799: -- Then we should maybe remove

[jira] [Commented] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-08 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118027#comment-16118027 ] Jim Ferenczi commented on LUCENE-7914: -- I've merged this to master and 7.x but since it's an

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Attachment: LUCENE-7914.patch Thanks for the great feedback [~jpountz] and [~rcmuir] I pushed

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Description: When creating an automaton from a regexp, some operators can create more states

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Attachment: LUCENE-7914.patch Right sorry, a prefix query is indeed infinite. I reverted the

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Attachment: LUCENE-7914.patch I removed the new constructor in AutomatonQuery and the optim in

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Description: When creating an automaton from a regexp, some operators can create more states

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Attachment: LUCENE-7914.patch It's not, it's just a copy/paste from another test in the class. I

[jira] [Created] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7914: Summary: Add safeguards to RegExp.toAutomaton and Operations Key: LUCENE-7914 URL: https://issues.apache.org/jira/browse/LUCENE-7914 Project: Lucene - Core

[jira] [Updated] (LUCENE-7914) Add safeguards to RegExp.toAutomaton and Operations

2017-08-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7914: - Attachment: LUCENE-7914.patch > Add safeguards to RegExp.toAutomaton and Operations >

[jira] [Updated] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-14 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7824: - Fix Version/s: 6.6 master (7.0) > Multi-word synonyms rule with common terms

[jira] [Resolved] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-14 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7824. -- Resolution: Resolved Thanks [~mattweber] > Multi-word synonyms rule with common terms at the

[jira] [Created] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-11 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7824: Summary: Multi-word synonyms rule with common terms at the same position are buggy Key: LUCENE-7824 URL: https://issues.apache.org/jira/browse/LUCENE-7824 Project:

[jira] [Updated] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-11 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7824: - Attachment: LUCENE-7824.patch > Multi-word synonyms rule with common terms at the same position

[jira] [Commented] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-12 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008305#comment-16008305 ] Jim Ferenczi commented on LUCENE-7824: -- I don't think we should try to optimize here. The number of

[jira] [Updated] (LUCENE-7824) Multi-word synonyms rule with common terms at the same position are buggy

2017-05-12 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7824: - Affects Version/s: master (7.0) 6.5.1 > Multi-word synonyms rule with

[jira] [Commented] (LUCENE-7872) TopDocs.totalHits should be a long

2017-06-09 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044282#comment-16044282 ] Jim Ferenczi commented on LUCENE-7872: -- +1 The patch looks good. TopGroups needs this too but

[jira] [Updated] (LUCENE-7874) DisjunctionMaxQuery could rewrite to BooleanQuery when tiebreaker == 1

2017-06-09 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7874: - Attachment: LUCENE-7874.patch Here is a patch > DisjunctionMaxQuery could rewrite to

[jira] [Created] (LUCENE-7874) DisjunctionMaxQuery could rewrite to BooleanQuery when tiebreaker == 1

2017-06-09 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7874: Summary: DisjunctionMaxQuery could rewrite to BooleanQuery when tiebreaker == 1 Key: LUCENE-7874 URL: https://issues.apache.org/jira/browse/LUCENE-7874 Project:

[jira] [Commented] (LUCENE-7833) Calculating minimum score instead of maximum score in ToParentBlockJoinQuery.BlockJoinScorer.setScoreAndFreq

2017-05-18 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015921#comment-16015921 ] Jim Ferenczi commented on LUCENE-7833: -- patch looks good, +1 > Calculating minimum score instead of

[jira] [Created] (LUCENE-7848) QueryBuilder.analyzeGraphPhrase does not handle gaps correctly

2017-05-23 Thread Jim Ferenczi (JIRA)
Jim Ferenczi created LUCENE-7848: Summary: QueryBuilder.analyzeGraphPhrase does not handle gaps correctly Key: LUCENE-7848 URL: https://issues.apache.org/jira/browse/LUCENE-7848 Project: Lucene -

[jira] [Updated] (LUCENE-7540) Upgrade ICU to 58.1

2017-05-23 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7540: - Attachment: LUCENE-7540.patch [~mikemccand] I ran into the same bug when trying to upgrade icu

[jira] [Commented] (LUCENE-7540) Upgrade ICU to 58.1

2017-05-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023149#comment-16023149 ] Jim Ferenczi commented on LUCENE-7540: -- Thanks [~rcmuir] and [~mikemccand] I pushed to master.

[jira] [Comment Edited] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023119#comment-16023119 ] Jim Ferenczi edited comment on LUCENE-7844 at 5/24/17 3:49 PM: --- +1 for the

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023119#comment-16023119 ] Jim Ferenczi commented on LUCENE-7844: -- +1 for the cleanup/code style of the code. Regarding the

[jira] [Updated] (LUCENE-7540) Upgrade ICU to 58.1

2017-05-26 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7540: - Fix Version/s: (was: 6.6) 6.7 > Upgrade ICU to 58.1 > ---

[jira] [Resolved] (LUCENE-7540) Upgrade ICU to 58.1

2017-05-26 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7540. -- Resolution: Fixed Merged in 6x (targeted for 6.7). Thanks [~rcmuir] > Upgrade ICU to 58.1 >

[jira] [Updated] (LUCENE-7848) QueryBuilder.analyzeGraphPhrase does not handle gaps correctly

2017-06-15 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7848: - Attachment: LUCENE-7848.patch Here is a simple patch that support gaps in

[jira] [Commented] (LUCENE-7878) QueryParser AND default operator and MultiWords synonyms failed if keywords exactly matches a synonym

2017-06-14 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049318#comment-16049318 ] Jim Ferenczi commented on LUCENE-7878: -- Thanks Emanuel ! I confirm that this is a bug and that the

[jira] [Updated] (LUCENE-7878) QueryParser AND default operator and MultiWords synonyms failed if keywords exactly matches a synonym

2017-06-14 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7878: - Attachment: LUCENE-7878.patch Here is a patch. The logic to simplify the boolean query produced

[jira] [Updated] (LUCENE-7878) QueryParser AND default operator and MultiWords synonyms failed if keywords exactly matches a synonym

2017-06-14 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7878: - Attachment: LUCENE-7878.patch A new patch that passes all the tests > QueryParser AND default

[jira] [Updated] (LUCENE-7878) QueryParser AND default operator and MultiWords synonyms failed if keywords exactly matches a synonym

2017-06-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-7878: - Fix Version/s: 6.7 master (7.0) > QueryParser AND default operator and

[jira] [Resolved] (LUCENE-7874) DisjunctionMaxQuery could rewrite to BooleanQuery when tiebreaker == 1

2017-06-16 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-7874. -- Resolution: Fixed Thanks [~jpountz] > DisjunctionMaxQuery could rewrite to BooleanQuery when

  1   2   3   4   >