[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814624#comment-16814624 ] Mike Drob commented on SOLR-13386: -- I see similar pattern in {{ClusterProperties}} and {

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818191#comment-16818191 ] Mike Drob commented on SOLR-13386: -- I imagine this is basically impossible to write a un

[jira] [Created] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-01-29 Thread Mike Drob (JIRA)
Mike Drob created SOLR-13190: Summary: Fuzzy search treated as server error instead of client error when terms are too complex Key: SOLR-13190 URL: https://issues.apache.org/jira/browse/SOLR-13190 Project

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758713#comment-16758713 ] Mike Drob commented on SOLR-13190: -- [~mikemccand] - WDYT? You were the original person t

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761956#comment-16761956 ] Mike Drob commented on SOLR-13190: -- Can you expand on that a little more? Tracing throug

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765499#comment-16765499 ] Mike Drob commented on SOLR-13190: -- We'd have to modify AutomatonQuery to handle multipl

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-06-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865172#comment-16865172 ] Mike Drob commented on SOLR-13190: -- Looks like I failed to mention in this initial repor

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772074#comment-16772074 ] Mike Drob commented on SOLR-13190: -- bq. Does converting an already deterministic automat

[jira] [Updated] (SOLR-4572) Mistake in the comment in source ...surround.parser.QueryParser.jj

2014-11-04 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-4572: Attachment: SOLR-4572.patch Patch that fixes the JavaDoc. > Mistake in the comment in source ...surround.par

[jira] [Moved] (LUCENE-6052) "ant regenerate" causes compilation errors

2014-11-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob moved ACCUMULO-3307 to LUCENE-6052: - Component/s: (was: build) general/build

[jira] [Created] (SOLR-6752) Buffer Cache allocate/lost should be exposed through JMX

2014-11-17 Thread Mike Drob (JIRA)
Mike Drob created SOLR-6752: --- Summary: Buffer Cache allocate/lost should be exposed through JMX Key: SOLR-6752 URL: https://issues.apache.org/jira/browse/SOLR-6752 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-6752) Buffer Cache allocate/lost should be exposed through JMX

2014-11-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6752: Attachment: SOLR-6752.patch Patch applies to current trunk, {{ant clean test}} passed for me with no issues.

[jira] [Commented] (SOLR-6752) Buffer Cache allocate/lost should be exposed through JMX

2014-11-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218077#comment-14218077 ] Mike Drob commented on SOLR-6752: - bq. I'm a little confused by the title - isn't this simp

[jira] [Created] (SOLR-7187) SolrCloud does not fully clean collection after delete

2015-03-03 Thread Mike Drob (JIRA)
Mike Drob created SOLR-7187: --- Summary: SolrCloud does not fully clean collection after delete Key: SOLR-7187 URL: https://issues.apache.org/jira/browse/SOLR-7187 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-7187) SolrCloud does not fully clean collection after delete

2015-03-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-7187: Description: When I attempt to delete a collection using {{/admin/collections?action=DELETE&name=collection1

[jira] [Updated] (SOLR-7187) SolrCloud does not fully clean collection after delete

2015-03-04 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-7187: Attachment: log.out.gz It was not originally applied, but I added it and see the same behavior. Also attachi

[jira] [Commented] (SOLR-7187) SolrCloud does not fully clean collection after delete

2015-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350353#comment-14350353 ] Mike Drob commented on SOLR-7187: - The data dir is deleted by each shard individually when

[jira] [Commented] (SOLR-7187) SolrCloud does not fully clean collection after delete

2015-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350586#comment-14350586 ] Mike Drob commented on SOLR-7187: - Yea, I traced the queues through from delete to unload.

[jira] [Created] (SOLR-7205) Ensure all SolrCore logging also includes core identifier

2015-03-06 Thread Mike Drob (JIRA)
Mike Drob created SOLR-7205: --- Summary: Ensure all SolrCore logging also includes core identifier Key: SOLR-7205 URL: https://issues.apache.org/jira/browse/SOLR-7205 Project: Solr Issue Type: Improv

[jira] [Commented] (SOLR-6673) MDC based logging of collection, shard etc.

2015-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350951#comment-14350951 ] Mike Drob commented on SOLR-6673: - Bump. Is there anything still holding this patch up? I

[jira] [Resolved] (SOLR-7205) Ensure all SolrCore logging also includes core identifier

2015-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-7205. - Resolution: Duplicate Ah, I was unfamiliar with MDC. Cool stuff, I'll close this as a dup. > Ensure all So

[jira] [Updated] (SOLR-6752) Buffer Cache allocate/lost metrics should be exposed

2014-11-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6752: Summary: Buffer Cache allocate/lost metrics should be exposed (was: Buffer Cache allocate/lost should be exp

[jira] [Created] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-19 Thread Mike Drob (JIRA)
Mike Drob created SOLR-6766: --- Summary: Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-6752) Buffer Cache allocate/lost metrics should be exposed

2014-11-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218449#comment-14218449 ] Mike Drob commented on SOLR-6752: - I will split this issue into this and SOLR-6766 to reduc

[jira] [Updated] (SOLR-6752) Buffer Cache allocate/lost metrics should be exposed

2014-11-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6752: Attachment: SOLR-6752.patch A patch for just tracking buffer cache allocate/lost metrics. > Buffer Cache all

[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219623#comment-14219623 ] Mike Drob commented on SOLR-6766: - [~markrmil...@gmail.com] - Continuing discussion from SO

[jira] [Updated] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6766: Attachment: SOLR-6766.patch This patch depends on the one on SOLR-6752 being applied first. Make HdfsDirctor

[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221124#comment-14221124 ] Mike Drob commented on SOLR-6766: - I didn't rename any of the metrics yet because that shou

[jira] [Updated] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6766: Attachment: SOLR-6766.patch Renamed some of the metrics, based on what the other caches use. Could not figur

[jira] [Commented] (SOLR-6752) Buffer Cache allocate/lost metrics should be exposed

2014-11-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223751#comment-14223751 ] Mike Drob commented on SOLR-6752: - Any thoughts on the latest version? > Buffer Cache allo

[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX

2014-11-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223785#comment-14223785 ] Mike Drob commented on SOLR-6766: - I build the patch against trunk, but it could probably g

[jira] [Updated] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-3973: -- Attachment: LUCENE-3973.patch I took the latest patch available and brought it up to current trunk. It'

[jira] [Updated] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-3973: -- Attachment: LUCENE-3973.patch Another attempt at the patch. Changes include: * Using a newer version of

[jira] [Commented] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309570#comment-14309570 ] Mike Drob commented on LUCENE-3973: --- You can run 'ant pmd' from inside of solr or lucen

[jira] [Commented] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309683#comment-14309683 ] Mike Drob commented on LUCENE-3973: --- I think having the task name tied to the implement

[jira] [Updated] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-3973: -- Attachment: LUCENE-3973.patch Sure, drop the precommit idea. I was just thinking out loud. Added a lin

[jira] [Commented] (LUCENE-3973) Incorporate PMD / FindBugs

2015-02-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311763#comment-14311763 ] Mike Drob commented on LUCENE-3973: --- bq. I'm just kind of curious how you envision PMD

[jira] [Created] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-09 Thread Mike Drob (JIRA)
Mike Drob created LUCENE-6232: - Summary: Replace ValueSource context Map with a more concrete data type Key: LUCENE-6232 URL: https://issues.apache.org/jira/browse/LUCENE-6232 Project: Lucene - Core

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313470#comment-14313470 ] Mike Drob commented on LUCENE-6232: --- What are our guarantees about backwards compatabil

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314468#comment-14314468 ] Mike Drob commented on LUCENE-6232: --- [~rjernst] - I saw that JIRA, but like the comment

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314471#comment-14314471 ] Mike Drob commented on LUCENE-6232: --- [~shebiki] - Leaving it non-final is probably fine

[jira] [Updated] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-6232: -- Attachment: LUCENE-6232.patch Attaching a patch that doesn't clean up all of the raw type warnings, but

[jira] [Updated] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-6232: -- Attachment: LUCENE-6232.patch New patch, updated to the current trunk. Previous one had some issues wit

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320667#comment-14320667 ] Mike Drob commented on LUCENE-6232: --- bq. It's called QueryContext since it seemed it co

[jira] [Updated] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-6232: -- Attachment: LUCENE-6232.patch Patch incorporating Yonic's feedback. > Replace ValueSource context Map

[jira] [Comment Edited] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320696#comment-14320696 ] Mike Drob edited comment on LUCENE-6232 at 2/13/15 8:28 PM: P

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

2015-02-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327925#comment-14327925 ] Mike Drob commented on LUCENE-6232: --- Ping. Has anybody had a chance to look at the late

[jira] [Commented] (SOLR-7134) Replication can still cause index corruption.

2015-02-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337423#comment-14337423 ] Mike Drob commented on SOLR-7134: - {code:title=RealTimeGetComponent.java} +} catch

[jira] [Commented] (SOLR-7134) Replication can still cause index corruption.

2015-02-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337757#comment-14337757 ] Mike Drob commented on SOLR-7134: - bq. Tests can last much too long if when we have no paus

[jira] [Commented] (SOLR-6944) ReplicationFactorTest and HttpPartitionTest both fail with org.apache.http.NoHttpResponseException: The target server failed to respond

2015-01-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292080#comment-14292080 ] Mike Drob commented on SOLR-6944: - [~erickerickson] - Committers on (any) Apache project ca

[jira] [Commented] (SOLR-6919) Log REST info before executing

2015-01-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295637#comment-14295637 ] Mike Drob commented on SOLR-6919: - [~gchanan] - Good question, I will figure out a way to t

[jira] [Updated] (SOLR-6919) Log REST info before executing

2015-01-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6919: Attachment: SOLR-6919.patch An example of the logging: {noformat} 2997 T13 C0 oasc.SolrCore.execute DEBUG [c

[jira] [Commented] (SOLR-6919) Log REST info before executing

2015-02-02 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302040#comment-14302040 ] Mike Drob commented on SOLR-6919: - bq. Checks that what we are matching against doesn't con

[jira] [Updated] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6919: Attachment: SOLR-6919.patch I checked out {IndexWriter}} and {{InfoStream}} and think it might be somewhat o

[jira] [Comment Edited] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303515#comment-14303515 ] Mike Drob edited comment on SOLR-6919 at 2/3/15 4:20 PM: - I checked

[jira] [Commented] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303536#comment-14303536 ] Mike Drob commented on SOLR-6919: - bq. Only other note on this topic is that if we do use a

[jira] [Commented] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303573#comment-14303573 ] Mike Drob commented on SOLR-6919: - Great, thanks. Comment made at https://cwiki.apache.org

[jira] [Updated] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6919: Attachment: SOLR-6919.patch Attaching a new patch that is built on top of the content that [~gchanan] alread

[jira] [Updated] (SOLR-6919) Log REST info before executing

2015-02-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6919: Attachment: SOLR-6919.patch bq. should the slow query log also go to the request log? I can see an argument m

[jira] [Created] (SOLR-7007) DistributedUpdateProcessor logs replay status as int instead of boolean

2015-01-20 Thread Mike Drob (JIRA)
Mike Drob created SOLR-7007: --- Summary: DistributedUpdateProcessor logs replay status as int instead of boolean Key: SOLR-7007 URL: https://issues.apache.org/jira/browse/SOLR-7007 Project: Solr Iss

[jira] [Updated] (SOLR-7007) DistributedUpdateProcessor logs replay status as int instead of boolean

2015-01-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-7007: Attachment: SOLR-7007.patch One-line patch to log as a boolean instead of an int. Applies cleanly to all bra

[jira] [Commented] (SOLR-6969) Just like we have to retry when the NameNode is in safemode on Solr startup, we also need to retry when opening a transaction log file for append when we get a RecoveryI

2015-01-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286485#comment-14286485 ] Mike Drob commented on SOLR-6969: - Is retrying always going to be safe? That works fine aft

[jira] [Created] (SOLR-6930) Provide "Circuit Breakers" For Expensive Solr Queries

2015-01-08 Thread Mike Drob (JIRA)
Mike Drob created SOLR-6930: --- Summary: Provide "Circuit Breakers" For Expensive Solr Queries Key: SOLR-6930 URL: https://issues.apache.org/jira/browse/SOLR-6930 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-6930) Provide "Circuit Breakers" For Expensive Solr Queries

2015-01-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269695#comment-14269695 ] Mike Drob commented on SOLR-6930: - The tricky part here is, of course, in estimating how mu

[jira] [Commented] (SOLR-6930) Provide "Circuit Breakers" For Expensive Solr Queries

2015-01-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269963#comment-14269963 ] Mike Drob commented on SOLR-6930: - [~hossman] - I think they started out the same, but that

[jira] [Commented] (SOLR-6930) Provide "Circuit Breakers" For Expensive Solr Queries

2015-01-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269968#comment-14269968 ] Mike Drob commented on SOLR-6930: - bq. I'm not a big fan of estimation and pre-emptive term

[jira] [Commented] (SOLR-6943) HdfsDirectoryFactory should fall back to system props for most of it's config if it is not found in solrconfig.xml.

2015-01-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274290#comment-14274290 ] Mike Drob commented on SOLR-6943: - My thoughts: {code:title=HdfsDirectoryFactory.java} +

[jira] [Commented] (SOLR-6969) Just like we have to retry when the NameNode is in safemode on Solr startup, we also need to retry when opening a transaction log file for append when we get a RecoveryI

2015-01-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276292#comment-14276292 ] Mike Drob commented on SOLR-6969: - Ignoring the error itself for a moment, the error messag

[jira] [Commented] (LUCENE-6153) randomize stored fields/vectors index blocksize

2014-12-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262297#comment-14262297 ] Mike Drob commented on LUCENE-6153: --- {code|title:CompressingStoredFieldsFormat.java} +

[jira] [Comment Edited] (LUCENE-6153) randomize stored fields/vectors index blocksize

2014-12-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262297#comment-14262297 ] Mike Drob edited comment on LUCENE-6153 at 12/31/14 4:52 PM: -

[jira] [Commented] (SOLR-6423) HdfsCollectionsAPIDistributedZkTest test fail: Could not find new collection awholynewcollection_1

2014-12-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262298#comment-14262298 ] Mike Drob commented on SOLR-6423: - There's work done against this issue, can it be resolved

[jira] [Commented] (LUCENE-6153) randomize stored fields/vectors index blocksize

2014-12-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262306#comment-14262306 ] Mike Drob commented on LUCENE-6153: --- A named constant would also mean that we don't hav

[jira] [Created] (SOLR-6919) Log REST info before executing

2015-01-06 Thread Mike Drob (JIRA)
Mike Drob created SOLR-6919: --- Summary: Log REST info before executing Key: SOLR-6919 URL: https://issues.apache.org/jira/browse/SOLR-6919 Project: Solr Issue Type: Improvement Components:

[jira] [Updated] (SOLR-6919) Log REST info before executing

2015-01-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-6919: Attachment: SOLR-6919.patch Patch based on trunk, but also applies cleanly to 5x and 4x > Log REST info befo

[jira] [Commented] (LUCENE-4335) Builds should regenerate all generated sources

2014-12-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238643#comment-14238643 ] Mike Drob commented on LUCENE-4335: --- I might be missing some of the more historical con

[jira] [Commented] (LUCENE-4335) Builds should regenerate all generated sources

2014-12-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238664#comment-14238664 ] Mike Drob commented on LUCENE-4335: --- Those are all good reasons! I would not submit a p

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068742#comment-15068742 ] Mike Drob commented on SOLR-8415: - bq. should take a path, like CLEAN Optional path or requ

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-23 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069844#comment-15069844 ] Mike Drob commented on SOLR-8415: - bq. Let's say you wanted to switch from secure setup old

[jira] [Commented] (SOLR-8575) Fix HDFSLogReader replay status numbers and a performance bug where we can reopen FSDataInputStream too often.

2016-01-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109639#comment-15109639 ] Mike Drob commented on SOLR-8575: - I had talked to [~andrew.wang] about this maybe a month

[jira] [Updated] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2016-01-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8415: Attachment: SOLR-8415.branch_5x.patch Attaching a {{--no-prefix}} patch for branch 5. > Provide command to s

[jira] [Created] (LUCENE-6993) Update TLDs to latest list

2016-01-25 Thread Mike Drob (JIRA)
Mike Drob created LUCENE-6993: - Summary: Update TLDs to latest list Key: LUCENE-6993 URL: https://issues.apache.org/jira/browse/LUCENE-6993 Project: Lucene - Core Issue Type: Improvement

[jira] [Updated] (LUCENE-6993) Update TLDs to latest list

2016-01-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-6993: -- Attachment: LUCENE-6993.patch Attaching a patch against trunk that updates the TLD Macro file and the

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2016-01-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121696#comment-15121696 ] Mike Drob commented on SOLR-8415: - What's the process for updating the Ref Guide? Should I

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2016-01-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122280#comment-15122280 ] Mike Drob commented on SOLR-8415: - Yes, that needs to be changed. Here's a fully updated se

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2016-01-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122344#comment-15122344 ] Mike Drob commented on SOLR-8415: - So it is. > Provide command to switch between non/secur

[jira] [Commented] (SOLR-8367) The new LIR 'all replicas participate' failsafe code needs to be improved.

2015-12-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047731#comment-15047731 ] Mike Drob commented on SOLR-8367: - SyncStrategy, the try-catch at line ~218 can go away. Do

[jira] [Commented] (SOLR-8378) Add upconfig and downconfig commands to the bin/solr script and managed-only schema to configsets

2015-12-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047835#comment-15047835 ] Mike Drob commented on SOLR-8378: - I think what Greg is suggesting is that there still be b

[jira] [Updated] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2015-12-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8392: Attachment: SOLR-8392.patch I'm not sure we can do that since updateTimeoutSecs is a class field. One reques

[jira] [Commented] (SOLR-8367) The new LIR 'all replicas participate' failsafe code needs to be improved.

2015-12-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049146#comment-15049146 ] Mike Drob commented on SOLR-8367: - bq. Since they are all fired off async, I don't know tha

[jira] [Commented] (SOLR-8368) A SolrCore needs to replay it's tlog before the leader election process.

2015-12-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049172#comment-15049172 ] Mike Drob commented on SOLR-8368: - Remove the TODO about doing replay before leader electio

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

2015-12-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049736#comment-15049736 ] Mike Drob commented on SOLR-8330: - This issue looks done - can we resolve it if there is no

[jira] [Resolved] (SOLR-8324) Logger Untanglement

2015-12-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-8324. - Resolution: Done Fix Version/s: (was: Trunk) Closing this out since it looks like all of the chi

[jira] [Created] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-14 Thread Mike Drob (JIRA)
Mike Drob created SOLR-8415: --- Summary: Provide command to switch between non/secure mode in ZK Key: SOLR-8415 URL: https://issues.apache.org/jira/browse/SOLR-8415 Project: Solr Issue Type: Improvem

[jira] [Updated] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8415: Attachment: SOLR-8415.patch Adding a {{patch -p0}} against trunk. Users can specify if they are setting or r

[jira] [Updated] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8415: Attachment: SOLR-8415.patch Attaching a new patch that includes some tests for converting both ways between

[jira] [Commented] (SOLR-8372) Canceled recovery can lead to data loss

2015-12-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060085#comment-15060085 ] Mike Drob commented on SOLR-8372: - Yonik - it looks like {{logReplayFinish}} is never used;

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062257#comment-15062257 ] Mike Drob commented on SOLR-8415: - Thanks Mark! That page looks reasonable. Proposed text,

[jira] [Commented] (SOLR-8415) Provide command to switch between non/secure mode in ZK

2015-12-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062382#comment-15062382 ] Mike Drob commented on SOLR-8415: - Also, we would add resetacl to https://cwiki.apache.org

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-09-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906959#comment-14906959 ] Mike Drob commented on SOLR-8075: - Patch LGTM. On commit, can you add a comment to {{waitF

[jira] [Created] (SOLR-8095) Allow disabling HDFS Locality Metrics

2015-09-24 Thread Mike Drob (JIRA)
Mike Drob created SOLR-8095: --- Summary: Allow disabling HDFS Locality Metrics Key: SOLR-8095 URL: https://issues.apache.org/jira/browse/SOLR-8095 Project: Solr Issue Type: Bug Components:

  1   2   3   4   5   6   7   >