[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-04-07 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r272887687 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1959,6 +1959,21 @@ public boolean isUsableForChildDocs()

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-31 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270683981 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -663,118 +661,36 @@ boolean

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-31 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270683816 ## File path: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java ## @@ -83,6 +86,17 @@ public static

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270067277 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -645,32 +660,126 @@ boolean

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270096287 ## File path: solr/core/src/test/org/apache/solr/update/processor/NestedAtomicUpdateTest.java ## @@ -0,0 +1,659 @@ +/* + * Licensed to

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270086512 ## File path: solr/core/src/test/org/apache/solr/cloud/NestedShardedAtomicUpdateTest.java ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270085155 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-block-atomic-update.xml ## @@ -0,0 +1,64 @@ + + + + + + +

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270092984 ## File path: solr/core/src/test/org/apache/solr/cloud/NestedShardedAtomicUpdateTest.java ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270092633 ## File path: solr/core/src/test/org/apache/solr/cloud/NestedShardedAtomicUpdateTest.java ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270078602 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -645,32 +660,126 @@ boolean

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270097963 ## File path: solr/solr-ref-guide/src/the-terms-component.adoc ## @@ -301,3 +301,5 @@ See the section <

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270075968 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -645,32 +660,126 @@ boolean

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-28 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270084153 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -1032,6 +1151,24 @@ protected

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-27 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269519745 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-block-atomic-update.xml ## @@ -0,0 +1,64 @@ + + + + + + +

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269404589 ## File path: solr/core/src/test-files/solr/collection1/conf/sharded-block-schema.xml ## @@ -0,0 +1,65 @@ + + + + + + + + + + +

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269404669 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-block-atomic-update.xml ## @@ -0,0 +1,64 @@ + + + + + + +

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269402083 ## File path: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java ## @@ -193,6 +194,10 @@ public static

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269405154 ## File path: solr/core/src/test/org/apache/solr/cloud/AtomicUpdateBlockShardedTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269405690 ## File path: solr/core/src/test/org/apache/solr/cloud/AtomicUpdateBlockShardedTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269404266 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -815,31 +871,7 @@ protected

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269403798 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java ## @@ -645,32 +660,78 @@ boolean