Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
login to application
â should display error message for invalid credentials
â should login for valid credentials
â should logout
metron-alerts App
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
+1
---
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
+ 1. Gret job. all pass
login to application
â should display error message for invalid credentials
â should login for valid credentials
â should logout
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/796
---
GitHub user iraghumitra reopened a pull request:
https://github.com/apache/metron/pull/803
Metron-1252: Build ui for grouping alerts into meta alerts
## Contributor Comments
The purpose of the PR is to provide GUI for grouping multiple alerts into a
meta alert, the rest api for
Github user iraghumitra closed the pull request at:
https://github.com/apache/metron/pull/803
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/811
+1 This was more challenging than meets the eye. Thanks for working
through this @justinleet . We have some use cases to figure out, but this is a
good first step toward metaalerts.
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r147152861
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -337,12 +343,67 @@ export class
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/811
+1 from me as well. Great job @justinleet
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/817
Hi @anandsubbu - Just a few issues that came to mind. These may or may not
be problems, so I just wanted to open them for discussion.
1. This will reinstall the same templates each time
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/811
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I had to force push the last merge since I was facing issues with github.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/817
The templates are installed from ansible right now for the vagrant builds.
Wouldn't we need to remove that step?
Have you tested full_dev ?
---
GitHub user anandsubbu opened a pull request:
https://github.com/apache/metron/pull/817
METRON-1283: Install Elasticsearch template as a part of the mpack startup
scripts
## Contributor Comments
For a Metron multi-node deployment using mpack, the Elasticsearch template
is
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147239180
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -218,6 +218,25 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147238667
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -249,6 +253,7 @@
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/812
+1
Ran up, Docs Home [Learn More] takes you to
https://metron.apache.org/current-book/index.html
---
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/818
METRON-1284: Remove extraneous dead query in ElasticsearchDao
## Contributor Comments
Delete a pointless query. Given that it's essentially just a noop (we
query ES and then do nothing with
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257285
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -218,6 +218,25 @@ public void
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147259905
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -218,6 +218,25 @@ public
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/801
+1 by inspection
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257082
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -249,6 +253,7 @@ identifier_operand :
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257992
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -249,6 +253,7 @@
23 matches
Mail list logo
