[GitHub] incubator-metron issue #374: METRON-587 Integration tests should use common ...

2016-11-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/374 Re-Run travis - build working locally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [DISCUSS] Replay Telemetry through Profiler

2016-11-29 Thread Matt Foley
+1 on the concept of a useful replay capability. Thoughts: 1. I agree with Otto’s observation that ML training has the same needs as you mention for Profiling, especially use cases #1 and #3, but also use case #2. 2. For use case #2, does it require (or at least significantly benefit from) a

[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/378 No objections- a caveat though. I was referring to the changes you made around the maven-jar-plugin, which now that I typed it I realize is a plugin, so please %s/dependency/plugin my

[GitHub] incubator-metron issue #377: METRON-595: ES Writer uses more than one IP

2016-11-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/377 I think you should >fetch apache && merge apache/master && push origin METRON-FOO --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] Modify Bylaws for veto clarification

2016-11-29 Thread Matt Foley
Forgive me, but this is text editing so I’m going to get editorial. A. In the current Bylaws, https://cwiki.apache.org/confluence/display/METRON/Apache+Metron+Bylaws , there are two paragraphs that might be affected by this change. The first is a bullet under “Voting”, which says: -1 – This

[GitHub] incubator-metron issue #377: METRON-595: ES Writer uses more than one IP

2016-11-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/377 Definitely seems to be some kind of sporadic failure with those integration tests. For now, close and reopen the PR and it would likely fix it. I created a JIRA to track the

Re: [DISCUSS] Replay Telemetry through Profiler

2016-11-29 Thread Otto Fowler
ON demand operations, as a general feature should be able to specify output as well as input. User wants to run one of or a set of parser | stellar | enrichment | profile | modeling on demand and output to HDFS | ZIP | INDEX | extendable On November 29, 2016 at 16:24:01, zeo...@gmail.com

Re: [DISCUSS] Coding Guidelines

2016-11-29 Thread Matt Foley
1. I think we need to emphasize good unit testing more. I guess METRON-37 integrated Cobertura with our build process, but how often does it run and where is JUnit code coverage reported? 2. Regarding the missing Code Style Guidelines, I’ve always thought the Hadoop Style guide was good:

Re: [DISCUSS] Modify Bylaws for veto clarification

2016-11-29 Thread Matt Foley
Regarding just the issue [C], voting for new committers and new PMC members: The old and now deprecated approach of having such votes be by “consensus approval”, where in fact any -1 was a veto, was intended by Apache for the sake of community harmony. However, it has been found by hard

[GitHub] incubator-metron issue #359: METRON-569: Change acking to prevent duplicate ...

2016-11-29 Thread DomenicPuzio
Github user DomenicPuzio commented on the issue: https://github.com/apache/incubator-metron/pull/359 Sorry for the delayed response, @cestella - I was taking some time off for the holiday. While I don't believe custom enrichment is pushing us over the timeout (we've clocked

[GitHub] incubator-metron pull request #374: METRON-587 Integration tests should use ...

2016-11-29 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/incubator-metron/pull/374 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-metron issue #377: METRON-595: ES Writer uses more than one IP

2016-11-29 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/incubator-metron/pull/377 @nickwallen somehow this fix failed a profiler test. can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron issue #377: METRON-595: ES Writer uses more than one IP

2016-11-29 Thread JonathanRider
Github user JonathanRider commented on the issue: https://github.com/apache/incubator-metron/pull/377 Looks like the build failed for a completely unrelated test. The latest commit in master fails the build on the same test. Should I wait until that is fixed and then merge

Re: [DISCUSS] Replay Telemetry through Profiler

2016-11-29 Thread zeo...@gmail.com
Regarding #4 - I would suggest that needs to be configurable. This would be useful if there was an issue with persisting and you wanted to replay to get data into the cluster - essentially a data load job. Also +1 to time shifting. On Tue, Nov 29, 2016 at 2:39 PM Matt Foley

[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/378 On the warning/failure deal, does [this](http://maven.apache.org/plugins/maven-dependency-plugin/examples/failing-the-build-on-dependency-analysis-warnings.html) do what you're looking

[GitHub] incubator-metron issue #373: METRON-591: Make the website in compliance with...

2016-11-29 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/incubator-metron/pull/373 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-metron pull request #378: METRON-596 Eliminate Maven warnings from...

2016-11-29 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/incubator-metron/pull/378 METRON-596 Eliminate Maven warnings from build Moving the maven-jar-plugin to a global variable and updating it. Removing a duplicate dependency that had both 'provided' and

[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/378 +1 (travis pending), glad to see the end of those. One small nit- if you find yourself doing wholesale dependency versioning, would you consider using the dependencyManagement

[GitHub] incubator-metron issue #365: METRON-565: apps/metron/enrichment/indexed dire...

2016-11-29 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/365 Yep, I'm +1, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[DISCUSS] Coding Guidelines

2016-11-29 Thread James Sirota
We have a really old (and incomplete) coding guidelines document that I'd like to clean up prior to our graduation. Does anyone have anything in particular they wanted to add/change about this document? Please post suggestions to this thread and I will incorporate them

[GitHub] incubator-metron pull request #374: METRON-587 Integration tests should use ...

2016-11-29 Thread ottobackwards
GitHub user ottobackwards reopened a pull request: https://github.com/apache/incubator-metron/pull/374 METRON-587 Integration tests should use common processor implementations where possible We have 7 or so integration tests that implement the Processor interface. Much of the code

[GitHub] incubator-metron issue #359: METRON-569: Change acking to prevent duplicate ...

2016-11-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/359 Yep, so my personal suggestion is to make sure that all messages get acked on a successful join by augmenting `streamMessageMap` and ensure that the cache refresh is *longer* than the

[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/378 On the dependency versioning, it is a good idea to use the dependencyManagement section, but I'd probably consider that cleanup out of scope for this ticket. I didn't want to start a

[GitHub] incubator-metron issue #366: METRON-576 Stellar function resolution takes to...

2016-11-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/366 Any other feedback guys? Just waiting on +1s if you guys are happy with the change. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-metron issue #366: METRON-576 Stellar function resolution takes to...

2016-11-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/366 +1 by inspection On Tue, Nov 29, 2016 at 08:49 Nick Allen wrote: > Any other feedback guys? Just waiting on +1s if you guys are happy with > the

[GitHub] incubator-metron pull request #366: METRON-576 Stellar function resolution t...

2016-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron pull request #376: METRON-593: Enable an automated static a...

2016-11-29 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/incubator-metron/pull/376 METRON-593: Enable an automated static analysis tool in the build Setup everything to use [Error Prone](http://errorprone.info/) with errors fixed and warnings on. This increases

[DISCUSS] Replay Telemetry through Profiler

2016-11-29 Thread Nick Allen
I would love any feedback from the community. Is this useful? How should this work? What use cases do you envision? What features do we need to support this? Feel free to respond in this thread or on the JIRA itself. METRON-594 The Profiler

[GitHub] incubator-metron pull request #377: METRON-595: ES Writer uses more than one...

2016-11-29 Thread JonathanRider
GitHub user JonathanRider opened a pull request: https://github.com/apache/incubator-metron/pull/377 METRON-595: ES Writer uses more than one IP Simple fix. Before, the client was reinitialzed for each ip, so only one was actually used. By initialing the client outside the loop, it

Re: [DISCUSS] Replay Telemetry through Profiler

2016-11-29 Thread Otto Fowler
I think these are valid cases, but that there is a more general ‘replay’ functionality with other cases as well. I would think that Metron may require a general replay story across those cases. * replay to MaaS much the same as you have here * replay of data for updated enrichment/triage/threat

[GitHub] incubator-metron issue #376: METRON-593: Enable an automated static analysis...

2016-11-29 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/376 Updated the root pom's maven-compiler-version to match what it was. Also noticed that the overridden versions in child poms tend to use 3.1. Does anyone know if that's intentional, or