Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
Okay, so I don't see anything requiring change. Thank you for the input On Thu, Dec 1, 2016 at 1:56 PM, Pierre Smits wrote: > Taher, > > For insights about what the load order in the special purpose folder is, > see the component-load.xml file in that folder. > For

Re: Some questions on plugin system

2016-12-01 Thread Pierre Smits
See also https://issues.apache.org/jira/browse/OFBIZ-8229 Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Thu, Dec 1, 2016 at 11:56 AM, Pierre Smits wrote: >

Re: Some questions on plugin system

2016-12-01 Thread Pierre Smits
Taher, For insights about what the load order in the special purpose folder is, see the component-load.xml file in that folder. For insights on where the dependencies exists, please visit the wiki page Jacques mentioned earlier and search the various open issues in JIRA about moving demo data

Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
Hi Pierre, What is the load order in /specialpurpose, what depends on what? Also what should we revisit about loadDefault and load readers? Taher Alkhateeb On Thu, Dec 1, 2016 at 1:31 PM, Pierre Smits wrote: > Taher, all, > > If we all are in favour to remove the

Re: Some questions on plugin system

2016-12-01 Thread Pierre Smits
Taher, all, If we all are in favour to remove the component-load .xml everywhere, and leave component dependencies to the list of components in then we need to revisit the gradle task 'loadDefault' too. Currently that task loads demo data by default (and that requires a specific load order). The

Re: Some questions on plugin system

2016-12-01 Thread Pierre Smits
For what it is worth: the component-load.xml file solely exists to facilitate how demo data is loaded. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Thu, Dec 1, 2016 at 11:08 AM,

Re: Some questions on plugin system

2016-12-01 Thread Jacques Le Roux
BTW I feel like repeating myself over and over :D, did not remember just stumbled upon it http://markmail.org/message/vax77ozzenxtw2ns Le 01/12/2016 à 10:56, Jacques Le Roux a écrit : That would be perfect. The link below could help (thanks to Ron) if we could verify/complete the

Re: Some questions on plugin system

2016-12-01 Thread Jacopo Cappellato
On Thu, Dec 1, 2016 at 10:35 AM, Taher Alkhateeb wrote: > [...] > So my suggestion to move forward in the plugin system is to: > - Rename /specialpurpose to /plugins > +1 > - remove /plugins/component-load.xml > +1 > - Refactor gradle to 1) not load a component

Re: Some questions on plugin system

2016-12-01 Thread Jacques Le Roux
That would be perfect. The link below could help (thanks to Ron) if we could verify/complete the specialpurpose interdependencies. I think there are none but not totally sure about that, we know about OFBIZ-6110 "Move as much as possible demo data from ecommerce to product or order components"

Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
Hello Everyone, After doing some refactoring on the core framework, I came to realize that we can make /specialpurpose behave like hot-deploy by simply deleting the component-load.xml. Instead, activating and deactivating the components can happen by going to an ofbiz-component.xml file and

Re: Some questions on plugin system

2016-11-23 Thread Nicolas Malin
Hello Taher, Your svn reorganization look fine, I just a doubt if in the future we arrive to separate the framework and application. And an other on all git connected on the current svn structure. After I'm in favor to continue the way, first on deploy plugin only by source and when we

Re: Some questions on plugin system

2016-09-28 Thread Taher Alkhateeb
Hello Everyone, Trying to move forward with our plugin system in OFBiz, I suggest the following changes: - Create a task called "pullPluginSource" which pulls an official Apache OFBiz plugin from a source repository (version control). This task serves specifically for developing plugins on Trunk

Re: Some questions on plugin system

2016-09-15 Thread Taher Alkhateeb
Thank you Jacopo, work is committed in r1760917 which mostly involves changes to the master build.gradle and README.md to describe the plugin system. On Thu, Sep 15, 2016 at 9:05 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Hi Taher, > > this is a follow up to the

Re: Some questions on plugin system

2016-09-15 Thread Jacopo Cappellato
Hi Taher, this is a follow up to the reviews and comments posted by me and others to the work you have contributed in OFBIZ-7972. Considering the feedback so far, and the minimal risk of side effects that your contribution may cause, I am asking you to commit your code to trunk: in this way it

Re: Some questions on plugin system

2016-09-13 Thread Taher Alkhateeb
Hello Folks, After quite a bit of work, I have a first working PoC for the plugin system with the following highlights: - Plugins are OFBiz components that reside in /specialpurpose (hopefully renamed to /plugins later) - Plugins can be published to maven repositories and retrieved from maven

Re: Some questions on plugin system

2016-09-09 Thread Jacques Le Roux
Le 09/09/2016 à 10:32, Jacopo Cappellato a écrit : On Thu, Sep 8, 2016 at 11:31 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... So it would be easier for us (OFBiz team) and contributors to deliver (at least free) plugins [...] The terms "us", "OFBiz team" and the distinction

Re: Some questions on plugin system

2016-09-09 Thread Taher Alkhateeb
Hi Jacques, Perhaps I did not emphasize this point so I'll try to make it clear: JitPack does not work! It creates jars from github projects which are not published. Therefore it does not fit as a complement to plugins which are just OFBiz components. If you want to use the latest version of a

Re: Some questions on plugin system

2016-09-09 Thread Jacopo Cappellato
On Thu, Sep 8, 2016 at 11:31 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > So it would be easier for us (OFBiz team) and contributors to deliver (at > least free) plugins [...] The terms "us", "OFBiz team" and the distinction with "contributors" don't make much sense to me

Re: Some questions on plugin system

2016-09-08 Thread Jacques Le Roux
Taher, inline... Le 09/09/2016 à 05:40, Taher Alkhateeb a écrit : Hi Jacques, JitPack is indeed a nice service and plugin. However I think it might not be a good fit for the plugin system because: - You're mixing up jar dependencies with components. OFBiz components are not jars and do not

Re: Some questions on plugin system

2016-09-08 Thread Taher Alkhateeb
Hi Jacques, JitPack is indeed a nice service and plugin. However I think it might not be a good fit for the plugin system because: - You're mixing up jar dependencies with components. OFBiz components are not jars and do not require pre-compilation. The primary purpose of JitPack is to build

Re: Some questions on plugin system

2016-09-08 Thread Jacques Le Roux
Hi Taher, While working on notsoserial, I got an idea about using JitPack in conjunction with GitHub for OFBiz-Gradle plugins. JitPack has a MIT license and allows to freely use standard GitHub repositories (like https://github.com/apache/ofbiz)*. * When you use JitPackyou don't download jars

Re: Some questions on plugin system

2016-08-30 Thread Nicolas Malin
Hi Taher Le 28/08/2016 à 18:41, Taher Alkhateeb a écrit : Hi Everyone, I am very happy to announce that after a lot of research I finally have a little working PoC solution for the OFBiz plugin system. I believe this system is very simple yet very powerful with the following simple API tasks

Re: Some questions on plugin system

2016-08-29 Thread Taher Alkhateeb
Yup sure, I'll fine tune some issues and upload a patch just as was done in Gradle. Wanted initial feedback first on the idea. On Aug 29, 2016 10:10 AM, "Pierre Smits" wrote: > Hi Taher, > > Like I said earlier: I need to be able to see it working. Could you upload >

Re: Some questions on plugin system

2016-08-29 Thread Pierre Smits
Hi Taher, Like I said earlier: I need to be able to see it working. Could you upload your solution as a patch to the issue you created earlier? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace

Re: Some questions on plugin system

2016-08-29 Thread Taher Alkhateeb
Hi Pierre, - The system can and does work with zip and tar.gz and normal folders. - The maven repo provides everything we need especially dependency management. I think upgrading from from your solution to the one I suggested below might be difficult once an ecosystem builds around the plug-in

Re: Some questions on plugin system

2016-08-29 Thread Pierre Smits
This solutions must be able to work with: - zip files - tar files and other zip variants (tar.gz, etc) - folder structures. That will enable the adopter to use local storage, but also releases stored in GitHub or even svn repos. At the moment I see the use of maven repos as overkill,

Re: Some questions on plugin system

2016-08-28 Thread Taher Alkhateeb
Hi Everyone, I am very happy to announce that after a lot of research I finally have a little working PoC solution for the OFBiz plugin system. I believe this system is very simple yet very powerful with the following simple API tasks 1- ./gradlew createPlugin: creates a plugin from templates 2-

Re: Some questions on plugin system

2016-08-26 Thread Jacques Le Roux
Le 25/08/2016 à 16:39, Taher Alkhateeb a écrit : Hello Everyone, I need some opinions for a PoC that I'm working on for the plugin system (OFBIZ-7972) and appreciate your help: repository design -- I am thinking of just having a very simple web server denoted as a