jlolling commented on PR #528:
URL: https://github.com/apache/poi/pull/528#issuecomment-1752888018
I will remove my name and set the ticket number instead. OK?
> On 9. Oct 2023, at 14:06, PJ Fanning ***@***.***> wrote:
>
>
> @pjfanning commented on this pull request.
>
pjfanning commented on code in PR #528:
URL: https://github.com/apache/poi/pull/528#discussion_r1350219068
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -191,8 +192,13 @@ public void removeRow(Row row) {
* @return Row representing the
jlolling commented on PR #528:
URL: https://github.com/apache/poi/pull/528#issuecomment-1752859725
I have not “randomly” changed code. I have started from a code some weeks
earlier. I will rebase my branch and continue.
> On 9. Oct 2023, at 13:44, PJ Fanning ***@***.***> wrote:
>
jlolling commented on PR #528:
URL: https://github.com/apache/poi/pull/528#issuecomment-1752856333
I will try to add a test case
I will also fix the typos but they are not caused by me.
> On 9. Oct 2023, at 13:43, PJ Fanning ***@***.***> wrote:
>
>
> @pjfanning requested
pjfanning commented on code in PR #528:
URL: https://github.com/apache/poi/pull/528#discussion_r1350196110
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -61,11 +62,7 @@ protected SXSSFSheet(SXSSFWorkbook workbook, XSSFSheet
xSheet, int
pjfanning commented on code in PR #528:
URL: https://github.com/apache/poi/pull/528#discussion_r1350194065
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1240,11 +1247,11 @@ public void setColumnGroupCollapsed(int columnNumber,
boolean
jlolling closed pull request #528: Allow append rows in Streaming workbook
URL: https://github.com/apache/poi/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
