Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112400291
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool UnionA
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112401278
--- Diff: relational_operators/UnionAllOperator.hpp ---
@@ -149,6 +151,11 @@ class UnionAllOperator : public RelationalOperator {
I have a PR out for a CLI which interfaces with the network over gRPC [1].
Julian recommended using a package called Avantica which wraps over a
standard JDBC+ODBC drivers and takes care the protocol.
The question I have for /dev is if we have a need right now for a standard
driver. I could see a
Thanks for bringing this up for discussion, Marc.
If you have any questions about Avatica (which is part of the Calcite project,
but may be spun off as a top-level project at some point in the future), I and
Josh Elser will be happy to answer them.
Julian
> On Apr 20, 2017, at 9:03 AM, Marc S
Long time, no talk, Marc. I should've just stayed subscribed to the list
after your last release concluded :)
FWIW, I'm hoping to rip out the transport "guts" of Avatica at some
point to be able to plug in gRPC (or similar "hot-ness"). Right now,
we're fairly well tied to Jetty server-side and
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407047
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407627
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406128
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407163
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406932
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411238
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407922
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405717
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112410750
--- Diff: cli/Flags.hpp ---
@@ -45,6 +45,8 @@ DECLARE_string(storage_path);
DECLARE_bool(preload_buffer_pool);
+DECLARE_int32(p
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112408163
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407440
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548387
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406197
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406425
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404491
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,18 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should also set --buffer
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404137
--- Diff: cli/CMakeLists.txt ---
@@ -150,6 +189,34 @@ if(USE_LINENOISE)
else()
target_link_libraries(quickstep_cli_LineReader
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405059
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549264
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112550617
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112403533
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option(ENABLE_NETWORK_C
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411604
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404840
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112413621
--- Diff: cli/tests/CMakeLists.txt ---
@@ -32,6 +32,17 @@ if (ENABLE_DISTRIBUTED)
"${PROJECT_SOURCE_DIR}/utility/textbased_te
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417113
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417078
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548566
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112414736
--- Diff: cli/CMakeLists.txt ---
@@ -39,18 +38,39 @@ if (ENABLE_GOOGLE_PROFILER)
set(QUICKSTEP_ENABLE_GOOGLE_PROFILER TRUE)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112416384
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547038
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417791
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417374
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417941
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548998
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112418012
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547359
--- Diff: cli/QuickstepCli.cpp ---
@@ -28,26 +28,23 @@
#include
#include
-#include "cli/CliConfig.h" // For QUICKSTEP_USE_LIN
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417234
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547224
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112409077
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548112
--- Diff: cli/tests/CMakeLists.txt ---
@@ -90,3 +101,18 @@ if (ENABLE_DISTRIBUTED)
${GFLAGS_LIB_NAME}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549890
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549415
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112414574
--- Diff: CMakeLists.txt ---
@@ -792,3 +797,14 @@ if (ENABLE_DISTRIBUTED)
${GFLAGS_LIB_NAME}
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/234
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/234
@Terranlee Unfortunately, I observed some non-deterministic results for the
following two queries in
`quickstep_queryoptimizer_tests_executiongenerator_select_distributed`.
So I su
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/236
WorkOrder proto clean-up.
This small PR sorts the `WorkOrder` in the alphabet order.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zu
51 matches
Mail list logo