Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review167669 --- Ship it! Ship It! - Colm O hEigeartaigh On March 1, 2017, 9:03 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated March 1, 2017, 9:03 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > b959f97 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/56654/diff/4/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/ --- (Updated March 1, 2017, 9:03 a.m.) Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1348 https://issues.apache.org/jira/browse/RANGER-1348 Repository: ranger Description --- Autocompletion not working properly Resource Autocompletion fuction I have submit the patch please review it. Diffs (updated) - plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java ba4d263 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java b959f97 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java 84e24c5 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java 93b2662 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java PRE-CREATION Diff: https://reviews.apache.org/r/56654/diff/4/ Changes: https://reviews.apache.org/r/56654/diff/3-4/ Testing --- Tested it Thanks, Qiang Zhang
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On Feb. 20, 2017, 9:46 a.m., Colm O hEigeartaigh wrote:
> > Thanks for making the changes. Could you update the patch to the latest
> > master, it doesn't apply as there was a change to AtlasClient. The other
> > change I'd like to see is that there is still a "atlasResourceParamter"
> > (instead of atlasResourceParameter) in AtlasResourceMgr.
>
> Colm O hEigeartaigh wrote:
> *bump* Please address my last comment and I'll review again with a view
> to merging the fix.
>
> Qiang Zhang wrote:
> Ok. I will update the patch after carefully tested and verified. Thanks!
I had modified code according to your review after updated lasted source from
ranger github repository. Other contributor modified related class
file.(https://github.com/apache/ranger/blob/master/plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java).
I modified records as following:
a) AtlasResourceMgr: There are no spaces around "=" here:
"atlasResourceName=context.getResourceName();" Modified.
b) AtlasResourceMgr: Change "atlasResourceParamter" to "atlasResourceParameter
Modified.
c) AtlasResourceMgr: There is an indentation problem in getAtlasResource()
Modified.
d) Are the changes to RangerAtlasAuthorizer + RangerAtlasResource required? We
should limit whitespace fixing just to classes that are being changed as part
of the commit. Modified.
e) AtlasClient: Missing space after = "this.statusUrl =atlasUrl +
ATLAS_STATUS_API_ENDPOINT;" Modified.
f) AtlasClient: Change this to 'username': LOG.error("No value found for
configuration 'usename'. Modified.
g) AtlasClient: Indentation wrong on line 315 "return lret;" Modified.
h) AtlasClient: Indentation wrong in the try block: lines 121 -> 135 Modified.
i) AtlasClient: getStatusResponse() method should be private Modified.
Please review the lasted patch. Thanks.
- Qiang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56654/#review166073
---
On March 1, 2017, 9:03 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56654/
> ---
>
> (Updated March 1, 2017, 9:03 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh,
> Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1348
> https://issues.apache.org/jira/browse/RANGER-1348
>
>
> Repository: ranger
>
>
> Description
> ---
>
> Autocompletion not working properly Resource Autocompletion fuction I have
> submit the patch please review it.
>
>
> Diffs
> -
>
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
> ba4d263
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
> b959f97
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java
> 84e24c5
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java
> 93b2662
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/56654/diff/4/
>
>
> Testing
> ---
>
> Tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On 二月 20, 2017, 9:46 a.m., Colm O hEigeartaigh wrote: > > Thanks for making the changes. Could you update the patch to the latest > > master, it doesn't apply as there was a change to AtlasClient. The other > > change I'd like to see is that there is still a "atlasResourceParamter" > > (instead of atlasResourceParameter) in AtlasResourceMgr. > > Colm O hEigeartaigh wrote: > *bump* Please address my last comment and I'll review again with a view > to merging the fix. Ok. I will update the patch after carefully tested and verified. Thanks! - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review166073 --- On 二月 18, 2017, 6:44 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated 二月 18, 2017, 6:44 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On Feb. 20, 2017, 9:46 a.m., Colm O hEigeartaigh wrote: > > Thanks for making the changes. Could you update the patch to the latest > > master, it doesn't apply as there was a change to AtlasClient. The other > > change I'd like to see is that there is still a "atlasResourceParamter" > > (instead of atlasResourceParameter) in AtlasResourceMgr. *bump* Please address my last comment and I'll review again with a view to merging the fix. - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review166073 --- On Feb. 18, 2017, 6:44 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 18, 2017, 6:44 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review166073 --- Thanks for making the changes. Could you update the patch to the latest master, it doesn't apply as there was a change to AtlasClient. The other change I'd like to see is that there is still a "atlasResourceParamter" (instead of atlasResourceParameter) in AtlasResourceMgr. - Colm O hEigeartaigh On Feb. 18, 2017, 6:44 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 18, 2017, 6:44 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/ --- (Updated 二月 18, 2017, 6:44 a.m.) Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Changes --- Modify the code format and spelling Bugs: RANGER-1348 https://issues.apache.org/jira/browse/RANGER-1348 Repository: ranger Description --- Autocompletion not working properly Resource Autocompletion fuction I have submit the patch please review it. Diffs (updated) - plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java ba4d263 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java 4f90469 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java 84e24c5 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java 93b2662 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java PRE-CREATION Diff: https://reviews.apache.org/r/56654/diff/ Testing --- Tested it Thanks, Qiang Zhang
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On 二月 17, 2017, 11:29 a.m., Colm O hEigeartaigh wrote:
> > Thanks for making the changes! There are still some more changes I'd like
> > to see however:
> >
> > a) AtlasResourceMgr: There are no spaces around "=" here:
> > "atlasResourceName=context.getResourceName();"
> > b) AtlasResourceMgr: Change "atlasResourceParamter" to
> > "atlasResourceParameter
> > c) AtlasResourceMgr: There is an indentation problem in getAtlasResource()
> > d) Are the changes to RangerAtlasAuthorizer + RangerAtlasResource required?
> > We should limit whitespace fixing just to classes that are being changed as
> > part of the commit.
> > e) AtlasClient: Missing space after = "this.statusUrl =atlasUrl +
> > ATLAS_STATUS_API_ENDPOINT;"
> > f) AtlasClient: Change this to 'username': LOG.error("No value found for
> > configuration 'usename'.
> > g) AtlasClient: Indentation wrong on line 315 "return lret;"
> > h) AtlasClient: Indentation wrong in the try block: lines 121 -> 135
> > i) AtlasClient: getStatusResponse() method should be private
Hi Thanks for you help .I have change my code template , According to your
opinion to alter nonstandard code, Please review again.
- Qiang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56654/#review165925
---
On 二月 17, 2017, 4:58 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56654/
> ---
>
> (Updated 二月 17, 2017, 4:58 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh,
> Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1348
> https://issues.apache.org/jira/browse/RANGER-1348
>
>
> Repository: ranger
>
>
> Description
> ---
>
> Autocompletion not working properly Resource Autocompletion fuction I have
> submit the patch please review it.
>
>
> Diffs
> -
>
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java
> 2038645
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java
> f056f3e
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
> ba4d263
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
> 4f90469
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java
> 84e24c5
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java
> 93b2662
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56654/diff/
>
>
> Testing
> ---
>
> Tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56654/#review165925
---
Thanks for making the changes! There are still some more changes I'd like to
see however:
a) AtlasResourceMgr: There are no spaces around "=" here:
"atlasResourceName=context.getResourceName();"
b) AtlasResourceMgr: Change "atlasResourceParamter" to "atlasResourceParameter
c) AtlasResourceMgr: There is an indentation problem in getAtlasResource()
d) Are the changes to RangerAtlasAuthorizer + RangerAtlasResource required? We
should limit whitespace fixing just to classes that are being changed as part
of the commit.
e) AtlasClient: Missing space after = "this.statusUrl =atlasUrl +
ATLAS_STATUS_API_ENDPOINT;"
f) AtlasClient: Change this to 'username': LOG.error("No value found for
configuration 'usename'.
g) AtlasClient: Indentation wrong on line 315 "return lret;"
h) AtlasClient: Indentation wrong in the try block: lines 121 -> 135
i) AtlasClient: getStatusResponse() method should be private
- Colm O hEigeartaigh
On Feb. 17, 2017, 4:58 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56654/
> ---
>
> (Updated Feb. 17, 2017, 4:58 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh,
> Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1348
> https://issues.apache.org/jira/browse/RANGER-1348
>
>
> Repository: ranger
>
>
> Description
> ---
>
> Autocompletion not working properly Resource Autocompletion fuction I have
> submit the patch please review it.
>
>
> Diffs
> -
>
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java
> 2038645
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java
> f056f3e
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
> ba4d263
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
> 4f90469
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java
> 84e24c5
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java
> 93b2662
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java
> PRE-CREATION
>
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56654/diff/
>
>
> Testing
> ---
>
> Tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On 二月 16, 2017, 4:14 p.m., Colm O hEigeartaigh wrote: > > Some general comments on the patch: > > > > a) Please make sure there is a single space either side of a "=" or "!=" or > > after a ",". It makes the code more readable and consistent. > > b) Change the Logger in AtlasResourceMgr from public to private > > c) "Paramter" appears in the code in a few places, it should be "Parameter". > > d) The indentation of Results class is not right in > > ResourceOperationResponse > > e) In AtlasClient, I think you could have a single method to create a > > Client, rather than creating one for each of the resources. Thank you for your advice,I have revised according to your advice, Please review again! - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165866 --- On 二月 17, 2017, 4:58 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated 二月 17, 2017, 4:58 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > 2038645 > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java > f056f3e > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/ --- (Updated 二月 17, 2017, 4:58 a.m.) Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Changes --- 1. Add a single space either side of a "=" or "!=" or after a ",". 2. Change the Logger in AtlasResourceMgr from public to private 3. Alter"Paramter" to "Parameter". 4. Formated ResourceOperationResponse class 5. In AtlasClient Only create one Client in getResourceList(final String resourceNameMatching, final String atlasResourceParameter, final List existingResourceList) Bugs: RANGER-1348 https://issues.apache.org/jira/browse/RANGER-1348 Repository: ranger Description --- Autocompletion not working properly Resource Autocompletion fuction I have submit the patch please review it. Diffs (updated) - plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 2038645 plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java f056f3e plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java ba4d263 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java 4f90469 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java 84e24c5 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java 93b2662 plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java PRE-CREATION Diff: https://reviews.apache.org/r/56654/diff/ Testing --- Tested it Thanks, Qiang Zhang
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165866 --- Some general comments on the patch: a) Please make sure there is a single space either side of a "=" or "!=" or after a ",". It makes the code more readable and consistent. b) Change the Logger in AtlasResourceMgr from public to private c) "Paramter" appears in the code in a few places, it should be "Parameter". d) The indentation of Results class is not right in ResourceOperationResponse e) In AtlasClient, I think you could have a single method to create a Client, rather than creating one for each of the resources. - Colm O hEigeartaigh On Feb. 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On Feb. 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)? > > Qiang Zhang wrote: > Hi, thanks for review . Because this is the development of new functions, > reuse part testconnection function code, so the code change is more, reuse > some code and reconstruction so modify the methods and properties. > > 2.1.RangerServiceAtlas.java > 1).Formatted code,Remove the TAB key is invalid > 2).alter " ret = > AtlasResourceMgr.getAtlasTermResources(serviceName,configs,context);" to "ret > = AtlasResourceMgr.getAtlasResources(serviceName, configs,context);" > > > 2.AtlasClient.java > 1) Increasing access to the resource of the atlas API url > 2) In many places alter Alter the term attribute to the > resourcebecause term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) > > 3).alter "getTermList( String termNameMatching, List > existingTermList)" to "getResourceList(final String > resourceNameMatching,final String atlasResourceParamter,final List > existingResourceList)" According to the type selection method of access > to resources > > 4).add alter connectionTestResource(final String > resourceNameMatching,final String atlasResourceParamter,List > existingResourceList)--Testconnection function method > getTypeResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)-Access to type > resources > > 5).add public List getEntityResource(final String > resourceNameMatching,final String atlasResourceParamter,List > existingResourceList)-Access to Entity resources > > 6).add getTermResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)-Access to Term > resources > > 7).add getTaxonomyResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)Access to > Taxonomy resources > > 8).add getOperationResource(final String resourceNameMatching,final > String atlasResourceParamter,List existingResourceList)Access to > Operation resources > > > 3.AtlasResourceMgr.java > 1).alter "getAtlasTermResources(String serviceName, Map > configs,ResourceLookupContext context)" to "getAtlasResources(String > serviceName, Map configs,ResourceLookupContext context)" > because term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) . and alter "atlasTermList" to > "atlasResourceList" > > 2). alter "public static List getAtlasTermResource(String > serviceName, Map configs, String atlasTermName, List > atlasTermList)" to "getAtlasResource(String serviceName, Map > configs, String atlasResourceName, String atlasResourceParamter,List > atlasResourceList)" because term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) > > > 4.ResourceEntityResponse.java > add ResourceEntityResponse class for Convert json string to > object(EntityResource) > > 5.ResourceOperationResponse.java > add ResourceOperationResponse class for Convert json string to > object(OperationResource) > > 6.ResourceTaxonomyResponse.java > add ResourceTaxonomyResponse class for Convert json string to > object(TaxonomyResource) > > 7.ResourceTermResponse.java > add ResourceTermResponse class for Convert json string to > object(TermResource) > > 8.ResourceTypeResponse.java > add ResourceTypeResponse class for Convert json string to > object(TypeResource) > > Colm O hEigeartaigh wrote: > What version of Atlas did you test against by the way? I tried the patch > yesterday against 0.8.0-SNAPSHOT and it didn't seem to work, unless I was > doing something wrong. Disregard my previous comment. I tested it against Atlas 0.7.1 and it is working fine. - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165680 --- On Feb. 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ran
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On Feb. 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)? > > Qiang Zhang wrote: > Hi, thanks for review . Because this is the development of new functions, > reuse part testconnection function code, so the code change is more, reuse > some code and reconstruction so modify the methods and properties. > > 2.1.RangerServiceAtlas.java > 1).Formatted code,Remove the TAB key is invalid > 2).alter " ret = > AtlasResourceMgr.getAtlasTermResources(serviceName,configs,context);" to "ret > = AtlasResourceMgr.getAtlasResources(serviceName, configs,context);" > > > 2.AtlasClient.java > 1) Increasing access to the resource of the atlas API url > 2) In many places alter Alter the term attribute to the > resourcebecause term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) > > 3).alter "getTermList( String termNameMatching, List > existingTermList)" to "getResourceList(final String > resourceNameMatching,final String atlasResourceParamter,final List > existingResourceList)" According to the type selection method of access > to resources > > 4).add alter connectionTestResource(final String > resourceNameMatching,final String atlasResourceParamter,List > existingResourceList)--Testconnection function method > getTypeResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)-Access to type > resources > > 5).add public List getEntityResource(final String > resourceNameMatching,final String atlasResourceParamter,List > existingResourceList)-Access to Entity resources > > 6).add getTermResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)-Access to Term > resources > > 7).add getTaxonomyResource(final String resourceNameMatching,final String > atlasResourceParamter,List existingResourceList)Access to > Taxonomy resources > > 8).add getOperationResource(final String resourceNameMatching,final > String atlasResourceParamter,List existingResourceList)Access to > Operation resources > > > 3.AtlasResourceMgr.java > 1).alter "getAtlasTermResources(String serviceName, Map > configs,ResourceLookupContext context)" to "getAtlasResources(String > serviceName, Map configs,ResourceLookupContext context)" > because term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) . and alter "atlasTermList" to > "atlasResourceList" > > 2). alter "public static List getAtlasTermResource(String > serviceName, Map configs, String atlasTermName, List > atlasTermList)" to "getAtlasResource(String serviceName, Map > configs, String atlasResourceName, String atlasResourceParamter,List > atlasResourceList)" because term is one of the types of resouce .Resource > contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) > > > 4.ResourceEntityResponse.java > add ResourceEntityResponse class for Convert json string to > object(EntityResource) > > 5.ResourceOperationResponse.java > add ResourceOperationResponse class for Convert json string to > object(OperationResource) > > 6.ResourceTaxonomyResponse.java > add ResourceTaxonomyResponse class for Convert json string to > object(TaxonomyResource) > > 7.ResourceTermResponse.java > add ResourceTermResponse class for Convert json string to > object(TermResource) > > 8.ResourceTypeResponse.java > add ResourceTypeResponse class for Convert json string to > object(TypeResource) What version of Atlas did you test against by the way? I tried the patch yesterday against 0.8.0-SNAPSHOT and it didn't seem to work, unless I was doing something wrong. - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165680 --- On Feb. 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the pa
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
> On 二月 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)? Hi, thanks for review . Because this is the development of new functions, reuse part testconnection function code, so the code change is more, reuse some code and reconstruction so modify the methods and properties. 2.1.RangerServiceAtlas.java 1).Formatted code,Remove the TAB key is invalid 2).alter " ret = AtlasResourceMgr.getAtlasTermResources(serviceName,configs,context);" to "ret = AtlasResourceMgr.getAtlasResources(serviceName, configs,context);" 2.AtlasClient.java 1) Increasing access to the resource of the atlas API url 2) In many places alter Alter the term attribute to the resourcebecause term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) 3).alter "getTermList( String termNameMatching, List existingTermList)" to "getResourceList(final String resourceNameMatching,final String atlasResourceParamter,final List existingResourceList)" According to the type selection method of access to resources 4).add alter connectionTestResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)--Testconnection function method getTypeResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)-Access to type resources 5).add public List getEntityResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)-Access to Entity resources 6).add getTermResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)-Access to Term resources 7).add getTaxonomyResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)Access to Taxonomy resources 8).add getOperationResource(final String resourceNameMatching,final String atlasResourceParamter,List existingResourceList)Access to Operation resources 3.AtlasResourceMgr.java 1).alter "getAtlasTermResources(String serviceName, Map configs,ResourceLookupContext context)" to "getAtlasResources(String serviceName, Map configs,ResourceLookupContext context)" because term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) . and alter "atlasTermList" to "atlasResourceList" 2). alter "public static List getAtlasTermResource(String serviceName, Map configs, String atlasTermName, List atlasTermList)" to "getAtlasResource(String serviceName, Map configs, String atlasResourceName, String atlasResourceParamter,List atlasResourceList)" because term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) 4.ResourceEntityResponse.java add ResourceEntityResponse class for Convert json string to object(EntityResource) 5.ResourceOperationResponse.java add ResourceOperationResponse class for Convert json string to object(OperationResource) 6.ResourceTaxonomyResponse.java add ResourceTaxonomyResponse class for Convert json string to object(TaxonomyResource) 7.ResourceTermResponse.java add ResourceTermResponse class for Convert json string to object(TermResource) 8.ResourceTypeResponse.java add ResourceTypeResponse class for Convert json string to object(TypeResource) - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165680 --- On 二月 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated 二月 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model
Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165680 --- Thanks for the patch! Could you strip out the indentation changes as it's difficult to see what the changes are in some of the files (e.g. are there changes in RangerServiceAtlas.java)? - Colm O hEigeartaigh On Feb. 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > --- > > (Updated Feb. 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > --- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > --- > > Tested it > > > Thanks, > > Qiang Zhang > >
