Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-19 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/#review185650
---


Ship it!




Ship It!

- Ramesh Mani


On Sept. 15, 2017, 10:17 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61553/
> ---
> 
> (Updated Sept. 15, 2017, 10:17 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1730
> https://issues.apache.org/jira/browse/RANGER-1730
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Actual :
> Provide utility to list user according to role.
> 
> Expected :
> Utility to list users for the given role based on thier authorization
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   
> security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   src/main/assembly/admin-web.xml cb1aad2 
> 
> 
> Diff: https://reviews.apache.org/r/61553/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on Simple against all roles
> Tested on Secure against all roles
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-18 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/#review185568
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 15, 2017, 10:17 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61553/
> ---
> 
> (Updated Sept. 15, 2017, 10:17 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1730
> https://issues.apache.org/jira/browse/RANGER-1730
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Actual :
> Provide utility to list user according to role.
> 
> Expected :
> Utility to list users for the given role based on thier authorization
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   
> security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   src/main/assembly/admin-web.xml cb1aad2 
> 
> 
> Diff: https://reviews.apache.org/r/61553/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on Simple against all roles
> Tested on Secure against all roles
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-15 Thread Fatima Khan 


> On Sept. 14, 2017, 6:12 a.m., Ramesh Mani wrote:
> > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
> > Lines 217 (patched)
> > 
> >
> > if UserRole is going to be not null 
> > do UserRole.equalsIgnoreCase(existingRole.get(0)). Verify similar check 
> > and correct it where ever needed.

userRole is a utility parameter and it can be null. In the main method, i have 
checked it against not null and the flow is different for null and not null. 
UserRole.equalsIgnoreCase(existingRole.get(0)) will execute only when userRole 
is not null.


- Fatima


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/#review185372
---


On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61553/
> ---
> 
> (Updated Sept. 14, 2017, 4:33 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1730
> https://issues.apache.org/jira/browse/RANGER-1730
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Actual :
> Provide utility to list user according to role.
> 
> Expected :
> Utility to list users for the given role based on thier authorization
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   
> security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   src/main/assembly/admin-web.xml cb1aad2 
> 
> 
> Diff: https://reviews.apache.org/r/61553/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on Simple against all roles
> Tested on Secure against all roles
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-15 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/
---

(Updated Sept. 15, 2017, 10:17 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1730
https://issues.apache.org/jira/browse/RANGER-1730


Repository: ranger


Description
---

Actual :
Provide utility to list user according to role.

Expected :
Utility to list users for the given role based on thier authorization


Diffs (updated)
-

  security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
 PRE-CREATION 
  
security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
 PRE-CREATION 
  src/main/assembly/admin-web.xml cb1aad2 


Diff: https://reviews.apache.org/r/61553/diff/4/

Changes: https://reviews.apache.org/r/61553/diff/3-4/


Testing
---

Tested on Simple against all roles
Tested on Secure against all roles


Thanks,

Fatima Khan

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-14 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/#review185372
---




security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 63 (patched)


name variables as userRole. Follow this pattern



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 133 (patched)


Please Indent the methods to start at same position, check all the methods



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 141 (patched)


Please use Apache CollectionUtils.isEmpty() if possible. Check all the 
other occurances of other similar checks



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 206 (patched)


Please check if currentEncryptedPassword can be null?



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 209 (patched)


can existingRole be null? Please verify



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 217 (patched)


if UserRole is going to be not null 
do UserRole.equalsIgnoreCase(existingRole.get(0)). Verify similar check and 
correct it where ever needed.



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 242 (patched)


Change this flag variable to "isUserAuthorized"



security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
Lines 247 (patched)


Authorized?


- Ramesh Mani


On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61553/
> ---
> 
> (Updated Sept. 14, 2017, 4:33 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1730
> https://issues.apache.org/jira/browse/RANGER-1730
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Actual :
> Provide utility to list user according to role.
> 
> Expected :
> Utility to list users for the given role based on thier authorization
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   
> security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
>  PRE-CREATION 
>   src/main/assembly/admin-web.xml cb1aad2 
> 
> 
> Diff: https://reviews.apache.org/r/61553/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on Simple against all roles
> Tested on Secure against all roles
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-13 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/
---

(Updated Sept. 14, 2017, 4:33 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1730
https://issues.apache.org/jira/browse/RANGER-1730


Repository: ranger


Description
---

Actual :
Provide utility to list user according to role.

Expected :
Utility to list users for the given role based on thier authorization


Diffs (updated)
-

  security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
 PRE-CREATION 
  
security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
 PRE-CREATION 
  src/main/assembly/admin-web.xml cb1aad2 


Diff: https://reviews.apache.org/r/61553/diff/3/

Changes: https://reviews.apache.org/r/61553/diff/2-3/


Testing
---

Tested on Simple against all roles
Tested on Secure against all roles


Thanks,

Fatima Khan

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-08-28 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/#review183957
---


Fix it, then Ship it!





security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java
Lines 46 (patched)


This patch fails the build on ranger-0.7 branch with the below error. 
Package org.mockito.junit (referenced in TestRoleBaseUserSearchUtil.java) does 
not exist in mockito 1.8.4 (ranger-0.7 uses 1.8.4 version, whereas master 
branch uses 2.7.22). This patch works fine for master branch. Can you create an 
updated patch for ranger-0.7?

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile 
(default-testCompile) on project security-admin-web: Compilation failure: 
Compilation failure:
[ERROR] 
/Users/vperiasamy/git/tlp-ranger/ranger-0.7/ranger/security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java:[46,24]
 error: package org.mockito.junit does not exist
[ERROR] 
/Users/vperiasamy/git/tlp-ranger/ranger-0.7/ranger/security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java:[48,9]
 error: cannot find symbol
```


- Velmurugan Periasamy


On Aug. 24, 2017, 4:31 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61553/
> ---
> 
> (Updated Aug. 24, 2017, 4:31 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1730
> https://issues.apache.org/jira/browse/RANGER-1730
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Actual :
> Provide utility to list user according to role.
> 
> Expected :
> Utility to list users for the given role based on thier authorization
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/rolebaseusersearchutil.py PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/view/VXUserRole.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/view/VXUserRoleList.java 
> PRE-CREATION 
>   
> security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61553/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on Simple against all roles
> Tested on Secure against all roles
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-08-23 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/
---

(Updated Aug. 24, 2017, 4:31 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
---

Added Unit test for RoleBaseUserSearchUtil.java


Bugs: RANGER-1730
https://issues.apache.org/jira/browse/RANGER-1730


Repository: ranger


Description
---

Actual :
Provide utility to list user according to role.

Expected :
Utility to list users for the given role based on thier authorization


Diffs (updated)
-

  security-admin/scripts/rolebaseusersearchutil.py PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXUserRole.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXUserRoleList.java 
PRE-CREATION 
  
security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61553/diff/2/

Changes: https://reviews.apache.org/r/61553/diff/1-2/


Testing
---

Tested on Simple against all roles
Tested on Secure against all roles


Thanks,

Fatima Khan

Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-08-11 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61553/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1730
https://issues.apache.org/jira/browse/RANGER-1730


Repository: ranger


Description
---

Actual :
Provide utility to list user according to role.

Expected :
Utility to list users for the given role based on thier authorization


Diffs
-

  security-admin/scripts/rolebaseusersearchutil.py PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXUserRole.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXUserRoleList.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61553/diff/1/


Testing
---

Tested on Simple against all roles
Tested on Secure against all roles


Thanks,

Fatima Khan