Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

> On Oct. 13, 2017, 8:57 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > > Line 165 (original), 184 (patched) > > > > > >

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

> On Oct. 13, 2017, 9:09 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java > > Lines 129 (patched) > > > > > > Can you add the following

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188138 --- Ship it! Ship It! - Na Li On Oct. 12, 2017, 7:35 p.m.,

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

> On Oct. 13, 2017, 8:57 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > > Line 165 (original), 184 (patched) > > > > > >

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review187979 --- should SentryService log the sentry service is ready? You only

Re: Review Request 62977: SENTRY-1984: Decrease number of max idle connections for Sentry clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62977/#review187978 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 3:21 p.m.,

Re: Review Request 62987: SENTRY-1987: Remove pom code related to non-existing TestSentryAuthorizationProvider class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62987/#review188010 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 8:12 p.m.,

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188022 ---

Re: Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/#review188030 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 9:03 p.m.,

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188013 ---

Re: Review Request 63026: SENTRY-1979 - Consolidate code for converting Hive privilege objects to Strings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63026/#review188202 --- Ship it! Ship It! - Na Li On Oct. 16, 2017, 11:33 a.m.,

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review188196 --- Ship it! Ship It! - Na Li On Oct. 16, 2017, 3:35 p.m.,

Re: Review Request 63046: SENTRY-1980: Move the hive-authz2 HMS client filtering implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63046/#review188359 ---

Re: Review Request 63047: SENTRY-1994: Bump Shiro dependency version to 1.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63047/#review188410 --- Ship it! Ship It! - Na Li On Oct. 16, 2017, 9:11 p.m.,

Re: Review Request 63048: SENTRY-1995: Bump Derby dependency version to 10.13.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63048/#review188409 --- Ship it! Ship It! - Na Li On Oct. 16, 2017, 9:16 p.m.,

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/#review191899 --- Ship it! Ship It! - Na Li On Nov. 22, 2017, 3:19 p.m.,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 22, 2017, 5:52 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 64179: SENTRY-2079: Sentry HA leader monitor does not work due to a mix of curator versions in the classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64179/#review192228 --- sentry-provider/sentry-provider-db/pom.xml Lines 230 (patched)

Re: Review Request 64179: SENTRY-2079: Sentry HA leader monitor does not work due to a mix of curator versions in the classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64179/#review192231 --- Ship it! Ship It! - Na Li On Nov. 29, 2017, 10:37 p.m.,

Re: Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64220/#review192329 --- Ship it! Ship It! - Na Li On Nov. 30, 2017, 6:36 p.m.,

Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by Hive 2 are causing conflicts with Sentry log4j

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64097/#review191933 --- Ship it! Ship It! - Na Li On Nov. 27, 2017, 8:16 p.m.,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 22, 2017, 6:29 p.m.) Review request for sentry, Arjun Mishra,

Review Request 64040: SENTRY-2070: TestSentryShellSolr tests are case sensitive to privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64040/ --- Review request for sentry, Hrishikesh Gadre, kalyan kumar kalvagadda, and

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 29, 2017, 4:50 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 251-252 (patched) > > > > > > This line is making me

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193563 ---

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review193839 ---

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

> On Dec. 15, 2017, 3:37 p.m., Arjun Mishra wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > > Lines 282 (patched) > > > > > > Is the fail

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review193939 --- Ship it! Ship It! - Na Li On Dec. 5, 2017, 9:09 p.m.,

Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Sergio Pena,

Re: Review Request 64471: SENTRY-2096: Fail unit tests at end

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64471/ --- (Updated Dec. 13, 2017, 10:29 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/#review191187 ---

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191352 --- Ship it! Ship It! - Na Li On Nov. 16, 2017, 7:29 p.m.,

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/#review191348 --- Ship it! Ship It! - Na Li On Nov. 16, 2017, 6:54 p.m.,

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191354 --- Have you run the tests for several times to make sure each test

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190856 --- Ship it! Ship It! - Na Li On Nov. 13, 2017, 5:12 p.m.,

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191522 --- Ship it! Ship It! - Na Li On Nov. 17, 2017, 10:29 p.m.,

Re: Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/#review191523 --- Ship it! Ship It! - Na Li On Nov. 17, 2017, 11:10 p.m.,

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:30 a.m., Vadim Spector wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > > Line 265 (original), 265 (patched) > >

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/ --- (Updated Nov. 21, 2017, 5:08 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191604 ---

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/ --- (Updated Nov. 21, 2017, 9:27 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 8:09 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Line 265 (original), 265 (patched) > > > > > > Is

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

> On Nov. 20, 2017, 11:43 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > > Lines 52-54 (patched) > > > > > > Can we

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/#review191647 --- what test have you done for this update? - Na Li On Nov. 21,

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191649 --- Ship it! Ship It! - Na Li On Nov. 21, 2017, 7:56 p.m.,

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191638 ---

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191640 ---

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 21, 2017, 11:44 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 21, 2017, 11:46 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 16, 2017, 7:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 348 (original), 353 (patched) > > > > > > You can add a log

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191233 ---

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 1, 2017, 7:32 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

> On Nov. 1, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote: > > Your description here is not in-line with the comments in jira. Jira states > > that intent of your change is to be in-line with the hive char set. Doing > > so it would solve another issue you may see. Please confirm. I have

Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/#review190600 --- should we remove the definition of profile hive-authz2 as well?

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190627 ---

Review Request 63709: SENTRY-2041: Change Index name in Package.jdo to match index name in SQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63709/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190657 ---

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190493 --- Ship it! Ship It! - Na Li On Nov. 7, 2017, 6:17 p.m.,

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review192925 ---

Re: Review Request 64451: SENTRY-2094: Enable TestHDFSIntegrationWithHA tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64451/#review193269 --- Ship it! Ship It! - Na Li On Dec. 8, 2017, 3:53 p.m.,

Review Request 64471: SENTRY-2096: Fail unit tests at end

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64471/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review193011 --- Ship it! Ship It! - Na Li On Dec. 5, 2017, 12:55 a.m.,

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

> On Dec. 5, 2017, 8:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > > Line 101 (original), 108 (patched) > > > > > >

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

> On Dec. 5, 2017, 8:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > > Line 101 (original), 108 (patched) > > > > > >

Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64392/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64392/ --- (Updated Dec. 6, 2017, 11:42 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64451: SENTRY-2094: Enable TestHDFSIntegrationWithHA tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64451/#review193276 --- You can remove some comment no longer valid such as "//TODO:

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

> On Dec. 4, 2017, 1 p.m., Colm O hEigeartaigh wrote: > > Why is a new "sentry-main" module needed as part of this fix? because of dependency. If the command is under one of existing directories, it will create circular dependency. That may be why the original code takes that approach

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review189653 ---

Review Request 63433: SENTRY-2026: Bump Hadoop version from 2.7.2 to 2.7.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63433/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.

Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 4:51 p.m.) Review request for sentry, Alexander

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202511 ---

Review Request 66972: SENTRY-2219: Create index AUTHZ_PATH_FK_IDX at table AUTHZ_PATH only when it does not exist for Oracle

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66972/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges

Re: Review Request 66910: SENTRY-2215: Remove unused SentryGrantRevokeTask class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66910/#review202470 --- Ship it! Ship It! - Na Li On May 4, 2018, 7:15 p.m., Sergio

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 7:25 p.m.) Review request for sentry, Alexander

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 4, 2018, 7:25 p.m.) Review request for sentry, Alexander

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202682 --- Ship it! Ship It! - Na Li On May 8, 2018, 8:20 p.m., Arjun

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 27 (original), 29 (patched) > > > > > > I think we

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/ --- (Updated May 8, 2018, 8:06 p.m.) Review request for sentry, Alexander

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202681 ---

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/ --- (Updated May 8, 2018, 7:47 p.m.) Review request for sentry, Alexander

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/#review202684 ---

Re: Review Request 67091: SENTRY-2218: Sentry-plug-in should have API's to handle grant/revoke privileges to users.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67091/#review203022 --- Ship it! Ship It! - Na Li On May 11, 2018, 8:05 p.m.,

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/ --- (Updated May 9, 2018, 4:25 p.m.) Review request for sentry, Alexander

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

> On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Lines 40 (patched) > > > > > > Shouldn't this

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 8:57 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 31 (original), 33 (patched) > > > > > > Can you add comment

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? > > Na Li wrote: > Sergio, I don't want to take the

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

> On April 23, 2018, 9:59 p.m., kalyan kumar kalvagadda wrote: > > You need to update the new version in SentryStoreSchemaInfo.java.Please > > make this change ans run the upgrade/install tests to make sure thay are > > fine. it is done - Na

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

> On April 27, 2018, 3:51 p.m., kalyan kumar kalvagadda wrote: > > Lina, This index might not be needed for every database. we need it for > > Oracle database for sure. > > > > For example, mysql creates an index automaticallym when a cloumn is added > > as a foreign key. Adding a duplicate

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 27, 2018, 3:13 p.m.) Review request for sentry, Alexander

Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/ --- Review request for sentry. Bugs: sentry-2226

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

> On May 10, 2018, 2:17 a.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > > Lines 123 (patched) > > > > > > Are roles

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

> On May 10, 2018, 2:17 a.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > > Lines 123 (patched) > > > > > > Are roles

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/ --- (Updated May 10, 2018, 7:18 p.m.) Review request for sentry. Bugs:

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

> On May 10, 2018, 2:17 a.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > > Lines 123 (patched) > > > > > > Are roles

Review Request 67072: SENTRY-2228: Improve on how to handle unsupported Hive commands

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67072/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar

  1   2   3   4   5   6   >