Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-05-13 Thread via GitHub
rombert commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2107505437 > I'm not sure what you mean by a "large number" of source files? There are only 4 files under src/main/java/ch/qos/logback and only 1 of those files copies any

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-05-07 Thread via GitHub
enapps-enorman commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2099081961 > Regarding the slf4j-api - could we not also register the capability ourselves, since we provide it and bypass the serviceloader? It seems like that

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-05-07 Thread via GitHub
rombert commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2098321478 @enapps-enorman Regarding the slf4j-api - could we not also register the capability ourselves, since we provide it and bypass the serviceloader?

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-05-01 Thread via GitHub
enapps-enorman commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2088735403 > slf4j.provider @rombert After further review, using slf4j-api without the service mediator as described in my last comment would also require

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-25 Thread via GitHub
enapps-enorman commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2077746890 > 1. ServiceLoder (+mediator) ... > Would it be possible to short-circuit the ServiceLoader in a similar manner to the work we do for Commons Johnzon?

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-25 Thread via GitHub
rombert commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2076491663 > For your reference, I stashed my workaround fragment bundle project at: https://github.com/enapps-enorman/sling-org-apache-sling-slf4j1x-compatibility On

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2076055412 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-22 Thread via GitHub
rombert commented on code in PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#discussion_r1574507607 ## src/main/java/ch/qos/logback/classic/PatternLayoutOsgi.java: ## @@ -0,0 +1,183 @@ +/** + * Logback: the reliable, generic, fast and flexible

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-22 Thread via GitHub
rishabhdaim commented on code in PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#discussion_r1574314774 ## src/main/java/ch/qos/logback/classic/PatternLayoutOsgi.java: ## @@ -0,0 +1,183 @@ +/** + * Logback: the reliable, generic, fast and

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2065428082 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2064825334 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-18 Thread via GitHub
rombert commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2063484884 Thanks a lot for preparing this @enapps-enorman ! I'll try to take a look in the coming days. -- This is an automated message from the Apache Git Service. To

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062945983 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062939330 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062929582 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062856322 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062848693 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062813806 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11906 Migrate to slf4j 2.x [sling-org-apache-sling-commons-log]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2062017247 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate