Re: [GitHub] storm issue #2539: STORM-2917: Check the derecated config nimbus.host

2018-01-30 Thread Joshua Serrin
unsubscribe On Tue, Jan 30, 2018 at 6:48 AM, MichealShin wrote: > Github user MichealShin commented on the issue: > > https://github.com/apache/storm/pull/2539 > > > [STORM-2917-2.zip](https://github.com/apache/storm/files/ > 1677510/STORM-2917-2.zip) >

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread Hugo Da Cruz Louro
I think that the bahir approach makes sense for connectors that don’t fall into the "first class support” category. I am in favor of moving such lower adoption connectors and have the interested communities support them with the most suitable release cycle. Connectors that are idle, such as

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread Harsha
Hi, In general connectors are independent of Storm run-time for most parts. I.e if the APIs are not changed (storm-core or trident haven't changed in years except the package re-name). You can take the latest connector and run in storm 1.0 or higher. So the users doesn't need to

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread P. Taylor Goetz
> On Jan 30, 2018, at 7:31 PM, Harsha wrote: > > Hi, >In general connectors are independent of Storm run-time for most > parts. I.e if the APIs are not changed (storm-core or trident haven't changed > in years except the package re-name). You can take the latest

[GitHub] storm issue #2537: STORM-2914: Implement ProcessingGuarantee.NONE in the spo...

2018-01-30 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2537 @srdo I left the [comment](https://issues.apache.org/jira/browse/STORM-2914?focusedCommentId=16346102=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16346102) on the JIRA.

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

2018-01-30 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2538 @srdo there is a discrepancy between the title of this pull request and the title of the associated JIRA. What problem are you trying to solve in this patch? Add meatada, or remove warnings?

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread P. Taylor Goetz
Also, in the interest of getting releases out, we have 3 open RC cycles in flight. Discussion energy might be better focused on that. -Taylor > On Jan 30, 2018, at 7:52 PM, P. Taylor Goetz wrote: > > > >> On Jan 30, 2018, at 7:31 PM, Harsha wrote: >>

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread P. Taylor Goetz
Hit send on that too soon... This is an important discussion topic, but has no effect on the current RCs. Id recommend focusing on the current releases and come back to this after getting releases out. -Taylor > On Jan 30, 2018, at 8:51 PM, P. Taylor Goetz wrote: > >

Re: [DISCUSS] Decouple Storm core and connectors

2018-01-30 Thread Jungtaek Lim
Agreed for this topic: this is not related to current release candidate and verifying release candidate is higher priority. For me I didn't start verifying 1.1.2 / 1.0.6 RC2 because the other topic I initiated could affect the current release. I'll post a short notice in that discussion thread.

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

2018-01-30 Thread Jungtaek Lim
Bump up this thread so that we could reach consensus earlier. Given that we got concern related to this, I think it is ideal to release 1.1.x/1.0.x with making decision and applying the change if we want. 2018년 1월 30일 (화) 오전 9:25, Jungtaek Lim 님이 작성: > Erik's concern brought

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164945684 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2638,6 +2647,34 @@ private int getNumOfAckerExecs(Map

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

2018-01-30 Thread Harsha
+1 to replace storm-kafka-client in 1.0.x branch -Harsha On Tue, Jan 30, 2018, at 7:04 PM, Jungtaek Lim wrote: > Bump up this thread so that we could reach consensus earlier. Given that we > got concern related to this, I think it is ideal to release 1.1.x/1.0.x > with making decision and applying

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

2018-01-30 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r164955129 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

2018-01-30 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r164956555 --- Diff: storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java --- @@ -17,72 +17,124 @@ */ package org.apache.storm.executor;

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164847348 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java --- @@ -0,0 +1,139 @@ +/** + * Licensed to the

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164800948 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java --- @@ -30,60 +29,62 @@ public class ThriftServer {

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164819054 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/sasl/SimpleSaslServerCallbackHandler.java --- @@ -0,0 +1,179 @@ +/** + * Licensed to

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164854143 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2254,14 +2262,13 @@ private void renewCredentials() throws Exception

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164822325 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/sasl/SimpleSaslServerCallbackHandler.java --- @@ -0,0 +1,179 @@ +/** + * Licensed to

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164822861 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/sasl/SimpleSaslServerCallbackHandler.java --- @@ -0,0 +1,179 @@ +/** + * Licensed to

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164848937 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java --- @@ -0,0 +1,139 @@ +/** + * Licensed to the

[GitHub] storm pull request #2540: [STORM-2916] separate hdfs-blobstore from storm-hd...

2018-01-30 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2540 [STORM-2916] separate hdfs-blobstore from storm-hdfs https://issues.apache.org/jira/browse/STORM-2916 Separate hdfs-blobstore from storm-hdfs module because others in the module are

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164886401 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenSigner.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164884692 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/kerberos/KerberosSaslTransportPlugin.java --- @@ -194,15 +223,15 @@ public TTransport

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164877371 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -140,9 +143,65 @@ public Credentials credentials(String

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164879002 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -140,9 +143,65 @@ public Credentials credentials(String

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

2018-01-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r164881908 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/AuthUtils.java --- @@ -264,6 +269,128 @@ public static IGroupMappingServiceProvider

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

2018-01-30 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r164971328 --- Diff: storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java --- @@ -89,63 +107,80 @@ public void emitDirect(int taskId,

[GitHub] storm issue #2539: STORM-2917: Check the derecated config nimbus.host

2018-01-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2539 @MichealShin Could you craft the patch against 1.x branch as well? Thanks in advance! ---

[GitHub] storm pull request #2539: STORM-2917: Check the derecated config nimbus.host

2018-01-30 Thread MichealShin
GitHub user MichealShin opened a pull request: https://github.com/apache/storm/pull/2539 STORM-2917: Check the derecated config nimbus.host There is a situation: the deployer wants to use the new nimbus config(nimbus.seeds), but still leave the blank deprecated

[GitHub] storm issue #2539: STORM-2917: Check the derecated config nimbus.host

2018-01-30 Thread MichealShin
Github user MichealShin commented on the issue: https://github.com/apache/storm/pull/2539 [STORM-2917-2.zip](https://github.com/apache/storm/files/1677510/STORM-2917-2.zip) @HeartSaVioR OK. ---