[GitHub] storm pull request #2635: [STORM-3029] don't use keytab based login for hbas...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2635#discussion_r182745958 --- Diff: external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java --- @@ -52,24 +54,27 @@ private HBaseSecurityUtil()

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182765656 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -109,6 +109,8 @@ import javax.security.auth.Subject; +import

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2638 [STORM-3034] Adding exception stacktrace for executor failures in worker You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182757546 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182758538 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182750384 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3032,9 +3019,19 @@ public void submitTopologyWithOpts(String

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182747281 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -184,6 +184,10 @@ The user can set some default configurations for the Resource Aware Scheduler

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182755817 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3032,9 +3019,19 @@ public void submitTopologyWithOpts(String

[GitHub] storm pull request #2631: [STORM-3025] Optimize Cluster methods with Caching...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2631 ---

[GitHub] storm pull request #2627: STORM-3022 Decouple storm-hive UTs with Hive (1.x)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2627 ---

[GitHub] storm issue #2637: Map of Spout configurations from `storm-kafka` to `storm-...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2637 I read the documentation for maxOffsetBehind you linked, and I think it is confusingly phrased. It says > If a failing tuple's offset is less than maxOffsetBehind, the spout stops retrying

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182833344 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -109,6 +109,8 @@ import javax.security.auth.Subject; +import static

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182843808 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -361,6 +363,7 @@ public void run() {

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182844665 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -361,6 +363,7 @@ public void run() { Time.sleep(s);

[GitHub] storm issue #2638: [STORM-3034] Adding exception stacktrace for executor fai...

Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2638 @srdo Moved the `LOG.error` before changing exception Cause. ---

[GitHub] storm pull request #2639: STORM-3035: fix the issue in JmsSpout.ack when toC...

GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2639 STORM-3035: fix the issue in JmsSpout.ack when toCommit is empty You can merge this pull request into a Git repository by running: $ git pull https://github.com/arunmahadevan/storm

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182833894 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -361,6 +363,7 @@ public void run() { Time.sleep(s);

[GitHub] storm pull request #2630: STORM-3024: Allow for scheduling to happen in the ...

Github user revans2 closed the pull request at: https://github.com/apache/storm/pull/2630 ---

[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2638#discussion_r182847223 --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java --- @@ -109,6 +109,8 @@ import javax.security.auth.Subject;

[GitHub] storm issue #2638: [STORM-3034] Adding exception stacktrace for executor fai...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2638 Sorry if I'm nitpicking you to death, but I don't think moving the log line is better. Now everyone gets an error level log, even if the exception is due to an interrupt. I'd prefer if we just include

[GitHub] storm issue #2621: [STORM-3017] Refactor pacemaker client exception handling

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2621 +1, thanks for fixing this. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user hustfxj commented on the issue: https://github.com/apache/storm/pull/2518 +1 Thank you for @vesense ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2518 +1 ---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182909146 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm issue #2637: Map of Spout configurations from `storm-kafka` to `storm-...

Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @srdo thanks for explaining that. I was looking at the GitHub file links that's why they were giving 404s. I have also modified the `socketTimeoutMs` setting map to not be supported